Completed
Pull Request — master (#93)
by Janis
04:38
created
lib/AppInfo/Application.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
          */
49 49
         $eventDispatcher = \OC::$server->getEventDispatcher();
50 50
         $eventDispatcher->addListener('OCA\Files::loadAdditionalScripts', 
51
-                function () {
51
+                function() {
52 52
                     script('ocr', 'dist/ocrapp');
53 53
                     style('ocr', 'ocrstyle');
54 54
                     // if not loaded before - load select2 for multi select languages
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
          * Register core services
60 60
          */
61 61
         $container->registerService('CurrentUID', 
62
-                function (IContainer $c) {
62
+                function(IContainer $c) {
63 63
                     /** @var \OC\Server $server */
64 64
                     $server = $c->query('ServerContainer');
65 65
                     $user = $server->getUserSession()
@@ -67,14 +67,14 @@  discard block
 block discarded – undo
67 67
                     return ($user) ? $user->getUID() : '';
68 68
                 });
69 69
         // Allow automatic DI for the View, until they migrated to Nodes API
70
-        $container->registerService(View::class, function () {
70
+        $container->registerService(View::class, function() {
71 71
             return new View('');
72 72
         }, false);
73 73
         /**
74 74
          * Register the PHPUtil
75 75
          */
76 76
         $container->registerService('PHPUtil', 
77
-                function (IContainer $c) {
77
+                function(IContainer $c) {
78 78
                     /** @var \OC\Server $server */
79 79
                     $server = $c->query('ServerContainer');
80 80
                     return new PHPUtil($server->getL10N('ocr'), $server->getLogger());
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
          * Register the Ocr Job mapper
84 84
          */
85 85
         $container->registerService('OcrJobMapper', 
86
-                function (IContainer $c) {
86
+                function(IContainer $c) {
87 87
                     /** @var \OC\Server $server */
88 88
                     $server = $c->query('ServerContainer');
89 89
                     return new OcrJobMapper($server->getDatabaseConnection());
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
          * Register the File mapper
93 93
          */
94 94
         $container->registerService('FileMapper', 
95
-                function (IContainer $c) {
95
+                function(IContainer $c) {
96 96
                     /** @var \OC\Server $server */
97 97
                     $server = $c->query('ServerContainer');
98 98
                     return new FileMapper($server->getDatabaseConnection());
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
          * Register the Share mapper
102 102
          */
103 103
         $container->registerService('ShareMapper', 
104
-                function (IContainer $c) {
104
+                function(IContainer $c) {
105 105
                     /** @var \OC\Server $server */
106 106
                     $server = $c->query('ServerContainer');
107 107
                     return new ShareMapper($server->getDatabaseConnection());
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
          * Register the App Config Service
111 111
          */
112 112
         $container->registerService('AppConfigService', 
113
-                function (IAppContainer $c) {
113
+                function(IAppContainer $c) {
114 114
                     /** @var \OC\Server $server */
115 115
                     $server = $c->query('ServerContainer');
116 116
                     return new AppConfigService($server->getConfig(), $server->getL10N('ocr'));
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
          * Register the Job Service
120 120
          */
121 121
         $container->registerService('FileService', 
122
-                function (IAppContainer $c) {
122
+                function(IAppContainer $c) {
123 123
                     /** @var \OC\Server $server */
124 124
                     $server = $c->query('ServerContainer');
125 125
                     return new FileService($server->getL10N('ocr'), $server->getLogger(), $c->query('CurrentUID'), 
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
          * Register the Redis Service
130 130
          */
131 131
         $container->registerService('RedisService', 
132
-                function (IAppContainer $c) {
132
+                function(IAppContainer $c) {
133 133
                     /** @var \OC\Server $server */
134 134
                     $server = $c->query('ServerContainer');
135 135
                     return new RedisService($c->query('OcrJobMapper'), $c->query('FileService'), $server->getConfig(), 
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
          * Register the Job Service
140 140
          */
141 141
         $container->registerService('JobService', 
142
-                function (IAppContainer $c) {
142
+                function(IAppContainer $c) {
143 143
                     /** @var \OC\Server $server */
144 144
                     $server = $c->query('ServerContainer');
145 145
                     return new JobService($server->getL10N('ocr'), $server->getLogger(), $c->query('CurrentUID'), 
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
          * Register the Status Service
152 152
          */
153 153
         $container->registerService('StatusService', 
154
-                function (IAppContainer $c) {
154
+                function(IAppContainer $c) {
155 155
                     /** @var \OC\Server $server */
156 156
                     $server = $c->query('ServerContainer');
157 157
                     return new StatusService($server->getL10N('ocr'), $server->getLogger(), $c->query('CurrentUID'), 
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
          * Controller
162 162
          */
163 163
         $container->registerService('StatusController', 
164
-                function (IAppContainer $c) {
164
+                function(IAppContainer $c) {
165 165
                     /** @var \OC\Server $server */
166 166
                     $server = $c->query('ServerContainer');
167 167
                     return new StatusController($c->getAppName(), $server->getRequest(), $c->query('StatusService'));
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
          * Controller
171 171
          */
172 172
         $container->registerService('JobController', 
173
-                function (IAppContainer $c) {
173
+                function(IAppContainer $c) {
174 174
                     /** @var \OC\Server $server */
175 175
                     $server = $c->query('ServerContainer');
176 176
                     return new JobController($c->getAppName(), $server->getRequest(), $c->query('JobService'), 
Please login to merge, or discard this patch.
lib/Controller/StatusController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
      * @return DataResponse
44 44
      */
45 45
     public function getStatus() {
46
-        return $this->handleNotFound(function () {
46
+        return $this->handleNotFound(function() {
47 47
             return $this->service->getStatus();
48 48
         });
49 49
     }
Please login to merge, or discard this patch.
lib/Service/JobService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@
 block discarded – undo
171 171
      * Delete an ocr job for a given id and userId.
172 172
      * 
173 173
      * @param
174
-     *            $jobId
174
+     integer            $jobId
175 175
      * @param string $userId            
176 176
      * @return OcrJob
177 177
      */
Please login to merge, or discard this patch.
lib/Service/AppConfigService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@
 block discarded – undo
81 81
      * @throws NotFoundException
82 82
      */
83 83
     public function setAppValue($key, $value) {
84
-        if(empty($key)) {
84
+        if (empty($key)) {
85 85
             throw new NotFoundException($this->l10n->t('The given settings key is empty.'));
86 86
         }
87 87
         switch ($key) {
Please login to merge, or discard this patch.
lib/Service/RedisService.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@
 block discarded – undo
167 167
             throw new NotFoundException($this->l10n->t('Message queueing capabilities are missing on the server.'));
168 168
         }
169 169
         $redis = new \Redis();
170
-        if (!$redis->connect($this->redisHost, $this->redisPort, 2.5, NULL, 100)) {
170
+        if (!$redis->connect($this->redisHost, $this->redisPort, 2.5, null, 100)) {
171 171
             $this->logger->debug('Cannot connect to Redis.');
172 172
             throw new NotFoundException($this->l10n->t('Cannot connect to Redis.'));
173 173
         }
Please login to merge, or discard this patch.
lib/Controller/AdminSettingsController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
      */
53 53
     public function getLanguages() {
54 54
         return $this->handleNotFound(
55
-                function () {
55
+                function() {
56 56
                     return [
57 57
                             'languages' => $this->appConfig->getAppValue(OcrConstants::LANGUAGES_CONFIG_KEY)
58 58
                     ];
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
      */
67 67
     public function evaluateRedisSettings() {
68 68
         return $this->handleNotFound(
69
-                function () {
69
+                function() {
70 70
                     return [
71 71
                             'set' => $this->appConfig->evaluateRedisSettings()
72 72
                     ];
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
      */
82 82
     public function setLanguages($languages) {
83 83
         return $this->handleNotFound(
84
-                function () use ($languages) {
84
+                function() use ($languages) {
85 85
                     $this->appConfig->setAppValue(OcrConstants::LANGUAGES_CONFIG_KEY, $languages);
86 86
                     return $this->l10n->t('Saved');
87 87
                 });
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
      */
98 98
     public function setRedis($redisHost, $redisPort, $redisDb) {
99 99
         return $this->handleNotFound(
100
-                function () use ($redisHost, $redisPort, $redisDb) {
100
+                function() use ($redisHost, $redisPort, $redisDb) {
101 101
                     $this->appConfig->setAppValue(OcrConstants::REDIS_CONFIG_KEY_HOST, $redisHost);
102 102
                     $this->appConfig->setAppValue(OcrConstants::REDIS_CONFIG_KEY_PORT, $redisPort);
103 103
                     $this->appConfig->setAppValue(OcrConstants::REDIS_CONFIG_KEY_DB, $redisDb);
Please login to merge, or discard this patch.
lib/Controller/JobController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
      */
64 64
     public function process($languages, $files) {
65 65
         return $this->handleNotFound(
66
-                function () use ($languages, $files) {
66
+                function() use ($languages, $files) {
67 67
                     return $this->service->process($languages, $files);
68 68
                 });
69 69
     }
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
      */
76 76
     public function getAllJobs() {
77 77
         return $this->handleNotFound(
78
-                function () {
78
+                function() {
79 79
                     return $this->service->getAllJobsForUser($this->userId);
80 80
                 });
81 81
     }
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
      */
89 89
     public function deleteJob($id) {
90 90
         return $this->handleNotFound(
91
-                function () use ($id) {
91
+                function() use ($id) {
92 92
                     return $this->service->deleteJob($id, $this->userId);
93 93
                 });
94 94
     }
Please login to merge, or discard this patch.