jakim / ig-monitoring

components/http/UserAgent.php

<?php
/**
 * Created for IG Monitoring.
 * User: jakim <pawel@jakimowski.info>
 * Date: 11.01.2018
 */

namespace app\components\http;


use yii\base\Component;
use yii\di\Instance;

class UserAgent extends Component
{
    public $cache = 'cache';

    /**
     * @return mixed
     * @throws \yii\base\InvalidConfigException
     */
    public function random()
    {
        /** @var \yii\caching\Cache $cache */
        $cache = Instance::ensure($this->cache);

        $items = $cache->getOrSet(__METHOD__, function() {
            return (new \jakim\ua\UserAgent())->fetch();
        }, 60 * 60 * 24 * 30);

        shuffle($items);

It seems like $items can also be of type false; however, parameter $array of shuffle() does only seem to accept array, maybe add an additional type check?

        return $items['0'];
    }
}