app\components\http\UserAgent::random()

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function random()
    {
        /** @var \yii\caching\Cache $cache */
        $cache = Instance::ensure($this->cache);

        $items = $cache->getOrSet(__METHOD__, function() {
            return (new \jakim\ua\UserAgent())->fetch();
        }, 60 * 60 * 24 * 30);

        shuffle($items);

It seems like $items can also be of type false; however, parameter $array of shuffle() does only seem to accept array, maybe add an additional type check?

        return $items['0'];
    }
}