Issues in AbstractRule.php (master) - Issues in master - jaeger-app/validate - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Validate/AbstractRule.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Jaeger
 *
 * @copyright	Copyright (c) 2015-2016, mithra62
 * @link		http://jaeger-app.com
 * @version		1.0
 * @filesource 	./Validate/AbstractRule.php
 */
namespace JaegerApp\Validate;

use JaegerApp\Validate\RuleInterface;
use JaegerApp\Exceptions\ValidateException;

/**
 * Jaeger - Abstract Validation Rule
 *
 * Contains useful helper methods for the validators
 *
 * @package Validate
 * @author Eric Lamb <[email protected]>
 */
abstract class AbstractRule implements RuleInterface
{

    /**
     * The shortname of the rule
     * Must be unique!
     * 
     * @var string
     */
    protected $name = '';

    /**
     * The error template
     * 
     * @var string
     */
    protected $error_message = '';

    /**
     * The name of the test file for upload testing
     * 
     * @var string
     */
    protected $test_file = 'test.txt';

    /**
     * The content the test file should contain for comparison testing
     * 
     * @var string
     */
    protected $test_string = 'm62';

    /**
     * Returns the path to the test file
     */
    protected function getTestFilePath()
    {
        return realpath(dirname(__FILE__) . '/' . $this->test_file);
    }

    /**
     * (non-PHPdoc)
     * 
     * @ignore
     *
     * @see \mithra62\Validate\RuleInterface::getErrorMessage()
     */
    public function getErrorMessage()
    {
        if ($this->error_message == '') {
            throw new ValidateException('Error Message is empty!');
        }
        
        return $this->error_message;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Sets the error message for the rule
     * 
     * @param string $message            
     * @return RuleInterface
     */
    public function setErrorMessage($message)
    {
        $this->error_message = $message;
        return $this;
    }

    /**
     * Sets the name parameter
     * 
     * @param string $name            
     * @return RuleInterface
     */
    public function setName($name)
    {
        $this->name = $name;
        return $this;
    }

    /**
     * (non-PHPdoc)
     * 
     * @ignore
     *
     * @see \mithra62\Validate\RuleInterface::getName()
     */
    public function getName()
    {
        if ($this->name == '') {
            throw new ValidateException('Rule name is empty!');
        }
        
        return $this->name;
    }
}

1			<?php
2			/**
3			* Jaeger
4			*
5			* @copyright Copyright (c) 2015-2016, mithra62
6			* @link http://jaeger-app.com
7			* @version 1.0
8			* @filesource ./Validate/AbstractRule.php
9			*/
10			namespace JaegerApp\Validate;
11
12			use JaegerApp\Validate\RuleInterface;
13			use JaegerApp\Exceptions\ValidateException;
14
15			/**
16			* Jaeger - Abstract Validation Rule
17			*
18			* Contains useful helper methods for the validators
19			*
20			* @package Validate
21			* @author Eric Lamb <[email protected]>
22			*/
23			abstract class AbstractRule implements RuleInterface
24			{
25
26			/**
27			* The shortname of the rule
28			* Must be unique!
29			*
30			* @var string
31			*/
32			protected $name = '';
33
34			/**
35			* The error template
36			*
37			* @var string
38			*/
39			protected $error_message = '';
40
41			/**
42			* The name of the test file for upload testing
43			*
44			* @var string
45			*/
46			protected $test_file = 'test.txt';
47
48			/**
49			* The content the test file should contain for comparison testing
50			*
51			* @var string
52			*/
53			protected $test_string = 'm62';
54
55			/**
56			* Returns the path to the test file
57			*/
58			protected function getTestFilePath()
59			{
60			return realpath(dirname(__FILE__) . '/' . $this->test_file);
61			}
62
63			/**
64			* (non-PHPdoc)
65			*
66			* @ignore
67			*
68			* @see \mithra62\Validate\RuleInterface::getErrorMessage()
69			*/
70			public function getErrorMessage()
71			{
72			if ($this->error_message == '') {
73			throw new ValidateException('Error Message is empty!');
74			}
75
76			return $this->error_message;
			0 ignored issues – show Bug Best Practice introduced 2016-04-19 04:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this->error_message;` (`string`) is incompatible with the return type declared by the interface `JaegerApp\Validate\RuleInterface::getErrorMessage` of type `array`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
77			}
78
79			/**
80			* Sets the error message for the rule
81			*
82			* @param string $message
83			* @return RuleInterface
84			*/
85			public function setErrorMessage($message)
86			{
87			$this->error_message = $message;
88			return $this;
89			}
90
91			/**
92			* Sets the name parameter
93			*
94			* @param string $name
95			* @return RuleInterface
96			*/
97			public function setName($name)
98			{
99			$this->name = $name;
100			return $this;
101			}
102
103			/**
104			* (non-PHPdoc)
105			*
106			* @ignore
107			*
108			* @see \mithra62\Validate\RuleInterface::getName()
109			*/
110			public function getName()
111			{
112			if ($this->name == '') {
113			throw new ValidateException('Rule name is empty!');
114			}
115
116			return $this->name;
117			}
118			}

jaeger-app / validate

Issues (4)

Security Analysis no request data

src/Validate/AbstractRule.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like