Inspection of "Adds photos to blog post feed via the enclosure ta..." - jacobemerick/web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f0fb12...3087cf )

by Jacob

created 2016-01-12 12:58 UTC

Status

Indentation +67 added lines, -67 removed lines patch added patch discarded remove patch

@@ -21,14 +21,14 @@  discard block
 block discarded – undo
  * @return boolean
  */
 $buildFeed = function (Feed $feed, $folder, $name = 'rss') {
-    $tempFeed = __DIR__ . "/../../public/{$folder}/{$name}-new.xml";
-    $finalFeed = __DIR__ . "/../../public/{$folder}/{$name}.xml";
+	$tempFeed = __DIR__ . "/../../public/{$folder}/{$name}-new.xml";
+	$finalFeed = __DIR__ . "/../../public/{$folder}/{$name}.xml";
 
-    $feedHandle = fopen($tempFeed, 'w');
-    fwrite($feedHandle, $feed->render());
-    fclose($feedHandle);
+	$feedHandle = fopen($tempFeed, 'w');
+	fwrite($feedHandle, $feed->render());
+	fclose($feedHandle);
 
-    rename($tempFeed, $finalFeed);
+	rename($tempFeed, $finalFeed);
 };
 
 
@@ -47,51 +47,51 @@  discard block
 block discarded – undo
 $activeBlogPosts = $blogPostRepository->getActivePosts();
 
 foreach ($activeBlogPosts as $blogPost) {
-    $blogPostItem = new Item();
+	$blogPostItem = new Item();
 
-    $blogPostItem->title($blogPost['title']);
+	$blogPostItem->title($blogPost['title']);
 
-    $url = "http://blog.jacobemerick.com/{$blogPost['category']}/{$blogPost['path']}/";
-    $blogPostItem->url($url);
-    $blogPostItem->guid($url, true);
+	$url = "http://blog.jacobemerick.com/{$blogPost['category']}/{$blogPost['path']}/";
+	$blogPostItem->url($url);
+	$blogPostItem->guid($url, true);
 
-    $description = $blogPost['body'];
-    $description = strip_tags($description);
-    $description = strtok($description, "\n");
-    if (strlen($description) > 250) {
-        $description = wordwrap($description, 250);
-        $description = strtok($description, "\n");
-        if (substr($description, -1) != '.') {
-            $description .= '&hellip;';
-        }
-    }
-    $description = html_entity_decode($description);
-    $blogPostItem->description($description);
+	$description = $blogPost['body'];
+	$description = strip_tags($description);
+	$description = strtok($description, "\n");
+	if (strlen($description) > 250) {
+		$description = wordwrap($description, 250);
+		$description = strtok($description, "\n");
+		if (substr($description, -1) != '.') {
+			$description .= '&hellip;';
+		}
+	}
+	$description = html_entity_decode($description);
+	$blogPostItem->description($description);
 
-    $categoryUrl = "http://blog.jacobemerick.com/{$blogPost['category']}/";
-    $blogPostItem->category($blogPost['category'], $categoryUrl);
+	$categoryUrl = "http://blog.jacobemerick.com/{$blogPost['category']}/";
+	$blogPostItem->category($blogPost['category'], $categoryUrl);
 
-    $pubDate = new DateTime($blogPost['date']);
-    $blogPostItem->pubDate($pubDate->getTimestamp());
+	$pubDate = new DateTime($blogPost['date']);
+	$blogPostItem->pubDate($pubDate->getTimestamp());
 
-    $firstPhoto = Content::instance('FetchFirstPhoto', $blogPost['body'])->activate(true, 'large');
-    if (!empty($firstPhoto)) {
-        $firstPhotoPieces = sscanf($firstPhoto, '<img src="%s" height="%d" width="%d" alt="%s" />');
-        $firstPhotoPath = current($firstPhotoPieces);
-        $firstPhotoPath = trim($firstPhotoPath, '"');
+	$firstPhoto = Content::instance('FetchFirstPhoto', $blogPost['body'])->activate(true, 'large');
+	if (!empty($firstPhoto)) {
+		$firstPhotoPieces = sscanf($firstPhoto, '<img src="%s" height="%d" width="%d" alt="%s" />');
+		$firstPhotoPath = current($firstPhotoPieces);
+		$firstPhotoPath = trim($firstPhotoPath, '"');
 
-        $firstPhotoInternalPath = __DIR__ . '/../../public' . $firstPhotoPath;
+		$firstPhotoInternalPath = __DIR__ . '/../../public' . $firstPhotoPath;
 
-        $firstPhotoSize = filesize($firstPhotoInternalPath);
+		$firstPhotoSize = filesize($firstPhotoInternalPath);
 
-        $fInfo = new finfo(FILEINFO_MIME_TYPE);
-        $firstPhotoType = $fInfo->file($firstPhotoInternalPath);
-        unset($fInfo);
+		$fInfo = new finfo(FILEINFO_MIME_TYPE);
+		$firstPhotoType = $fInfo->file($firstPhotoInternalPath);
+		unset($fInfo);
 
-        $blogPostItem->enclosure("http://blog.jacobemerick.com{$firstPhotoPath}", $firstPhotoSize, $firstPhotoType);
-    }
+		$blogPostItem->enclosure("http://blog.jacobemerick.com{$firstPhotoPath}", $firstPhotoSize, $firstPhotoType);
+	}
 
-    $blogPostItem->appendTo($blogPostChannel);
+	$blogPostItem->appendTo($blogPostChannel);
 }
 
 $buildFeed($blogPostFeed, 'blog');
@@ -109,33 +109,33 @@  discard block
 block discarded – undo
 $activeBlogComments = $commentRepository->getActiveCommentsBySite('blog');
 
 foreach ($activeBlogComments as $blogComment) {
-    $blogCommentItem = new Item();
-
-    $blogCommentItem->title("Comment on '{$blogComment['title']}' from {$blogComment['name']}");
-
-    $url = "http://blog.jacobemerick.com/{$blogComment['category']}/{$blogComment['path']}/";
-    $url .= "#comment-{$blogComment['id']}";
-    $blogCommentItem->url($url);
-    $blogCommentItem->guid($url, true);
-
-    $description = $blogComment['body'];
-    $description = strip_tags($description);
-    $description = strtok($description, "\n");
-    if (strlen($description) > 250) {
-        $description = wordwrap($description, 250);
-        $description = strtok($description, "\n");
-        if (substr($description, -1) != '.') {
-            $description .= '&hellip;';
-        }
-    }
-    $description = html_entity_decode($description);
-    $description = trim($description);
-    $blogCommentItem->description($description);
-
-    $pubDate = new DateTime($blogComment['date']);
-    $blogCommentItem->pubDate($pubDate->getTimestamp());
-
-    $blogCommentItem->appendTo($blogCommentChannel);
+	$blogCommentItem = new Item();
+
+	$blogCommentItem->title("Comment on '{$blogComment['title']}' from {$blogComment['name']}");
+
+	$url = "http://blog.jacobemerick.com/{$blogComment['category']}/{$blogComment['path']}/";
+	$url .= "#comment-{$blogComment['id']}";
+	$blogCommentItem->url($url);
+	$blogCommentItem->guid($url, true);
+
+	$description = $blogComment['body'];
+	$description = strip_tags($description);
+	$description = strtok($description, "\n");
+	if (strlen($description) > 250) {
+		$description = wordwrap($description, 250);
+		$description = strtok($description, "\n");
+		if (substr($description, -1) != '.') {
+			$description .= '&hellip;';
+		}
+	}
+	$description = html_entity_decode($description);
+	$description = trim($description);
+	$blogCommentItem->description($description);
+
+	$pubDate = new DateTime($blogComment['date']);
+	$blogCommentItem->pubDate($pubDate->getTimestamp());
+
+	$blogCommentItem->appendTo($blogCommentChannel);
 }
 
 $buildFeed($blogCommentFeed, 'blog', 'rss-comments');

Please login to merge, or discard this patch.

		@@ -21,14 +21,14 @@ discard block
		block discarded – undo
21	21	* @return boolean
22	22	*/
23	23	$buildFeed = function (Feed $feed, $folder, $name = 'rss') {
24		- $tempFeed = __DIR__ . "/../../public/{$folder}/{$name}-new.xml";
25		- $finalFeed = __DIR__ . "/../../public/{$folder}/{$name}.xml";
	24	+ $tempFeed = __DIR__ . "/../../public/{$folder}/{$name}-new.xml";
	25	+ $finalFeed = __DIR__ . "/../../public/{$folder}/{$name}.xml";
26	26
27		- $feedHandle = fopen($tempFeed, 'w');
28		- fwrite($feedHandle, $feed->render());
29		- fclose($feedHandle);
	27	+ $feedHandle = fopen($tempFeed, 'w');
	28	+ fwrite($feedHandle, $feed->render());
	29	+ fclose($feedHandle);
30	30
31		- rename($tempFeed, $finalFeed);
	31	+ rename($tempFeed, $finalFeed);
32	32	};
33	33
34	34
		@@ -47,51 +47,51 @@ discard block
		block discarded – undo
47	47	$activeBlogPosts = $blogPostRepository->getActivePosts();
48	48
49	49	foreach ($activeBlogPosts as $blogPost) {
50		- $blogPostItem = new Item();
	50	+ $blogPostItem = new Item();
51	51
52		- $blogPostItem->title($blogPost['title']);
	52	+ $blogPostItem->title($blogPost['title']);
53	53
54		- $url = "http://blog.jacobemerick.com/{$blogPost['category']}/{$blogPost['path']}/";
55		- $blogPostItem->url($url);
56		- $blogPostItem->guid($url, true);
	54	+ $url = "http://blog.jacobemerick.com/{$blogPost['category']}/{$blogPost['path']}/";
	55	+ $blogPostItem->url($url);
	56	+ $blogPostItem->guid($url, true);
57	57
58		- $description = $blogPost['body'];
59		- $description = strip_tags($description);
60		- $description = strtok($description, "\n");
61		- if (strlen($description) > 250) {
62		- $description = wordwrap($description, 250);
63		- $description = strtok($description, "\n");
64		- if (substr($description, -1) != '.') {
65		- $description .= '…';
66		- }
67		- }
68		- $description = html_entity_decode($description);
69		- $blogPostItem->description($description);
	58	+ $description = $blogPost['body'];
	59	+ $description = strip_tags($description);
	60	+ $description = strtok($description, "\n");
	61	+ if (strlen($description) > 250) {
	62	+ $description = wordwrap($description, 250);
	63	+ $description = strtok($description, "\n");
	64	+ if (substr($description, -1) != '.') {
	65	+ $description .= '…';
	66	+ }
	67	+ }
	68	+ $description = html_entity_decode($description);
	69	+ $blogPostItem->description($description);
70	70
71		- $categoryUrl = "http://blog.jacobemerick.com/{$blogPost['category']}/";
72		- $blogPostItem->category($blogPost['category'], $categoryUrl);
	71	+ $categoryUrl = "http://blog.jacobemerick.com/{$blogPost['category']}/";
	72	+ $blogPostItem->category($blogPost['category'], $categoryUrl);
73	73
74		- $pubDate = new DateTime($blogPost['date']);
75		- $blogPostItem->pubDate($pubDate->getTimestamp());
	74	+ $pubDate = new DateTime($blogPost['date']);
	75	+ $blogPostItem->pubDate($pubDate->getTimestamp());
76	76
77		- $firstPhoto = Content::instance('FetchFirstPhoto', $blogPost['body'])->activate(true, 'large');
78		- if (!empty($firstPhoto)) {
79		- $firstPhotoPieces = sscanf($firstPhoto, '<img src="%s" height="%d" width="%d" alt="%s" />');
80		- $firstPhotoPath = current($firstPhotoPieces);
81		- $firstPhotoPath = trim($firstPhotoPath, '"');
	77	+ $firstPhoto = Content::instance('FetchFirstPhoto', $blogPost['body'])->activate(true, 'large');
	78	+ if (!empty($firstPhoto)) {
	79	+ $firstPhotoPieces = sscanf($firstPhoto, '<img src="%s" height="%d" width="%d" alt="%s" />');
	80	+ $firstPhotoPath = current($firstPhotoPieces);
	81	+ $firstPhotoPath = trim($firstPhotoPath, '"');
82	82
83		- $firstPhotoInternalPath = __DIR__ . '/../../public' . $firstPhotoPath;
	83	+ $firstPhotoInternalPath = __DIR__ . '/../../public' . $firstPhotoPath;
84	84
85		- $firstPhotoSize = filesize($firstPhotoInternalPath);
	85	+ $firstPhotoSize = filesize($firstPhotoInternalPath);
86	86
87		- $fInfo = new finfo(FILEINFO_MIME_TYPE);
88		- $firstPhotoType = $fInfo->file($firstPhotoInternalPath);
89		- unset($fInfo);
	87	+ $fInfo = new finfo(FILEINFO_MIME_TYPE);
	88	+ $firstPhotoType = $fInfo->file($firstPhotoInternalPath);
	89	+ unset($fInfo);
90	90
91		- $blogPostItem->enclosure("http://blog.jacobemerick.com{$firstPhotoPath}", $firstPhotoSize, $firstPhotoType);
92		- }
	91	+ $blogPostItem->enclosure("http://blog.jacobemerick.com{$firstPhotoPath}", $firstPhotoSize, $firstPhotoType);
	92	+ }
93	93
94		- $blogPostItem->appendTo($blogPostChannel);
	94	+ $blogPostItem->appendTo($blogPostChannel);
95	95	}
96	96
97	97	$buildFeed($blogPostFeed, 'blog');
		@@ -109,33 +109,33 @@ discard block
		block discarded – undo
109	109	$activeBlogComments = $commentRepository->getActiveCommentsBySite('blog');
110	110
111	111	foreach ($activeBlogComments as $blogComment) {
112		- $blogCommentItem = new Item();
113		-
114		- $blogCommentItem->title("Comment on '{$blogComment['title']}' from {$blogComment['name']}");
115		-
116		- $url = "http://blog.jacobemerick.com/{$blogComment['category']}/{$blogComment['path']}/";
117		- $url .= "#comment-{$blogComment['id']}";
118		- $blogCommentItem->url($url);
119		- $blogCommentItem->guid($url, true);
120		-
121		- $description = $blogComment['body'];
122		- $description = strip_tags($description);
123		- $description = strtok($description, "\n");
124		- if (strlen($description) > 250) {
125		- $description = wordwrap($description, 250);
126		- $description = strtok($description, "\n");
127		- if (substr($description, -1) != '.') {
128		- $description .= '…';
129		- }
130		- }
131		- $description = html_entity_decode($description);
132		- $description = trim($description);
133		- $blogCommentItem->description($description);
134		-
135		- $pubDate = new DateTime($blogComment['date']);
136		- $blogCommentItem->pubDate($pubDate->getTimestamp());
137		-
138		- $blogCommentItem->appendTo($blogCommentChannel);
	112	+ $blogCommentItem = new Item();
	113	+
	114	+ $blogCommentItem->title("Comment on '{$blogComment['title']}' from {$blogComment['name']}");
	115	+
	116	+ $url = "http://blog.jacobemerick.com/{$blogComment['category']}/{$blogComment['path']}/";
	117	+ $url .= "#comment-{$blogComment['id']}";
	118	+ $blogCommentItem->url($url);
	119	+ $blogCommentItem->guid($url, true);
	120	+
	121	+ $description = $blogComment['body'];
	122	+ $description = strip_tags($description);
	123	+ $description = strtok($description, "\n");
	124	+ if (strlen($description) > 250) {
	125	+ $description = wordwrap($description, 250);
	126	+ $description = strtok($description, "\n");
	127	+ if (substr($description, -1) != '.') {
	128	+ $description .= '…';
	129	+ }
	130	+ }
	131	+ $description = html_entity_decode($description);
	132	+ $description = trim($description);
	133	+ $blogCommentItem->description($description);
	134	+
	135	+ $pubDate = new DateTime($blogComment['date']);
	136	+ $blogCommentItem->pubDate($pubDate->getTimestamp());
	137	+
	138	+ $blogCommentItem->appendTo($blogCommentChannel);
139	139	}
140	140
141	141	$buildFeed($blogCommentFeed, 'blog', 'rss-comments');

jacobemerick / web

Push — master ( f0fb12...3087cf )

Status

Category

Indentation +67 added lines, -67 removed lines patch added patch discarded remove patch