Inspection of "Adds remaining methods for the post repository" - jacobemerick/web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d7fe62...34318d )

by Jacob

created 2015-12-01 23:11 UTC

Status

Indentation +136 added lines, -136 removed lines patch added patch discarded remove patch

@@ -7,165 +7,165 @@  discard block
 block discarded – undo
 class MysqlPostRepository implements PostRepository
 {
 
-    /** @var  Aura\Sql\ConnectionLocator */
-    protected $connections;
-
-    /**
-     * @param Aura\Sql\ConnectionLocator $connections
-     */
-    public function __construct(ConnectionLocator $connections)
-    {
-        $this->connections = $connections;
-    }
-
-    /**
-     * @param string $category
-     * @param string $path
-     *
-     * @return array|false
-     */
-    public function findPostByPath($category, $path)
-    {
-        $query = "
+	/** @var  Aura\Sql\ConnectionLocator */
+	protected $connections;
+
+	/**
+	 * @param Aura\Sql\ConnectionLocator $connections
+	 */
+	public function __construct(ConnectionLocator $connections)
+	{
+		$this->connections = $connections;
+	}
+
+	/**
+	 * @param string $category
+	 * @param string $path
+	 *
+	 * @return array|false
+	 */
+	public function findPostByPath($category, $path)
+	{
+		$query = "
             SELECT `id`, `title`, `path`, `date`, `body`, `category`
             FROM `jpemeric_blog`.`post`
             WHERE `path` = :path AND `category` = :category AND `display` = :is_active
             LIMIT 1";
-        $bindings = [
-            'path'      => $path,
-            'category'  => $category,
-            'is_active' => 1,
-        ];
-
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchOne($query, $bindings);
-    }
-
-    public function getActivePosts($limit = null, $offset = 0)
-    {
-        $query = "
+		$bindings = [
+			'path'      => $path,
+			'category'  => $category,
+			'is_active' => 1,
+		];
+
+		return $this
+			->connections
+			->getRead()
+			->fetchOne($query, $bindings);
+	}
+
+	public function getActivePosts($limit = null, $offset = 0)
+	{
+		$query = "
             SELECT `id`, `title`, `path`, `date`, `body`, `category`
             FROM `jpemeric_blog`.`post`
             WHERE `display` = :is_active
             ORDER BY `date` DESC";
-        if ($limit != null) {
-            $query .= "
+		if ($limit != null) {
+			$query .= "
             LIMIT {$offset}, {$limit}";
-        }
+		}
 
-        $bindings = [
-            'is_active' => 1,
-        ];
+		$bindings = [
+			'is_active' => 1,
+		];
 
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchAll($query, $bindings);
-    }
+		return $this
+			->connections
+			->getRead()
+			->fetchAll($query, $bindings);
+	}
 
-    public function getActivePostsCount()
-    {
-        $query = "
+	public function getActivePostsCount()
+	{
+		$query = "
             SELECT COUNT(1) AS `count`
             FROM `jpemeric_blog`.`post`
             WHERE `display` = :is_active";
-        $bindings = [
-            'is_active' => 1,
-        ];
-
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchValue($query, $bindings);
-    }
-
-    public function getActivePostsByTag($tag, $limit = null, $offset = 0)
-    {
-        $query = "
+		$bindings = [
+			'is_active' => 1,
+		];
+
+		return $this
+			->connections
+			->getRead()
+			->fetchValue($query, $bindings);
+	}
+
+	public function getActivePostsByTag($tag, $limit = null, $offset = 0)
+	{
+		$query = "
             SELECT `id`, `title`, `path`, `date`, `body`, `category`
             FROM `jpemeric_blog`.`post`
             INNER JOIN `jpemeric_blog`.`ptlink` ON `ptlink`.`post_id` = `post`.`id` AND
                                                    `ptlink`.`tag_id` = :tag_id
             WHERE `display` = :is_active";
-        if ($limit != null) {
-            $query .= "
+		if ($limit != null) {
+			$query .= "
             LIMIT {$offset}, {$limit}";
-        }
-
-        $bindings = [
-            'tag_id'    => $tag,
-            'is_active' => 1,
-        ];
-
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchAll($query, $bindings);
-    }
-
-    public function getActivePostsCountByTag($tag)
-    {
-        $query = "
+		}
+
+		$bindings = [
+			'tag_id'    => $tag,
+			'is_active' => 1,
+		];
+
+		return $this
+			->connections
+			->getRead()
+			->fetchAll($query, $bindings);
+	}
+
+	public function getActivePostsCountByTag($tag)
+	{
+		$query = "
             SELECT COUNT(1) AS `count`
             FROM `jpemeric_blog`.`post`
             INNER JOIN `jpemeric_blog`.`ptlink` ON `ptlink`.`post_id` = `post`.`id` AND
                                                    `ptlink`.`tag_id` = :tag_id
             WHERE `display` = :is_active";
-        $bindings = [
-            'tag_id'    => $tag,
-            'is_active' => 1,
-        ];
-
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchValue($query, $bindings);
-    }
-
-    public function getActivePostsByCategory($category, $limit = null, $offset = 0)
-    {
-        $query = "
+		$bindings = [
+			'tag_id'    => $tag,
+			'is_active' => 1,
+		];
+
+		return $this
+			->connections
+			->getRead()
+			->fetchValue($query, $bindings);
+	}
+
+	public function getActivePostsByCategory($category, $limit = null, $offset = 0)
+	{
+		$query = "
             SELECT `id`, `title`, `path`, `date`, `body`, `category`
             FROM `jpemeric_blog`.`post`
             WHERE `category` = :category AND `display` = :is_active";
-        if ($limit != null) {
-            $query .= "
+		if ($limit != null) {
+			$query .= "
             LIMIT {$offset}, {$limit}";
-        }
-
-        $bindings = [
-            'category'  => $category,
-            'is_active' => 1,
-        ];
-
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchAll($query, $bindings);
-    }
-
-    public function getActivePostsCountByCategory($category)
-    {
-        $query = "
+		}
+
+		$bindings = [
+			'category'  => $category,
+			'is_active' => 1,
+		];
+
+		return $this
+			->connections
+			->getRead()
+			->fetchAll($query, $bindings);
+	}
+
+	public function getActivePostsCountByCategory($category)
+	{
+		$query = "
             SELECT COUNT(1) AS `count`
             FROM `jpemeric_blog`.`post`
             WHERE `category` = :category AND `display` = :is_active";
-        $bindings = [
-            'category'  => $category,
-            'is_active' => 1,
-        ];
-
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchValue($query, $bindings);
-    }
-
-    public function getActivePostsByRelatedTags($post, $limit = 4)
-    {
-        $query = "
+		$bindings = [
+			'category'  => $category,
+			'is_active' => 1,
+		];
+
+		return $this
+			->connections
+			->getRead()
+			->fetchValue($query, $bindings);
+	}
+
+	public function getActivePostsByRelatedTags($post, $limit = 4)
+	{
+		$query = "
             SELECT `id`, `title`, `path`, `date`, `body`, `category`, COUNT(1) AS `count`
             FROM `jpemeric_blog`.`post`
             INNER JOIN `jpemeric_blog`.`ptlink` ON `ptlink`.`post_id` = `post`.`id` AND
@@ -185,14 +185,14 @@  discard block
 block discarded – undo
             GROUP BY `id`
             ORDER BY `count` DESC
             LIMIT {$limit}";
-        $bindings = [
-            'post'      => $post,
-            'is_active' => 1,
-        ];
-
-        return $this
-            ->connections
-            ->getRead()
-            ->fetchAll($query, $bindings);
-    }
+		$bindings = [
+			'post'      => $post,
+			'is_active' => 1,
+		];
+
+		return $this
+			->connections
+			->getRead()
+			->fetchAll($query, $bindings);
+	}
 }

Please login to merge, or discard this patch.

src/Domain/Blog/PostRepository.php 2 patches

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -4,12 +4,12 @@
 block discarded – undo
 
 interface PostRepository
 {
-    public function findPostByPath($category, $path);
-    public function getActivePosts($limit = null, $offset= 0);
-    public function getActivePostsCount();
-    public function getActivePostsByTag($tag, $limit = null, $offset = 0);
-    public function getActivePostsCountByTag($tag);
-    public function getActivePostsByCategory($category, $limit = null, $offset = 0);
-    public function getActivePostsCountByCategory($category);
-    public function getActivePostsByRelatedTags($post, $limit = 4);
+	public function findPostByPath($category, $path);
+	public function getActivePosts($limit = null, $offset= 0);
+	public function getActivePostsCount();
+	public function getActivePostsByTag($tag, $limit = null, $offset = 0);
+	public function getActivePostsCountByTag($tag);
+	public function getActivePostsByCategory($category, $limit = null, $offset = 0);
+	public function getActivePostsCountByCategory($category);
+	public function getActivePostsByRelatedTags($post, $limit = 4);
 }

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -5,7 +5,7 @@
 block discarded – undo
 interface PostRepository
 {
     public function findPostByPath($category, $path);
-    public function getActivePosts($limit = null, $offset= 0);
+    public function getActivePosts($limit = null, $offset = 0);
     public function getActivePostsCount();
     public function getActivePostsByTag($tag, $limit = null, $offset = 0);
     public function getActivePostsCountByTag($tag);

Please login to merge, or discard this patch.

		@@ -7,165 +7,165 @@ discard block
		block discarded – undo
7	7	class MysqlPostRepository implements PostRepository
8	8	{
9	9
10		- /** @var Aura\Sql\ConnectionLocator */
11		- protected $connections;
12		-
13		- /**
14		- * @param Aura\Sql\ConnectionLocator $connections
15		- */
16		- public function __construct(ConnectionLocator $connections)
17		- {
18		- $this->connections = $connections;
19		- }
20		-
21		- /**
22		- * @param string $category
23		- * @param string $path
24		- *
25		- * @return array\|false
26		- */
27		- public function findPostByPath($category, $path)
28		- {
29		- $query = "
	10	+ /** @var Aura\Sql\ConnectionLocator */
	11	+ protected $connections;
	12	+
	13	+ /**
	14	+ * @param Aura\Sql\ConnectionLocator $connections
	15	+ */
	16	+ public function __construct(ConnectionLocator $connections)
	17	+ {
	18	+ $this->connections = $connections;
	19	+ }
	20	+
	21	+ /**
	22	+ * @param string $category
	23	+ * @param string $path
	24	+ *
	25	+ * @return array\|false
	26	+ */
	27	+ public function findPostByPath($category, $path)
	28	+ {
	29	+ $query = "
30	30	SELECT `id`, `title`, `path`, `date`, `body`, `category`
31	31	FROM `jpemeric_blog`.`post`
32	32	WHERE `path` = :path AND `category` = :category AND `display` = :is_active
33	33	LIMIT 1";
34		- $bindings = [
35		- 'path' => $path,
36		- 'category' => $category,
37		- 'is_active' => 1,
38		- ];
39		-
40		- return $this
41		- ->connections
42		- ->getRead()
43		- ->fetchOne($query, $bindings);
44		- }
45		-
46		- public function getActivePosts($limit = null, $offset = 0)
47		- {
48		- $query = "
	34	+ $bindings = [
	35	+ 'path' => $path,
	36	+ 'category' => $category,
	37	+ 'is_active' => 1,
	38	+ ];
	39	+
	40	+ return $this
	41	+ ->connections
	42	+ ->getRead()
	43	+ ->fetchOne($query, $bindings);
	44	+ }
	45	+
	46	+ public function getActivePosts($limit = null, $offset = 0)
	47	+ {
	48	+ $query = "
49	49	SELECT `id`, `title`, `path`, `date`, `body`, `category`
50	50	FROM `jpemeric_blog`.`post`
51	51	WHERE `display` = :is_active
52	52	ORDER BY `date` DESC";
53		- if ($limit != null) {
54		- $query .= "
	53	+ if ($limit != null) {
	54	+ $query .= "
55	55	LIMIT {$offset}, {$limit}";
56		- }
	56	+ }
57	57
58		- $bindings = [
59		- 'is_active' => 1,
60		- ];
	58	+ $bindings = [
	59	+ 'is_active' => 1,
	60	+ ];
61	61
62		- return $this
63		- ->connections
64		- ->getRead()
65		- ->fetchAll($query, $bindings);
66		- }
	62	+ return $this
	63	+ ->connections
	64	+ ->getRead()
	65	+ ->fetchAll($query, $bindings);
	66	+ }
67	67
68		- public function getActivePostsCount()
69		- {
70		- $query = "
	68	+ public function getActivePostsCount()
	69	+ {
	70	+ $query = "
71	71	SELECT COUNT(1) AS `count`
72	72	FROM `jpemeric_blog`.`post`
73	73	WHERE `display` = :is_active";
74		- $bindings = [
75		- 'is_active' => 1,
76		- ];
77		-
78		- return $this
79		- ->connections
80		- ->getRead()
81		- ->fetchValue($query, $bindings);
82		- }
83		-
84		- public function getActivePostsByTag($tag, $limit = null, $offset = 0)
85		- {
86		- $query = "
	74	+ $bindings = [
	75	+ 'is_active' => 1,
	76	+ ];
	77	+
	78	+ return $this
	79	+ ->connections
	80	+ ->getRead()
	81	+ ->fetchValue($query, $bindings);
	82	+ }
	83	+
	84	+ public function getActivePostsByTag($tag, $limit = null, $offset = 0)
	85	+ {
	86	+ $query = "
87	87	SELECT `id`, `title`, `path`, `date`, `body`, `category`
88	88	FROM `jpemeric_blog`.`post`
89	89	INNER JOIN `jpemeric_blog`.`ptlink` ON `ptlink`.`post_id` = `post`.`id` AND
90	90	`ptlink`.`tag_id` = :tag_id
91	91	WHERE `display` = :is_active";
92		- if ($limit != null) {
93		- $query .= "
	92	+ if ($limit != null) {
	93	+ $query .= "
94	94	LIMIT {$offset}, {$limit}";
95		- }
96		-
97		- $bindings = [
98		- 'tag_id' => $tag,
99		- 'is_active' => 1,
100		- ];
101		-
102		- return $this
103		- ->connections
104		- ->getRead()
105		- ->fetchAll($query, $bindings);
106		- }
107		-
108		- public function getActivePostsCountByTag($tag)
109		- {
110		- $query = "
	95	+ }
	96	+
	97	+ $bindings = [
	98	+ 'tag_id' => $tag,
	99	+ 'is_active' => 1,
	100	+ ];
	101	+
	102	+ return $this
	103	+ ->connections
	104	+ ->getRead()
	105	+ ->fetchAll($query, $bindings);
	106	+ }
	107	+
	108	+ public function getActivePostsCountByTag($tag)
	109	+ {
	110	+ $query = "
111	111	SELECT COUNT(1) AS `count`
112	112	FROM `jpemeric_blog`.`post`
113	113	INNER JOIN `jpemeric_blog`.`ptlink` ON `ptlink`.`post_id` = `post`.`id` AND
114	114	`ptlink`.`tag_id` = :tag_id
115	115	WHERE `display` = :is_active";
116		- $bindings = [
117		- 'tag_id' => $tag,
118		- 'is_active' => 1,
119		- ];
120		-
121		- return $this
122		- ->connections
123		- ->getRead()
124		- ->fetchValue($query, $bindings);
125		- }
126		-
127		- public function getActivePostsByCategory($category, $limit = null, $offset = 0)
128		- {
129		- $query = "
	116	+ $bindings = [
	117	+ 'tag_id' => $tag,
	118	+ 'is_active' => 1,
	119	+ ];
	120	+
	121	+ return $this
	122	+ ->connections
	123	+ ->getRead()
	124	+ ->fetchValue($query, $bindings);
	125	+ }
	126	+
	127	+ public function getActivePostsByCategory($category, $limit = null, $offset = 0)
	128	+ {
	129	+ $query = "
130	130	SELECT `id`, `title`, `path`, `date`, `body`, `category`
131	131	FROM `jpemeric_blog`.`post`
132	132	WHERE `category` = :category AND `display` = :is_active";
133		- if ($limit != null) {
134		- $query .= "
	133	+ if ($limit != null) {
	134	+ $query .= "
135	135	LIMIT {$offset}, {$limit}";
136		- }
137		-
138		- $bindings = [
139		- 'category' => $category,
140		- 'is_active' => 1,
141		- ];
142		-
143		- return $this
144		- ->connections
145		- ->getRead()
146		- ->fetchAll($query, $bindings);
147		- }
148		-
149		- public function getActivePostsCountByCategory($category)
150		- {
151		- $query = "
	136	+ }
	137	+
	138	+ $bindings = [
	139	+ 'category' => $category,
	140	+ 'is_active' => 1,
	141	+ ];
	142	+
	143	+ return $this
	144	+ ->connections
	145	+ ->getRead()
	146	+ ->fetchAll($query, $bindings);
	147	+ }
	148	+
	149	+ public function getActivePostsCountByCategory($category)
	150	+ {
	151	+ $query = "
152	152	SELECT COUNT(1) AS `count`
153	153	FROM `jpemeric_blog`.`post`
154	154	WHERE `category` = :category AND `display` = :is_active";
155		- $bindings = [
156		- 'category' => $category,
157		- 'is_active' => 1,
158		- ];
159		-
160		- return $this
161		- ->connections
162		- ->getRead()
163		- ->fetchValue($query, $bindings);
164		- }
165		-
166		- public function getActivePostsByRelatedTags($post, $limit = 4)
167		- {
168		- $query = "
	155	+ $bindings = [
	156	+ 'category' => $category,
	157	+ 'is_active' => 1,
	158	+ ];
	159	+
	160	+ return $this
	161	+ ->connections
	162	+ ->getRead()
	163	+ ->fetchValue($query, $bindings);
	164	+ }
	165	+
	166	+ public function getActivePostsByRelatedTags($post, $limit = 4)
	167	+ {
	168	+ $query = "
169	169	SELECT `id`, `title`, `path`, `date`, `body`, `category`, COUNT(1) AS `count`
170	170	FROM `jpemeric_blog`.`post`
171	171	INNER JOIN `jpemeric_blog`.`ptlink` ON `ptlink`.`post_id` = `post`.`id` AND
		@@ -185,14 +185,14 @@ discard block
		block discarded – undo
185	185	GROUP BY `id`
186	186	ORDER BY `count` DESC
187	187	LIMIT {$limit}";
188		- $bindings = [
189		- 'post' => $post,
190		- 'is_active' => 1,
191		- ];
192		-
193		- return $this
194		- ->connections
195		- ->getRead()
196		- ->fetchAll($query, $bindings);
197		- }
	188	+ $bindings = [
	189	+ 'post' => $post,
	190	+ 'is_active' => 1,
	191	+ ];
	192	+
	193	+ return $this
	194	+ ->connections
	195	+ ->getRead()
	196	+ ->fetchAll($query, $bindings);
	197	+ }
198	198	}

		@@ -4,12 +4,12 @@
		block discarded – undo
4	4
5	5	interface PostRepository
6	6	{
7		- public function findPostByPath($category, $path);
8		- public function getActivePosts($limit = null, $offset= 0);
9		- public function getActivePostsCount();
10		- public function getActivePostsByTag($tag, $limit = null, $offset = 0);
11		- public function getActivePostsCountByTag($tag);
12		- public function getActivePostsByCategory($category, $limit = null, $offset = 0);
13		- public function getActivePostsCountByCategory($category);
14		- public function getActivePostsByRelatedTags($post, $limit = 4);
	7	+ public function findPostByPath($category, $path);
	8	+ public function getActivePosts($limit = null, $offset= 0);
	9	+ public function getActivePostsCount();
	10	+ public function getActivePostsByTag($tag, $limit = null, $offset = 0);
	11	+ public function getActivePostsCountByTag($tag);
	12	+ public function getActivePostsByCategory($category, $limit = null, $offset = 0);
	13	+ public function getActivePostsCountByCategory($category);
	14	+ public function getActivePostsByRelatedTags($post, $limit = 4);
15	15	}

		@@ -5,7 +5,7 @@
		block discarded – undo
5	5	interface PostRepository
6	6	{
7	7	public function findPostByPath($category, $path);
8		- public function getActivePosts($limit = null, $offset= 0);
	8	+ public function getActivePosts($limit = null, $offset = 0);
9	9	public function getActivePostsCount();
10	10	public function getActivePostsByTag($tag, $limit = null, $offset = 0);
11	11	public function getActivePostsCountByTag($tag);

jacobemerick / web

Push — master ( d7fe62...34318d )

Status

Category

Indentation +136 added lines, -136 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch