CategoryController::behaviors() - Code Metrics - Inspection of "Improve all project" - itstructure/yii2-template-simple - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e41cc1...feed29 )

by Andrey

created 2020-07-26 16:47 UTC

CategoryController::behaviors() A

↳ Parent: CategoryController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	21
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	21
loc	21
rs	9.584
c	0
b	0
f	0

<?php

namespace app\controllers;

use Yii;
use yii\data\Pagination;
use yii\helpers\ArrayHelper;
use yii\web\NotFoundHttpException;
use yii\filters\{AccessControl, VerbFilter};
use app\models\{Category, Product};

/**
 * Class CategoryController
 *
 * @package app\controllers
 */
class CategoryController extends BaseController

{
    /**
     * @return array
     */
    public function behaviors()
    {
        return ArrayHelper::merge(parent::behaviors(), [
            'access' => [
                'class' => AccessControl::class,
                'rules' => [
                    [
                        'allow' => true,
                        'actions' => ['index','view'],
                        'roles' => ['?', '@'],
                    ],
                ],
            ],
            'verbs' => [
                'class' => VerbFilter::class,
                'actions' => [
                    'view' => ['get'],
                ],
            ],
        ]);
    }

    /**
     * Displays category page with products.
     * @param $alias
     * @return string
     * @throws NotFoundHttpException
     */
    public function actionView($alias)
    {
        $model = Category::find()->where([
            'alias' => $alias
        ])->andWhere([
            'active' => 1
        ])->one();

        if (null === $model) {
            throw new NotFoundHttpException('Category not fount with alias = '.$alias.'.');
        }

        $this->setMetaParams($model);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $productsQuery = Product::find()->where([
            'categoryId' => $model->id
        ])->andWhere([
            'active' => 1
        ]);

        $pagination = new Pagination([
            'totalCount' => $productsQuery->count(),
            'defaultPageSize' => Yii::$app->params['defaultPageSize']
        ]);

        return $this->render('view', [
            'model' => $model,
            'pagination' => $pagination,
            'products' => $productsQuery->offset($pagination->offset)
                ->limit($pagination->limit)
                ->all()
        ]);
    }
}


1		<?php
2
3		namespace app\controllers;
4
5		use Yii;
6		use yii\data\Pagination;
7		use yii\helpers\ArrayHelper;
8		use yii\web\NotFoundHttpException;
9		use yii\filters\{AccessControl, VerbFilter};
10		use app\models\{Category, Product};
11
12		/**
13		* Class CategoryController
14		*
15		* @package app\controllers
16		*/
17	View Code Duplication	class CategoryController extends BaseController
		0 ignored issues – show Duplication introduced 2020-07-26 16:54 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
18		{
19		/**
20		* @return array
21		*/
22		public function behaviors()
23		{
24		return ArrayHelper::merge(parent::behaviors(), [
25		'access' => [
26		'class' => AccessControl::class,
27		'rules' => [
28		[
29		'allow' => true,
30		'actions' => ['index','view'],
31		'roles' => ['?', '@'],
32		],
33		],
34		],
35		'verbs' => [
36		'class' => VerbFilter::class,
37		'actions' => [
38		'view' => ['get'],
39		],
40		],
41		]);
42		}
43
44		/**
45		* Displays category page with products.
46		* @param $alias
47		* @return string
48		* @throws NotFoundHttpException
49		*/
50		public function actionView($alias)
51		{
52		$model = Category::find()->where([
53		'alias' => $alias
54		])->andWhere([
55		'active' => 1
56		])->one();
57
58		if (null === $model) {
59		throw new NotFoundHttpException('Category not fount with alias = '.$alias.'.');
60		}
61
62		$this->setMetaParams($model);
		0 ignored issues – show Bug introduced 2020-07-26 16:54 UTC by Report Bug Copy Issue Report It seems like `$model` defined by `\app\models\Category::fi...('active' => 1))->one()` on line `52` can also be of type `array`; however, `app\controllers\BaseController::setMetaParams()` does only seem to accept `null\|object<yii\db\ActiveRecord>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
63
64		$productsQuery = Product::find()->where([
65		'categoryId' => $model->id
66		])->andWhere([
67		'active' => 1
68		]);
69
70		$pagination = new Pagination([
71		'totalCount' => $productsQuery->count(),
72		'defaultPageSize' => Yii::$app->params['defaultPageSize']
73		]);
74
75		return $this->render('view', [
76		'model' => $model,
77		'pagination' => $pagination,
78		'products' => $productsQuery->offset($pagination->offset)
79		->limit($pagination->limit)
80		->all()
81		]);
82		}
83		}
84

itstructure / yii2-template-simple

Push — master ( e41cc1...feed29 )

CategoryController::behaviors() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like