app\controllers\CategoryController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	67
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	8

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	behaviors()	21	21	1
A	actionView()	33	33	2

<?php

namespace app\controllers;

use Yii;
use yii\data\Pagination;
use yii\helpers\ArrayHelper;
use yii\web\NotFoundHttpException;
use yii\filters\{AccessControl, VerbFilter};
use app\models\{Category, Product};

/**
 * Class CategoryController
 *
 * @package app\controllers
 */
class CategoryController extends BaseController

This class seems to be duplicated in your project.

{
    /**
     * @return array
     */
    public function behaviors()
    {
        return ArrayHelper::merge(parent::behaviors(), [
            'access' => [
                'class' => AccessControl::class,
                'rules' => [
                    [
                        'allow' => true,
                        'actions' => ['index','view'],
                        'roles' => ['?', '@'],
                    ],
                ],
            ],
            'verbs' => [
                'class' => VerbFilter::class,
                'actions' => [
                    'view' => ['get'],
                ],
            ],
        ]);
    }

    /**
     * Displays category page with products.
     * @param $alias
     * @return string
     * @throws NotFoundHttpException
     */
    public function actionView($alias)
    {
        $model = Category::find()->where([
            'alias' => $alias
        ])->andWhere([
            'active' => 1
        ])->one();

        if (null === $model) {
            throw new NotFoundHttpException('Category not fount with alias = '.$alias.'.');
        }

        $this->setMetaParams($model);

It seems like $model defined by \app\models\Category::find()->where(array('alias' => $alias))->andWhere(array('active' => 1))->one() on line 52 can also be of type array; however, app\controllers\BaseController::setMetaParams() does only seem to accept null|object<yii\db\ActiveRecord>, maybe add an additional type check?

        $productsQuery = Product::find()->where([
            'categoryId' => $model->id
        ])->andWhere([
            'active' => 1
        ]);

        $pagination = new Pagination([
            'totalCount' => $productsQuery->count(),
            'defaultPageSize' => Yii::$app->params['defaultPageSize']
        ]);

        return $this->render('view', [
            'model' => $model,
            'pagination' => $pagination,
            'products' => $productsQuery->offset($pagination->offset)
                ->limit($pagination->limit)
                ->all()
        ]);
    }
}