app\controllers\admin\SettingController::actionIndex()

Complexity

Conditions	5
Paths	3

Size

Total Lines	23
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function actionIndex()
    {
        if (!$this->checkAccessToAdministrate()) {
            return $this->accessError();
        }

        /* @var $model \app\models\Setting */
        $model = Yii::$app->get('settings')
            ->setModel()
            ->getSettings();

        if (Yii::$app->request->isPost && $model->load(Yii::$app->request->post()) && $model->save()) {

It seems like Yii::app->request->post() can also be of type object; however, parameter $data of yii\base\Model::load() does only seem to accept array, maybe add an additional type check?

            return $this->redirect([

The expression return $this->redirect(array('/' . $this->shortLanguage . '/admin/settings')) returns the type yii\web\Response which is incompatible with the documented return type string.

                '/'.$this->shortLanguage.'/admin/settings'
            ]);
        }

        $fields = [
            'model' => $model,
            'roles' => Yii::$app->authManager->getRoles()

The method getRoles() does not exist on null.

        ];

        return $this->render('index', $fields);
    }