app\controllers\admin\SettingController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	actionIndex()	0	23	5

<?php

namespace app\controllers\admin;

use Yii;
use app\traits\{LanguageTrait, AdminBeforeActionTrait, AccessTrait};
use Itstructure\AdminModule\controllers\AdminController;

/**
 * Class SettingController
 * SettingController implements the CRUD actions for Setting model.
 *
 * @package app\controllers\admin
 */
class SettingController extends AdminController
{
    use LanguageTrait, AdminBeforeActionTrait, AccessTrait;

The trait app\traits\AccessTrait requires the property $user which is not provided by app\controllers\admin\SettingController.

The trait app\traits\AdminBeforeActionTrait requires the property $controller which is not provided by app\controllers\admin\SettingController.

    /**
     * List of records.
     *
     * @return string
     */
    public function actionIndex()
    {
        if (!$this->checkAccessToAdministrate()) {
            return $this->accessError();
        }

        /* @var $model \app\models\Setting */
        $model = Yii::$app->get('settings')
            ->setModel()
            ->getSettings();

        if (Yii::$app->request->isPost && $model->load(Yii::$app->request->post()) && $model->save()) {

It seems like Yii::app->request->post() can also be of type object; however, parameter $data of yii\base\Model::load() does only seem to accept array, maybe add an additional type check?

            return $this->redirect([

The expression return $this->redirect(array('/' . $this->shortLanguage . '/admin/settings')) returns the type yii\web\Response which is incompatible with the documented return type string.

                '/'.$this->shortLanguage.'/admin/settings'
            ]);
        }

        $fields = [
            'model' => $model,
            'roles' => Yii::$app->authManager->getRoles()

The method getRoles() does not exist on null.

        ];

        return $this->render('index', $fields);
    }
}