itrukhin / bxconsole

src/Cron.php

Spacing +50 added lines, -50 removed lines

@@ -40,45 +40,45 @@ 
         set_time_limit(EnvHelper::getCrontabTimeout());
 
         $logger = EnvHelper::getLogger('bx_cron');
-        if($logger) {
+        if ($logger) {
             $this->setLogger($logger);
         }
 
         $showStatus = $input->getOption('status');
         $byTime = $input->getOption('bytime');
-        if($showStatus) {
+        if ($showStatus) {
             $sort = ($byTime ? self::SORT_TIME : self::SORT_NAME);
             $this->showStatus($output, $sort);
             return 0;
         }
 
-        if(EnvHelper::getSwitch('BX_CRONTAB_RUN', EnvHelper::SWITCH_STATE_OFF)) {
-            if($this->logger) {
+        if (EnvHelper::getSwitch('BX_CRONTAB_RUN', EnvHelper::SWITCH_STATE_OFF)) {
+            if ($this->logger) {
                 $this->logger->alert('BxCron switch off');
             }
             return 0;
         }
 
-        if(!$this->lock()) {
+        if (!$this->lock()) {
             $msg = 'The command is already running in another process.';
             $output->writeln($msg);
-            if($this->logger) {
+            if ($this->logger) {
                 $this->logger->warning($msg);
             }
             return 0;
         }
 
-        if($sleepInterval = EnvHelper::checkSleepInterval()) {
+        if ($sleepInterval = EnvHelper::checkSleepInterval()) {
             $msg = sprintf("Sleep in interval %s", $sleepInterval);
             $output->writeln($msg);
-            if($this->logger) {
+            if ($this->logger) {
                 $this->logger->warning($msg);
             }
             return 0;
         }
 
         $clean = $input->getOption('clean');
-        if($clean) {
+        if ($clean) {
             $command = $this->getApplication()->find($clean);
             $this->cleanJob($command->getName());
             $output->writeln($command->getName() . " will be executed now");
@@ -86,7 +86,7 @@ 
         }
 
         $cleanAll = $input->getOption('all');
-        if($cleanAll) {
+        if ($cleanAll) {
             $this->cleanJob();
             $output->writeln("All commands will be executed now");
             return 0;
@@ -111,10 +111,10 @@ 
         $lastExec = 0;
         $hasError = false;
 
-        foreach($jobs as $cmd => $job) {
+        foreach ($jobs as $cmd => $job) {
             $execTime = $job['last_exec'];
-            if($execTime > $lastExec) $lastExec = $execTime;
-            if(!empty($job['error'])) {
+            if ($execTime > $lastExec) $lastExec = $execTime;
+            if (!empty($job['error'])) {
                 $hasError = true;
             }
         }
@@ -133,7 +133,7 @@ 
             'Status',
         ];
 
-        if($hasError) {
+        if ($hasError) {
             $header[] = 'Error';
         }
 
@@ -143,15 +143,15 @@ 
         ]);
 
         $cnt = 1;
-        foreach($jobs as $cmd => $job) {
-            if($cnt > 1) $table->addRow(new TableSeparator());
+        foreach ($jobs as $cmd => $job) {
+            if ($cnt > 1) $table->addRow(new TableSeparator());
             $row = [
                 $cmd,
                 $job['period'],
                 ($job['last_exec'] ? date("d.m.Y H:i:s", $job['last_exec']) : 'NONE'),
                 $job['status'],
             ];
-            if($hasError) {
+            if ($hasError) {
                 $row[] = $job['error'];
             }
             $table->addRow($row);
@@ -165,9 +165,9 @@ 
 
         $crontab = [];
 
-        if($command) {
+        if ($command) {
             $crontab = $this->getCronTab();
-            if($crontab === false) {
+            if ($crontab === false) {
                 return false;
             }
             unset($crontab[$command]);
@@ -182,7 +182,7 @@ 
         $allTimeout = EnvHelper::getCrontabTimeout();
         $workTime = 0;
 
-        if(is_array($jobs) && !empty($jobs)) {
+        if (is_array($jobs) && !empty($jobs)) {
 
             /*
              * Минимально допустимый период выполнения одной задачи
@@ -191,9 +191,9 @@ 
             $this->minAgentPeriod = (count($jobs) + 1) * EnvHelper::getBxCrontabPeriod();
             $this->logger->alert(sprintf("Minimal agent period: %d", $this->minAgentPeriod));
 
-            foreach($jobs as $cmd => $job) {
+            foreach ($jobs as $cmd => $job) {
 
-                if($this->isActualJob($job)) {
+                if ($this->isActualJob($job)) {
 
                     $job['status'] = self::EXEC_STATUS_WORK;
                     $this->updateJob($cmd, $job);
@@ -207,12 +207,12 @@ 
                         $returnCode = $command->run($cmdInput, $output);
                         $execTime = microtime(true) - $timeStart;
 
-                        if(!$returnCode) {
+                        if (!$returnCode) {
 
                             $job['status'] = self::EXEC_STATUS_SUCCESS;
 
                             $msg = sprintf("%s: SUCCESS [%.2f s]", $cmd, $execTime);
-                            if($this->logger) {
+                            if ($this->logger) {
                                 $this->logger->alert($msg);
                             }
                             $output->writeln(PHP_EOL . $msg);
@@ -223,7 +223,7 @@ 
                             $job['error_code'] = $returnCode;
 
                             $msg = sprintf("%s: ERROR [%.2f s]", $cmd, $execTime);
-                            if($this->logger) {
+                            if ($this->logger) {
                                 $this->logger->alert($msg);
                             }
                             $output->writeln(PHP_EOL . $msg);
@@ -235,14 +235,14 @@ 
                         $job['error'] = $e->getMessage();
 
 
-                        if($this->logger) {
+                        if ($this->logger) {
                             $this->logger->error($e, ['command' => $cmd]);
                         }
                         $output->writeln(PHP_EOL . 'ERROR: ' . $e->getMessage());
 
                     } finally {
 
-                        if(!$execTime) {
+                        if (!$execTime) {
                             $execTime = microtime(true) - $timeStart;
                         }
                         $job['last_exec'] = time();
@@ -252,7 +252,7 @@ 
                     $this->updateJob($cmd, $job);
 
                     $workTime += $execTime;
-                    if($workTime * 2 > $allTimeout) {
+                    if ($workTime * 2 > $allTimeout) {
                         break;
                     }
                     /*
@@ -266,21 +266,21 @@ 
 
     protected function isActualJob(&$job) {
 
-        if($job['status'] == self::EXEC_STATUS_WORK) {
+        if ($job['status'] == self::EXEC_STATUS_WORK) {
             return false;
         }
 
         $period = intval($job['period']);
 
-        if($period > 0) {
-            if($period < $this->minAgentPeriod) {
+        if ($period > 0) {
+            if ($period < $this->minAgentPeriod) {
                 $job['orig_period'] = $period;
                 $period = $job['period'] = $this->minAgentPeriod;
             }
-            if(time() - $job['last_exec'] >= $period) {
+            if (time() - $job['last_exec'] >= $period) {
                 return true;
             }
-        } else if(!empty($job['times'])) {
+        } else if (!empty($job['times'])) {
             //TODO:
         }
 
@@ -290,7 +290,7 @@ 
     public function getCronJobs() {
 
         $crontab = $this->getCronTab();
-        if($crontab === false) {
+        if ($crontab === false) {
             return false;
         }
 
@@ -300,9 +300,9 @@ 
         $commands = $app->all();
 
         $selfCommands = [];
-        foreach($commands as $command) {
+        foreach ($commands as $command) {
             /** @var BxCommand $command */
-            if($command instanceof BxCommand) {
+            if ($command instanceof BxCommand) {
                 $name = $command->getName();
                 $selfCommands[$name] = [
                     'object' => $command,
@@ -312,19 +312,19 @@ 
 
         $agents = [];
         $reader = new AnnotationReader();
-        foreach($selfCommands as $cmd => $selfCommand) {
+        foreach ($selfCommands as $cmd => $selfCommand) {
             $reflectionClass = new \ReflectionClass($selfCommand['object']);
             $annotations = $reader->getClassAnnotations($reflectionClass);
 
-            foreach($annotations as $annotation) {
-                if($annotation instanceof Agent) {
+            foreach ($annotations as $annotation) {
+                if ($annotation instanceof Agent) {
                     $agents[$cmd] = $annotation->toArray();
                 }
             }
         }
 
-        foreach($crontab as $cmd => $job) {
-            if(is_array($job) && isset($agents[$cmd])) {
+        foreach ($crontab as $cmd => $job) {
+            if (is_array($job) && isset($agents[$cmd])) {
                 $agents[$cmd] = array_merge($job, $agents[$cmd]);
             }
         }
@@ -343,7 +343,7 @@ 
 
         $crontab = $this->getCronTab();
 
-        if($crontab === false) {
+        if ($crontab === false) {
             return false;
         } else {
             $crontab = array_merge($crontab, $changedAgents);
@@ -361,7 +361,7 @@ 
         $fh = fopen($filename, 'c');
         if (flock($fh, LOCK_EX)) {
             ftruncate($fh, 0);
-            if(!fwrite($fh, json_encode($agents, JSON_PRETTY_PRINT))) {
+            if (!fwrite($fh, json_encode($agents, JSON_PRETTY_PRINT))) {
                 throw new \Exception('Unable to write BX_CRONTAB : ' . $filename);
             }
         } else {
@@ -381,16 +381,16 @@ 
         $filename = EnvHelper::getCrontabFile();
 
         $fh = fopen($filename, 'r');
-        if(!$fh) {
+        if (!$fh) {
             return false;
         }
-        if(flock($fh, LOCK_SH)) {
+        if (flock($fh, LOCK_SH)) {
             $cronTab = [];
             clearstatcache();
             $filesize = (int) filesize($filename);
-            if($filesize > 0 && $data = fread($fh, $filesize)) {
+            if ($filesize > 0 && $data = fread($fh, $filesize)) {
                 $decoded = json_decode($data, true);
-                if(is_array($decoded)) {
+                if (is_array($decoded)) {
                     $cronTab = $decoded;
                 } else {
                     throw new \Exception("Unable to parse cronTab");
@@ -407,14 +407,14 @@ 
 
     protected function sortCronTab(array &$crontab, $sort = self::SORT_NAME) {
 
-        if($sort == self::SORT_TIME) {
+        if ($sort == self::SORT_TIME) {
             $sorting = [];
-            foreach($crontab as $cmd => $data) {
+            foreach ($crontab as $cmd => $data) {
                 $sorting[$cmd] = $data['last_exec'];
             }
             arsort($sorting, SORT_NUMERIC);
             $sorted = [];
-            foreach($sorting as $cmd => $time) {
+            foreach ($sorting as $cmd => $time) {
                 $sorted[$cmd] = $crontab[$cmd];
             }
             $crontab = $sorted;