CommonMutableContainerTrait::addAll() - Code Metrics - Inspection of "Merge branch 'master' of github.com:italolelis/col..." - italolelis/collections - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 747a6a...c6c655 )

by Ítalo

created 2016-06-24 22:26 UTC

CommonMutableContainerTrait::addAll() B

↳ Parent: CommonMutableContainerTrait

Complexity

Conditions	5
Paths	5

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	5.2742

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	17
ccs	7
cts	9
cp	0.7778
rs	8.8571
cc	5
eloc	9
nc	5
nop	1
crap	5.2742

<?php

namespace Collections\Traits;

use Collections\ArrayList;
use Collections\Iterable;
use Collections\Iterator\LazyKeysIterable;
use Collections\MapInterface;
use Collections\Pair;

trait CommonMutableContainerTrait
{
    /**
     * {@inheritdoc}
     */
    public function addAll($items)
    {
        $this->validateTraversable($items);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $isMap = $items instanceof MapInterface;

        foreach ($items as $key => $value) {
            if (is_array($value)) {
                $value = new static($value);

            }

            if ($isMap && !$value instanceof Pair) {
                $value = new Pair($key, $value);
            }

            $this->add($value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }

    /**
     * {@inheritdoc}
     */
    public function values()
    {
        return new ArrayList($this);
    }

    public function keys()
    {
        return new ArrayList(new LazyKeysIterable($this));
    }

    /**
     * {@inheritDoc}
     */
    public function concat($iterable)
    {
        if ($iterable instanceof Iterable) {
            $iterable = $iterable->toArray();
        }

        return new static(array_merge_recursive($this->toArray(), $iterable));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * {@inheritdoc}
     */
    public function clear()
    {
        $old = $this->container;
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->container = [];

        unset($old);

        return $this;
    }
}


1		<?php
2
3		namespace Collections\Traits;
4
5		use Collections\ArrayList;
6		use Collections\Iterable;
7		use Collections\Iterator\LazyKeysIterable;
8		use Collections\MapInterface;
9		use Collections\Pair;
10
11		trait CommonMutableContainerTrait
12		{
13		/**
14		* {@inheritdoc}
15	1	*/
16		public function addAll($items)
17	1	{
18		$this->validateTraversable($items);
		0 ignored issues – show Bug introduced 2016-06-24 22:28 UTC by Report Bug Copy Issue Report It seems like `validateTraversable()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19		$isMap = $items instanceof MapInterface;
20
21		foreach ($items as $key => $value) {
22		if (is_array($value)) {
23	2	$value = new static($value);
		0 ignored issues – show Unused Code introduced 2016-06-24 22:28 UTC by Report Bug Copy Issue Report The call to `CommonMutableContainerTrait::__construct()` has too many arguments starting with `$value`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
24		}
25	1
26	1	if ($isMap && !$value instanceof Pair) {
27	1	$value = new Pair($key, $value);
28		}
29
30	1	$this->add($value);
		0 ignored issues – show Bug introduced 2016-06-24 22:28 UTC by Report Bug Copy Issue Report It seems like `add()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31		}
32	1	}
33
34	2	/**
35		* {@inheritdoc}
36		*/
37	3	public function values()
38	3	{
39	1	return new ArrayList($this);
40	1	}
41	1
42	1	public function keys()
43		{
44	1	return new ArrayList(new LazyKeysIterable($this));
45		}
46
47		/**
48		* {@inheritDoc}
49		*/
50	17	public function concat($iterable)
51		{
52	17	if ($iterable instanceof Iterable) {
53	17	$iterable = $iterable->toArray();
54	16	}
55	6
56	6	return new static(array_merge_recursive($this->toArray(), $iterable));
		0 ignored issues – show Bug introduced 2016-06-24 22:28 UTC by Report Bug Copy Issue Report It seems like `toArray()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Unused Code introduced 2016-06-24 22:28 UTC by Report Bug Copy Issue Report The call to `CommonMutableContainerTrait::__construct()` has too many arguments starting with `array_merge_recursive($t...->toArray(), $iterable)`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
57	16	}
58	1
59	17	/**
60		* {@inheritdoc}
61	17	*/
62		public function clear()
63		{
64		$old = $this->container;
		0 ignored issues – show Bug introduced 2016-06-24 22:28 UTC by Report Bug Copy Issue Report The property `container` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
65
66		$this->container = [];
67	1
68		unset($old);
69	1
70	1	return $this;
71	1	}
72		}
73

italolelis / collections

Push — master ( 747a6a...c6c655 )

CommonMutableContainerTrait::addAll() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like