Collections\Traits\CommonMutableContainerTrait

Complexity

Total Complexity

10

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Test Coverage

Coverage

93.94%

Importance

Changes	10
Bugs	4	Features	2

5 Methods

Rating	Name	Duplication	Size	Complexity
B	addAll()	0	17	5
A	values()	0	4	1
A	keys()	0	4	1
A	concat()	0	8	2
A	clear()	0	10	1

<?php

namespace Collections\Traits;

use Collections\ArrayList;
use Collections\Iterable;
use Collections\Iterator\LazyKeysIterable;
use Collections\MapInterface;
use Collections\Pair;

trait CommonMutableContainerTrait
{
    /**
     * {@inheritdoc}
     */
    public function addAll($items)
    {
        $this->validateTraversable($items);

It seems like validateTraversable() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $isMap = $items instanceof MapInterface;

        foreach ($items as $key => $value) {
            if (is_array($value)) {
                $value = new static($value);

The call to CommonMutableContainerTrait::__construct() has too many arguments starting with $value.

            }

            if ($isMap && !$value instanceof Pair) {
                $value = new Pair($key, $value);
            }

            $this->add($value);

It seems like add() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }
    }

    /**
     * {@inheritdoc}
     */
    public function values()
    {
        return new ArrayList($this);
    }

    public function keys()
    {
        return new ArrayList(new LazyKeysIterable($this));
    }

    /**
     * {@inheritDoc}
     */
    public function concat($iterable)
    {
        if ($iterable instanceof Iterable) {
            $iterable = $iterable->toArray();
        }

        return new static(array_merge_recursive($this->toArray(), $iterable));

It seems like toArray() must be provided by classes using this trait. How about adding it as abstract method to this trait?

The call to CommonMutableContainerTrait::__construct() has too many arguments starting with array_merge_recursive($this->toArray(), $iterable).

    }

    /**
     * {@inheritdoc}
     */
    public function clear()
    {
        $old = $this->container;

The property container does not exist. Did you maybe forget to declare it?

        $this->container = [];

        unset($old);

        return $this;
    }
}