CommonImmMutableContainerTrait::concat() - Code Metrics - Inspection of "Merge branch 'master' of github.com:italolelis/col..." - italolelis/collections - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 747a6a...c6c655 )

by Ítalo

created 2016-06-24 22:26 UTC

CommonImmMutableContainerTrait::concat() A

↳ Parent: CommonImmMutableContainerTrait

Complexity

Conditions	3
Paths	4

Size

Total Lines	12
Code Lines	7

Duplication

Lines	12
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	12
loc	12
rs	9.4285
cc	3
eloc	7
nc	4
nop	1

<?php

namespace Collections\Traits;

use Collections\Immutable\ImmArrayList;
use Collections\Iterator\LazyConcatIterator;
use Collections\Iterator\LazyKeysIterable;

trait CommonImmMutableContainerTrait
{
    /**
     * {@inheritdoc}
     */
    public function values()
    {
        return $this->toImmVector();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function keys()
    {
        return new ImmArrayList(new LazyKeysIterable($this));
    }

    /**
     * {@inheritDoc}
     */
    public function concat($iterable)

    {
        if (is_array($iterable)) {
            $iterable = new ImmArrayList($iterable);
        }

        if ($iterable instanceof \Traversable) {
            return new ImmArrayList(new LazyConcatIterator($this, $iterable));
        } else {
            throw new \InvalidArgumentException('Parameter must be an array or an instance of Traversable');
        }
    }
}


1		<?php
2
3		namespace Collections\Traits;
4
5		use Collections\Immutable\ImmArrayList;
6		use Collections\Iterator\LazyConcatIterator;
7		use Collections\Iterator\LazyKeysIterable;
8
9		trait CommonImmMutableContainerTrait
10		{
11		/**
12		* {@inheritdoc}
13		*/
14		public function values()
15		{
16		return $this->toImmVector();
		0 ignored issues – show Bug introduced 2016-06-24 22:28 UTC by Report Bug Copy Issue Report It seems like `toImmVector()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
17		}
18
19		public function keys()
20		{
21		return new ImmArrayList(new LazyKeysIterable($this));
22		}
23
24		/**
25		* {@inheritDoc}
26		*/
27	View Code Duplication	public function concat($iterable)
		0 ignored issues – show Duplication introduced 2016-06-24 22:28 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28		{
29		if (is_array($iterable)) {
30		$iterable = new ImmArrayList($iterable);
31		}
32
33		if ($iterable instanceof \Traversable) {
34		return new ImmArrayList(new LazyConcatIterator($this, $iterable));
35		} else {
36		throw new \InvalidArgumentException('Parameter must be an array or an instance of Traversable');
37		}
38		}
39		}
40

italolelis / collections

Push — master ( 747a6a...c6c655 )

CommonImmMutableContainerTrait::concat() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like