Collections\Traits\CommonImmMutableContainerTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	31
Duplicated Lines	38.71 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	values()	0	4	1
A	keys()	0	4	1
A	concat()	12	12	3

<?php

namespace Collections\Traits;

use Collections\Immutable\ImmArrayList;
use Collections\Iterator\LazyConcatIterator;
use Collections\Iterator\LazyKeysIterable;

trait CommonImmMutableContainerTrait
{
    /**
     * {@inheritdoc}
     */
    public function values()
    {
        return $this->toImmVector();

It seems like toImmVector() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function keys()
    {
        return new ImmArrayList(new LazyKeysIterable($this));
    }

    /**
     * {@inheritDoc}
     */
    public function concat($iterable)

This method seems to be duplicated in your project.

    {
        if (is_array($iterable)) {
            $iterable = new ImmArrayList($iterable);
        }

        if ($iterable instanceof \Traversable) {
            return new ImmArrayList(new LazyConcatIterator($this, $iterable));
        } else {
            throw new \InvalidArgumentException('Parameter must be an array or an instance of Traversable');
        }
    }
}