irishdan / ResponsiveImageBundle

FileManager.php

Doc Comments +5 added lines, -5 removed lines

@@ -191,7 +191,7 @@ 
 
     /**
      * @param $fileName
-     * @return mixed
+     * @return boolean
      */
     public function fileExists($fileName)
     {
@@ -203,8 +203,8 @@ 
     /**
      * Deletes a directory and its contents or a file.
      *
-     * @param $target
-     * @return bool
+     * @param string $target
+     * @return boolean|null
      */
     public function deleteDirectory($target)
     {
@@ -231,7 +231,7 @@ 
 
     /**
      * @param $path
-     * @return bool
+     * @return boolean|null
      */
     public function deleteFile($path)
     {
@@ -389,7 +389,7 @@ 
     /**
      * Ensures that a string has a trailing slash or not.
      *
-     * @param      $path
+     * @param      boolean|string $path
      * @param bool $slash
      * @return string
      */

ImageMaker.php

Doc Comments +1 added lines, -1 removed lines

@@ -115,7 +115,7 @@
      *
      * @param       $source
      * @param       $destination
-     * @param array $style
+     * @param boolean $style
      * @param null  $cropFocusCoords
      * @return string
      */

Spacing +2 added lines, -2 removed lines

@@ -96,7 +96,7 @@ 
 
     protected function scaleImage($width, $height)
     {
-        $this->img->resize($width, $height, function ($constraint) {
+        $this->img->resize($width, $height, function($constraint) {
             $constraint->aspectRatio();
         });
     }
@@ -160,7 +160,7 @@ 
                         }
                     }
 
-                    $this->img->fit($this->styleData['width'], $this->styleData['height'], function ($constraint) {
+                    $this->img->fit($this->styleData['width'], $this->styleData['height'], function($constraint) {
                         $constraint->upsize();
                     });
 

ResponsiveImageManager.php

Doc Comments +3 added lines, -3 removed lines

@@ -82,9 +82,9 @@ 
      * Creates styled images for an image object.
      * Handles generation from the controller or the form.
      *
-     * @param $imageObject
+     * @param ResponsiveImageInterface $imageObject
      * @param $styleName
-     * @return mixed
+     * @return string
      */
     private function createImageDerivative($imageObject, $styleName = NULL)
     {
@@ -116,7 +116,7 @@ 
      *
      * @param ResponsiveImageInterface $image
      * @paran string $stylename
-     * @return image
+     * @return string
      */
     public function createStyledImages(ResponsiveImageInterface $image, $stylename = NULL)
     {

Spacing +4 added lines, -4 removed lines

@@ -227,13 +227,13 @@ 
             
             // Check if the file exists on the server.
             if (!$this->system->fileExists($filename)) {
-                $fetchFromS3 =  TRUE;
+                $fetchFromS3 = TRUE;
             }
             $tree = $this->system->getUploadsDirectory() . '/' . $filename;
             // If the policy was set to keep no files locally, then original should be downloaded from s3.
             if (!empty($fetchFromS3)) {
-                $s3key = empty($this->config['aws_s3']['directory']) ? $tree :  $this->config['aws_s3']['directory'] . '/' . $tree;
-                $this->system->directoryExists($directory , TRUE);
+                $s3key = empty($this->config['aws_s3']['directory']) ? $tree : $this->config['aws_s3']['directory'] . '/' . $tree;
+                $this->system->directoryExists($directory, TRUE);
                 $this->s3->fetchS3Object($path, $s3key);
             }
 
@@ -266,7 +266,7 @@ 
         $enabled = $this->s3enabled();
         if ($enabled) {
             $aws_config = $this->config['aws_s3'];
-            $remoteFilePolicy = empty($aws_config['remote_file_policy']) ? 'ALL': $aws_config['remote_file_policy'];
+            $remoteFilePolicy = empty($aws_config['remote_file_policy']) ? 'ALL' : $aws_config['remote_file_policy'];
 
             // If AWS is enabled.
             if ($enabled) {

Braces +3 added lines, -6 removed lines

@@ -96,8 +96,7 @@ 
         if (!empty($styleName)) {
             // $paths = [];
             $paths = [$styleName => $paths[$styleName]];
-        }
-        else {
+        } else {
             unset($paths[0]);
         }
 
@@ -175,8 +174,7 @@ 
         // @TODO: at yet implemented.
         if (empty($styles)) {
             // Delete all styled files.
-        }
-        else {
+        } else {
             // Delete files for the given style.
         }
     }
@@ -219,8 +217,7 @@ 
         $fetchFromS3 = FALSE;
         if (!empty($this->images[0])) {
             return $this->images[0][0];
-        }
-        else {
+        } else {
             // The original file is in difference places depending on the local file policy.
             $directory = $this->system->getStorageDirectory('original');
             $path = $directory . $filename;

StyleManager.php

Doc Comments +2 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
     /**
      * StyleManager constructor.
      *
-     * @param \ResponsiveImageBundle\FileManager $system
+     * @param FileManager $system
      * @param array                              $parameters
      */
     public function __construct(FileManager $system, array $parameters)
@@ -163,7 +163,7 @@ 
     /**
      * Prefixes url string with the displayPathPrefix string, if the style and the config require it.
      *
-     * @param $url
+     * @param string $url
      * @param $style
      * @return string
      */

Tests/Entity/TestImage.php

Doc Comments +3 added lines, -1 removed lines

@@ -67,6 +67,9 @@ 
         return $this->path;
     }
 
+    /**
+     * @param string $path
+     */
     public function setPath($path)
     {
         $this->path = $path;
@@ -156,7 +159,6 @@ 
     /**
      * Generates an <img> tag for a given style.
      *
-     * @param null $style
      * @return string
      */
     public function img()

Uploader.php

Doc Comments +3 added lines, -3 removed lines

@@ -67,7 +67,7 @@ 
      * Sanitizes and cleans up filename
      *
      * @param $str
-     * @return mixed
+     * @return string
      */
     private function createFilename($str)
     {
@@ -90,7 +90,7 @@ 
     /**
      * Convert MB/K/G to bytesize
      *
-     * @param $uploadMaxSize
+     * @param string $uploadMaxSize
      * @return int
      */
     public function mToBytes($uploadMaxSize)
@@ -118,7 +118,7 @@ 
     /**
      * Checks to see if a file name is unique in the storage directory.
      *
-     * @param $name
+     * @param string $name
      * @return bool
      */
     private function isUniqueFilename($name)

Form/ResponsiveImageType.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
             ->add('title')
             ->add('alt');
 
-        $builder->addEventListener(FormEvents::PRE_SET_DATA, function (FormEvent $event) {
+        $builder->addEventListener(FormEvents::PRE_SET_DATA, function(FormEvent $event) {
             $image = $event->getData();
             $form = $event->getForm();
             // Conditionally add form elements.

FocusCropDataCalculator.php

Spacing +2 added lines, -2 removed lines

@@ -101,9 +101,9 @@
         $focusY2 = $this->focusCoordinates[3];
 
         if ($type == 'near') {
-            $point = ${'focus' . $axis . '1'} - ${'crop' . $axis . '1'};
+            $point = ${'focus' . $axis . '1'} -${'crop' . $axis . '1'};
         } else {
-            $point = ${'focus' . $axis . '2'} - ${'crop' . $axis . '1'};
+            $point = ${'focus' . $axis . '2'} -${'crop' . $axis . '1'};
         }
 
         return $point;

DependencyInjection/Configuration.php

Indentation +2 added lines, -2 removed lines

@@ -104,8 +104,8 @@
                 //     ->values(['KEEP_ALL', 'KEEP_NONE', 'KEEP_ORIGINAL'])
                 // ->end()
                 ->enumNode('remote_file_policy')
-                   ->defaultValue('ALL')
-                   ->values(['ALL', 'STYLED_ONLY'])
+                    ->defaultValue('ALL')
+                    ->values(['ALL', 'STYLED_ONLY'])
                 ->end()
                 ->scalarNode('temp_directory')
                     ->defaultValue(null)