irishdan / ResponsiveImageBundle

ImageProcessing/ImageManager.php

Doc Comments +3 added lines

@@ -145,6 +145,9 @@
         return $this->fileSystem->has($path);
     }
 
+    /**
+     * @param string $customStyleString
+     */
     public function createCustomStyledImage(ResponsiveImageInterface $image, $customStyleString, $forceGenerate = false)
     {
         // @TODO: To avoid creating images, that already exist, check if it exists, need a way to disable this checking

Braces +1 added lines, -2 removed lines

@@ -123,8 +123,7 @@
     {
         if (!empty($style)) {
             $path = $this->styleManager->getStylePath($image, $style);
-        }
-        else {
+        } else {
             $path = $image->getPath();
         }
         $this->fileSystem->delete($path);

StyleManager.php

Doc Comments +3 added lines

@@ -60,6 +60,9 @@
         }
     }
 
+    /**
+     * @param string $src
+     */
     public function setImageAttributes(ResponsiveImageInterface $image, $styleName = null, $src = null)
     {
         // Use the style data to figure out the width and height for this image

Braces +4 added lines, -8 removed lines

@@ -98,8 +98,7 @@ 
 
         if (empty($coordinates)) {
             $geometry = new CoordinateGeometry(0, 0, $image->getWidth(), $image->getHeight());
-        }
-        else {
+        } else {
             $cropCoordinates = explode(':', $coordinates)[0];
             $points          = explode(',', $cropCoordinates);
             $geometry        = new CoordinateGeometry(
@@ -145,8 +144,7 @@ 
             if (strpos($styleName, 'custom_') === 0) {
                 return $this->styleDataFromCustomStyleString($styleName);
             }
-        }
-        else {
+        } else {
             return $this->styles[$styleName];
         }
 
@@ -240,8 +238,7 @@ 
                         // We need to derive the width.
                         $scaledDimensions = $this->getScaledDimensions($image, $styleData);
                         $width            = $scaledDimensions['width'];
-                    }
-                    else {
+                    } else {
                         $width = $styleData['width'];
                     }
 
@@ -268,8 +265,7 @@ 
 
         if (!empty($styleName)) {
             $stylePath = $this->buildStylePath($styleName, $filename);
-        }
-        else {
+        } else {
             $stylePath = $filename;
         }
 

Tests/Entity/TestImage.php

Doc Comments +3 added lines

@@ -60,6 +60,9 @@
         return $this->path;
     }
 
+    /**
+     * @param string $path
+     */
     public function setPath($path)
     {
         $this->path = $path;

Tests/ResponsiveImageTestCase.php

Doc Comments +3 added lines

@@ -77,6 +77,9 @@
         return $exitCode;
     }
 
+    /**
+     * @param string $serviceName
+     */
     protected function getService($serviceName)
     {
         if (empty($this->testKernel)) {

Braces +1 added lines, -2 removed lines

@@ -47,8 +47,7 @@
         foreach ($files as $file) {
             if (is_dir($file)) {
                 self::deleteDirectory($file);
-            }
-            else {
+            } else {
                 unlink($file);
             }
         }

Twig/ResponsiveImageExtension.php

Doc Comments +10 added lines, -10 removed lines

@@ -51,7 +51,7 @@ 
     }
 
     /**
-     * @return array
+     * @return \Twig_SimpleFunction[]
      */
     public function getFunctions()
     {
@@ -101,7 +101,7 @@ 
      * @param                          $pictureSetName
      * @param                          $selector
      *
-     * @return mixed|string
+     * @return string
      */
     public function generateBackgroundImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $pictureSetName, $selector)
     {
@@ -125,7 +125,7 @@ 
      * @param                          $pictureSetName
      * @param bool                     $generate
      *
-     * @return mixed|string
+     * @return string
      */
     public function generatePictureImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $pictureSetName, $generate = false)
     {
@@ -146,7 +146,7 @@ 
      * @internal
      *
      * @param array $data
-     * @param array $keys
+     * @param string[] $keys
      */
     private function convertPathsToUrls(array &$data, array $keys)
     {
@@ -188,7 +188,7 @@ 
      * @param                          $pictureSetName
      * @param bool                     $generate
      *
-     * @return mixed|string
+     * @return string
      */
     public function generateSizesImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $pictureSetName, $generate = false)
     {
@@ -216,7 +216,7 @@ 
      * @param null                     $styleName
      * @param bool                     $generate
      *
-     * @return mixed|string
+     * @return string
      */
     public function generateStyledImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $styleName = null, $generate = false)
     {
@@ -231,7 +231,7 @@ 
      * @param string                   $width
      * @param null                     $height
      *
-     * @return mixed|string
+     * @return string
      */
     public function cropImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $width = '', $height = null)
     {
@@ -250,7 +250,7 @@ 
      * @param string                   $width
      * @param string                   $height
      *
-     * @return mixed|string
+     * @return string
      */
     public function scaleImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $width = '', $height = '')
     {
@@ -266,9 +266,9 @@ 
     /**
      * @param \Twig_Environment        $environment
      * @param ResponsiveImageInterface $image
-     * @param null                     $styleName
+     * @param null|string                     $styleName
      *
-     * @return mixed|string
+     * @return string
      */
     protected function renderImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $styleName = null)
     {

Braces +2 added lines, -4 removed lines

@@ -157,8 +157,7 @@ 
                     $subData[$item] = $this->createPublicFileUrl($path);
                 }
                 $data[$key] = $subData;
-            }
-            else {
+            } else {
                 $data[$key] = $this->createPublicFileUrl($data[$key]);
             }
         }
@@ -274,8 +273,7 @@ 
     {
         if (!empty($styleName)) {
             $path = $this->styleManager->getStylePath($image, $styleName);
-        }
-        else {
+        } else {
             $path = $image->getPath();
         }
 

Controller/ImageController.php

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
                 $response->setExpires(date_create()->modify('+1 years'));
 
                 $response->setCallback(
-                    function () use ($stream) {
+                    function() use ($stream) {
                         if (ftell($stream['stream']) !== 0) {
                             rewind($stream['stream']);
                         }

Braces +2 added lines, -4 removed lines

@@ -68,12 +68,10 @@
                 );
 
                 return $response;
-            }
-            else {
+            } else {
                 throw $this->createNotFoundException('Derived image could not be created');
             }
-        }
-        else {
+        } else {
             throw $this->createNotFoundException('The file does not exist');
         }
     }

Command/GenerateImageEntityCommand.php

Spacing +6 added lines, -6 removed lines

@@ -153,7 +153,7 @@ 
 
             $question->setValidator(['Sensio\Bundle\GeneratorBundle\Command\Validators', 'validateBundleName']);
             $question->setNormalizer(
-                function ($value) {
+                function($value) {
                     return $value ? trim($value) : '';
                 }
             );
@@ -176,7 +176,7 @@ 
                 $input->getOption('entity_name')
             );
             $question->setValidator(
-                function ($answer) {
+                function($answer) {
                     // Should only contain letters.
                     $valid = preg_match('/^[a-zA-Z]+$/', $answer);
                     if (!$valid) {
@@ -189,7 +189,7 @@ 
                 }
             );
             $question->setNormalizer(
-                function ($value) {
+                function($value) {
                     return $value ? trim($value) : '';
                 }
             );
@@ -269,18 +269,18 @@ 
             ), 'yes'
         );
         $question->setNormalizer(
-            function ($value) {
+            function($value) {
                 return $value[0] == 'y' ? 'y' : 'n';
             }
         );
         $question->setValidator(
-            function ($answer) {
+            function($answer) {
                 // Should only contain letters.
                 $allowed = [
                     'y',
                     'n',
                 ];
-                $valid   = in_array($answer, $allowed);
+                $valid = in_array($answer, $allowed);
                 if (!$valid) {
                     throw new \RuntimeException(
                         'Only allowed values are ' . implode(', ', $allowed)

Braces +1 added lines, -2 removed lines

@@ -138,8 +138,7 @@
                 throw new \RuntimeException(
                     'Aborting, overwrite permission is needed.'
                 );
-            }
-            else {
+            } else {
                 $this->overwrite = true;
             }
         }

Command/GenerateImageEntityCrudCommand.php

Braces +1 added lines, -2 removed lines

@@ -141,8 +141,7 @@
         $output->write('Updating the routing: ');
         if ('annotation' != $format) {
             $runner($this->updateRouting($questionHelper, $input, $output, $bundle, $format, $entity, $prefix));
-        }
-        else {
+        } else {
             $runner($this->updateAnnotationRouting($bundle, $entity, $prefix));
         }
 

Form/ResponsiveImageType.php

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
 
         $builder->addEventListener(
             FormEvents::PRE_SET_DATA,
-            function (FormEvent $event) {
+            function(FormEvent $event) {
                 $image = $event->getData();
                 $form  = $event->getForm();
                 // Conditionally add form elements.

Braces +1 added lines, -2 removed lines

@@ -56,8 +56,7 @@
                             'data' => $image,
                         ]
                     );
-                }
-                else {
+                } else {
                     $form->add('file', FileType::class, ['label' => 'Upload an image']);
                 }
             }