irishdan / ResponsiveImageBundle

ImageProcessing/ImageManager.php

Doc Comments +3 added lines

@@ -145,6 +145,9 @@
         return $this->fileSystem->has($path);
     }
 
+    /**
+     * @param string $customStyleString
+     */
     public function createCustomStyledImage(ResponsiveImageInterface $image, $customStyleString, $forceGenerate = false)
     {
         // @TODO: To avoid creating images, that already exist, check if it exists, need a way to disable this checking

StyleManager.php

Doc Comments +3 added lines

@@ -60,6 +60,9 @@
         }
     }
 
+    /**
+     * @param string $src
+     */
     public function setImageAttributes(ResponsiveImageInterface $image, $styleName = null, $src = null)
     {
         // Use the style data to figure out the width and height for this image

Tests/Entity/TestImage.php

Doc Comments +3 added lines

@@ -60,6 +60,9 @@
         return $this->path;
     }
 
+    /**
+     * @param string $path
+     */
     public function setPath($path)
     {
         $this->path = $path;

Tests/ResponsiveImageTestCase.php

Doc Comments +3 added lines

@@ -77,6 +77,9 @@
         return $exitCode;
     }
 
+    /**
+     * @param string $serviceName
+     */
     protected function getService($serviceName)
     {
         if (empty($this->testKernel)) {

Twig/ResponsiveImageExtension.php

Doc Comments +10 added lines, -10 removed lines

@@ -51,7 +51,7 @@ 
     }
 
     /**
-     * @return array
+     * @return \Twig_SimpleFunction[]
      */
     public function getFunctions()
     {
@@ -101,7 +101,7 @@ 
      * @param                          $pictureSetName
      * @param                          $selector
      *
-     * @return mixed|string
+     * @return string
      */
     public function generateBackgroundImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $pictureSetName, $selector)
     {
@@ -125,7 +125,7 @@ 
      * @param                          $pictureSetName
      * @param bool                     $generate
      *
-     * @return mixed|string
+     * @return string
      */
     public function generatePictureImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $pictureSetName, $generate = false)
     {
@@ -146,7 +146,7 @@ 
      * @internal
      *
      * @param array $data
-     * @param array $keys
+     * @param string[] $keys
      */
     private function convertPathsToUrls(array &$data, array $keys)
     {
@@ -188,7 +188,7 @@ 
      * @param                          $pictureSetName
      * @param bool                     $generate
      *
-     * @return mixed|string
+     * @return string
      */
     public function generateSizesImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $pictureSetName, $generate = false)
     {
@@ -216,7 +216,7 @@ 
      * @param null                     $styleName
      * @param bool                     $generate
      *
-     * @return mixed|string
+     * @return string
      */
     public function generateStyledImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $styleName = null, $generate = false)
     {
@@ -231,7 +231,7 @@ 
      * @param string                   $width
      * @param null                     $height
      *
-     * @return mixed|string
+     * @return string
      */
     public function cropImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $width = '', $height = null)
     {
@@ -250,7 +250,7 @@ 
      * @param string                   $width
      * @param string                   $height
      *
-     * @return mixed|string
+     * @return string
      */
     public function scaleImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $width = '', $height = '')
     {
@@ -266,9 +266,9 @@ 
     /**
      * @param \Twig_Environment        $environment
      * @param ResponsiveImageInterface $image
-     * @param null                     $styleName
+     * @param null|string                     $styleName
      *
-     * @return mixed|string
+     * @return string
      */
     protected function renderImage(\Twig_Environment $environment, ResponsiveImageInterface $image, $styleName = null)
     {

Controller/ImageController.php

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
                 $response->setExpires(date_create()->modify('+1 years'));
 
                 $response->setCallback(
-                    function () use ($stream) {
+                    function() use ($stream) {
                         if (ftell($stream['stream']) !== 0) {
                             rewind($stream['stream']);
                         }

Command/GenerateImageEntityCommand.php

Spacing +6 added lines, -6 removed lines

@@ -153,7 +153,7 @@ 
 
             $question->setValidator(['Sensio\Bundle\GeneratorBundle\Command\Validators', 'validateBundleName']);
             $question->setNormalizer(
-                function ($value) {
+                function($value) {
                     return $value ? trim($value) : '';
                 }
             );
@@ -176,7 +176,7 @@ 
                 $input->getOption('entity_name')
             );
             $question->setValidator(
-                function ($answer) {
+                function($answer) {
                     // Should only contain letters.
                     $valid = preg_match('/^[a-zA-Z]+$/', $answer);
                     if (!$valid) {
@@ -189,7 +189,7 @@ 
                 }
             );
             $question->setNormalizer(
-                function ($value) {
+                function($value) {
                     return $value ? trim($value) : '';
                 }
             );
@@ -269,18 +269,18 @@ 
             ), 'yes'
         );
         $question->setNormalizer(
-            function ($value) {
+            function($value) {
                 return $value[0] == 'y' ? 'y' : 'n';
             }
         );
         $question->setValidator(
-            function ($answer) {
+            function($answer) {
                 // Should only contain letters.
                 $allowed = [
                     'y',
                     'n',
                 ];
-                $valid   = in_array($answer, $allowed);
+                $valid = in_array($answer, $allowed);
                 if (!$valid) {
                     throw new \RuntimeException(
                         'Only allowed values are ' . implode(', ', $allowed)

Form/ResponsiveImageType.php

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
 
         $builder->addEventListener(
             FormEvents::PRE_SET_DATA,
-            function (FormEvent $event) {
+            function(FormEvent $event) {
                 $image = $event->getData();
                 $form  = $event->getForm();
                 // Conditionally add form elements.

ImageProcessing/ImageStyler.php

Spacing +2 added lines, -2 removed lines

@@ -98,7 +98,7 @@ 
         $this->image->resize(
             $width,
             $height,
-            function ($constraint) {
+            function($constraint) {
                 $constraint->aspectRatio();
             }
         );
@@ -177,7 +177,7 @@ 
                     $this->image->fit(
                         $this->styleData['width'],
                         $this->styleData['height'],
-                        function ($constraint) {
+                        function($constraint) {
                             $constraint->upsize();
                         }
                     );

Doc Comments +6 added lines, -2 removed lines

@@ -120,8 +120,8 @@ 
      * Performs the image manipulation using current style information
      * and user defined crop and focus rectangles.
      *
-     * @param       $source
-     * @param       $destination
+     * @param       string $source
+     * @param       string $destination
      * @param array $style
      * @param null $cropFocusCoords
      *
@@ -177,6 +177,10 @@ 
                     $this->image->fit(
                         $this->styleData['width'],
                         $this->styleData['height'],
+
+                        /**
+                         * @param string $constraint
+                         */
                         function ($constraint) {
                             $constraint->upsize();
                         }