irishdan / NotificationBundle

Command/CreateDatabaseNotificationCommand.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 
         // @TODO: Add existing bundle validation
         $question->setValidator(['Sensio\Bundle\GeneratorBundle\Command\Validators', 'validateBundleName']);
-        $question->setNormalizer(function ($value) {
+        $question->setNormalizer(function($value) {
             return $value ? trim($value) : '';
         });
         $question->setMaxAttempts(2);

DatabaseNotificationManager.php

Doc Comments +3 added lines, -3 removed lines

@@ -84,7 +84,7 @@ 
 
     /**
      * @param DatabaseNotificationInterface $notification
-     * @param null                          $now
+     * @param null|\DateTime                          $now
      * @param bool                          $flush
      */
     public function setReadAtDate(DatabaseNotificationInterface $notification, $now = null, $flush = true)
@@ -104,7 +104,7 @@ 
 
     /**
      * @param NotifiableInterface $notifiable
-     * @param null                $now
+     * @param \DateTime                $now
      */
     public function setUsersNotificationsAsRead(NotifiableInterface $notifiable, $now = null)
     {
@@ -159,7 +159,7 @@ 
     }
 
     /**
-     * @return bool|mixed
+     * @return string
      */
     protected function notificationEntityName()
     {

NotificationManager.php

Doc Comments +2 added lines, -2 removed lines

@@ -112,7 +112,7 @@ 
 
     /**
      * @param DatabaseNotificationInterface $notification
-     * @return bool
+     * @return boolean|null
      */
     public function markAsRead(DatabaseNotificationInterface $notification)
     {
@@ -128,7 +128,7 @@ 
 
     /**
      * @param NotifiableInterface $user
-     * @return bool
+     * @return boolean|null
      */
     public function markAllAsRead(NotifiableInterface $user)
     {

Adapter/BaseMessageAdapter.php

Doc Comments +2 added lines, -2 removed lines

@@ -39,7 +39,7 @@ 
      * @param $data
      * @param $user
      * @param $template
-     * @return mixed
+     * @return string
      */
     protected function renderTwigTemplate($data, $user, $template)
     {
@@ -138,7 +138,7 @@ 
     }
 
     /**
-     * @param mixed $channeName
+     * @param string $channelName
      */
     public function setChannelName($channelName)
     {

DependencyInjection/Configuration.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace IrishDan\NotificationBundle\DependencyInjection;
 
-use IrishDan\NotificationBundle\DependencyInjection\Factory\BroadcasterFactory;
 use IrishDan\NotificationBundle\DependencyInjection\Factory\ChannelFactory;
 use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;

Command/CreateNotificationCommand.php

Spacing +5 added lines, -5 removed lines

@@ -62,7 +62,7 @@ 
         // @TODO: Add existing bundle validation
         $question->setValidator(['Sensio\Bundle\GeneratorBundle\Command\Validators', 'validateBundleName']);
         $question->setNormalizer(
-            function ($value) {
+            function($value) {
                 return $value ? trim($value) : '';
             }
         );
@@ -85,7 +85,7 @@ 
             $input->getOption('notification_name')
         );
         $question->setValidator(
-            function ($answer) {
+            function($answer) {
                 // Should only contain letters.
                 $valid = preg_match('/^[a-zA-Z]+$/', $answer);
                 if (!$valid) {
@@ -98,7 +98,7 @@ 
             }
         );
         $question->setNormalizer(
-            function ($value) {
+            function($value) {
                 return $value ? trim($value) : '';
             }
         );
@@ -164,13 +164,13 @@ 
             ), 'yes'
         );
         $question->setNormalizer(
-            function ($value) {
+            function($value) {
                 return $value[0] == 'y' ? 'y' : 'n';
             }
         );
 
         $question->setValidator(
-            function ($answer) {
+            function($answer) {
                 // Should only contain letters.
                 $allowed = [
                     'y',

Doc Comments +3 added lines

@@ -157,6 +157,9 @@
         $questionHelper->writeGeneratorSummary($output, []);
     }
 
+    /**
+     * @param InputInterface $input
+     */
     protected function createYesNoQuestion($questionHelper, $input, $channel)
     {
         $question = new Question(

DependencyInjection/NotificationExtension.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use IrishDan\NotificationBundle\DependencyInjection\Factory\BroadcasterFactory;
 use IrishDan\NotificationBundle\DependencyInjection\Factory\ChannelFactory;
 use Symfony\Component\Config\FileLocator;
-use Symfony\Component\DependencyInjection\Compiler\PassConfig;
 use Symfony\Component\DependencyInjection\Definition;
 use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
 use Symfony\Component\DependencyInjection\Reference;

EventListener/MessageCRUDSubscriber.php

Doc Comments +4 added lines

@@ -64,6 +64,10 @@
         ];
     }
 
+    /**
+     * @param string $string
+     * @param \IrishDan\NotificationBundle\Message\MessageInterface $message
+     */
     protected function log($string, $message)
     {
         if ($this->logger) {

Subscriber/NotificationChannelSubscriber.php

Unused Use Statements -5 removed lines

@@ -4,13 +4,8 @@
 
 use IrishDan\NotificationBundle\Adapter\MessageAdapterInterface;
 use IrishDan\NotificationBundle\Channel\ChannelInterface;
-use IrishDan\NotificationBundle\Channel\EventChannel;
-use IrishDan\NotificationBundle\Event\MessageCreatedEvent;
-use IrishDan\NotificationBundle\Event\MessageDispatchedEvent;
 use IrishDan\NotificationBundle\Event\NotificationReadyToFormatEvent;
 use IrishDan\NotificationBundle\Exception\MessageDispatchException;
-use IrishDan\NotificationBundle\Message\MessageInterface;
-use Psr\Log\LoggerInterface;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 

Spacing +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
         // get the adapter name from the
         // $adapterKey = $message->getChannel();
         $adapterKey = $this->channelConfigMap[$notification->getChannel()]['adapter'];
-        $channelConfiguration =  $this->channelConfigMap[$notification->getChannel()]['config'];
+        $channelConfiguration = $this->channelConfigMap[$notification->getChannel()]['config'];
 
         // Get the adapter for this channel
         // and inject it into the adapterless channel