irishdan / NotificationBundle

Command/CreateDatabaseNotificationCommand.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 
         // @TODO: Add existing bundle validation
         $question->setValidator(['Sensio\Bundle\GeneratorBundle\Command\Validators', 'validateBundleName']);
-        $question->setNormalizer(function ($value) {
+        $question->setNormalizer(function($value) {
             return $value ? trim($value) : '';
         });
         $question->setMaxAttempts(2);

NotificationCollection.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
     public function markAsRead()
     {
         // @TODO: sort it.
-        $this->entities->forAll(function ($notification) {
+        $this->entities->forAll(function($notification) {
             $notification->markAsRead();
         });
     }

Command/CreateNotificationCommand.php

Spacing +6 added lines, -6 removed lines

@@ -62,7 +62,7 @@ 
         // @TODO: Add existing bundle validation
         $question->setValidator(['Sensio\Bundle\GeneratorBundle\Command\Validators', 'validateBundleName']);
         $question->setNormalizer(
-            function ($value) {
+            function($value) {
                 return $value ? trim($value) : '';
             }
         );
@@ -85,7 +85,7 @@ 
             $input->getOption('notification_name')
         );
         $question->setValidator(
-            function ($answer) {
+            function($answer) {
                 // Should only contain letters.
                 $valid = preg_match('/^[a-zA-Z]+$/', $answer);
                 if (!$valid) {
@@ -98,7 +98,7 @@ 
             }
         );
         $question->setNormalizer(
-            function ($value) {
+            function($value) {
                 return $value ? trim($value) : '';
             }
         );
@@ -164,19 +164,19 @@ 
             ), 'yes'
         );
         $question->setNormalizer(
-            function ($value) {
+            function($value) {
                 return $value[0] == 'y' ? 'y' : 'n';
             }
         );
 
         $question->setValidator(
-            function ($answer) {
+            function($answer) {
                 // Should only contain letters.
                 $allowed = [
                     'y',
                     'n',
                 ];
-                $valid   = in_array($answer, $allowed);
+                $valid = in_array($answer, $allowed);
                 if (!$valid) {
                     throw new \RuntimeException(
                         'Only allowed value are ' . implode(', ', $allowed)

Doc Comments +12 added lines

@@ -155,6 +155,10 @@ 
         $questionHelper->writeGeneratorSummary($output, []);
     }
 
+    /**
+     * @param \Sensio\Bundle\GeneratorBundle\Command\Helper\QuestionHelper $questionHelper
+     * @param InputInterface $input
+     */
     protected function createYesNoQuestion($questionHelper, $input, $channel)
     {
         $question = new Question(
@@ -164,12 +168,20 @@ 
             ), 'yes'
         );
         $question->setNormalizer(
+
+            /**
+             * @param \Sensio\Bundle\GeneratorBundle\Command\Helper\QuestionHelper $value
+             */
             function ($value) {
                 return $value[0] == 'y' ? 'y' : 'n';
             }
         );
 
         $question->setValidator(
+
+            /**
+             * @param \Sensio\Bundle\GeneratorBundle\Command\Helper\QuestionHelper $answer
+             */
             function ($answer) {
                 // Should only contain letters.
                 $allowed = [

DependencyInjection/NotificationExtension.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace IrishDan\NotificationBundle\DependencyInjection;
 
-use IrishDan\NotificationBundle\DependencyInjection\Factory\Broadcaster\SlackBroadcasterFactory;
 use Symfony\Component\DependencyInjection\Definition;
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\HttpKernel\DependencyInjection\Extension;

Doc Comments +3 added lines

@@ -86,6 +86,9 @@
         }
     }
 
+    /**
+     * @param ContainerBuilder $container
+     */
     private function createBroadcaster($name, $broadcaster, $container)
     {
         // @TODO:

Channel/EventChannel.php

Braces +1 added lines, -2 removed lines

@@ -72,8 +72,7 @@
         try {
             if (!empty($this->dispatchers[$dispatcherKey])) {
                 $this->dispatchers[$dispatcherKey]->dispatch($message);
-            }
-            else {
+            } else {
                 throw new MessageDispatchException(
                     sprintf('No dispatcher available with key "%s"', $dispatcherKey)
                 );

Test/Channel/EventChannelTest.php

Indentation +2 added lines, -2 removed lines

@@ -21,8 +21,8 @@
         $this->notification = $this->getNotificationWithUser();
 
         $this->eventDispatcher = $this->getMockBuilder(EventDispatcherInterface::class)
-                                      ->disableOriginalConstructor()
-                                      ->getMock();
+                                        ->disableOriginalConstructor()
+                                        ->getMock();
 
         $this->eventChannel = new EventChannel($this->eventDispatcher);
     }

PusherManager.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
             'cluster'   => $this->config['cluster'],
             'encrypted' => $this->config['encrypted'],
         ];
-        $pusher  = new \Pusher(
+        $pusher = new \Pusher(
             $this->config['auth_key'],
             $this->config['secret'],
             $this->config['app_id'],

DatabaseNotificationManager.php

Doc Comments +3 added lines, -3 removed lines

@@ -84,7 +84,7 @@ 
 
     /**
      * @param DatabaseNotificationInterface $notification
-     * @param null                          $now
+     * @param null|\DateTime                          $now
      * @param bool                          $flush
      */
     public function setReadAtDate(DatabaseNotificationInterface $notification, $now = null, $flush = true)
@@ -104,7 +104,7 @@ 
 
     /**
      * @param NotifiableInterface $notifiable
-     * @param null                $now
+     * @param \DateTime                $now
      */
     public function setUsersNotificationsAsRead(NotifiableInterface $notifiable, $now = null)
     {
@@ -159,7 +159,7 @@ 
     }
 
     /**
-     * @return bool|mixed
+     * @return string
      */
     protected function notificationEntityName()
     {

Broadcast/Broadcaster.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace IrishDan\NotificationBundle\Broadcast;
 
 use IrishDan\NotificationBundle\Channel\ChannelInterface;
-use IrishDan\NotificationBundle\Notification\NotifiableInterface;
 use IrishDan\NotificationBundle\Notification\NotificationInterface;
 
 class Broadcaster