Roulette::get() - Code Metrics - Inspection of "merge" - irfaardy/php-gatcha - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 08b4be...8d11b6 )

by IRFA

created 2020-03-21 13:55 UTC

Roulette::get() A

↳ Parent: Roulette

Complexity

Conditions	5
Paths	7

Size

Total Lines	22
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	13
c	0
b	0
f	0
dl	0
loc	22
rs	9.5222
cc	5
nc	7
nop	1

<?php 
/* 
	Author:Irfa Ardiansyah <[email protected]>
	Simple Items Gatcha with PHP
*/
namespace Irfa\Gatcha\Roulette;

use Exception;
use Irfa\Gatcha\Roulette\RateUp;

class Roulette extends RateUp {
 	
 	protected static function jsonItem($dt){
 		$data['data'] = ['item' => $dt];

 		return json_encode($data);
 	}
 	protected static function itemDropUp($item_list, $items, $rate)
 	{
 		return self::_itemDropUp($item_list, $items, $rate);
 	}
	protected static function get($items) {
		if (is_array($items))
		{
			$max = 0;
			foreach ($items as $key => $value) {
				$max += $value;
				$items[$key] = $max;
			}

			$random = mt_rand(1, $max);

				foreach ($items as $item => $max)
				{
					if ($random <= $max) {
						break;
					}
				}
				 return $item;

		} else {
				throw new Exception('Parameter must be an array.');

				return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
		}
	}
	
}

1			<?php
2			/*
3			Author:Irfa Ardiansyah <[email protected]>
4			Simple Items Gatcha with PHP
5			*/
6			namespace Irfa\Gatcha\Roulette;
7
8			use Exception;
9			use Irfa\Gatcha\Roulette\RateUp;
10
11			class Roulette extends RateUp {
12
13			protected static function jsonItem($dt){
14			$data['data'] = ['item' => $dt];
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-03-21 13:56 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Loading history...
15			return json_encode($data);
16			}
17			protected static function itemDropUp($item_list, $items, $rate)
18			{
19			return self::_itemDropUp($item_list, $items, $rate);
20			}
21			protected static function get($items) {
22			if (is_array($items))
23			{
24			$max = 0;
25			foreach ($items as $key => $value) {
26			$max += $value;
27			$items[$key] = $max;
28			}
29
30			$random = mt_rand(1, $max);
31
32			foreach ($items as $item => $max)
33			{
34			if ($random <= $max) {
35			break;
36			}
37			}
38			return $item;
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-03-19 04:24 UTC by Report Bug Copy Issue Report The variable `$item` seems to be defined by a `foreach` iteration on line `32`. Are you sure the iterator is never empty, otherwise this variable is not defined? Loading history...
39			} else {
40			throw new Exception('Parameter must be an array.');
41
42			return false;
			0 ignored issues – show Unused Code introduced 2020-03-19 04:24 UTC by Report Bug Copy Issue Report `return false` is not reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
43			}
44			}
45
46			}

irfaardy / php-gatcha

Push — master ( 08b4be...8d11b6 )

Roulette::get() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like