Irfa\Gatcha\Roulette\Roulette

Complexity

Total Complexity

7

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	jsonItem()	0	3	1
A	get()	0	22	5
A	itemDropUp()	0	3	1

<?php 
/* 
	Author:Irfa Ardiansyah <irfa.backend@protonmail.com>
	Simple Items Gatcha with PHP
*/
namespace Irfa\Gatcha\Roulette;

use Exception;
use Irfa\Gatcha\Roulette\RateUp;

class Roulette extends RateUp {
 	
 	protected static function jsonItem($dt){
 		$data['data'] = ['item' => $dt];

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

 		return json_encode($data);
 	}
 	protected static function itemDropUp($item_list, $items, $rate)
 	{
 		return self::_itemDropUp($item_list, $items, $rate);
 	}
	protected static function get($items) {
		if (is_array($items))
		{
			$max = 0;
			foreach ($items as $key => $value) {
				$max += $value;
				$items[$key] = $max;
			}

			$random = mt_rand(1, $max);

				foreach ($items as $item => $max)
				{
					if ($random <= $max) {
						break;
					}
				}
				 return $item;

The variable $item seems to be defined by a foreach iteration on line 32. Are you sure the iterator is never empty, otherwise this variable is not defined?

		} else {
				throw new Exception('Parameter must be an array.');

				return false;

return false is not reachable.

		}
	}
	
}