Inspection of "Updated Directory Structure" - iqltechnologies/brighty - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — main (c9f3a5)

by TARIQ

created 2022-04-21 06:53 UTC

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -2,18 +2,18 @@
 block discarded – undo
 
 $error = false;
 
-	// $req = {
-	// 	$name => "PHP Version",
-	// 	$check => (version_compare(PHP_VERSION, '7.2.5') >= 0)
-	// }
+    // $req = {
+    // 	$name => "PHP Version",
+    // 	$check => (version_compare(PHP_VERSION, '7.2.5') >= 0)
+    // }
 
 
 class Requirements{
 
 	
-	__construct(){
+    __construct(){
 
-	}
+    }
 }
 
 if (version_compare(PHP_VERSION, '7.2.5') >= 0) {

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -8,7 +8,7 @@
 block discarded – undo
 	// }
 
 
-class Requirements{
+class Requirements {
 
 	
 	__construct(){

Please login to merge, or discard this patch.

www/brighty/public/install/installer.class.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -33,16 +33,16 @@  discard block
 block discarded – undo
         ];
     }
 
-    public function add_requirement($requirement){
+    public function add_requirement($requirement) {
 
 
     }
 
-    public function is_installation_finished(){
+    public function is_installation_finished() {
 
-        if ( file_exists($new_installation->config_path) &&
+        if (file_exists($new_installation->config_path) &&
             (!isset($_POST['step']) || isset($_POST['step']) 
-            && $_POST['step'] !== Install::$last_step)){
+            && $_POST['step'] !== Install::$last_step)) {
 
                 return true;
 
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
                     }
                 }
 
-                if (! $this->copy_app_config()) {
+                if (!$this->copy_app_config()) {
                     $config_copy_failed = true;
                 }
 

Please login to merge, or discard this patch.

www/brighty/public/install/html.php 3 patches

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -47,10 +47,10 @@
 block discarded – undo
                   </div>
                   <?php } ?>
                   <?php if($step == 1){
-                     include_once('requirements.php');
-                     } else if($step == 2){
-                     include_once('file_permissions.php');
-                     } else if($step == 3){ ?>
+                        include_once('requirements.php');
+                        } else if($step == 2){
+                        include_once('file_permissions.php');
+                        } else if($step == 3){ ?>
                   <?php echo '<form action="" method="post" accept-charset="utf-8">'; ?>
                   <?php echo '<input type="hidden" name="step" value="'.$step.'">'; ?>
                   <div class="form-group">

Please login to merge, or discard this patch.

Spacing +21 added lines, -21 removed lines patch added patch discarded remove patch

@@ -18,41 +18,41 @@  discard block
 block discarded – undo
                </div>
                <div class="row" style="padding: 20px;padding-bottom: 0;
 ">
-                  <div class="col-3 text-center <?php if($passed_steps[1] == true || $step == 1){echo 'bg-default';} ?> padding-10">
+                  <div class="col-3 text-center <?php if ($passed_steps[1] == true || $step == 1) {echo 'bg-default'; } ?> padding-10">
                      <h5>Requirements</h5>
                   </div>
-                  <div class="col-2 text-center <?php if($passed_steps[2] || $step == 2){echo 'bg-default';} else {echo 'bg-not-passed';} ?> padding-10">
+                  <div class="col-2 text-center <?php if ($passed_steps[2] || $step == 2) {echo 'bg-default'; } else {echo 'bg-not-passed'; } ?> padding-10">
                      <h5>Permissions</h5>
                   </div>
-                  <div class="col-3 text-center <?php if($passed_steps[3] || $step == 3){echo 'bg-default';} else {echo 'bg-not-passed';} ?> padding-10">
+                  <div class="col-3 text-center <?php if ($passed_steps[3] || $step == 3) {echo 'bg-default'; } else {echo 'bg-not-passed'; } ?> padding-10">
                      <h5> Database setup</h5>
                   </div>
-                  <div class="col-2 text-center <?php if($passed_steps[4] || $step == 4){echo 'bg-default';} else {echo 'bg-not-passed';} ?> padding-10">
+                  <div class="col-2 text-center <?php if ($passed_steps[4] || $step == 4) {echo 'bg-default'; } else {echo 'bg-not-passed'; } ?> padding-10">
                      <h5> Install</h5>
                   </div>
-                  <div class="finish col-2 text-center <?php if($step == 5){echo 'bg-success';}else {echo 'bg-not-passed';} ?> padding-10">
+                  <div class="finish col-2 text-center <?php if ($step == 5) {echo 'bg-success'; } else {echo 'bg-not-passed'; } ?> padding-10">
                      <h5> Finish</h5>
                   </div>
                </div>
                <div class="install-row">
                   <p style="padding:20px 10px">This is a list of all system requirements to install <?php echo $this->software_name; ?>. Based on the test results, current status is listed below. Please fix any unfulfilled requirement to be able to proceed further. </p>
-                  <?php if($debug != ''){ ?>
+                  <?php if ($debug != '') { ?>
                   <p class="sql-debug-alert text-success" style="margin-bottom:20px;">
                      <b><?php echo $debug; ?></b>
                   </p>
                   <?php } ?>
-                  <?php if(isset($error) && $error != ''){ ?>
+                  <?php if (isset($error) && $error != '') { ?>
                   <div class="alert alert-danger text-center">
                      <?php echo $error; ?>
                   </div>
                   <?php } ?>
-                  <?php if($step == 1){
+                  <?php if ($step == 1) {
                      include_once('requirements.php');
-                     } else if($step == 2){
+                     } else if ($step == 2) {
                      include_once('file_permissions.php');
-                     } else if($step == 3){ ?>
+                     } else if ($step == 3) { ?>
                   <?php echo '<form action="" method="post" accept-charset="utf-8">'; ?>
-                  <?php echo '<input type="hidden" name="step" value="'.$step.'">'; ?>
+                  <?php echo '<input type="hidden" name="step" value="' . $step . '">'; ?>
                   <div class="form-group">
                      <label for="hostname" class="control-label">Hostname</label>
                      <input type="text" class="form-control" name="hostname" value="localhost">
@@ -74,13 +74,13 @@  discard block
 block discarded – undo
                      <button type="submit" class="btn btn-success">Check Database</button>
                   </div>
                   </form>
-                  <?php } else if($step == 4){ ?>
+                  <?php } else if ($step == 4) { ?>
                   <?php echo '<form action="" method="post" accept-charset="utf-8" id="installForm">'; ?>
-                  <?php echo '<input type="hidden" name="step" value="'.$step.'">'; ?>
-                  <?php echo '<input type="hidden" name="hostname" value="'.$_POST['hostname'].'">'; ?>
-                  <?php echo '<input type="hidden" name="username" value="'.$_POST['username'].'">'; ?>
-                  <?php echo '<input type="hidden" name="password" value="'.$_POST['password'].'">'; ?>
-                  <?php echo '<input type="hidden" name="database" value="'.$_POST['database'].'">'; ?>
+                  <?php echo '<input type="hidden" name="step" value="' . $step . '">'; ?>
+                  <?php echo '<input type="hidden" name="hostname" value="' . $_POST['hostname'] . '">'; ?>
+                  <?php echo '<input type="hidden" name="username" value="' . $_POST['username'] . '">'; ?>
+                  <?php echo '<input type="hidden" name="password" value="' . $_POST['password'] . '">'; ?>
+                  <?php echo '<input type="hidden" name="database" value="' . $_POST['database'] . '">'; ?>
                   <div class="form-group">
                      <div class="form-group">
                         <label for="base_url" class="control-label">Base URL <a href="https://help.perfexcrm.com/faq/what-is-base-url/" target="_blank">Read more...</a></label>
@@ -128,9 +128,9 @@  discard block
 block discarded – undo
                      <label for="timezone" class="control-label">Timezone</label>
                      <select name="timezone" data-live-search="true" id="timezone" class="form-control" required data-none-selected-text="Select system timezone">
                         <option value=""></option>
-                        <?php foreach($this->get_timezones_list() as $key => $timezones){ ?>
+                        <?php foreach ($this->get_timezones_list() as $key => $timezones) { ?>
                         <optgroup label="<?php echo $key; ?>">
-                           <?php foreach($timezones as $timezone){ ?>
+                           <?php foreach ($timezones as $timezone) { ?>
                            <option value="<?php echo $timezone; ?>"><?php echo $timezone; ?></option>
                            <?php } ?>
                         </optgroup>
@@ -142,9 +142,9 @@  discard block
 block discarded – undo
                      <button type="submit" class="btn btn-success" id="installBtn">Install</button>
                   </div>
                   </form>
-                  <?php } else if($step == 5){ ?>
+                  <?php } else if ($step == 5) { ?>
                   <h4 class="bold">Installation successful!</h4>
-                  <?php if(isset($config_copy_failed)){ ?>
+                  <?php if (isset($config_copy_failed)) { ?>
                   <p class="text-danger">
                      Failed to copy application/config/app-config-sample.php. Please navigate to application/config/ and copy the file app-config-sample.php and rename it to app-config.php
                   </p>

Please login to merge, or discard this patch.

Braces +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@
 block discarded – undo
                   <div class="col-2 text-center <?php if($passed_steps[4] || $step == 4){echo 'bg-default';} else {echo 'bg-not-passed';} ?> padding-10">
                      <h5> Install</h5>
                   </div>
-                  <div class="finish col-2 text-center <?php if($step == 5){echo 'bg-success';}else {echo 'bg-not-passed';} ?> padding-10">
+                  <div class="finish col-2 text-center <?php if($step == 5){echo 'bg-success';} else {echo 'bg-not-passed';} ?> padding-10">
                      <h5> Finish</h5>
                   </div>
                </div>

Please login to merge, or discard this patch.

www/brighty/public/install/file_permissions.php 2 patches

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -211,7 +211,7 @@
 block discarded – undo
     echo '<input type="hidden" name="permissions_success" value="true">';
     echo '<div class="text-left">';
     echo '<button type="submit" class="btn btn-success">Setup Database</button>';
-     echo '</div>';
+        echo '</div>';
     echo '</form>';
     echo '</div>';
 }

Please login to merge, or discard this patch.

Spacing +20 added lines, -20 removed lines patch added patch discarded remove patch

@@ -1,114 +1,114 @@  discard block
 block discarded – undo
 <?php
 $error = false;
-if (!is_writable('../uploads/estimates')){
+if (!is_writable('../uploads/estimates')) {
     $error = true;
     $requirement_estimates = "<span class='label label-danger'>No (Make uploads/estimates writable) - Permissions 0755</span>";
 } else {
     $requirement_estimates = "<span class='label label-success'>Ok</span>";
 }
-if (!is_writable('../uploads/proposals')){
+if (!is_writable('../uploads/proposals')) {
     $error = true;
     $requirement_proposals = "<span class='label label-danger'>No (Make uploads/proposals writable) - Permissions 0755</span>";
 } else {
     $requirement_proposals = "<span class='label label-success'>Ok</span>";
 }
-if (!is_writable('../uploads/ticket_attachments')){
+if (!is_writable('../uploads/ticket_attachments')) {
     $error = true;
     $requirement1 = "<span class='label label-danger'>No (Make uploads/ticket_attachments writable) - Permissions 0755</span>";
 } else {
     $requirement1 = "<span class='label label-success'>Ok</span>";
 }
-if (!is_writable('../uploads/tasks')){
+if (!is_writable('../uploads/tasks')) {
     $error = true;
     $requirement2 = "<span class='label label-danger'>No (Make uploads/tasks writable) - Permissions 0755</span>";
 } else {
     $requirement2 = "<span class='label label-success'>Ok</span>";
 }
-if (!is_writable('../uploads/staff_profile_images')){
+if (!is_writable('../uploads/staff_profile_images')) {
     $error = true;
     $requirement3 = "<span class='label label-danger'>No (Make uploads/staff_profile_images writable) - Permissions 0755</span>";
 } else {
     $requirement3 = "<span class='label label-success'>Ok</span>";
 }
-if (!is_writable('../uploads/projects')){
+if (!is_writable('../uploads/projects')) {
     $error = true;
     $requirement4 = "<span class='label label-danger'>No (Make uploads/projects writable) - Permissions 0755</span>";
 } else {
     $requirement4 = "<span class='label label-success'>Ok</span>";
 }
-if (!is_writable('../uploads/newsfeed')){
+if (!is_writable('../uploads/newsfeed')) {
     $error = true;
     $requirement5 = "<span class='label label-danger'>No (Make uploads/newsfeed writable) - Permissions 0755</span>";
 } else {
     $requirement5 = "<span class='label label-success'>Ok</span>";
 }
-if (!is_writable('../uploads/leads')){
+if (!is_writable('../uploads/leads')) {
     $error = true;
     $requirement6 = "<span class='label label-danger'>No (Make uploads/leads writable) - Permissions 0755</span>";
 } else {
     $requirement6 = "<span class='label label-success'>Ok</span>";
 }
-if (!is_writable('../uploads/invoices')){
+if (!is_writable('../uploads/invoices')) {
     $error = true;
     $requirement7 = "<span class='label label-danger'>No (Make uploads/invoices writable) - Permissions 0755</span>";
 } else {
     $requirement7 = "<span class='label label-success'>Ok</span>";
 }
-if (!is_writable('../uploads/expenses')){
+if (!is_writable('../uploads/expenses')) {
     $error = true;
     $requirement8 = "<span class='label label-danger'>No (Make uploads/expenses writable) - Permissions 0755</span>";
 } else {
     $requirement8 = "<span class='label label-success'>Ok</span>";
 }
-if (!is_writable('../uploads/discussions')){
+if (!is_writable('../uploads/discussions')) {
     $error = true;
     $requirement9 = "<span class='label label-danger'>No (Make uploads/discussions writable) - Permissions 0755</span>";
 } else {
     $requirement9 = "<span class='label label-success'>Ok</span>";
 }
-if (!is_writable('../uploads/contracts')){
+if (!is_writable('../uploads/contracts')) {
     $error = true;
     $requirement10 = "<span class='label label-danger'>No (Make uploads/contracts writable) - Permissions 0755</span>";
 } else {
     $requirement10 = "<span class='label label-success'>Ok</span>";
 }
-if (!is_writable('../uploads/company')){
+if (!is_writable('../uploads/company')) {
     $error = true;
     $requirement11 = "<span class='label label-danger'>No (Make uploads/company writable) - Permissions 0755</span>";
 } else {
     $requirement11 = "<span class='label label-success'>Ok</span>";
 }
-if (!is_writable('../uploads/clients')){
+if (!is_writable('../uploads/clients')) {
     $error = true;
     $requirement12 = "<span class='label label-danger'>No (Make uploads/clients writable) - Permissions 0755</span>";
 } else {
     $requirement12 = "<span class='label label-success'>Ok</span>";
 }
-if (!is_writable('../uploads/client_profile_images')){
+if (!is_writable('../uploads/client_profile_images')) {
     $error = true;
     $requirement13 = "<span class='label label-danger'>No (Make uploads/client_profile_images writable) - Permissions 0755</span>";
 } else {
     $requirement13 = "<span class='label label-success'>Ok</span>";
 }
-if (!is_writable('../application/config')){
+if (!is_writable('../application/config')) {
     $error = true;
     $requirement14 = "<span class='label label-danger'>No (Make application/config/ writable - Permissions 0755</span>";
 } else {
     $requirement14 = "<span class='label label-success'>Ok</span>";
 }
-if (!is_writable('../application/config/config.php')){
+if (!is_writable('../application/config/config.php')) {
     $error = true;
     $requirement15 = "<span class='label label-danger'>No (Make application/config/config.php writable) - Permissions 0644</span>";
 } else {
     $requirement15 = "<span class='label label-success'>Ok</span>";
 }
-if (!is_writable('../application/config/app-config-sample.php')){
+if (!is_writable('../application/config/app-config-sample.php')) {
     $error = true;
     $requirement16 = "<span class='label label-danger'>No (Make application/config/app-config-sample.php writable) - Permissions - 0644</span>";
 } else {
     $requirement16 = "<span class='label label-success'>Ok</span>";
 }
-if (!is_writable('../temp')){
+if (!is_writable('../temp')) {
     $error = true;
     $requirement17 = "<span class='label label-danger'>No (Make temp folder writable) - Permissions 0755</span>";
 } else {
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
     </tbody>
 </table>
 <hr />
-<?php if ($error == true){
+<?php if ($error == true) {
     echo '<div class="text-center alert alert-danger">You need to fix the requirements in order to install Perfex CRM</div>';
 } else {
     echo '<div class="text-center">';

Please login to merge, or discard this patch.

www/brighty/app/Config/Database.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -63,7 +63,7 @@
 block discarded – undo
         'password' => '',
         'database' => ':memory:',
         'DBDriver' => 'SQLite3',
-        'DBPrefix' => 'db_',  // Needed to ensure we're working correctly with prefixes live. DO NOT REMOVE FOR CI DEVS
+        'DBPrefix' => 'db_', // Needed to ensure we're working correctly with prefixes live. DO NOT REMOVE FOR CI DEVS
         'pConnect' => false,
         'DBDebug'  => (ENVIRONMENT !== 'production'),
         'charset'  => 'utf8',

Please login to merge, or discard this patch.

www/brighty/app/Config/Events.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -22,7 +22,7 @@  discard block
 block discarded – undo
  *      Events::on('create', [$myInstance, 'myMethod']);
  */
 
-Events::on('pre_system', static function () {
+Events::on('pre_system', static function() {
     if (ENVIRONMENT !== 'testing') {
         if (ini_get('zlib.output_compression')) {
             throw FrameworkException::forEnabledZlibOutputCompression();
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
             ob_end_flush();
         }
 
-        ob_start(static function ($buffer) {
+        ob_start(static function($buffer) {
             return $buffer;
         });
     }
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
      * --------------------------------------------------------------------
      * If you delete, they will no longer be collected.
      */
-    if (CI_DEBUG && ! is_cli()) {
+    if (CI_DEBUG && !is_cli()) {
         Events::on('DBQuery', 'CodeIgniter\Debug\Toolbar\Collectors\Database::collect');
         Services::toolbar()->respond();
     }

Please login to merge, or discard this patch.

www/brighty/app/Config/Constants.php 1 patch

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -35,11 +35,11 @@  discard block
 block discarded – undo
  */
 defined('SECOND') || define('SECOND', 1);
 defined('MINUTE') || define('MINUTE', 60);
-defined('HOUR')   || define('HOUR', 3600);
-defined('DAY')    || define('DAY', 86400);
-defined('WEEK')   || define('WEEK', 604800);
-defined('MONTH')  || define('MONTH', 2592000);
-defined('YEAR')   || define('YEAR', 31536000);
+defined('HOUR') || define('HOUR', 3600);
+defined('DAY') || define('DAY', 86400);
+defined('WEEK') || define('WEEK', 604800);
+defined('MONTH') || define('MONTH', 2592000);
+defined('YEAR') || define('YEAR', 31536000);
 defined('DECADE') || define('DECADE', 315360000);
 
 /*
@@ -67,13 +67,13 @@  discard block
 block discarded – undo
  |       http://tldp.org/LDP/abs/html/exitcodes.html
  |
  */
-defined('EXIT_SUCCESS')        || define('EXIT_SUCCESS', 0); // no errors
-defined('EXIT_ERROR')          || define('EXIT_ERROR', 1); // generic error
-defined('EXIT_CONFIG')         || define('EXIT_CONFIG', 3); // configuration error
-defined('EXIT_UNKNOWN_FILE')   || define('EXIT_UNKNOWN_FILE', 4); // file not found
-defined('EXIT_UNKNOWN_CLASS')  || define('EXIT_UNKNOWN_CLASS', 5); // unknown class
+defined('EXIT_SUCCESS') || define('EXIT_SUCCESS', 0); // no errors
+defined('EXIT_ERROR') || define('EXIT_ERROR', 1); // generic error
+defined('EXIT_CONFIG') || define('EXIT_CONFIG', 3); // configuration error
+defined('EXIT_UNKNOWN_FILE') || define('EXIT_UNKNOWN_FILE', 4); // file not found
+defined('EXIT_UNKNOWN_CLASS') || define('EXIT_UNKNOWN_CLASS', 5); // unknown class
 defined('EXIT_UNKNOWN_METHOD') || define('EXIT_UNKNOWN_METHOD', 6); // unknown class member
-defined('EXIT_USER_INPUT')     || define('EXIT_USER_INPUT', 7); // invalid user input
-defined('EXIT_DATABASE')       || define('EXIT_DATABASE', 8); // database error
-defined('EXIT__AUTO_MIN')      || define('EXIT__AUTO_MIN', 9); // lowest automatically-assigned error code
-defined('EXIT__AUTO_MAX')      || define('EXIT__AUTO_MAX', 125); // highest automatically-assigned error code
+defined('EXIT_USER_INPUT') || define('EXIT_USER_INPUT', 7); // invalid user input
+defined('EXIT_DATABASE') || define('EXIT_DATABASE', 8); // database error
+defined('EXIT__AUTO_MIN') || define('EXIT__AUTO_MIN', 9); // lowest automatically-assigned error code
+defined('EXIT__AUTO_MAX') || define('EXIT__AUTO_MAX', 125); // highest automatically-assigned error code

Please login to merge, or discard this patch.

www/brighty/app/Config/Mimes.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -491,7 +491,7 @@
 block discarded – undo
     {
         $extension = trim(strtolower($extension), '. ');
 
-        if (! array_key_exists($extension, static::$mimes)) {
+        if (!array_key_exists($extension, static::$mimes)) {
             return null;
         }
 

Please login to merge, or discard this patch.

www/brighty/app/Views/errors/html/error_404.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -73,7 +73,7 @@
 block discarded – undo
 		<h1>404 - File Not Found</h1>
 
 		<p>
-			<?php if (! empty($message) && $message !== '(null)') : ?>
+			<?php if (!empty($message) && $message !== '(null)') : ?>
 				<?= nl2br(esc($message)) ?>
 			<?php else : ?>
 				Sorry! Cannot seem to find the page you were looking for.

Please login to merge, or discard this patch.

		@@ -211,7 +211,7 @@
		block discarded – undo
211	211	echo '<input type="hidden" name="permissions_success" value="true">';
212	212	echo '<div class="text-left">';
213	213	echo '<button type="submit" class="btn btn-success">Setup Database</button>';
214		- echo '</div>';
	214	+ echo '</div>';
215	215	echo '</form>';
216	216	echo '</div>';
217	217	}

		@@ -491,7 +491,7 @@
		block discarded – undo
491	491	{
492	492	$extension = trim(strtolower($extension), '. ');
493	493
494		- if (! array_key_exists($extension, static::$mimes)) {
	494	+ if (!array_key_exists($extension, static::$mimes)) {
495	495	return null;
496	496	}
497	497

		@@ -2,18 +2,18 @@
		block discarded – undo
2	2
3	3	$error = false;
4	4
5		- // $req = {
6		- // $name => "PHP Version",
7		- // $check => (version_compare(PHP_VERSION, '7.2.5') >= 0)
8		- // }
	5	+ // $req = {
	6	+ // $name => "PHP Version",
	7	+ // $check => (version_compare(PHP_VERSION, '7.2.5') >= 0)
	8	+ // }
9	9
10	10
11	11	class Requirements{
12	12
13	13
14		- __construct(){
	14	+ __construct(){
15	15
16		- }
	16	+ }
17	17	}
18	18
19	19	if (version_compare(PHP_VERSION, '7.2.5') >= 0) {

		@@ -8,7 +8,7 @@
		block discarded – undo
8	8	// }
9	9
10	10
11		-class Requirements{
	11	+class Requirements {
12	12
13	13
14	14	__construct(){

		@@ -33,16 +33,16 @@ discard block
		block discarded – undo
33	33	];
34	34	}
35	35
36		- public function add_requirement($requirement){
	36	+ public function add_requirement($requirement) {
37	37
38	38
39	39	}
40	40
41		- public function is_installation_finished(){
	41	+ public function is_installation_finished() {
42	42
43		- if ( file_exists($new_installation->config_path) &&
	43	+ if (file_exists($new_installation->config_path) &&
44	44	(!isset($_POST['step']) \|\| isset($_POST['step'])
45		- && $_POST['step'] !== Install::$last_step)){
	45	+ && $_POST['step'] !== Install::$last_step)) {
46	46
47	47	return true;
48	48
		@@ -144,7 +144,7 @@ discard block
		block discarded – undo
144	144	}
145	145	}
146	146
147		- if (! $this->copy_app_config()) {
	147	+ if (!$this->copy_app_config()) {
148	148	$config_copy_failed = true;
149	149	}
150	150

		@@ -47,10 +47,10 @@
		block discarded – undo
47	47	</div>
48	48	<?php } ?>
49	49	<?php if($step == 1){
50		- include_once('requirements.php');
51		- } else if($step == 2){
52		- include_once('file_permissions.php');
53		- } else if($step == 3){ ?>
	50	+ include_once('requirements.php');
	51	+ } else if($step == 2){
	52	+ include_once('file_permissions.php');
	53	+ } else if($step == 3){ ?>
54	54	<?php echo '<form action="" method="post" accept-charset="utf-8">'; ?>
55	55	<?php echo '<input type="hidden" name="step" value="'.$step.'">'; ?>
56	56	<div class="form-group">

		@@ -18,41 +18,41 @@ discard block
		block discarded – undo
18	18	</div>
19	19	<div class="row" style="padding: 20px;padding-bottom: 0;
20	20	">
21		- <div class="col-3 text-center <?php if($passed_steps[1] == true \|\| $step == 1){echo 'bg-default';} ?> padding-10">
	21	+ <div class="col-3 text-center <?php if ($passed_steps[1] == true \|\| $step == 1) {echo 'bg-default'; } ?> padding-10">
22	22	<h5>Requirements</h5>
23	23	</div>
24		- <div class="col-2 text-center <?php if($passed_steps[2] \|\| $step == 2){echo 'bg-default';} else {echo 'bg-not-passed';} ?> padding-10">
	24	+ <div class="col-2 text-center <?php if ($passed_steps[2] \|\| $step == 2) {echo 'bg-default'; } else {echo 'bg-not-passed'; } ?> padding-10">
25	25	<h5>Permissions</h5>
26	26	</div>
27		- <div class="col-3 text-center <?php if($passed_steps[3] \|\| $step == 3){echo 'bg-default';} else {echo 'bg-not-passed';} ?> padding-10">
	27	+ <div class="col-3 text-center <?php if ($passed_steps[3] \|\| $step == 3) {echo 'bg-default'; } else {echo 'bg-not-passed'; } ?> padding-10">
28	28	<h5> Database setup</h5>
29	29	</div>
30		- <div class="col-2 text-center <?php if($passed_steps[4] \|\| $step == 4){echo 'bg-default';} else {echo 'bg-not-passed';} ?> padding-10">
	30	+ <div class="col-2 text-center <?php if ($passed_steps[4] \|\| $step == 4) {echo 'bg-default'; } else {echo 'bg-not-passed'; } ?> padding-10">
31	31	<h5> Install</h5>
32	32	</div>
33		- <div class="finish col-2 text-center <?php if($step == 5){echo 'bg-success';}else {echo 'bg-not-passed';} ?> padding-10">
	33	+ <div class="finish col-2 text-center <?php if ($step == 5) {echo 'bg-success'; } else {echo 'bg-not-passed'; } ?> padding-10">
34	34	<h5> Finish</h5>
35	35	</div>
36	36	</div>
37	37	<div class="install-row">
38	38	<p style="padding:20px 10px">This is a list of all system requirements to install <?php echo $this->software_name; ?>. Based on the test results, current status is listed below. Please fix any unfulfilled requirement to be able to proceed further. </p>
39		- <?php if($debug != ''){ ?>
	39	+ <?php if ($debug != '') { ?>
40	40	<p class="sql-debug-alert text-success" style="margin-bottom:20px;">
41	41	<b><?php echo $debug; ?></b>
42	42	</p>
43	43	<?php } ?>
44		- <?php if(isset($error) && $error != ''){ ?>
	44	+ <?php if (isset($error) && $error != '') { ?>
45	45	<div class="alert alert-danger text-center">
46	46	<?php echo $error; ?>
47	47	</div>
48	48	<?php } ?>
49		- <?php if($step == 1){
	49	+ <?php if ($step == 1) {
50	50	include_once('requirements.php');
51		- } else if($step == 2){
	51	+ } else if ($step == 2) {
52	52	include_once('file_permissions.php');
53		- } else if($step == 3){ ?>
	53	+ } else if ($step == 3) { ?>
54	54	<?php echo '<form action="" method="post" accept-charset="utf-8">'; ?>
55		- <?php echo '<input type="hidden" name="step" value="'.$step.'">'; ?>
	55	+ <?php echo '<input type="hidden" name="step" value="' . $step . '">'; ?>
56	56	<div class="form-group">
57	57	<label for="hostname" class="control-label">Hostname</label>
58	58	<input type="text" class="form-control" name="hostname" value="localhost">
		@@ -74,13 +74,13 @@ discard block
		block discarded – undo
74	74	<button type="submit" class="btn btn-success">Check Database</button>
75	75	</div>
76	76	</form>
77		- <?php } else if($step == 4){ ?>
	77	+ <?php } else if ($step == 4) { ?>
78	78	<?php echo '<form action="" method="post" accept-charset="utf-8" id="installForm">'; ?>
79		- <?php echo '<input type="hidden" name="step" value="'.$step.'">'; ?>
80		- <?php echo '<input type="hidden" name="hostname" value="'.$_POST['hostname'].'">'; ?>
81		- <?php echo '<input type="hidden" name="username" value="'.$_POST['username'].'">'; ?>
82		- <?php echo '<input type="hidden" name="password" value="'.$_POST['password'].'">'; ?>
83		- <?php echo '<input type="hidden" name="database" value="'.$_POST['database'].'">'; ?>
	79	+ <?php echo '<input type="hidden" name="step" value="' . $step . '">'; ?>
	80	+ <?php echo '<input type="hidden" name="hostname" value="' . $_POST['hostname'] . '">'; ?>
	81	+ <?php echo '<input type="hidden" name="username" value="' . $_POST['username'] . '">'; ?>
	82	+ <?php echo '<input type="hidden" name="password" value="' . $_POST['password'] . '">'; ?>
	83	+ <?php echo '<input type="hidden" name="database" value="' . $_POST['database'] . '">'; ?>
84	84	<div class="form-group">
85	85	<div class="form-group">
86	86	<label for="base_url" class="control-label">Base URL <a href="https://help.perfexcrm.com/faq/what-is-base-url/" target="_blank">Read more...</a></label>
		@@ -128,9 +128,9 @@ discard block
		block discarded – undo
128	128	<label for="timezone" class="control-label">Timezone</label>
129	129	<select name="timezone" data-live-search="true" id="timezone" class="form-control" required data-none-selected-text="Select system timezone">
130	130	<option value=""></option>
131		- <?php foreach($this->get_timezones_list() as $key => $timezones){ ?>
	131	+ <?php foreach ($this->get_timezones_list() as $key => $timezones) { ?>
132	132	<optgroup label="<?php echo $key; ?>">
133		- <?php foreach($timezones as $timezone){ ?>
	133	+ <?php foreach ($timezones as $timezone) { ?>
134	134	<option value="<?php echo $timezone; ?>"><?php echo $timezone; ?></option>
135	135	<?php } ?>
136	136	</optgroup>
		@@ -142,9 +142,9 @@ discard block
		block discarded – undo
142	142	<button type="submit" class="btn btn-success" id="installBtn">Install</button>
143	143	</div>
144	144	</form>
145		- <?php } else if($step == 5){ ?>
	145	+ <?php } else if ($step == 5) { ?>
146	146	<h4 class="bold">Installation successful!</h4>
147		- <?php if(isset($config_copy_failed)){ ?>
	147	+ <?php if (isset($config_copy_failed)) { ?>
148	148	<p class="text-danger">
149	149	Failed to copy application/config/app-config-sample.php. Please navigate to application/config/ and copy the file app-config-sample.php and rename it to app-config.php
150	150	</p>

		@@ -30,7 +30,7 @@
		block discarded – undo
30	30	<div class="col-2 text-center <?php if($passed_steps[4] \|\| $step == 4){echo 'bg-default';} else {echo 'bg-not-passed';} ?> padding-10">
31	31	<h5> Install</h5>
32	32	</div>
33		- <div class="finish col-2 text-center <?php if($step == 5){echo 'bg-success';}else {echo 'bg-not-passed';} ?> padding-10">
	33	+ <div class="finish col-2 text-center <?php if($step == 5){echo 'bg-success';} else {echo 'bg-not-passed';} ?> padding-10">
34	34	<h5> Finish</h5>
35	35	</div>
36	36	</div>

		@@ -1,114 +1,114 @@ discard block
		block discarded – undo
1	1	<?php
2	2	$error = false;
3		-if (!is_writable('../uploads/estimates')){
	3	+if (!is_writable('../uploads/estimates')) {
4	4	$error = true;
5	5	$requirement_estimates = "<span class='label label-danger'>No (Make uploads/estimates writable) - Permissions 0755</span>";
6	6	} else {
7	7	$requirement_estimates = "<span class='label label-success'>Ok</span>";
8	8	}
9		-if (!is_writable('../uploads/proposals')){
	9	+if (!is_writable('../uploads/proposals')) {
10	10	$error = true;
11	11	$requirement_proposals = "<span class='label label-danger'>No (Make uploads/proposals writable) - Permissions 0755</span>";
12	12	} else {
13	13	$requirement_proposals = "<span class='label label-success'>Ok</span>";
14	14	}
15		-if (!is_writable('../uploads/ticket_attachments')){
	15	+if (!is_writable('../uploads/ticket_attachments')) {
16	16	$error = true;
17	17	$requirement1 = "<span class='label label-danger'>No (Make uploads/ticket_attachments writable) - Permissions 0755</span>";
18	18	} else {
19	19	$requirement1 = "<span class='label label-success'>Ok</span>";
20	20	}
21		-if (!is_writable('../uploads/tasks')){
	21	+if (!is_writable('../uploads/tasks')) {
22	22	$error = true;
23	23	$requirement2 = "<span class='label label-danger'>No (Make uploads/tasks writable) - Permissions 0755</span>";
24	24	} else {
25	25	$requirement2 = "<span class='label label-success'>Ok</span>";
26	26	}
27		-if (!is_writable('../uploads/staff_profile_images')){
	27	+if (!is_writable('../uploads/staff_profile_images')) {
28	28	$error = true;
29	29	$requirement3 = "<span class='label label-danger'>No (Make uploads/staff_profile_images writable) - Permissions 0755</span>";
30	30	} else {
31	31	$requirement3 = "<span class='label label-success'>Ok</span>";
32	32	}
33		-if (!is_writable('../uploads/projects')){
	33	+if (!is_writable('../uploads/projects')) {
34	34	$error = true;
35	35	$requirement4 = "<span class='label label-danger'>No (Make uploads/projects writable) - Permissions 0755</span>";
36	36	} else {
37	37	$requirement4 = "<span class='label label-success'>Ok</span>";
38	38	}
39		-if (!is_writable('../uploads/newsfeed')){
	39	+if (!is_writable('../uploads/newsfeed')) {
40	40	$error = true;
41	41	$requirement5 = "<span class='label label-danger'>No (Make uploads/newsfeed writable) - Permissions 0755</span>";
42	42	} else {
43	43	$requirement5 = "<span class='label label-success'>Ok</span>";
44	44	}
45		-if (!is_writable('../uploads/leads')){
	45	+if (!is_writable('../uploads/leads')) {
46	46	$error = true;
47	47	$requirement6 = "<span class='label label-danger'>No (Make uploads/leads writable) - Permissions 0755</span>";
48	48	} else {
49	49	$requirement6 = "<span class='label label-success'>Ok</span>";
50	50	}
51		-if (!is_writable('../uploads/invoices')){
	51	+if (!is_writable('../uploads/invoices')) {
52	52	$error = true;
53	53	$requirement7 = "<span class='label label-danger'>No (Make uploads/invoices writable) - Permissions 0755</span>";
54	54	} else {
55	55	$requirement7 = "<span class='label label-success'>Ok</span>";
56	56	}
57		-if (!is_writable('../uploads/expenses')){
	57	+if (!is_writable('../uploads/expenses')) {
58	58	$error = true;
59	59	$requirement8 = "<span class='label label-danger'>No (Make uploads/expenses writable) - Permissions 0755</span>";
60	60	} else {
61	61	$requirement8 = "<span class='label label-success'>Ok</span>";
62	62	}
63		-if (!is_writable('../uploads/discussions')){
	63	+if (!is_writable('../uploads/discussions')) {
64	64	$error = true;
65	65	$requirement9 = "<span class='label label-danger'>No (Make uploads/discussions writable) - Permissions 0755</span>";
66	66	} else {
67	67	$requirement9 = "<span class='label label-success'>Ok</span>";
68	68	}
69		-if (!is_writable('../uploads/contracts')){
	69	+if (!is_writable('../uploads/contracts')) {
70	70	$error = true;
71	71	$requirement10 = "<span class='label label-danger'>No (Make uploads/contracts writable) - Permissions 0755</span>";
72	72	} else {
73	73	$requirement10 = "<span class='label label-success'>Ok</span>";
74	74	}
75		-if (!is_writable('../uploads/company')){
	75	+if (!is_writable('../uploads/company')) {
76	76	$error = true;
77	77	$requirement11 = "<span class='label label-danger'>No (Make uploads/company writable) - Permissions 0755</span>";
78	78	} else {
79	79	$requirement11 = "<span class='label label-success'>Ok</span>";
80	80	}
81		-if (!is_writable('../uploads/clients')){
	81	+if (!is_writable('../uploads/clients')) {
82	82	$error = true;
83	83	$requirement12 = "<span class='label label-danger'>No (Make uploads/clients writable) - Permissions 0755</span>";
84	84	} else {
85	85	$requirement12 = "<span class='label label-success'>Ok</span>";
86	86	}
87		-if (!is_writable('../uploads/client_profile_images')){
	87	+if (!is_writable('../uploads/client_profile_images')) {
88	88	$error = true;
89	89	$requirement13 = "<span class='label label-danger'>No (Make uploads/client_profile_images writable) - Permissions 0755</span>";
90	90	} else {
91	91	$requirement13 = "<span class='label label-success'>Ok</span>";
92	92	}
93		-if (!is_writable('../application/config')){
	93	+if (!is_writable('../application/config')) {
94	94	$error = true;
95	95	$requirement14 = "<span class='label label-danger'>No (Make application/config/ writable - Permissions 0755</span>";
96	96	} else {
97	97	$requirement14 = "<span class='label label-success'>Ok</span>";
98	98	}
99		-if (!is_writable('../application/config/config.php')){
	99	+if (!is_writable('../application/config/config.php')) {
100	100	$error = true;
101	101	$requirement15 = "<span class='label label-danger'>No (Make application/config/config.php writable) - Permissions 0644</span>";
102	102	} else {
103	103	$requirement15 = "<span class='label label-success'>Ok</span>";
104	104	}
105		-if (!is_writable('../application/config/app-config-sample.php')){
	105	+if (!is_writable('../application/config/app-config-sample.php')) {
106	106	$error = true;
107	107	$requirement16 = "<span class='label label-danger'>No (Make application/config/app-config-sample.php writable) - Permissions - 0644</span>";
108	108	} else {
109	109	$requirement16 = "<span class='label label-success'>Ok</span>";
110	110	}
111		-if (!is_writable('../temp')){
	111	+if (!is_writable('../temp')) {
112	112	$error = true;
113	113	$requirement17 = "<span class='label label-danger'>No (Make temp folder writable) - Permissions 0755</span>";
114	114	} else {
		@@ -203,7 +203,7 @@ discard block
		block discarded – undo
203	203	</tbody>
204	204	</table>
205	205	<hr />
206		-<?php if ($error == true){
	206	+<?php if ($error == true) {
207	207	echo '<div class="text-center alert alert-danger">You need to fix the requirements in order to install Perfex CRM</div>';
208	208	} else {
209	209	echo '<div class="text-center">';

		@@ -63,7 +63,7 @@
		block discarded – undo
63	63	'password' => '',
64	64	'database' => ':memory:',
65	65	'DBDriver' => 'SQLite3',
66		- 'DBPrefix' => 'db_', // Needed to ensure we're working correctly with prefixes live. DO NOT REMOVE FOR CI DEVS
	66	+ 'DBPrefix' => 'db_', // Needed to ensure we're working correctly with prefixes live. DO NOT REMOVE FOR CI DEVS
67	67	'pConnect' => false,
68	68	'DBDebug' => (ENVIRONMENT !== 'production'),
69	69	'charset' => 'utf8',

		@@ -22,7 +22,7 @@ discard block
		block discarded – undo
22	22	* Events::on('create', [$myInstance, 'myMethod']);
23	23	*/
24	24
25		-Events::on('pre_system', static function () {
	25	+Events::on('pre_system', static function() {
26	26	if (ENVIRONMENT !== 'testing') {
27	27	if (ini_get('zlib.output_compression')) {
28	28	throw FrameworkException::forEnabledZlibOutputCompression();
		@@ -32,7 +32,7 @@ discard block
		block discarded – undo
32	32	ob_end_flush();
33	33	}
34	34
35		- ob_start(static function ($buffer) {
	35	+ ob_start(static function($buffer) {
36	36	return $buffer;
37	37	});
38	38	}
		@@ -43,7 +43,7 @@ discard block
		block discarded – undo
43	43	* --------------------------------------------------------------------
44	44	* If you delete, they will no longer be collected.
45	45	*/
46		- if (CI_DEBUG && ! is_cli()) {
	46	+ if (CI_DEBUG && !is_cli()) {
47	47	Events::on('DBQuery', 'CodeIgniter\Debug\Toolbar\Collectors\Database::collect');
48	48	Services::toolbar()->respond();
49	49	}

		@@ -35,11 +35,11 @@ discard block
		block discarded – undo
35	35	*/
36	36	defined('SECOND') \|\| define('SECOND', 1);
37	37	defined('MINUTE') \|\| define('MINUTE', 60);
38		-defined('HOUR') \|\| define('HOUR', 3600);
39		-defined('DAY') \|\| define('DAY', 86400);
40		-defined('WEEK') \|\| define('WEEK', 604800);
41		-defined('MONTH') \|\| define('MONTH', 2592000);
42		-defined('YEAR') \|\| define('YEAR', 31536000);
	38	+defined('HOUR') \|\| define('HOUR', 3600);
	39	+defined('DAY') \|\| define('DAY', 86400);
	40	+defined('WEEK') \|\| define('WEEK', 604800);
	41	+defined('MONTH') \|\| define('MONTH', 2592000);
	42	+defined('YEAR') \|\| define('YEAR', 31536000);
43	43	defined('DECADE') \|\| define('DECADE', 315360000);
44	44
45	45	/*
		@@ -67,13 +67,13 @@ discard block
		block discarded – undo
67	67	\| http://tldp.org/LDP/abs/html/exitcodes.html
68	68	\|
69	69	*/
70		-defined('EXIT_SUCCESS') \|\| define('EXIT_SUCCESS', 0); // no errors
71		-defined('EXIT_ERROR') \|\| define('EXIT_ERROR', 1); // generic error
72		-defined('EXIT_CONFIG') \|\| define('EXIT_CONFIG', 3); // configuration error
73		-defined('EXIT_UNKNOWN_FILE') \|\| define('EXIT_UNKNOWN_FILE', 4); // file not found
74		-defined('EXIT_UNKNOWN_CLASS') \|\| define('EXIT_UNKNOWN_CLASS', 5); // unknown class
	70	+defined('EXIT_SUCCESS') \|\| define('EXIT_SUCCESS', 0); // no errors
	71	+defined('EXIT_ERROR') \|\| define('EXIT_ERROR', 1); // generic error
	72	+defined('EXIT_CONFIG') \|\| define('EXIT_CONFIG', 3); // configuration error
	73	+defined('EXIT_UNKNOWN_FILE') \|\| define('EXIT_UNKNOWN_FILE', 4); // file not found
	74	+defined('EXIT_UNKNOWN_CLASS') \|\| define('EXIT_UNKNOWN_CLASS', 5); // unknown class
75	75	defined('EXIT_UNKNOWN_METHOD') \|\| define('EXIT_UNKNOWN_METHOD', 6); // unknown class member
76		-defined('EXIT_USER_INPUT') \|\| define('EXIT_USER_INPUT', 7); // invalid user input
77		-defined('EXIT_DATABASE') \|\| define('EXIT_DATABASE', 8); // database error
78		-defined('EXIT__AUTO_MIN') \|\| define('EXIT__AUTO_MIN', 9); // lowest automatically-assigned error code
79		-defined('EXIT__AUTO_MAX') \|\| define('EXIT__AUTO_MAX', 125); // highest automatically-assigned error code
	76	+defined('EXIT_USER_INPUT') \|\| define('EXIT_USER_INPUT', 7); // invalid user input
	77	+defined('EXIT_DATABASE') \|\| define('EXIT_DATABASE', 8); // database error
	78	+defined('EXIT__AUTO_MIN') \|\| define('EXIT__AUTO_MIN', 9); // lowest automatically-assigned error code
	79	+defined('EXIT__AUTO_MAX') \|\| define('EXIT__AUTO_MAX', 125); // highest automatically-assigned error code

		@@ -73,7 +73,7 @@
		block discarded – undo
73	73	<h1>404 - File Not Found</h1>
74	74
75	75	<p>
76		- <?php if (! empty($message) && $message !== '(null)') : ?>
	76	+ <?php if (!empty($message) && $message !== '(null)') : ?>
77	77	<?= nl2br(esc($message)) ?>
78	78	<?php else : ?>
79	79	Sorry! Cannot seem to find the page you were looking for.

iqltechnologies / brighty

Branch — main (c9f3a5)

Category

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +21 added lines, -21 removed lines patch added patch discarded remove patch

Braces +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +20 added lines, -20 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch