intraface / intraface.dk

src/DB/Sql.php

Doc Comments +6 added lines

@@ -26,6 +26,9 @@ 
         $this->db->setOption('portability', MDB2_PORTABILITY_NONE);
     }
 
+    /**
+     * @param string $SQL
+     */
     function query($SQL)
     {
         $this->result = $this->db->query($SQL);
@@ -101,6 +104,9 @@ 
         return mysql_escape_string($value);
     }
 
+    /**
+     * @param string $type
+     */
     function quote($value, $type)
     {
         return $this->db->quote($value, $type);

Spacing +5 added lines, -5 removed lines

@@ -16,11 +16,11 @@ 
         if (empty($dbhost) OR empty($dbuser) OR empty($dbpass) OR empty($dbname)) {
             $this->db = MDB2::singleton(DB_DSN);
         } else {
-            $this->db = MDB2::singleton('mysql://' . $dbuser . ':' . $dbpass . '@' . $dbhost . '/' . $dbname);
+            $this->db = MDB2::singleton('mysql://'.$dbuser.':'.$dbpass.'@'.$dbhost.'/'.$dbname);
         }
 
         if (PEAR::isError($this->db)) {
-            die($this->db->getMessage() . ' ' . $this->db->getUserInfo());
+            die($this->db->getMessage().' '.$this->db->getUserInfo());
         }
         $this->db->query('SET NAMES utf8');
         $this->db->setOption('portability', MDB2_PORTABILITY_NONE);
@@ -30,7 +30,7 @@ 
     {
         $this->result = $this->db->query($SQL);
         if (PEAR::isError($this->result)) {
-            die($this->result->getMessage() . ' ' . $this->result->getUserInfo());
+            die($this->result->getMessage().' '.$this->result->getUserInfo());
         }
     }
 
@@ -38,7 +38,7 @@ 
     {
         $this->result = $this->db->exec($SQL);
         if (PEAR::isError($this->result)) {
-            die($this->result->getMessage() . ' ' . $this->result->getUserInfo());
+            die($this->result->getMessage().' '.$this->result->getUserInfo());
         }
 
         $this->result->free();
@@ -52,7 +52,7 @@ 
         // while($db->next_record()) {
         $this->row = $this->result->fetchRow(MDB2_FETCHMODE_ASSOC);
         if (PEAR::isError($this->row)) {
-            die($this->row->getMessage() . '' . $this->row->getUserInfo());
+            die($this->row->getMessage().''.$this->row->getUserInfo());
         }
 
         return($this->row);

src/Intraface/AddressGateway.php

Doc Comments +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
      * @param string  $belong_to    What the address belongs to, corresponding to the ones in Address::getBelongToTypes()
      * @param integer $belong_to_id From belong_to. NB not id on the address
      *
-     * @return object Address
+     * @return Intraface_Address Address
      */
     public function findByBelongToAndId($belong_to, $belong_to_id)
     {

src/Intraface/functions.php

Doc Comments +1 added lines

@@ -58,6 +58,7 @@
     /**

      * This function is dynamically redefinable.

      * @see $GLOBALS['_global_function_callback_email']

+     * @param string $args
      */

     function autoop($args) {

         $args = func_get_args();

Spacing +1 added lines, -1 removed lines

@@ -196,7 +196,7 @@
 function intrafaceBackendErrorhandler($errno, $errstr, $errfile, $errline, $errcontext)
 {
     if (!defined('ERROR_LOG')) {
-        define('ERROR_LOG', dirname(__FILE__) . '/../log/error.log');
+        define('ERROR_LOG', dirname(__FILE__).'/../log/error.log');
     }
     $errorhandler = new ErrorHandler;
     if (!defined('ERROR_LEVEL_CONTINUE_SCRIPT')) {

src/Intraface/KernelGateway.php

Doc Comments +3 added lines

@@ -8,6 +8,9 @@
         $this->translation = $translation;
     }
 
+    /**
+     * @param Intraface_User $user
+     */
     function findByUserobject($user)
     {
         $kernel = new Intraface_Kernel(session_id());

src/Intraface/Log.php

Doc Comments +6 added lines

@@ -6,6 +6,9 @@ 
 

 interface Observer

 {

+    /**
+     * @return boolean
+     */
     function update($code, $msg);

 }

 

@@ -47,6 +50,9 @@ 
         }

     }

 

+    /**
+     * @param string $table
+     */
     function tableExists($table)

     {

         $this->db->loadModule('Manager', null, true);

Spacing +2 added lines, -2 removed lines

@@ -64,12 +64,12 @@
         $result = $this->db->createTable($this->table_name, $this->table_definition);
 
         if (PEAR::isError($result)) {
-            throw new Exception('create ' . $result->getMessage());
+            throw new Exception('create '.$result->getMessage());
         }
 
         $result = $this->db->createConstraint($this->table_name, 'PRIMARY', $this->definition);
         if (PEAR::isError($result)) {
-            throw new Exception('primary ' . $result->getMessage());
+            throw new Exception('primary '.$result->getMessage());
         }
     }
 

src/Intraface/modules/accounting/AccountGateway.php

Doc Comments +4 added lines, -1 removed lines

@@ -65,7 +65,7 @@ 
     /**
      * @deprecated
      * @param $id
-     * @return unknown_type
+     * @return Account
      */
     function findFromId($id)
     {
@@ -78,6 +78,9 @@ 
     	return new Account($this->year, $id);
     }
 
+    /**
+     * @param string $type
+     */
     function findByType($type, $saldo = false)
     {
         return $this->getList($type, $saldo);

Indentation +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
         $this->year = $year;
     }
 
-   /**
+    /**
      * Denne funktion bruges bl.a. under bogf�ringen, s� man bare taster kontonummer
      * og s� s�ttes den rigtige konto.
      *

Spacing +2 added lines, -2 removed lines

@@ -74,7 +74,7 @@ 
 
     function findById($id)
     {
-        require_once dirname(__FILE__) . '/Account.php';
+        require_once dirname(__FILE__).'/Account.php';
         return new Account($this->year, $id);
     }
 
@@ -187,7 +187,7 @@ 
         $db = new DB_Sql;
         $sql = "SELECT id
             FROM accounting_account
-            WHERE intranet_id = " . $this->year->kernel->intranet->get("id") . " AND year_id = ".$this->year->get('id')." AND active = 1";
+            WHERE intranet_id = " . $this->year->kernel->intranet->get("id")." AND year_id = ".$this->year->get('id')." AND active = 1";
         $db->query($sql);
 
         return $db->numRows();

src/Intraface/modules/accounting/PostGateway.php

Doc Comments +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
      *
      * @param object $voucher
      *
-     * @return void
+     * @return string
      */
     function __construct($voucher)
     {

Spacing +4 added lines, -4 removed lines

@@ -39,11 +39,11 @@ 
     {
         $post_id = (int)$post_id;
         $db = new DB_Sql;
-        $db->query("SELECT voucher_id FROM accounting_post WHERE id = " . $post_id . " AND year_id = " . $year->get('id') . " AND intranet_id=" . $year->kernel->intranet->get('id'));
+        $db->query("SELECT voucher_id FROM accounting_post WHERE id = ".$post_id." AND year_id = ".$year->get('id')." AND intranet_id=".$year->kernel->intranet->get('id'));
         if (!$db->nextRecord()) {
             return new Post(new Voucher($year));
         }
-        $post =  new Post(new Voucher($year, $db->f('voucher_id')), (int)$post_id);
+        $post = new Post(new Voucher($year, $db->f('voucher_id')), (int)$post_id);
         return $post;
 
     }
@@ -51,13 +51,13 @@ 
     public function getList($type = 'stated')
     {
         $db = new DB_Sql;
-        $sql = "SELECT voucher.reference, post.id, post.text, post.voucher_id, post.date, post.account_id, post.debet, post.credit, post.stated, DATE_FORMAT(post.date, '%d-%m-%Y') AS date_dk FROM accounting_post post INNER JOIN accounting_voucher voucher ON post.voucher_id = voucher.id WHERE post.year_id = " . $this->voucher->year->get('id') . " AND post.intranet_id = " . $this->voucher->year->kernel->intranet->get('id');
+        $sql = "SELECT voucher.reference, post.id, post.text, post.voucher_id, post.date, post.account_id, post.debet, post.credit, post.stated, DATE_FORMAT(post.date, '%d-%m-%Y') AS date_dk FROM accounting_post post INNER JOIN accounting_voucher voucher ON post.voucher_id = voucher.id WHERE post.year_id = ".$this->voucher->year->get('id')." AND post.intranet_id = ".$this->voucher->year->kernel->intranet->get('id');
         if ($type == 'stated') {
             $sql .= " AND post.stated = 1";
         } elseif ($type == 'draft') {
             $sql .= " AND post.stated = 0";
         }
-        $db->query($sql . " ORDER BY post.voucher_id DESC, post.id DESC");
+        $db->query($sql." ORDER BY post.voucher_id DESC, post.id DESC");
 
         $i = 0;
         $this->value['list_saldo'] = 0;

src/Intraface/modules/accounting/VoucherFileGateway.php

Doc Comments +3 added lines

@@ -90,6 +90,9 @@
         return $files;
     }
 
+    /**
+     * @param string $url
+     */
     function url($url)
     {
         return PATH_WWW . 'restricted' . $url;

Spacing +5 added lines, -5 removed lines

@@ -22,14 +22,14 @@ 
 
     function findFromId($id)
     {
-        require_once dirname(__FILE__) . '/VoucherFile.php';
+        require_once dirname(__FILE__).'/VoucherFile.php';
         return new VoucherFile($this->voucher, $id);
     }
 
     function getList()
     {
         $db = new DB_Sql;
-        $db->query("SELECT * FROM accounting_voucher_file WHERE active = 1 AND voucher_id = " . $this->voucher->get('id') . " AND intranet_id=" . $this->voucher->year->kernel->intranet->get('id'));
+        $db->query("SELECT * FROM accounting_voucher_file WHERE active = 1 AND voucher_id = ".$this->voucher->get('id')." AND intranet_id=".$this->voucher->year->kernel->intranet->get('id'));
         $i = 0;
         $files = array();
         while ($db->nextRecord()) {
@@ -49,7 +49,7 @@ 
                         $files[$i]['description'] = 'Momsperiode';
                     }
                     $files[$i]['name'] = 'Momsperiode';
-                    $files[$i]['file_uri'] = $this->url('/module/accounting/year/'.$this->voucher->year->getId().'/vat/' . $db->f('belong_to_id'));
+                    $files[$i]['file_uri'] = $this->url('/module/accounting/year/'.$this->voucher->year->getId().'/vat/'.$db->f('belong_to_id'));
                     break;
                 case 'file':
                     $this->voucher->year->kernel->useModule('filemanager');
@@ -63,7 +63,7 @@ 
                         $files[$i]['description'] = 'Kreditnota';
                     }
                     $files[$i]['name'] = 'Kreditnota';
-                    $files[$i]['file_uri'] = $this->url('/module/debtor/credit_note/' . $db->f('belong_to_id') . '.pdf');
+                    $files[$i]['file_uri'] = $this->url('/module/debtor/credit_note/'.$db->f('belong_to_id').'.pdf');
                     break;
                 case 'reminder':
                     if (empty($files[$i]['description'])) {
@@ -91,6 +91,6 @@ 
 
     function url($url)
     {
-        return PATH_WWW . 'restricted' . $url;
+        return PATH_WWW.'restricted'.$url;
     }
 }

src/Intraface/modules/accounting/VoucherGateway.php

Doc Comments +2 added lines, -3 removed lines

@@ -16,7 +16,7 @@ 
      *
      * @param object  $year_object
      *
-     * @return void
+     * @return string
      */
     public function __construct($year_object)
     {
@@ -32,10 +32,9 @@ 
     /**
      * Creates a voucher
      *
-     * @param object $year
      * @param string $voucher_number
      *
-     * @return void
+     * @return Voucher
      */
     public function findFromVoucherNumber($voucher_number)
     {

Spacing +3 added lines, -3 removed lines

@@ -25,7 +25,7 @@ 
 
     public function findFromId($id)
     {
-        require_once dirname(__FILE__) . '/Voucher.php';
+        require_once dirname(__FILE__).'/Voucher.php';
         return new Voucher($this->year, $id);
     }
 
@@ -40,7 +40,7 @@ 
     public function findFromVoucherNumber($voucher_number)
     {
         $db = new DB_Sql;
-        $db->query("SELECT id FROM accounting_voucher WHERE number = '".safeToDb($voucher_number)."' AND year_id = '".$this->year->get('id')."' AND intranet_id = " . $this->year->kernel->intranet->get('id'));
+        $db->query("SELECT id FROM accounting_voucher WHERE number = '".safeToDb($voucher_number)."' AND year_id = '".$this->year->get('id')."' AND intranet_id = ".$this->year->kernel->intranet->get('id'));
         if (!$db->nextRecord()) {
             return new Voucher($this->year);
         }
@@ -93,7 +93,7 @@ 
 
         $db->query("SELECT MAX(number) AS max_voucher_number
             FROM accounting_voucher
-            WHERE intranet_id = " . $this->year->kernel->intranet->get('id') . "
+            WHERE intranet_id = " . $this->year->kernel->intranet->get('id')."
                 AND year_id = " . $this->year->get('id'));
         if (!$db->nextRecord()) {
             return 0;