intraface / intraface.dk

src/Intraface/XMLRPC/CMS/Server0300.php

Doc Comments +3 added lines

@@ -9,6 +9,9 @@
  */

 class Intraface_XMLRPC_CMS_Server0300 extends Intraface_XMLRPC_Server0100

 {

+    /**
+     * @param integer $site_id
+     */
     private function factory($site_id)

     {

         if (!$this->kernel->weblogin->hasModuleAccess('cms')) { // -2

Spacing +2 added lines, -2 removed lines

@@ -63,7 +63,7 @@ 
             // level 9999 cannot be recognized, so we take top level
             // 0 which should be top level does not work - the variable is not set
 
-            $cmspage->value['navigation_toplevel'] = $cmspage->navigation->build(9999, 'array');    // 'toplevel'
+            $cmspage->value['navigation_toplevel'] = $cmspage->navigation->build(9999, 'array'); // 'toplevel'
             $cmspage->value['navigation_sublevel'] = $cmspage->navigation->build(1, 'array'); // 'sublevel'
             $cmspage->value['sections'] = $cmspage->collect();
             $cmspage->value['comments'] = $cmspage->getComments();
@@ -145,7 +145,7 @@ 
         $this->factory($site_id);
 
         $cmspage = new CMS_Page($this->site);
-        $value['toplevel'] = $cmspage->navigation->build(9999, 'array');    // 'toplevel'
+        $value['toplevel'] = $cmspage->navigation->build(9999, 'array'); // 'toplevel'
         $value['sublevel'] = $cmspage->navigation->build(1, 'array'); // 'sublevel'
 
         return $this->prepareResponseData($value);

src/Intraface/XMLRPC/Contact/Server.php

Doc Comments +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
      *
      * @param struct $credentials Credentials to use the server
      *
-     * @return array
+     * @return boolean
      */
     protected function checkCredentials($credentials)
     {

Spacing +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
 
         if (count($credentials) != 2) { // -4
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got ' . count($credentials) . ' arguments - need 2', -4);
+            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got '.count($credentials).' arguments - need 2', -4);
         }
         if (empty($credentials['private_key'])) { // -5
             require_once 'XML/RPC2/Exception.php';

src/Intraface/XMLRPC/Server.php

Doc Comments +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
      *
      * @param struct $credentials Credentials to use the server
      *
-     * @return array
+     * @return boolean
      */
     protected function checkCredentials($credentials)
     {

Spacing +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
 
         if (count($credentials) != 2) { // -4
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got ' . count($credentials) . ' arguments - need 2', -4);
+            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got '.count($credentials).' arguments - need 2', -4);
         }
         if (empty($credentials['private_key'])) { // -5
             require_once 'XML/RPC2/Exception.php';

src/Intraface/XMLRPC/Shop/Server.php

Doc Comments +2 added lines, -2 removed lines

@@ -260,7 +260,7 @@ 
      * @param string  $text              Extra text to the itemline
      * @param integer $product_detail_id Product detail id
      *
-     * @return mixed
+     * @return boolean
      */
     public function changeProductInBasket($credentials, $product_id, $quantity, $text = '', $product_detail_id = 0)
     {
@@ -607,7 +607,7 @@ 
      *
      * @param struct $credentials Credentials to use the server
      *
-     * @return array
+     * @return boolean
      */
     private function checkCredentials($credentials)
     {

Spacing +15 added lines, -15 removed lines

@@ -57,34 +57,34 @@ 
 
 
         // sublevel has to be used so other searches are not overwritten
-        $product->getDBQuery()->storeResult('use_stored', 'webshop_' . $area . '_' .  md5($this->credentials['session_id']), 'sublevel');
+        $product->getDBQuery()->storeResult('use_stored', 'webshop_'.$area.'_'.md5($this->credentials['session_id']), 'sublevel');
         $debug2 = serialize($mixed);
         if (isset($mixed['offset']) and array_key_exists('offset', $mixed) and is_numeric($mixed['offset'])) {
             $product->getDBQuery()->useStored(true);
             $product->getDBQuery()->setPagingOffset((int)$mixed['offset']);
-            $debug2 .= 'offset ' . $mixed['offset'];
+            $debug2 .= 'offset '.$mixed['offset'];
         } elseif (isset($mixed['use_stored']) and array_key_exists('use_stored', $mixed) and $mixed['use_stored'] == 'true') {
             $product->getDBQuery()->useStored(true);
             $debug2 .= 'use_stored true';
         } else {
             if (isset($mixed['search']) and array_key_exists('search', $mixed) and !empty($mixed['search'])) {
                 $product->getDBQuery()->setFilter('search', $mixed['search']);
-                $debug2 .= 'search ' . $mixed['search'];
+                $debug2 .= 'search '.$mixed['search'];
             }
 
             if (isset($mixed['keywords']) and array_key_exists('keywords', $mixed) and !empty($mixed['keywords'])) {
                 $product->getDBQuery()->setFilter('keywords', $mixed['keywords']);
-                $debug2 .= 'keyword ' . $mixed['keywords'];
+                $debug2 .= 'keyword '.$mixed['keywords'];
             }
 
             if (isset($mixed['ids']) and array_key_exists('ids', $mixed) and is_array($mixed['ids'])) {
                 $product->getDBQuery()->setFilter('ids', $mixed['ids']);
-                $debug2 .= 'ids ' . implode(', ', $mixed['ids']);
+                $debug2 .= 'ids '.implode(', ', $mixed['ids']);
             }
 
             if (isset($mixed['sorting']) and array_key_exists('sorting', $mixed) and !empty($mixed['sorting'])) {
                 $product->getDBQuery()->setFilter('sorting', $mixed['sorting']);
-                $debug2 .= 'sorting ' . $mixed['sorting'];
+                $debug2 .= 'sorting '.$mixed['sorting'];
             }
         }
 
@@ -176,7 +176,7 @@ 
 
         if (PEAR::isError($db)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException($db->getMessage() . $db->getUserInfo(), -1);
+            throw new XML_RPC2_FaultException($db->getMessage().$db->getUserInfo(), -1);
         }
 
         $featured = new Intraface_Webshop_FeaturedProducts($this->kernel->intranet, $db);
@@ -347,7 +347,7 @@ 
 
         if (!$order_id = $this->webshop->placeOrder($values)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('order could not be placed. It returned the following error: ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('order could not be placed. It returned the following error: '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return $order_id;
@@ -384,7 +384,7 @@ 
 
         if (!$payment_id = $onlinepayment->save($values)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('Onlinebetaling kunne ikke blive gemt' . strtolower(implode(', ', $onlinepayment->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('Onlinebetaling kunne ikke blive gemt'.strtolower(implode(', ', $onlinepayment->error->getMessage())), -4);
         }
 
         return $payment_id;
@@ -415,7 +415,7 @@ 
 
         if (!$payment_id = $onlinepayment->create()) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('onlinepayment could not be created' . strtolower(implode(', ', $onlinepayment->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('onlinepayment could not be created'.strtolower(implode(', ', $onlinepayment->error->getMessage())), -4);
         }
 
         return $payment_id;
@@ -444,7 +444,7 @@ 
 
         if (!$this->webshop->basket->saveAddress($values)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('datails could not be saved ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('datails could not be saved '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return true;
@@ -483,7 +483,7 @@ 
         $customer_coupon = $this->utf8Decode($customer_coupon);
         if (!$this->webshop->basket->saveCustomerCoupon($customer_coupon)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('datails could not be saved ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('datails could not be saved '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return true;
@@ -523,7 +523,7 @@ 
         $customer_ean = $this->utf8Decode($customer_ean);
         if (!$this->webshop->basket->saveCustomerEan($customer_ean)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('ean could not be saved ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('ean could not be saved '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return true;
@@ -563,7 +563,7 @@ 
         $customer_comment = $this->utf8Decode($customer_comment);
         if (!$this->webshop->basket->saveCustomerComment($customer_comment)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('datails could not be saved ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('datails could not be saved '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return true;
@@ -615,7 +615,7 @@ 
 
         if (count($credentials) != 2) { // -4
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got ' . count($credentials) . ' arguments - need 2', -4);
+            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got '.count($credentials).' arguments - need 2', -4);
         }
         if (empty($credentials['private_key'])) { // -5
             require_once 'XML/RPC2/Exception.php';

Indentation +2 added lines, -2 removed lines

@@ -233,7 +233,7 @@ 
         return $this->prepareResponseData($product->getRelatedProducts());
     }
 
-   /**
+    /**
      * Gets featured products
      *
      * Method is experimental and only used by discimport.dk. If you need to use it
@@ -278,7 +278,7 @@ 
 
     }
 
-   /**
+    /**
      * Gets product keywords which can be used to sort ones webshop
      *
      *

src/Intraface/XMLRPC/Shop/Server0100.php

Doc Comments +4 added lines, -3 removed lines

@@ -250,6 +250,7 @@ 
      * Formats array to return from product list from Doctrine
      *
      * @param object $doctrine_products Doctrine_Collection
+     * @param integer $attribute_id
      * @return array with products
      */
     private function createDoctrineProductsListArray($doctrine_products, $attribute_id = null)
@@ -563,7 +564,6 @@ 
      *
      * @param struct  $credentials Credentials to use the server
      * @param integer $shop_id    Id for the shop
-     * @param integer $id          Product id
      *
      * @return array
      */
@@ -741,7 +741,7 @@ 
      *
      * @param struct  $credentials       Credentials to use the server
      * @param integer $shop_id    Id for the shop
-     * @param integer $produt_id         Product id to add
+     * @param integer $product_id         Product id to add
      * @param integer $product_variation_id Product variation id to change
      * @param integer $quantity          Optional quantity
      * @param string  $text              Extra text to the itemline
@@ -784,7 +784,7 @@ 
      * @param string  $text              Extra text to the itemline
      * @param integer $product_detail_id Product detail id
      *
-     * @return mixed
+     * @return boolean
      */
     public function changeProductInBasket($credentials, $shop_id, $product_id, $product_variation_id, $quantity, $text = '', $product_detail_id = 0)
     {
@@ -1238,6 +1238,7 @@ 
     /**
      * Initialize the webshop
      *
+     * @param integer $shop_id
      * @return void
      */
     private function _factoryWebshop($shop_id)

Spacing +14 added lines, -14 removed lines

@@ -74,40 +74,40 @@ 
         }
 
         // sublevel has to be used so other searches are not overwritten
-        $product->getDBQuery()->storeResult('use_stored', 'webshop_' . $area . '_' .  md5($this->credentials['session_id']), 'sublevel');
+        $product->getDBQuery()->storeResult('use_stored', 'webshop_'.$area.'_'.md5($this->credentials['session_id']), 'sublevel');
         $debug2 = serialize($mixed);
         if (isset($mixed['offset']) and is_numeric($mixed['offset']) and $mixed['offset'] > 0) {
             $product->getDBQuery()->useStored(true);
             $product->getDBQuery()->setPagingOffset((int)$mixed['offset']);
-            $debug2 .= 'offset ' . $mixed['offset'];
+            $debug2 .= 'offset '.$mixed['offset'];
         } elseif (isset($mixed['use_stored']) and array_key_exists('use_stored', $mixed) and $mixed['use_stored'] == 'true') {
             $product->getDBQuery()->useStored(true);
             $debug2 .= 'use_stored true';
         } else {
             if (array_key_exists('search', $mixed) and !empty($mixed['search'])) {
                 $product->getDBQuery()->setFilter('search', $mixed['search']);
-                $debug2 .= 'search ' . $mixed['search'];
+                $debug2 .= 'search '.$mixed['search'];
             }
 
             if (array_key_exists('keywords', $mixed) and !empty($mixed['keywords'])) {
                 $product->getDBQuery()->setFilter('keywords', $mixed['keywords']);
-                $debug2 .= 'keyword ' . $mixed['keywords'];
+                $debug2 .= 'keyword '.$mixed['keywords'];
             }
 
             if (array_key_exists('category', $mixed) and !empty($mixed['category'])) {
                 $product->getDBQuery()->setFilter('shop_id', $shop_id);
                 $product->getDBQuery()->setFilter('category', $mixed['category']);
-                $debug2 .= 'category ' . $mixed['category'];
+                $debug2 .= 'category '.$mixed['category'];
             }
 
             if (isset($mixed['ids']) and array_key_exists('ids', $mixed) and is_array($mixed['ids'])) {
                 $product->getDBQuery()->setFilter('ids', $mixed['ids']);
-                $debug2 .= 'ids ' . implode(', ', $mixed['ids']);
+                $debug2 .= 'ids '.implode(', ', $mixed['ids']);
             }
 
             if (array_key_exists('sorting', $mixed) and !empty($mixed['sorting'])) {
                 $product->getDBQuery()->setFilter('sorting', $mixed['sorting']);
-                $debug2 .= 'sorting ' . $mixed['sorting'];
+                $debug2 .= 'sorting '.$mixed['sorting'];
             }
         }
 
@@ -613,7 +613,7 @@ 
 
         if (PEAR::isError($db)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException($db->getMessage() . $db->getUserInfo(), -1);
+            throw new XML_RPC2_FaultException($db->getMessage().$db->getUserInfo(), -1);
         }
 
         $featured = new Intraface_modules_shop_FeaturedProducts($this->kernel->intranet, $this->webshop->getShop(), $db);
@@ -878,7 +878,7 @@ 
 
         if (!$order_id = $this->webshop->placeOrder($values)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('order could not be placed. It returned the following error: ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('order could not be placed. It returned the following error: '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return $this->prepareResponseData($this->webshop->getOrderIdentifierKey());
@@ -908,7 +908,7 @@ 
 
         if (!$this->webshop->getBasket()->saveAddress($values)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('datails could not be saved ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('datails could not be saved '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return $this->prepareResponseData(true);
@@ -949,7 +949,7 @@ 
         $customer_coupon = $this->processRequestData($customer_coupon);
         if (!$this->webshop->getBasket()->saveCustomerCoupon($customer_coupon)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('datails could not be saved ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('datails could not be saved '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return $this->prepareResponseData(true);
@@ -990,7 +990,7 @@ 
         $customer_ean = $this->processRequestData($customer_ean);
         if (!$this->webshop->getBasket()->saveCustomerEan($customer_ean)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('ean could not be saved ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('ean could not be saved '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return $this->prepareResponseData(true);
@@ -1032,7 +1032,7 @@ 
         $customer_comment = $this->processRequestData($customer_comment);
         if (!$this->webshop->getBasket()->saveCustomerComment($customer_comment)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('datails could not be saved ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('datails could not be saved '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return $this->prepareResponseData(true);
@@ -1091,7 +1091,7 @@ 
         $payment_method = $this->processRequestData($payment_method);
         if (!$this->webshop->getBasket()->savePaymentMethod($payment_method)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('datails could not be saved ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('datails could not be saved '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return $this->prepareResponseData(true);

Indentation +2 added lines, -2 removed lines

@@ -233,7 +233,7 @@ 
         return $this->prepareResponseData($product->getRelatedProducts());
     }
 
-   /**
+    /**
      * Gets featured products
      *
      * Method is experimental and only used by discimport.dk. If you need to use it
@@ -278,7 +278,7 @@ 
 
     }
 
-   /**
+    /**
      * Gets product keywords which can be used to sort ones webshop
      *
      *

src/Intraface/XMLRPC/Shop/Server2.php

Doc Comments +3 added lines, -3 removed lines

@@ -212,7 +212,6 @@ 
      *
      * @param struct  $credentials Credentials to use the server
      * @param integer $shop_id    Id for the shop
-     * @param integer $id          Product id
      *
      * @return array
      */
@@ -328,7 +327,7 @@ 
      *
      * @param struct  $credentials       Credentials to use the server
      * @param integer $shop_id    Id for the shop
-     * @param integer $produt_id         Product id to add
+     * @param integer $product_id         Product id to add
      * @param integer $product_variation_id Product variation id to change
      * @param integer $quantity          Optional quantity
      * @param string  $text              Extra text to the itemline
@@ -371,7 +370,7 @@ 
      * @param string  $text              Extra text to the itemline
      * @param integer $product_detail_id Product detail id
      *
-     * @return mixed
+     * @return boolean
      */
     public function changeProductInBasket($credentials, $shop_id, $product_id, $product_variation_id, $quantity, $text = '', $product_detail_id = 0)
     {
@@ -791,6 +790,7 @@ 
     /**
      * Initialize the webshop
      *
+     * @param integer $shop_id
      * @return void
      */
     private function _factoryWebshop($shop_id)

Indentation +2 added lines, -2 removed lines

@@ -233,7 +233,7 @@ 
         return $this->prepareResponseData($product->getRelatedProducts());
     }
 
-   /**
+    /**
      * Gets featured products
      *
      * Method is experimental and only used by discimport.dk. If you need to use it
@@ -278,7 +278,7 @@ 
 
     }
 
-   /**
+    /**
      * Gets product keywords which can be used to sort ones webshop
      *
      *

Spacing +15 added lines, -15 removed lines

@@ -60,40 +60,40 @@ 
 
 
         // sublevel has to be used so other searches are not overwritten
-        $product->getDBQuery()->storeResult('use_stored', 'webshop_' . $area . '_' .  md5($this->credentials['session_id']), 'sublevel');
+        $product->getDBQuery()->storeResult('use_stored', 'webshop_'.$area.'_'.md5($this->credentials['session_id']), 'sublevel');
         $debug2 = serialize($mixed);
         if (isset($mixed['offset']) and array_key_exists('offset', $mixed) and is_numeric($mixed['offset'])) {
             $product->getDBQuery()->useStored(true);
             $product->getDBQuery()->setPagingOffset((int)$mixed['offset']);
-            $debug2 .= 'offset ' . $mixed['offset'];
+            $debug2 .= 'offset '.$mixed['offset'];
         } elseif (isset($mixed['use_stored']) and array_key_exists('use_stored', $mixed) and $mixed['use_stored'] == 'true') {
             $product->getDBQuery()->useStored(true);
             $debug2 .= 'use_stored true';
         } else {
             if (array_key_exists('search', $mixed) and !empty($mixed['search'])) {
                 $product->getDBQuery()->setFilter('search', $mixed['search']);
-                $debug2 .= 'search ' . $mixed['search'];
+                $debug2 .= 'search '.$mixed['search'];
             }
 
             if (array_key_exists('keywords', $mixed) and !empty($mixed['keywords'])) {
                 $product->getDBQuery()->setFilter('keywords', $mixed['keywords']);
-                $debug2 .= 'keyword ' . $mixed['keywords'];
+                $debug2 .= 'keyword '.$mixed['keywords'];
             }
 
             if (array_key_exists('category', $mixed) and !empty($mixed['category'])) {
                 $product->getDBQuery()->setFilter('shop_id', $shop_id);
                 $product->getDBQuery()->setFilter('category', $mixed['category']);
-                $debug2 .= 'category ' . $mixed['category'];
+                $debug2 .= 'category '.$mixed['category'];
             }
 
             if (isset($mixed['ids']) and array_key_exists('ids', $mixed) and is_array($mixed['ids'])) {
                 $product->getDBQuery()->setFilter('ids', $mixed['ids']);
-                $debug2 .= 'ids ' . implode(', ', $mixed['ids']);
+                $debug2 .= 'ids '.implode(', ', $mixed['ids']);
             }
 
             if (array_key_exists('sorting', $mixed) and !empty($mixed['sorting'])) {
                 $product->getDBQuery()->setFilter('sorting', $mixed['sorting']);
-                $debug2 .= 'sorting ' . $mixed['sorting'];
+                $debug2 .= 'sorting '.$mixed['sorting'];
             }
         }
 
@@ -196,7 +196,7 @@ 
                         'name' => $variation->getName(),
                         'attributes' => $attributes_array,
                         'identifier' => $attribute_string,
-                        'price_incl_vat' => round(($product->get('price') + $detail->getPriceDifference()) * (1 + $product->get('vat_percent')/100), 2),
+                        'price_incl_vat' => round(($product->get('price') + $detail->getPriceDifference())*(1 + $product->get('vat_percent')/100), 2),
                         'weight' => $product->get('weight') + $detail->getWeightDifference()
                     ),
                     'stock' => $variation->getStock($product)->get()
@@ -256,7 +256,7 @@ 
 
         if (PEAR::isError($db)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException($db->getMessage() . $db->getUserInfo(), -1);
+            throw new XML_RPC2_FaultException($db->getMessage().$db->getUserInfo(), -1);
         }
 
         $featured = new Intraface_modules_shop_FeaturedProducts($this->kernel->intranet, $this->webshop->getShop(), $db);
@@ -459,7 +459,7 @@ 
 
         if (!$order_id = $this->webshop->placeOrder($values)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('order could not be placed. It returned the following error: ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('order could not be placed. It returned the following error: '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return $this->prepareResponseData($this->webshop->getOrderIdentifierKey());
@@ -489,7 +489,7 @@ 
 
         if (!$this->webshop->getBasket()->saveAddress($values)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('datails could not be saved ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('datails could not be saved '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return $this->prepareResponseData(true);
@@ -530,7 +530,7 @@ 
         $customer_coupon = $this->processRequestData($customer_coupon);
         if (!$this->webshop->getBasket()->saveCustomerCoupon($customer_coupon)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('datails could not be saved ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('datails could not be saved '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return $this->prepareResponseData(true);
@@ -571,7 +571,7 @@ 
         $customer_ean = $this->processRequestData($customer_ean);
         if (!$this->webshop->getBasket()->saveCustomerEan($customer_ean)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('ean could not be saved ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('ean could not be saved '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return $this->prepareResponseData(true);
@@ -613,7 +613,7 @@ 
         $customer_comment = $this->processRequestData($customer_comment);
         if (!$this->webshop->getBasket()->saveCustomerComment($customer_comment)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('datails could not be saved ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('datails could not be saved '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return $this->prepareResponseData(true);
@@ -672,7 +672,7 @@ 
         $payment_method = $this->processRequestData($payment_method);
         if (!$this->webshop->getBasket()->savePaymentMethod($payment_method)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('datails could not be saved ' . strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
+            throw new XML_RPC2_FaultException('datails could not be saved '.strtolower(implode(', ', $this->webshop->error->getMessage())), -4);
         }
 
         return $this->prepareResponseData(true);

tests/unit/Accounting/VatPeriodTest.php

Doc Comments +6 added lines

@@ -48,6 +48,9 @@ 
         $this->value['saldo'] = 100;
     }
 
+    /**
+     * @param string $type
+     */
     function getSaldo($type, $date_from, $date_to)
     {
 
@@ -79,6 +82,9 @@ 
         return 1;
     }
 
+    /**
+     * @param integer $id
+     */
     function getAccount($id)
     {
         return new FakeVatPeriodAccount(new FakeVatPeriodYear, $id);

Spacing +2 added lines, -2 removed lines

@@ -104,7 +104,7 @@ 
 
         // ganges med -1 for at f� rigtigt fortegn til udregning
         $this->value['saldo_vat_out'] = $account_vat_in->get('saldo');
-        $saldo_total += -1 * $this->value['saldo_vat_out']; // total
+        $saldo_total += -1*$this->value['saldo_vat_out']; // total
 
 
         // Moms af varek�b i udlandet
@@ -115,7 +115,7 @@ 
 
         // ganges med -1 for at f� rigtigt fortegn til udregning
         $this->value['saldo_vat_abroad'] = $account_vat_abroad->get('saldo');
-        $saldo_total += -1 * $this->value['saldo_vat_abroad'];
+        $saldo_total += -1*$this->value['saldo_vat_abroad'];
 
         // K�bsmoms
         // K�bsmomsen inkluderer ogs� den udregnede moms af moms af varek�b i udlandet.

tests/unit/CMS/CMSStubs.php

Doc Comments +8 added lines

@@ -8,6 +8,10 @@ 
     public $kernel;
     public $cmssite;
     public $dbquery;
+
+    /**
+     * @param FakeCMSSite $site
+     */
     function __construct($site)
     {
         $this->cmssite = $site;
@@ -37,6 +41,10 @@ 
 {
     public $kernel;
     public $cmssite;
+
+    /**
+     * @param FakeCMSPage $page
+     */
     function __construct($page)
     {
         $this->cmspage = $page;

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
     {
         $this->cmssite = $site;
         $this->kernel = $site->kernel;
-        $this->dbquery = new Intraface_DBQuery($this->kernel, 'cms_page', 'cms_page.intranet_id = '.$this->kernel->intranet->get('id').' AND cms_page.active = 1 AND site_id = ' . $this->cmssite->get('id'));
+        $this->dbquery = new Intraface_DBQuery($this->kernel, 'cms_page', 'cms_page.intranet_id = '.$this->kernel->intranet->get('id').' AND cms_page.active = 1 AND site_id = '.$this->cmssite->get('id'));
     }
     function get()
     {

tests/unit/CMS/SectionTest.php

Doc Comments +3 added lines

@@ -9,6 +9,9 @@
     public $kernel;
     public $cmssite;
 
+    /**
+     * @param Stub_Kernel $kernel
+     */
     function __construct($kernel)
     {
         $this->kernel = $kernel;