intraface / intraface.dk

src/Intraface/modules/cms/Section.php

Doc Comments +6 added lines

@@ -62,11 +62,17 @@
         return new CMS_Parameter($this);

     }

 

+    /**
+     * @param string $key
+     */
     function addParameter($key, $value)

     {

         return $this->parameter->save($key, $value);

     }

 

+    /**
+     * @param string $type
+     */
     function factory($object, $type, $value)

     {

         $class_prefix = 'Intraface_modules_cms_templatesection_';

Spacing +6 added lines, -6 removed lines

@@ -30,7 +30,7 @@ 
         $this->db = MDB2::singleton(DB_DSN);
         $this->cmspage = $cmspage;
         $this->kernel = $cmspage->kernel;
-        $this->id = (int) $id;
+        $this->id = (int)$id;
         //$template_class = 'CMS_Template_' . $this->value['type'];
 
         $this->error = new Intraface_Error();
@@ -184,16 +184,16 @@ 
         if ($this->id == 0) {
             $sql_type = "INSERT INTO ";
             $sql_end = ", date_created = NOW(),
-                type_key = ".$var['type_key'] . ",
+                type_key = ".$var['type_key'].",
                 template_section_id = ".$var['template_section_id'];
         } else {
             $sql_type = "UPDATE ";
-            $sql_end = " WHERE id = " . $this->id;
+            $sql_end = " WHERE id = ".$this->id;
         }
-        $sql = $sql_type . " cms_section SET
+        $sql = $sql_type." cms_section SET
                 intranet_id = ".$this->cmspage->kernel->intranet->get('id').",
-                page_id=". (int)$this->cmspage->get('id') . ",
-                site_id=". (int)$this->cmspage->cmssite->get('id') . ",
+                page_id=". (int)$this->cmspage->get('id').",
+                site_id=". (int)$this->cmspage->cmssite->get('id').",
                 date_updated = NOW()
             " . $sql_end;
 

src/Intraface/modules/cms/section/Longtext.php

Doc Comments +6 added lines

@@ -12,6 +12,9 @@ 
 {
     private $allowed_tags = '';
 
+    /**
+     * @param FakeCMSPage $cmspage
+     */
     function __construct($cmspage, $id = 0)
     {
         $this->value['type'] = 'longtext';
@@ -52,6 +55,9 @@ 
         return true;
     }
 
+    /**
+     * @param string[] $array
+     */
     public static function convertArrayToTags($array)
     {
         $tags = '';

src/Intraface/modules/cms/Template.php

Doc Comments +6 added lines

@@ -65,6 +65,9 @@ 
         return 'cms_template';
     }
 
+    /**
+     * @param DB_Sql $db
+     */
     function getPosition($db)
     {
         return new Ilib_Position($db, 'cms_template', $this->id, 'site_id = ' . $this->cmssite->get('id'), 'id', 'position');
@@ -131,6 +134,9 @@ 
     }
 
 
+    /**
+     * @return string
+     */
     function save($var)
     {
         if (!empty($var['for_page_type']) && is_array($var['for_page_type'])) {

Spacing +8 added lines, -8 removed lines

@@ -67,7 +67,7 @@ 
 
     function getPosition($db)
     {
-        return new Ilib_Position($db, 'cms_template', $this->id, 'site_id = ' . $this->cmssite->get('id'), 'id', 'position');
+        return new Ilib_Position($db, 'cms_template', $this->id, 'site_id = '.$this->cmssite->get('id'), 'id', 'position');
     }
 
     /**
@@ -78,7 +78,7 @@ 
         switch ($type) {
             case 'id':
                 $db = new DB_Sql;
-                $db->query("SELECT site_id, id FROM cms_template WHERE id = " . $id . " AND intranet_id = " . $kernel->intranet->get('id'));
+                $db->query("SELECT site_id, id FROM cms_template WHERE id = ".$id." AND intranet_id = ".$kernel->intranet->get('id'));
                 if (!$db->nextRecord()) {
                     return false;
                 }
@@ -97,7 +97,7 @@ 
     function load()
     {
         $db = new DB_Sql;
-        $db->query("SELECT id, name, site_id, identifier, for_page_type FROM cms_template WHERE intranet_id = " . $this->cmssite->kernel->intranet->get('id') . " AND id = " . $this->id);
+        $db->query("SELECT id, name, site_id, identifier, for_page_type FROM cms_template WHERE intranet_id = ".$this->cmssite->kernel->intranet->get('id')." AND id = ".$this->id);
 
         if (!$db->nextRecord()) {
             return 0;
@@ -146,12 +146,12 @@ 
         $db = new DB_Sql;
         if ($this->id > 0) {
             $sql_type = "UPDATE ";
-            $sql_end = " WHERE id = " . $this->id;
+            $sql_end = " WHERE id = ".$this->id;
         } else {
             $sql_type = "INSERT INTO ";
             $sql_end = ", date_created = NOW()";
         }
-        $db->query($sql_type . " cms_template SET
+        $db->query($sql_type." cms_template SET
             name = '".safeToDb($var['name'])."',
             date_updated = NOW(),
             intranet_id = ".safeToDb($this->cmssite->kernel->intranet->get('id')).",
@@ -179,7 +179,7 @@ 
             $sql_extra = '';
         }
 
-        $db->query("SELECT id, name, identifier, for_page_type FROM cms_template WHERE ".$sql_extra." intranet_id = " . $this->cmssite->kernel->intranet->get('id') . " AND site_id = " . $this->cmssite->get('id') . " AND active = 1 ORDER BY name");
+        $db->query("SELECT id, name, identifier, for_page_type FROM cms_template WHERE ".$sql_extra." intranet_id = ".$this->cmssite->kernel->intranet->get('id')." AND site_id = ".$this->cmssite->get('id')." AND active = 1 ORDER BY name");
         $i = 0;
         $templates = array();
         while ($db->nextRecord()) {
@@ -212,14 +212,14 @@ 
     function delete()
     {
         $db = new DB_Sql;
-        $db->query("UPDATE cms_template SET active = 0 WHERE id = " . $this->id);
+        $db->query("UPDATE cms_template SET active = 0 WHERE id = ".$this->id);
         return true;
     }
 
     function isIdentifierUnique($identifier)
     {
         $db = new DB_Sql;
-        $db->query("SELECT id FROM cms_template WHERE site_id = " . $this->cmssite->get('id') . " AND identifier = '".$identifier."' AND active = 1 AND id != " . $this->id);
+        $db->query("SELECT id FROM cms_template WHERE site_id = ".$this->cmssite->get('id')." AND identifier = '".$identifier."' AND active = 1 AND id != ".$this->id);
         if ($db->numRows() == 0) {
             return true;
         } else {

src/Intraface/modules/contact/Contact.php

Doc Comments +6 added lines, -21 removed lines

@@ -257,7 +257,6 @@ 
      *
      * @param object $kernel
      * @param string $type   What should the contact object be created from
-     * @param string $id     The value which corresponds to the type
      *
      * @return  object
      */
@@ -318,7 +317,7 @@ 
     /**
      * Loads values for the contact into an array
      *
-     * @return true on success
+     * @return boolean on success
      */
     private function load()
     {
@@ -394,7 +393,7 @@ 
      *
      * @param array $var Values to validate
      *
-     * @return true on success
+     * @return boolean on success
      */
     public function validate($var)
     {
@@ -502,20 +501,6 @@ 
     /**
      * Saves the contact
      *
-     * @param   int $var['id']  Kundeid
-     * @param   string $var['company']
-     * @param   string $var['address']
-     * @param   string $var['postalcode']
-     * @param   string $var['town']
-     * @param   string $var['country']
-     * @param   string $var['email']
-     * @param   string $var['website']
-     * @param   string $var['phone']
-     * @param   string $var['deliveryaddress']
-     * @param   string $var['deliverypostalcode']
-     * @param   string $var['deliverytown']
-     * @param   string $var['deliverycountry']
-     * @param   string $var['paymentcondition']
      *
      * @return void
      */
@@ -616,7 +601,7 @@ 
      *
      * Never delete a contact entirely. Should only be deactivated.
      *
-     * @return integer  0 = false eller 1 = true
+     * @return boolean  0 = false eller 1 = true
      */
     public function delete()
     {
@@ -659,7 +644,7 @@ 
      *
      * @param string $number
      *
-     * @return true hvis det er frit
+     * @return boolean hvis det er frit
      */
     public function isNumberFree($number)
     {
@@ -822,7 +807,7 @@ 
      *
      * TODO M�ske burde denne metode hedde loadKeywords()?
      *
-     * @return object
+     * @return Keyword
      */
     function getKeywords()
     {
@@ -858,7 +843,7 @@ 
      *
      * @param integer $id Optional id of the contact person
      *
-     * @return object
+     * @return ContactPerson
      */
     function loadContactPerson($id = 0)
     {

Indentation -3 removed lines

@@ -105,9 +105,6 @@
 
  function getContacts()
  }
-
-
-
  *
  * @package Intraface_Contact
  * @author  Lars Olesen <lars@legestue.net>

Spacing +24 added lines, -24 removed lines

@@ -119,7 +119,7 @@ 
  * @license
  *
  */
-require_once dirname(__FILE__) . '/ContactPerson.php';
+require_once dirname(__FILE__).'/ContactPerson.php';
 require_once 'Intraface/functions.php';
 
 class Contact extends Intraface_Standard
@@ -386,7 +386,7 @@ 
     {
         // HACK NECCESSARY FOR THE NEWSLETTERSUBSCRIBER
         $this->kernel->useModule('contact');
-        return ($this->value['login_url'] = 'http://' . $this->kernel->getSetting()->get('intranet', 'contact.login_url') . '/' .$this->kernel->intranet->get('identifier') . '/login?code='. $this->get('code'));
+        return ($this->value['login_url'] = 'http://'.$this->kernel->getSetting()->get('intranet', 'contact.login_url').'/'.$this->kernel->intranet->get('identifier').'/login?code='.$this->get('code'));
     }
 
     /**
@@ -556,16 +556,16 @@ 
 
         // prepare sql to update or insert
         if ($this->id > 0) {
-            $sql="UPDATE contact ";
-            $sql_after=" WHERE id='".$this->id."'";
+            $sql = "UPDATE contact ";
+            $sql_after = " WHERE id='".$this->id."'";
             $sql_create = "";
         } else {
-            $sql="INSERT INTO contact ";
-            $sql_after = ", code='".safeToDb(md5(date('Y-m-d H:i:s') . $sql_items))."'";
+            $sql = "INSERT INTO contact ";
+            $sql_after = ", code='".safeToDb(md5(date('Y-m-d H:i:s').$sql_items))."'";
             $sql_create = "date_created = NOW(),";
         }
 
-        $sql .= " SET	".$sql_create. "
+        $sql .= " SET	".$sql_create."
             intranet_id = '". $this->kernel->intranet->get('id')."',"
             .$sql_items.
             "date_changed = NOW()
@@ -595,7 +595,7 @@ 
             // Delivery Address
         foreach ($address_fields as $key => $value) {
             if (array_key_exists('delivery_'.$value, $var)) {
-                $delivery_address_to_save[$value] = $var['delivery_' . $value];
+                $delivery_address_to_save[$value] = $var['delivery_'.$value];
             }
         }
 
@@ -629,7 +629,7 @@ 
             return false;
         }
         $db = new DB_Sql;
-        $db->query("UPDATE contact SET active = 0, date_changed = NOW() WHERE intranet_id = " . $this->kernel->intranet->get("id") . " AND id = " . $this->id);
+        $db->query("UPDATE contact SET active = 0, date_changed = NOW() WHERE intranet_id = ".$this->kernel->intranet->get("id")." AND id = ".$this->id);
         return true;
     }
 
@@ -649,7 +649,7 @@ 
             return false;
         }
         $db = new DB_Sql;
-        $db->query("UPDATE contact SET active = 1, date_changed = NOW() WHERE intranet_id = " . $this->kernel->intranet->get("id") . " AND id = " . $this->id);
+        $db->query("UPDATE contact SET active = 1, date_changed = NOW() WHERE intranet_id = ".$this->kernel->intranet->get("id")." AND id = ".$this->id);
 
         return true;
     }
@@ -667,9 +667,9 @@ 
         $db = new DB_Sql();
         $sql = "SELECT id
             FROM contact
-            WHERE intranet_id = " . $this->kernel->intranet->get("id") . "
-                AND number = " . (int)$number . "
-                AND id <> " . $this->id . "
+            WHERE intranet_id = " . $this->kernel->intranet->get("id")."
+                AND number = " . (int)$number."
+                AND id <> " . $this->id."
                 AND active = 1
             LIMIT 1";
         $db->query($sql);
@@ -689,7 +689,7 @@ 
     public function getMaxNumber()
     {
         $db = new DB_Sql();
-        $db->query("SELECT number FROM contact WHERE intranet_id = " . $this->kernel->intranet->get("id") . " ORDER BY number DESC");
+        $db->query("SELECT number FROM contact WHERE intranet_id = ".$this->kernel->intranet->get("id")." ORDER BY number DESC");
         if (!$db->nextRecord()) {
             return 0;
         }
@@ -781,11 +781,11 @@ 
                 WHERE address.type=3
                     AND contact.active = 1
                     AND address.active = 1
-                    AND contact.intranet_id = " . $db->quote($this->kernel->intranet->get('id'), 'integer') . "
-                    AND contact.id != " . $db->quote($this->id, 'integer') . "
+                    AND contact.intranet_id = " . $db->quote($this->kernel->intranet->get('id'), 'integer')."
+                    AND contact.id != " . $db->quote($this->id, 'integer')."
                     AND (
-                        (address.email = " . $db->quote($this->address->get('email'), 'text') . " AND address.email != '')
-                        OR (address.phone = " . $db->quote($this->address->get('phone'), 'text') . " AND address.phone != ''))
+                        (address.email = " . $db->quote($this->address->get('email'), 'text')." AND address.email != '')
+                        OR (address.phone = " . $db->quote($this->address->get('phone'), 'text')." AND address.phone != ''))
 
                     ";
 
@@ -874,7 +874,7 @@ 
     function isFilledIn()
     {
         $db = new DB_Sql;
-        $db->query("SELECT count(*) AS antal FROM contact WHERE intranet_id = " . $this->kernel->intranet->get('id'));
+        $db->query("SELECT count(*) AS antal FROM contact WHERE intranet_id = ".$this->kernel->intranet->get('id'));
         if ($db->nextRecord()) {
             return $db->f('antal');
         }
@@ -892,7 +892,7 @@ 
             return false;
         }
         $db = new DB_Sql;
-        $db->query("UPDATE contact SET code = '".md5($this->id . date('Y-m-d H:i:s') . $this->kernel->intranet->get('id'))."' WHERE id = " . $this->id);
+        $db->query("UPDATE contact SET code = '".md5($this->id.date('Y-m-d H:i:s').$this->kernel->intranet->get('id'))."' WHERE id = ".$this->id);
         $this->load();
         return true;
     }
@@ -909,7 +909,7 @@ 
             return false;
         }
         $db = new DB_Sql;
-        $db->query("UPDATE contact SET password = '".md5($this->id . date('Y-m-d H:i:s') . $this->kernel->intranet->get('id'))."' WHERE id = " . $this->id);
+        $db->query("UPDATE contact SET password = '".md5($this->id.date('Y-m-d H:i:s').$this->kernel->intranet->get('id'))."' WHERE id = ".$this->id);
         $this->load();
         return true;
     }
@@ -922,7 +922,7 @@ 
     function getNewsletterSubscriptions()
     {
         $db = new DB_Sql;
-        $db->query("SELECT * FROM newsletter_subscriber WHERE optin = 1 AND active = 1 AND contact_id = " . $this->id . " AND intranet_id =" . $this->kernel->intranet->get('id'));
+        $db->query("SELECT * FROM newsletter_subscriber WHERE optin = 1 AND active = 1 AND contact_id = ".$this->id." AND intranet_id =".$this->kernel->intranet->get('id'));
         $lists = array();
         while ($db->nextRecord()) {
             $lists[] = $db->f('list_id');
@@ -938,7 +938,7 @@ 
     function needNewsletterOptin()
     {
         $db = new DB_Sql;
-        $db->query("SELECT list_id, code FROM newsletter_subscriber WHERE optin = 0 AND contact_id = " . $this->id . " AND intranet_id =" . $this->kernel->intranet->get('id'));
+        $db->query("SELECT list_id, code FROM newsletter_subscriber WHERE optin = 0 AND contact_id = ".$this->id." AND intranet_id =".$this->kernel->intranet->get('id'));
         $lists = array();
         $i = 0;
         while ($db->nextRecord()) {
@@ -959,7 +959,7 @@ 
     function canBeDeleted()
     {
         $db = new DB_Sql;
-        $db->query("SELECT * FROM debtor WHERE contact_id = " . $this->id . " AND intranet_id = " . $this->kernel->intranet->get('id'));
+        $db->query("SELECT * FROM debtor WHERE contact_id = ".$this->id." AND intranet_id = ".$this->kernel->intranet->get('id'));
         if (!$db->nextRecord()) {
             return true;
         }

src/Intraface/modules/contact/ContactReminder.php

Doc Comments +3 added lines

@@ -8,6 +8,9 @@
 

 class OnlinePaymentDefault extends OnlinePayment

 {

+    /**
+     * @param integer $id
+     */
     function __construct($kernel, $id) {

 

         parent::__construct($kernel, $id);

Indentation +6 added lines, -6 removed lines

@@ -225,7 +225,7 @@ 
             throw new Exception('Could not save information in ContactReminder->update' . $result->getUserInfo());
             return false;
         }
-         return $this->id;
+            return $this->id;
     }
 
     /**
@@ -245,8 +245,8 @@ 
             throw new Exception('Could not postphone reminder' . $result->getUserInfo());
             return false;
         }
-         $this->load();
-         return true;
+            $this->load();
+            return true;
     }
 
     /**
@@ -278,7 +278,7 @@ 
         if ($result->numRows() == 0) {
             return array();
         }
-         return $result->fetchAll(MDB2_FETCHMODE_ASSOC);
+            return $result->fetchAll(MDB2_FETCHMODE_ASSOC);
 
     }
 
@@ -297,8 +297,8 @@ 
             throw new Exception('Could not postphone reminder' . $result->getUserInfo());
             return false;
         }
-         $this->load();
-         return true;
+            $this->load();
+            return true;
 
     }
 

Spacing +18 added lines, -18 removed lines

@@ -199,9 +199,9 @@ 
             throw new Exception("Was not able to convert date in ContactReminder->update");
         }
 
-        $sql = "reminder_date = ".$this->db->quote($date->get(), 'date')."," .
-                "date_changed = NOW()," .
-                "subject = ".$this->db->quote($input['subject'], 'text')."," .
+        $sql = "reminder_date = ".$this->db->quote($date->get(), 'date').",".
+                "date_changed = NOW(),".
+                "subject = ".$this->db->quote($input['subject'], 'text').",".
                 "description = ".$this->db->quote($input['description'], 'text')."";
 
         if ($this->error->isError()) {
@@ -212,17 +212,17 @@ 
             $result = $this->db->exec("UPDATE contact_reminder_single SET ".$sql." WHERE intranet_id = ".$this->db->quote($this->contact->kernel->intranet->get('id'), 'integer')." AND id = ".$this->db->quote($this->id, 'integer'));
         } else {
             $result = $this->db->exec("INSERT INTO contact_reminder_single SET ".$sql.", ".
-                "intranet_id = ".$this->db->quote($this->contact->kernel->intranet->get('id'), 'integer')."," .
-                "contact_id = ".$this->db->quote($this->contact->get('id'), 'integer')."," .
-                "created_by_user_id = ".$this->db->quote($this->contact->kernel->user->get('id'), 'integer')."," .
-                "status_key = 1," .
-                "date_created = NOW()," .
+                "intranet_id = ".$this->db->quote($this->contact->kernel->intranet->get('id'), 'integer').",".
+                "contact_id = ".$this->db->quote($this->contact->get('id'), 'integer').",".
+                "created_by_user_id = ".$this->db->quote($this->contact->kernel->user->get('id'), 'integer').",".
+                "status_key = 1,".
+                "date_created = NOW(),".
                 "active = 1");
             $this->id = $this->db->lastInsertID();
         }
 
         if (PEAR::isError($result)) {
-            throw new Exception('Could not save information in ContactReminder->update' . $result->getUserInfo());
+            throw new Exception('Could not save information in ContactReminder->update'.$result->getUserInfo());
             return false;
         }
          return $this->id;
@@ -240,9 +240,9 @@ 
         /**
          * @todo: validation needed - not crucial as we are setting the postpone date
          */
-        $result = $this->db->exec('UPDATE contact_reminder_single SET date_changed = NOW(), reminder_date = ' .$this->db->quote($date, 'date').' WHERE intranet_id = '.$this->db->quote($this->contact->kernel->intranet->get('id'), 'integer').' AND id = '.$this->db->quote($this->id, 'integer'));
+        $result = $this->db->exec('UPDATE contact_reminder_single SET date_changed = NOW(), reminder_date = '.$this->db->quote($date, 'date').' WHERE intranet_id = '.$this->db->quote($this->contact->kernel->intranet->get('id'), 'integer').' AND id = '.$this->db->quote($this->id, 'integer'));
         if (PEAR::isError($result)) {
-            throw new Exception('Could not postphone reminder' . $result->getUserInfo());
+            throw new Exception('Could not postphone reminder'.$result->getUserInfo());
             return false;
         }
          $this->load();
@@ -265,11 +265,11 @@ 
 
         $db = MDB2::singleton(DB_DSN);
         //
-        $result = $db->query('SELECT contact_reminder_single.*, DATE_FORMAT(contact_reminder_single.reminder_date, "%d-%m-%Y") AS dk_reminder_date, address.name AS contact_name ' .
-                'FROM contact_reminder_single ' .
-                'INNER JOIN contact ON (contact_reminder_single.contact_id = contact.id AND contact.intranet_id = '.$db->quote($kernel->intranet->get('id'), 'integer') . ' AND contact.active = 1) '.
-                'LEFT JOIN address ON (address.belong_to_id = contact.id AND address.type = 3 AND address.active = 1) ' .
-                'WHERE contact_reminder_single.reminder_date < DATE_ADD(NOW(), INTERVAL 30 DAY) AND contact_reminder_single.intranet_id = ' .$db->quote($kernel->intranet->get('id'), 'integer').' AND contact_reminder_single.active = 1 AND contact_reminder_single.status_key = 1 ' .
+        $result = $db->query('SELECT contact_reminder_single.*, DATE_FORMAT(contact_reminder_single.reminder_date, "%d-%m-%Y") AS dk_reminder_date, address.name AS contact_name '.
+                'FROM contact_reminder_single '.
+                'INNER JOIN contact ON (contact_reminder_single.contact_id = contact.id AND contact.intranet_id = '.$db->quote($kernel->intranet->get('id'), 'integer').' AND contact.active = 1) '.
+                'LEFT JOIN address ON (address.belong_to_id = contact.id AND address.type = 3 AND address.active = 1) '.
+                'WHERE contact_reminder_single.reminder_date < DATE_ADD(NOW(), INTERVAL 30 DAY) AND contact_reminder_single.intranet_id = '.$db->quote($kernel->intranet->get('id'), 'integer').' AND contact_reminder_single.active = 1 AND contact_reminder_single.status_key = 1 '.
                 'ORDER BY contact_reminder_single.reminder_date ASC');
         if (PEAR::isError($result)) {
             die($result->getUserInfo());
@@ -292,9 +292,9 @@ 
     {
         $status_key = array_search($status, $this->status_types);
 
-        $result = $this->db->exec('UPDATE contact_reminder_single SET date_changed = NOW(), status_key = ' .$this->db->quote($status_key, 'integer').' WHERE intranet_id = '.$this->db->quote($this->contact->kernel->intranet->get('id'), 'integer').' AND id = '.$this->db->quote($this->id, 'integer'));
+        $result = $this->db->exec('UPDATE contact_reminder_single SET date_changed = NOW(), status_key = '.$this->db->quote($status_key, 'integer').' WHERE intranet_id = '.$this->db->quote($this->contact->kernel->intranet->get('id'), 'integer').' AND id = '.$this->db->quote($this->id, 'integer'));
         if (PEAR::isError($result)) {
-            throw new Exception('Could not postphone reminder' . $result->getUserInfo());
+            throw new Exception('Could not postphone reminder'.$result->getUserInfo());
             return false;
         }
          $this->load();

src/Intraface/modules/debtor/Debtor.php

Doc Comments +10 added lines, -10 removed lines

@@ -143,7 +143,7 @@ 
      *
      * @param object  $kernel Kernel
      * @param integer $id     Debtor id or debtor identifier_key
-     * @param type    $tpye   String TODO What is this used for as a last parameter?
+     * @param type    $type   String TODO What is this used for as a last parameter?
      */
     public static function factory($kernel, $id = 0, $type = "")
     {
@@ -618,7 +618,7 @@ 
     /**
      * S�tter status for debtoren
      *
-     * @return true / false
+     * @return boolean / false
      */
     public function setStatus($status)
     {
@@ -676,7 +676,7 @@ 
      * @param string  $from    Where from
      * @param integer $from_id From id
      *
-     * @return true / false
+     * @return boolean / false
      */
     private function setFrom($from = 'manuel', $from_id = 0)
     {
@@ -1135,7 +1135,7 @@ 
     /**
      * Gets the intranet address
      *
-     * @return object
+     * @return Intraface_Address
      */
     public function getIntranetAddress()
     {
@@ -1173,7 +1173,7 @@ 
     /**
      * Returns the total amount on Debtor
      *
-     * @return object Ilib_Variable_Float with total
+     * @return Ilib_Variable_Float Ilib_Variable_Float with total
      */
     public function getTotal()
     {
@@ -1198,7 +1198,7 @@ 
     /**
      * Returns arrears on a debtor
      *
-     * @return object Ilib_Variable_Float with arrears
+     * @return Ilib_Variable_Float Ilib_Variable_Float with arrears
      */
     public function getArrears()
     {
@@ -1221,7 +1221,7 @@ 
     /**
      * returns the possible debtor types!
      *
-     * @return array types
+     * @return string[] types
      */
     static function getDebtorTypes()
     {
@@ -1235,7 +1235,7 @@ 
     /**
      * returns the possible places where the debtor comes from
      *
-     * @return array with the allowed froms
+     * @return string[] with the allowed froms
      */
     private function getFromTypes()
     {
@@ -1251,7 +1251,7 @@ 
     /**
      * returns possible status types
      *
-     * @return array possible status types
+     * @return string[] possible status types
      */
     private function getStatusTypes()
     {
@@ -1266,7 +1266,7 @@ 
     /**
      * returns possible payment methods
      *
-     * @return array possible payment methods
+     * @return string[] possible payment methods
      */
     private function getPaymentMethods()
     {

Indentation +5 added lines, -5 removed lines

@@ -391,7 +391,7 @@ 
         }
 
         if ($this->type == "invoice") {
-          // Hvis det er en faktura skal der indtastes en due_date, ellers er det ligegyldigt!
+            // Hvis det er en faktura skal der indtastes en due_date, ellers er det ligegyldigt!
             if ($validator->isDate($input["due_date"], "Ugyldig leveringsdato", "allow_no_year")) {
                 $due_date = new Intraface_Date($input["due_date"]);
                 $due_date->convert2db();
@@ -447,7 +447,7 @@ 
             $input["round_off"] = 0;
         }
 
-      // user_id = ".$this->kernel->user->get('id').", // skal puttes p�, men kun hvis det ikke er fra webshop.
+        // user_id = ".$this->kernel->user->get('id').", // skal puttes p�, men kun hvis det ikke er fra webshop.
         $db = new DB_Sql;
         if ($this->id == 0) {
             $infinite_check = 0;
@@ -1124,9 +1124,9 @@ 
     function getPaymentInformation()
     {
         $info = array('bank_name'    => $this->kernel->setting->get("intranet", "bank_name"),
-                      'bank_reg_number' => $this->kernel->setting->get("intranet", "bank_reg_number"),
-                      'bank_account_number' => $this->kernel->setting->get("intranet", "bank_account_number"),
-                      'giro_account_number' => $this->kernel->setting->get("intranet", "giro_account_number")
+                        'bank_reg_number' => $this->kernel->setting->get("intranet", "bank_reg_number"),
+                        'bank_account_number' => $this->kernel->setting->get("intranet", "bank_account_number"),
+                        'giro_account_number' => $this->kernel->setting->get("intranet", "giro_account_number")
         );
 
         return $info;

Spacing +18 added lines, -18 removed lines

@@ -271,7 +271,7 @@ 
 
         // Bruges til at afg�re, hvor debtor er sendt hent til
         $db = new DB_Sql;
-        $db->query("SELECT id, type FROM debtor WHERE where_from > 2 AND where_from_id = " . $this->id . " AND active = 1");
+        $db->query("SELECT id, type FROM debtor WHERE where_from > 2 AND where_from_id = ".$this->id." AND active = 1");
         if ($db->nextRecord()) {
             if ($db->f('type') > 0) {
                 $types = self::getDebtorTypes();
@@ -305,7 +305,7 @@ 
         // @todo Currency is always loaded, should be done with left join. Oh give me more doctrine!
         $currency = $this->getCurrency();
 
-        for ($i = 0, $max = count($item), $total = 0, $total_currency = 0; $i<$max; $i++) {
+        for ($i = 0, $max = count($item), $total = 0, $total_currency = 0; $i < $max; $i++) {
             $total += $item[$i]["amount"]->getAsIso();
             if ($currency) {
                 $total_currency += $item[$i]['amount_currency']->getAsIso();
@@ -462,12 +462,12 @@ 
             } while ($db->nextRecord());
 
             $sql_type = "INSERT INTO ";
-            $sql_after = ", date_created = NOW(), identifier_key = \"".$identifier."\", intranet_id = " . $this->kernel->intranet->get('id');
+            $sql_after = ", date_created = NOW(), identifier_key = \"".$identifier."\", intranet_id = ".$this->kernel->intranet->get('id');
         } else {
             $sql_type = "UPDATE ";
-            $sql_after = " WHERE id = " . $this->id . " AND intranet_id = " . $this->kernel->intranet->get('id');
+            $sql_after = " WHERE id = ".$this->id." AND intranet_id = ".$this->kernel->intranet->get('id');
         }
-        $sql = $sql_type . "debtor SET contact_id = " . $contact->get('id') . ",
+        $sql = $sql_type."debtor SET contact_id = ".$contact->get('id').",
             contact_address_id = ".$contact_address_id.",
             contact_person_id = ".$input['contact_person_id'].",
             intranet_address_id = ".$this->kernel->intranet->address->get("address_id").",
@@ -482,7 +482,7 @@ 
             currency_id = ".$currency_id.",
             currency_product_price_exchange_rate_id = ".$currency_exchange_rate_id.",
             payment_method=".$input['payment_method'].",
-            girocode='".$input['girocode']."' " . $internal_note_sql . $sql_after;
+            girocode='".$input['girocode']."' ".$internal_note_sql.$sql_after;
 
             // attention_to = '". $input['attention_to'] ."',
 
@@ -494,7 +494,7 @@ 
         }
 
         if (is_object($this->kernel->user) and strtolower(get_class($this->kernel->user)) == 'user') {
-            $db->query("UPDATE debtor SET user_id = ".$this->kernel->user->get('id')." WHERE id = " . $this->id);
+            $db->query("UPDATE debtor SET user_id = ".$this->kernel->user->get('id')." WHERE id = ".$this->id);
         }
 
         $this->load();
@@ -514,9 +514,9 @@ 
             return false;
         }
         $db = new DB_Sql;
-        $db->query("SELECT id FROM debtor WHERE id = " . $this->id . " AND intranet_id = " . $this->kernel->intranet->get('id'). " AND type = '".$this->type_key."' LIMIT 1");
+        $db->query("SELECT id FROM debtor WHERE id = ".$this->id." AND intranet_id = ".$this->kernel->intranet->get('id')." AND type = '".$this->type_key."' LIMIT 1");
         if ($db->nextRecord()) {
-            $db->query("UPDATE debtor SET active = 0 WHERE id = " . $this->id . " AND intranet_id = " . $this->kernel->intranet->get('id') . "  AND type = '".$this->type_key."'");
+            $db->query("UPDATE debtor SET active = 0 WHERE id = ".$this->id." AND intranet_id = ".$this->kernel->intranet->get('id')."  AND type = '".$this->type_key."'");
             return true;
         }
         return false;
@@ -566,7 +566,7 @@ 
 
         switch ($this->type) {
             case "invoice":
-                $values['due_date'] = date("d-m-Y", time() + 24 * 60 * 60 * $debtor_object->contact->get("paymentcondition"));
+                $values['due_date'] = date("d-m-Y", time() + 24*60*60*$debtor_object->contact->get("paymentcondition"));
                 if (empty($values['payment_method']) and $this->kernel->setting->get('intranet', 'bank_account_number')) {
                     $values['payment_method'] = 1;
                 }
@@ -663,7 +663,7 @@ 
         }
 
         $db = new Db_Sql;
-        $db->query("UPDATE debtor SET status = ".$status_id.", ".$sql."  WHERE id = " . $this->id . " AND intranet_id = " . $this->kernel->intranet->get('id'));
+        $db->query("UPDATE debtor SET status = ".$status_id.", ".$sql."  WHERE id = ".$this->id." AND intranet_id = ".$this->kernel->intranet->get('id'));
         $this->load();
 
         return true;
@@ -690,7 +690,7 @@ 
             return false;
         }
         $db = new Db_Sql;
-        $db->query("UPDATE debtor SET where_from = ".(int)$from.", where_from_id = " . $from_id . " WHERE id = " . $this->id);
+        $db->query("UPDATE debtor SET where_from = ".(int)$from.", where_from_id = ".$from_id." WHERE id = ".$this->id);
         return true;
     }
 
@@ -711,7 +711,7 @@ 
         }
         $contact_id = (int)$contact_id;
         $db = new DB_Sql;
-        $db->query("UPDATE debtor SET contact_id = " . $contact_id . " WHERE id = " . $this->id . " AND intranet_id = " . $this->kernel->intranet->get("id") . " AND type='".$this->type_key."'");
+        $db->query("UPDATE debtor SET contact_id = ".$contact_id." WHERE id = ".$this->id." AND intranet_id = ".$this->kernel->intranet->get("id")." AND type='".$this->type_key."'");
 
         return true;
     }
@@ -740,7 +740,7 @@ 
             case 'contact':
                 $sql = "SELECT id
                 FROM debtor
-                    WHERE intranet_id = " . $this->kernel->intranet->get("id") . "
+                    WHERE intranet_id = " . $this->kernel->intranet->get("id")."
                         AND contact_id = ".(int)$type_id."
               AND type='".$this->type_key."'
               AND active = 1";
@@ -774,7 +774,7 @@ 
     public function isFilledIn()
     {
         $db = new DB_Sql;
-        $db->query("SELECT id FROM debtor WHERE type = " . $this->type_key . " AND intranet_id = " . $this->kernel->intranet->get('id'));
+        $db->query("SELECT id FROM debtor WHERE type = ".$this->type_key." AND intranet_id = ".$this->kernel->intranet->get('id'));
         return $db->numRows();
     }
 
@@ -972,7 +972,7 @@ 
     {
         $number = safeToDb($number);
         $db = new DB_Sql;
-        $sql = "SELECT id FROM debtor WHERE intranet_id = " . $this->kernel->intranet->get('id') . " AND number = '".$number."' AND type = '".$this->type_key."' AND id != " . $this->id." AND active = 1";
+        $sql = "SELECT id FROM debtor WHERE intranet_id = ".$this->kernel->intranet->get('id')." AND number = '".$number."' AND type = '".$this->type_key."' AND id != ".$this->id." AND active = 1";
         $db->query($sql);
         if ($db->numRows() == 0) {
             return true;
@@ -1057,7 +1057,7 @@ 
     {
         // FIXME - check on date
         $db = new DB_Sql;
-        $db->query("UPDATE debtor SET date_stated = '" . $voucher_date . "', voucher_id = '".$voucher_id."' WHERE id = " . $this->id . " AND intranet_id = " . $this->kernel->intranet->get('id'));
+        $db->query("UPDATE debtor SET date_stated = '".$voucher_date."', voucher_id = '".$voucher_id."' WHERE id = ".$this->id." AND intranet_id = ".$this->kernel->intranet->get('id'));
         return true;
     }
 
@@ -1301,6 +1301,6 @@ 
 
     function getPaymentLink($url)
     {
-        return $url . $this->getIdentifier();
+        return $url.$this->getIdentifier();
     }
 }

src/Intraface/modules/debtor/DebtorItem.php

Doc Comments +2 added lines, -2 removed lines

@@ -240,7 +240,7 @@ 
     /**
      * Gets the tax percent on the individual product
      *
-     * @return float
+     * @return integer
      */
     public function getTaxPercent()
     {
@@ -570,7 +570,7 @@ 
     /**
      * Returns position object
      *
-     * @return object Ilib_Position
+     * @return Ilib_Position Ilib_Position
      */
     function getPosition($db)
     {

Indentation +3 added lines, -3 removed lines

@@ -282,7 +282,7 @@ 
             $product = new Product($this->debtor->kernel, $input["product_id"], $input['product_detail_id']);
 
             if (!is_object($product) || $product->get('id') == 0) {
-                 $this->error->set("Ugyldigt produkt");
+                    $this->error->set("Ugyldigt produkt");
             } else {
                 $product_detail_id = $product->get("detail_id");
             }
@@ -374,7 +374,7 @@ 
         $product = new Product($this->debtor->kernel, $product_id);
 
         if (!is_object($product) || $product->get('id') == 0) {
-             throw new Excetion('Invalid product id');
+                throw new Excetion('Invalid product id');
         } else {
             $product_detail_id = $product->get("detail_id");
         }
@@ -501,7 +501,7 @@ 
                     $i++;
                 }
             } else {
-                 throw new Exception("Ugyldig produktdetalje i DebtorItem->getList() on ".$db->f('product_id').'/'.$db->f('product_detail_id'));
+                    throw new Exception("Ugyldig produktdetalje i DebtorItem->getList() on ".$db->f('product_id').'/'.$db->f('product_detail_id'));
             }
         }
         unset($db);

Spacing +8 added lines, -8 removed lines

@@ -224,7 +224,7 @@ 
         // TODO how do we handle vat? this should return raw prices
         // and then the tax percent should return the tax to apply
         // the calculator should handle the final price
-        return $this->getProductPrice() * $this->get('quantity');
+        return $this->getProductPrice()*$this->get('quantity');
     }
 
     /**
@@ -234,7 +234,7 @@ 
      */
     public function getWeight()
     {
-        return $this->getProductWeight() * $this->get('quantity');
+        return $this->getProductWeight()*$this->get('quantity');
     }
 
     /**
@@ -471,14 +471,14 @@ 
                     $variation = $product->getVariation($db->f('product_variation_id'));
                     $detail = $variation->getDetail($db->f('product_variation_detail_id'));
                     $item["name"] = $product->get("name").' - '.$variation->getName();
-                    $item["number"]= $product->get("number").'.'.$variation->getNumber();
+                    $item["number"] = $product->get("number").'.'.$variation->getNumber();
                     $item["price"] = $detail->getPrice($product);
                     if ($currency) {
                         $item['price_currency'] = $detail->getPriceInCurrency($currency, $this->debtor->get('currency_product_price_exchange_rate_id'), $product);
                     }
                 } else {
                     $item["name"] = $product->get("name");
-                    $item["number"]= $product->get("number");
+                    $item["number"] = $product->get("number");
                     $item["price"] = $product->getDetails()->getPrice();
                     if ($currency) {
                         $item['price_currency'] = $product->getDetails()->getPriceInCurrency($currency, $this->debtor->get('currency_product_price_exchange_rate_id'));
@@ -487,16 +487,16 @@ 
 
                 if ($product->get("vat") == 0) {
                     $item_no_vat[$j] = $item;
-                    $item_no_vat[$j]["amount"] = new Ilib_Variable_Float($item["quantity"] * $item["price"]->getAsIso(2));
+                    $item_no_vat[$j]["amount"] = new Ilib_Variable_Float($item["quantity"]*$item["price"]->getAsIso(2));
                     if ($currency) {
-                        $item_no_vat[$j]["amount_currency"] = new Ilib_Variable_Float($item["quantity"] * $item["price_currency"]->getAsIso(2), 'iso');
+                        $item_no_vat[$j]["amount_currency"] = new Ilib_Variable_Float($item["quantity"]*$item["price_currency"]->getAsIso(2), 'iso');
                     }
                     $j++;
                 } else {
                     $item_with_vat[$i] = $item;
-                    $item_with_vat[$i]["amount"] = new Ilib_Variable_Float($item["quantity"] * $item["price"]->getAsIso(2) * 1.25);
+                    $item_with_vat[$i]["amount"] = new Ilib_Variable_Float($item["quantity"]*$item["price"]->getAsIso(2)*1.25);
                     if ($currency) {
-                        $item_with_vat[$i]["amount_currency"] = new Ilib_Variable_Float($item["quantity"] * $item["price_currency"]->getAsIso(2) * 1.25, 'iso');
+                        $item_with_vat[$i]["amount_currency"] = new Ilib_Variable_Float($item["quantity"]*$item["price_currency"]->getAsIso(2)*1.25, 'iso');
                     }
                     $i++;
                 }

src/Intraface/modules/filemanager/AppendFile.php

Doc Comments +3 added lines, -2 removed lines

@@ -26,7 +26,7 @@ 
      * @param string  $belong_to    Which type the file belongs to
      * @param integer $belong_to_id The id this appended file belongs to
      *
-     * @return void
+     * @return integer
      */
     public function __construct($kernel, $belong_to, $belong_to_id)
     {
@@ -157,7 +157,7 @@ 
     /**
      * Adds an array with files
      *
-     * @param array $files An array with files
+     * @param FakeAppendFileFile[] $files An array with files
      *
      * @return boolean
      */
@@ -188,6 +188,7 @@ 
     /**
      * Undelete
      *
+     * @param integer $id
      * @return boolean
      */
     public function undelete($id)

Spacing +2 added lines, -2 removed lines

@@ -99,7 +99,7 @@ 
         if ($this->dbquery) {
             return $this->dbquery;
         }
-        $this->dbquery = new Ilib_DBQuery('filehandler_append_file', 'filehandler_append_file.active = 1 AND filehandler_append_file.intranet_id='.$this->kernel->intranet->get('id').' AND filehandler_append_file.belong_to_key = '.$this->belong_to_key.' AND filehandler_append_file.belong_to_id = ' . $this->belong_to_id);
+        $this->dbquery = new Ilib_DBQuery('filehandler_append_file', 'filehandler_append_file.active = 1 AND filehandler_append_file.intranet_id='.$this->kernel->intranet->get('id').' AND filehandler_append_file.belong_to_key = '.$this->belong_to_key.' AND filehandler_append_file.belong_to_id = '.$this->belong_to_id);
         $this->dbquery->createStore($this->kernel->getSessionId(), 'intranet_id = '.intval($this->kernel->intranet->get('id')));
         return $this->dbquery;
     }
@@ -115,7 +115,7 @@ 
     {
         $db = new DB_Sql();
         $db->query("SELECT id FROM filehandler_append_file
-            WHERE intranet_id = " . $this->kernel->intranet->get('id') . "
+            WHERE intranet_id = " . $this->kernel->intranet->get('id')."
                 AND belong_to_key = ".$this->belong_to_key."
                 AND belong_to_id = ".$this->belong_to_id."
                 AND file_handler_id = ".$file_id."

src/Intraface/modules/filemanager/FileHandler.php

Doc Comments +4 added lines, -4 removed lines

@@ -198,7 +198,7 @@ 
     /**
      * Creates a filehandler
      *
-     * @param object $kernel     Kernel object
+     * @param Stub_Kernel $kernel     Kernel object
      * @param string $access_key The accesskey
      *
      * @return object
@@ -359,7 +359,8 @@ 
      * creates and temporary file handler
      *
      * @param string optional file name
-     * @return object temporary file
+     * @param string $file_name
+     * @return TemporaryFile temporary file
      */
     public function createTemporaryFile($file_name = null)
     {
@@ -689,8 +690,7 @@ 
     /**
      * Returns RandomKeyGenerator
      *
-     * @param integer $length the length of the random key
-     * @return object RandomKeyGenerator
+     * @return Ilib_RandomKeyGenerator RandomKeyGenerator
      */
     private function getRandomKeyGenerator()
     {

Spacing +4 added lines, -4 removed lines

@@ -114,7 +114,7 @@ 
         $this->id = (int)$file_id;
         $this->error = new Ilib_Error;
 
-        $this->upload_path = PATH_UPLOAD . $this->kernel->intranet->get('id') . '/';
+        $this->upload_path = PATH_UPLOAD.$this->kernel->intranet->get('id').'/';
         $this->tempdir_path = $this->upload_path.PATH_UPLOAD_TEMPORARY;
         $this->file_viewer = FILE_VIEWER;
         $this->www_path = PATH_WWW;
@@ -260,7 +260,7 @@ 
         $this->loadMimeTypes();
         $this->value['file_type'] = $this->_getMimeType((int)$db->f('file_type_key'));
         $this->value['is_image'] = $this->file_types[$this->get('file_type_key')]['image'];
-        $this->value['file_path'] = $this->upload_path . $db->f('server_file_name');
+        $this->value['file_path'] = $this->upload_path.$db->f('server_file_name');
 
         if (file_exists($this->get('file_path'))) {
             $this->value['last_modified'] = filemtime($this->get('file_path'));
@@ -407,7 +407,7 @@ 
         }
 
         $db = new DB_Sql;
-        $deleted_file_name = $this->upload_path . '_deleted_' . $this->get('server_file_name');
+        $deleted_file_name = $this->upload_path.'_deleted_'.$this->get('server_file_name');
         if (file_exists($deleted_file_name)) {
             if (!rename($deleted_file_name, $this->upload_path.$this->get('server_file_name'))) {
                 throw new Exception("Kunne ikke omdøbe filen i FileHandler->undelete()");
@@ -682,7 +682,7 @@ 
     public function moveFromTemporary()
     {
         $db = new DB_Sql;
-        $db->query("UPDATE file_handler SET temporary = 0 WHERE user_id = ".$this->kernel->user->get('id')." AND id = " . $this->id);
+        $db->query("UPDATE file_handler SET temporary = 0 WHERE user_id = ".$this->kernel->user->get('id')." AND id = ".$this->id);
         return true;
     }