intraface / intraface.dk

src/DB/Sql.php

Doc Comments +6 added lines

@@ -26,6 +26,9 @@ 
         $this->db->setOption('portability', MDB2_PORTABILITY_NONE);
     }
 
+    /**
+     * @param string $SQL
+     */
     function query($SQL)
     {
         $this->result = $this->db->query($SQL);
@@ -101,6 +104,9 @@ 
         return mysql_escape_string($value);
     }
 
+    /**
+     * @param string $type
+     */
     function quote($value, $type)
     {
         return $this->db->quote($value, $type);

Spacing +5 added lines, -5 removed lines

@@ -16,11 +16,11 @@ 
         if (empty($dbhost) OR empty($dbuser) OR empty($dbpass) OR empty($dbname)) {
             $this->db = MDB2::singleton(DB_DSN);
         } else {
-            $this->db = MDB2::singleton('mysql://' . $dbuser . ':' . $dbpass . '@' . $dbhost . '/' . $dbname);
+            $this->db = MDB2::singleton('mysql://'.$dbuser.':'.$dbpass.'@'.$dbhost.'/'.$dbname);
         }
 
         if (PEAR::isError($this->db)) {
-            die($this->db->getMessage() . ' ' . $this->db->getUserInfo());
+            die($this->db->getMessage().' '.$this->db->getUserInfo());
         }
         $this->db->query('SET NAMES utf8');
         $this->db->setOption('portability', MDB2_PORTABILITY_NONE);
@@ -30,7 +30,7 @@ 
     {
         $this->result = $this->db->query($SQL);
         if (PEAR::isError($this->result)) {
-            die($this->result->getMessage() . ' ' . $this->result->getUserInfo());
+            die($this->result->getMessage().' '.$this->result->getUserInfo());
         }
     }
 
@@ -38,7 +38,7 @@ 
     {
         $this->result = $this->db->exec($SQL);
         if (PEAR::isError($this->result)) {
-            die($this->result->getMessage() . ' ' . $this->result->getUserInfo());
+            die($this->result->getMessage().' '.$this->result->getUserInfo());
         }
 
         $this->result->free();
@@ -52,7 +52,7 @@ 
         // while($db->next_record()) {
         $this->row = $this->result->fetchRow(MDB2_FETCHMODE_ASSOC);
         if (PEAR::isError($this->row)) {
-            die($this->row->getMessage() . '' . $this->row->getUserInfo());
+            die($this->row->getMessage().''.$this->row->getUserInfo());
         }
 
         return($this->row);

src/Intraface/AddressGateway.php

Doc Comments +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
      * @param string  $belong_to    What the address belongs to, corresponding to the ones in Address::getBelongToTypes()
      * @param integer $belong_to_id From belong_to. NB not id on the address
      *
-     * @return object Address
+     * @return Intraface_Address Address
      */
     public function findByBelongToAndId($belong_to, $belong_to_id)
     {

src/Intraface/KernelGateway.php

Doc Comments +3 added lines

@@ -8,6 +8,9 @@
         $this->translation = $translation;
     }
 
+    /**
+     * @param Intraface_User $user
+     */
     function findByUserobject($user)
     {
         $kernel = new Intraface_Kernel(session_id());

src/Intraface/modules/accounting/PostGateway.php

Doc Comments +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
      *
      * @param object $voucher
      *
-     * @return void
+     * @return string
      */
     function __construct($voucher)
     {

Spacing +4 added lines, -4 removed lines

@@ -39,11 +39,11 @@ 
     {
         $post_id = (int)$post_id;
         $db = new DB_Sql;
-        $db->query("SELECT voucher_id FROM accounting_post WHERE id = " . $post_id . " AND year_id = " . $year->get('id') . " AND intranet_id=" . $year->kernel->intranet->get('id'));
+        $db->query("SELECT voucher_id FROM accounting_post WHERE id = ".$post_id." AND year_id = ".$year->get('id')." AND intranet_id=".$year->kernel->intranet->get('id'));
         if (!$db->nextRecord()) {
             return new Post(new Voucher($year));
         }
-        $post =  new Post(new Voucher($year, $db->f('voucher_id')), (int)$post_id);
+        $post = new Post(new Voucher($year, $db->f('voucher_id')), (int)$post_id);
         return $post;
 
     }
@@ -51,13 +51,13 @@ 
     public function getList($type = 'stated')
     {
         $db = new DB_Sql;
-        $sql = "SELECT voucher.reference, post.id, post.text, post.voucher_id, post.date, post.account_id, post.debet, post.credit, post.stated, DATE_FORMAT(post.date, '%d-%m-%Y') AS date_dk FROM accounting_post post INNER JOIN accounting_voucher voucher ON post.voucher_id = voucher.id WHERE post.year_id = " . $this->voucher->year->get('id') . " AND post.intranet_id = " . $this->voucher->year->kernel->intranet->get('id');
+        $sql = "SELECT voucher.reference, post.id, post.text, post.voucher_id, post.date, post.account_id, post.debet, post.credit, post.stated, DATE_FORMAT(post.date, '%d-%m-%Y') AS date_dk FROM accounting_post post INNER JOIN accounting_voucher voucher ON post.voucher_id = voucher.id WHERE post.year_id = ".$this->voucher->year->get('id')." AND post.intranet_id = ".$this->voucher->year->kernel->intranet->get('id');
         if ($type == 'stated') {
             $sql .= " AND post.stated = 1";
         } elseif ($type == 'draft') {
             $sql .= " AND post.stated = 0";
         }
-        $db->query($sql . " ORDER BY post.voucher_id DESC, post.id DESC");
+        $db->query($sql." ORDER BY post.voucher_id DESC, post.id DESC");
 
         $i = 0;
         $this->value['list_saldo'] = 0;

src/Intraface/modules/accounting/VoucherFileGateway.php

Doc Comments +3 added lines

@@ -90,6 +90,9 @@
         return $files;
     }
 
+    /**
+     * @param string $url
+     */
     function url($url)
     {
         return PATH_WWW . 'restricted' . $url;

Spacing +5 added lines, -5 removed lines

@@ -22,14 +22,14 @@ 
 
     function findFromId($id)
     {
-        require_once dirname(__FILE__) . '/VoucherFile.php';
+        require_once dirname(__FILE__).'/VoucherFile.php';
         return new VoucherFile($this->voucher, $id);
     }
 
     function getList()
     {
         $db = new DB_Sql;
-        $db->query("SELECT * FROM accounting_voucher_file WHERE active = 1 AND voucher_id = " . $this->voucher->get('id') . " AND intranet_id=" . $this->voucher->year->kernel->intranet->get('id'));
+        $db->query("SELECT * FROM accounting_voucher_file WHERE active = 1 AND voucher_id = ".$this->voucher->get('id')." AND intranet_id=".$this->voucher->year->kernel->intranet->get('id'));
         $i = 0;
         $files = array();
         while ($db->nextRecord()) {
@@ -49,7 +49,7 @@ 
                         $files[$i]['description'] = 'Momsperiode';
                     }
                     $files[$i]['name'] = 'Momsperiode';
-                    $files[$i]['file_uri'] = $this->url('/module/accounting/year/'.$this->voucher->year->getId().'/vat/' . $db->f('belong_to_id'));
+                    $files[$i]['file_uri'] = $this->url('/module/accounting/year/'.$this->voucher->year->getId().'/vat/'.$db->f('belong_to_id'));
                     break;
                 case 'file':
                     $this->voucher->year->kernel->useModule('filemanager');
@@ -63,7 +63,7 @@ 
                         $files[$i]['description'] = 'Kreditnota';
                     }
                     $files[$i]['name'] = 'Kreditnota';
-                    $files[$i]['file_uri'] = $this->url('/module/debtor/credit_note/' . $db->f('belong_to_id') . '.pdf');
+                    $files[$i]['file_uri'] = $this->url('/module/debtor/credit_note/'.$db->f('belong_to_id').'.pdf');
                     break;
                 case 'reminder':
                     if (empty($files[$i]['description'])) {
@@ -91,6 +91,6 @@ 
 
     function url($url)
     {
-        return PATH_WWW . 'restricted' . $url;
+        return PATH_WWW.'restricted'.$url;
     }
 }

src/Intraface/modules/accounting/VoucherGateway.php

Doc Comments +2 added lines, -3 removed lines

@@ -16,7 +16,7 @@ 
      *
      * @param object  $year_object
      *
-     * @return void
+     * @return string
      */
     public function __construct($year_object)
     {
@@ -32,10 +32,9 @@ 
     /**
      * Creates a voucher
      *
-     * @param object $year
      * @param string $voucher_number
      *
-     * @return void
+     * @return Voucher
      */
     public function findFromVoucherNumber($voucher_number)
     {

Spacing +3 added lines, -3 removed lines

@@ -25,7 +25,7 @@ 
 
     public function findFromId($id)
     {
-        require_once dirname(__FILE__) . '/Voucher.php';
+        require_once dirname(__FILE__).'/Voucher.php';
         return new Voucher($this->year, $id);
     }
 
@@ -40,7 +40,7 @@ 
     public function findFromVoucherNumber($voucher_number)
     {
         $db = new DB_Sql;
-        $db->query("SELECT id FROM accounting_voucher WHERE number = '".safeToDb($voucher_number)."' AND year_id = '".$this->year->get('id')."' AND intranet_id = " . $this->year->kernel->intranet->get('id'));
+        $db->query("SELECT id FROM accounting_voucher WHERE number = '".safeToDb($voucher_number)."' AND year_id = '".$this->year->get('id')."' AND intranet_id = ".$this->year->kernel->intranet->get('id'));
         if (!$db->nextRecord()) {
             return new Voucher($this->year);
         }
@@ -93,7 +93,7 @@ 
 
         $db->query("SELECT MAX(number) AS max_voucher_number
             FROM accounting_voucher
-            WHERE intranet_id = " . $this->year->kernel->intranet->get('id') . "
+            WHERE intranet_id = " . $this->year->kernel->intranet->get('id')."
                 AND year_id = " . $this->year->get('id'));
         if (!$db->nextRecord()) {
             return 0;

src/Intraface/modules/cms/ElementGateway.php

Doc Comments +9 added lines

@@ -11,6 +11,9 @@ 
         $this->kernel = $kernel;
     }
 
+    /**
+     * @param string $type
+     */
     function findBySectionAndType($section, $type)
     {
         $class = $this->class_prefix . ucfirst($type);
@@ -37,6 +40,9 @@ 
         return new $class(CMS_Section::factory($this->kernel, 'id', $this->db->f('section_id')), $this->db->f('id'));
     }
 
+    /**
+     * @param string $id
+     */
     function findByKernelAndId($kernel, $id)
     {
         $cms_module = $kernel->getModule('cms');
@@ -53,6 +59,9 @@ 
         return new $class(CMS_Section::factory($kernel, 'id', $this->db->f('section_id')), $this->db->f('id'));
     }
 
+    /**
+     * @param string $id
+     */
     function findBySectionAndId($section, $id)
     {
         // FIXME - jeg tror den her kan skabe en del

Spacing +7 added lines, -7 removed lines

@@ -13,7 +13,7 @@ 
 
     function findBySectionAndType($section, $type)
     {
-        $class = $this->class_prefix . ucfirst($type);
+        $class = $this->class_prefix.ucfirst($type);
 
         if (!class_exists($class)) {
             throw new Exception('Class does not exist');
@@ -26,11 +26,11 @@ 
         $cms_module = $this->kernel->getModule('cms');
         $element_types = $cms_module->getSetting('element_types');
 
-        $this->db->query("SELECT id, section_id, type_key FROM cms_element WHERE id = " . $id . " AND intranet_id = " . $this->kernel->intranet->get('id'));
+        $this->db->query("SELECT id, section_id, type_key FROM cms_element WHERE id = ".$id." AND intranet_id = ".$this->kernel->intranet->get('id'));
         if (!$this->db->nextRecord()) {
             return false;
         }
-        $class = $this->class_prefix . ucfirst($element_types[$this->db->f('type_key')]);
+        $class = $this->class_prefix.ucfirst($element_types[$this->db->f('type_key')]);
         if (!class_exists($class)) {
             return false;
         }
@@ -42,11 +42,11 @@ 
         $cms_module = $kernel->getModule('cms');
         $element_types = $cms_module->getSetting('element_types');
 
-        $this->db->query("SELECT id, section_id, type_key FROM cms_element WHERE id = " . $id . " AND intranet_id = " . $kernel->intranet->get('id'));
+        $this->db->query("SELECT id, section_id, type_key FROM cms_element WHERE id = ".$id." AND intranet_id = ".$kernel->intranet->get('id'));
         if (!$this->db->nextRecord()) {
             return false;
         }
-        $class = $this->class_prefix . ucfirst($element_types[$this->db->f('type_key')]);
+        $class = $this->class_prefix.ucfirst($element_types[$this->db->f('type_key')]);
         if (!class_exists($class)) {
             return false;
         }
@@ -61,12 +61,12 @@ 
         $cms_module = $section->kernel->getModule('cms');
         $element_types = $cms_module->getSetting('element_types');
 
-        $this->db->query("SELECT id, section_id, type_key FROM cms_element WHERE id = " . $id . " AND intranet_id = " . $section->kernel->intranet->get('id'));
+        $this->db->query("SELECT id, section_id, type_key FROM cms_element WHERE id = ".$id." AND intranet_id = ".$section->kernel->intranet->get('id'));
         if (!$this->db->nextRecord()) {
             return false;
         }
 
-        $class = $this->class_prefix . ucfirst($element_types[$this->db->f('type_key')]);
+        $class = $this->class_prefix.ucfirst($element_types[$this->db->f('type_key')]);
         if (!class_exists($class)) {
             return false;
         }

src/Intraface/modules/contact/ContactReminder.php

Doc Comments +3 added lines

@@ -124,6 +124,9 @@
         }
     }
 
+    /**
+     * @param integer $id
+     */
     public function factory($kernel, $id)
     {
         $gateway = new Intraface_modules_contact_MemosGateway($kernel);

Spacing +18 added lines, -18 removed lines

@@ -199,9 +199,9 @@ 
             throw new Exception("Was not able to convert date in ContactReminder->update");
         }
 
-        $sql = "reminder_date = ".$this->db->quote($date->get(), 'date')."," .
-                "date_changed = NOW()," .
-                "subject = ".$this->db->quote($input['subject'], 'text')."," .
+        $sql = "reminder_date = ".$this->db->quote($date->get(), 'date').",".
+                "date_changed = NOW(),".
+                "subject = ".$this->db->quote($input['subject'], 'text').",".
                 "description = ".$this->db->quote($input['description'], 'text')."";
 
         if ($this->error->isError()) {
@@ -212,17 +212,17 @@ 
             $result = $this->db->exec("UPDATE contact_reminder_single SET ".$sql." WHERE intranet_id = ".$this->db->quote($this->contact->kernel->intranet->get('id'), 'integer')." AND id = ".$this->db->quote($this->id, 'integer'));
         } else {
             $result = $this->db->exec("INSERT INTO contact_reminder_single SET ".$sql.", ".
-                "intranet_id = ".$this->db->quote($this->contact->kernel->intranet->get('id'), 'integer')."," .
-                "contact_id = ".$this->db->quote($this->contact->get('id'), 'integer')."," .
-                "created_by_user_id = ".$this->db->quote($this->contact->kernel->user->get('id'), 'integer')."," .
-                "status_key = 1," .
-                "date_created = NOW()," .
+                "intranet_id = ".$this->db->quote($this->contact->kernel->intranet->get('id'), 'integer').",".
+                "contact_id = ".$this->db->quote($this->contact->get('id'), 'integer').",".
+                "created_by_user_id = ".$this->db->quote($this->contact->kernel->user->get('id'), 'integer').",".
+                "status_key = 1,".
+                "date_created = NOW(),".
                 "active = 1");
             $this->id = $this->db->lastInsertID();
         }
 
         if (PEAR::isError($result)) {
-            throw new Exception('Could not save information in ContactReminder->update' . $result->getUserInfo());
+            throw new Exception('Could not save information in ContactReminder->update'.$result->getUserInfo());
             return false;
         }
          return $this->id;
@@ -240,9 +240,9 @@ 
         /**
          * @todo: validation needed - not crucial as we are setting the postpone date
          */
-        $result = $this->db->exec('UPDATE contact_reminder_single SET date_changed = NOW(), reminder_date = ' .$this->db->quote($date, 'date').' WHERE intranet_id = '.$this->db->quote($this->contact->kernel->intranet->get('id'), 'integer').' AND id = '.$this->db->quote($this->id, 'integer'));
+        $result = $this->db->exec('UPDATE contact_reminder_single SET date_changed = NOW(), reminder_date = '.$this->db->quote($date, 'date').' WHERE intranet_id = '.$this->db->quote($this->contact->kernel->intranet->get('id'), 'integer').' AND id = '.$this->db->quote($this->id, 'integer'));
         if (PEAR::isError($result)) {
-            throw new Exception('Could not postphone reminder' . $result->getUserInfo());
+            throw new Exception('Could not postphone reminder'.$result->getUserInfo());
             return false;
         }
          $this->load();
@@ -265,11 +265,11 @@ 
 
         $db = MDB2::singleton(DB_DSN);
         //
-        $result = $db->query('SELECT contact_reminder_single.*, DATE_FORMAT(contact_reminder_single.reminder_date, "%d-%m-%Y") AS dk_reminder_date, address.name AS contact_name ' .
-                'FROM contact_reminder_single ' .
-                'INNER JOIN contact ON (contact_reminder_single.contact_id = contact.id AND contact.intranet_id = '.$db->quote($kernel->intranet->get('id'), 'integer') . ' AND contact.active = 1) '.
-                'LEFT JOIN address ON (address.belong_to_id = contact.id AND address.type = 3 AND address.active = 1) ' .
-                'WHERE contact_reminder_single.reminder_date < DATE_ADD(NOW(), INTERVAL 30 DAY) AND contact_reminder_single.intranet_id = ' .$db->quote($kernel->intranet->get('id'), 'integer').' AND contact_reminder_single.active = 1 AND contact_reminder_single.status_key = 1 ' .
+        $result = $db->query('SELECT contact_reminder_single.*, DATE_FORMAT(contact_reminder_single.reminder_date, "%d-%m-%Y") AS dk_reminder_date, address.name AS contact_name '.
+                'FROM contact_reminder_single '.
+                'INNER JOIN contact ON (contact_reminder_single.contact_id = contact.id AND contact.intranet_id = '.$db->quote($kernel->intranet->get('id'), 'integer').' AND contact.active = 1) '.
+                'LEFT JOIN address ON (address.belong_to_id = contact.id AND address.type = 3 AND address.active = 1) '.
+                'WHERE contact_reminder_single.reminder_date < DATE_ADD(NOW(), INTERVAL 30 DAY) AND contact_reminder_single.intranet_id = '.$db->quote($kernel->intranet->get('id'), 'integer').' AND contact_reminder_single.active = 1 AND contact_reminder_single.status_key = 1 '.
                 'ORDER BY contact_reminder_single.reminder_date ASC');
         if (PEAR::isError($result)) {
             die($result->getUserInfo());
@@ -292,9 +292,9 @@ 
     {
         $status_key = array_search($status, $this->status_types);
 
-        $result = $this->db->exec('UPDATE contact_reminder_single SET date_changed = NOW(), status_key = ' .$this->db->quote($status_key, 'integer').' WHERE intranet_id = '.$this->db->quote($this->contact->kernel->intranet->get('id'), 'integer').' AND id = '.$this->db->quote($this->id, 'integer'));
+        $result = $this->db->exec('UPDATE contact_reminder_single SET date_changed = NOW(), status_key = '.$this->db->quote($status_key, 'integer').' WHERE intranet_id = '.$this->db->quote($this->contact->kernel->intranet->get('id'), 'integer').' AND id = '.$this->db->quote($this->id, 'integer'));
         if (PEAR::isError($result)) {
-            throw new Exception('Could not postphone reminder' . $result->getUserInfo());
+            throw new Exception('Could not postphone reminder'.$result->getUserInfo());
             return false;
         }
          $this->load();

Indentation +6 added lines, -6 removed lines

@@ -224,7 +224,7 @@ 
             throw new Exception('Could not save information in ContactReminder->update' . $result->getUserInfo());
             return false;
         }
-         return $this->id;
+            return $this->id;
     }
 
     /**
@@ -244,8 +244,8 @@ 
             throw new Exception('Could not postphone reminder' . $result->getUserInfo());
             return false;
         }
-         $this->load();
-         return true;
+            $this->load();
+            return true;
     }
 
     /**
@@ -277,7 +277,7 @@ 
         if ($result->numRows() == 0) {
             return array();
         }
-         return $result->fetchAll(MDB2_FETCHMODE_ASSOC);
+            return $result->fetchAll(MDB2_FETCHMODE_ASSOC);
     }
 
     /**
@@ -295,8 +295,8 @@ 
             throw new Exception('Could not postphone reminder' . $result->getUserInfo());
             return false;
         }
-         $this->load();
-         return true;
+            $this->load();
+            return true;
     }
 
     public function getDBQuery()

src/Intraface/modules/debtor/Controller/Create.php

Doc Comments +3 added lines

@@ -87,6 +87,9 @@
         return 'Create';
     }
 
+    /**
+     * @return string
+     */
     function getType()
     {
         return $this->context->context->getType();

Spacing +3 added lines, -3 removed lines

@@ -25,7 +25,7 @@ 
         if ($this->query('contact_id') == '') {
             return new k_SeeOther($this->url('contact'));
         }
-        $smarty = $this->template->create(dirname(__FILE__) . '/templates/edit');
+        $smarty = $this->template->create(dirname(__FILE__).'/templates/edit');
         return $smarty->render($this);
     }
 
@@ -55,7 +55,7 @@ 
         }
 
         if ($debtor->update($_POST)) {
-            return new k_SeeOther($this->url('../' . $debtor->get('id')));
+            return new k_SeeOther($this->url('../'.$debtor->get('id')));
         }
 
         return $this->render();
@@ -67,7 +67,7 @@ 
             return $this->body();
         }
 
-        $due_time = time() + $this->getContact()->get('paymentcondition') * 24 * 60 * 60;
+        $due_time = time() + $this->getContact()->get('paymentcondition')*24*60*60;
         $due_date = date('d-m-Y', $due_time);
 
         return array(