intraface / intraface.dk

src/Intraface/modules/debtor/Controller/Depreciations.php

Doc Comments +3 added lines

@@ -23,6 +23,9 @@
         return $this->context->getKernel();
     }
 
+    /**
+     * @return Invoice
+     */
     function getModel()
     {
         return $this->context->getModel();

Spacing +2 added lines, -2 removed lines

@@ -52,7 +52,7 @@ 
         $depreciation = $this->getDepreciation();
         if ($id = $depreciation->update($_POST)) {
             if ($this->getKernel()->user->hasModuleAccess('accounting')) {
-                return new k_SeeOther($this->url($id . '/state'));
+                return new k_SeeOther($this->url($id.'/state'));
             } else {
                 return new k_SeeOther($this->url('../'));
             }
@@ -64,7 +64,7 @@ 
     {
         $invoice_module = $this->getKernel()->useModule('invoice');
         $depreciation = $this->getDepreciation();
-        $smarty = $this->template->create(dirname(__FILE__) . '/templates/depreciation');
+        $smarty = $this->template->create(dirname(__FILE__).'/templates/depreciation');
         return $smarty->render($this);
     }
 }

src/Intraface/modules/debtor/DebtorDoctrineGateway.php

Doc Comments -1 removed lines

@@ -77,7 +77,6 @@
      * s� man kan se, hvad folk er interesseret i.
      * S�gemaskinen skal v�re tolerant for stavefejl
      *
-     * @param object $search
      *
      * @return object collection containing products
      */

Spacing +4 added lines, -4 removed lines

@@ -199,16 +199,16 @@
 
         switch ($dbquery->getFilter("sorting")) {
             case 1:
-                $query =  $query->addOrderBy('number ASC, item.position');
+                $query = $query->addOrderBy('number ASC, item.position');
                 break;
             case 2:
-                $query =  $query->addOrderBy('contact.number ASC, item.position');
+                $query = $query->addOrderBy('contact.number ASC, item.position');
                 break;
             case 3:
-                $query =  $query->addOrderBy('contact_address.name ASC, item.position');
+                $query = $query->addOrderBy('contact_address.name ASC, item.position');
                 break;
             default:
-                $query =  $query->addOrderBy('number DESC, item.position');
+                $query = $query->addOrderBy('number DESC, item.position');
         }
 
 

src/Intraface/modules/debtor/DebtorGateway.php

Doc Comments +4 added lines, -3 removed lines

@@ -20,7 +20,7 @@ 
     /**
      * returns the possible debtor types!
      *
-     * @return array types
+     * @return string[] types
      */
     static function getDebtorTypes()
     {
@@ -60,8 +60,6 @@ 
     /**
      * Bruges til at lave en menu p� kontakten eller produktet
      *
-     * @param string  $type    contact eller product
-     * @param integer $type_id id p� contact eller product.
      *
      * @return integer
      */
@@ -95,6 +93,9 @@ 
         return $db->numRows();
     }
 
+    /**
+     * @param integer $id
+     */
     function findById($id)
     {
         if (is_int($id) && $id != 0) {

Spacing +4 added lines, -4 removed lines

@@ -69,7 +69,7 @@ 
     {
                 $sql = "SELECT id
                 FROM debtor
-                    WHERE intranet_id = " . $this->kernel->intranet->get("id") . "
+                    WHERE intranet_id = " . $this->kernel->intranet->get("id")."
                         AND contact_id = ".(int)$contact_id."
               AND type='".$this->type_key."'
               AND active = 1";
@@ -82,7 +82,7 @@ 
     function setNewContactId($old_contact_id, $new_contact_id)
     {
         $db = new DB_Sql;
-        $db->query('UPDATE debtor SET contact_id = ' . $new_contact_id . ' WHERE contact_id = ' . $old_contact_id);
+        $db->query('UPDATE debtor SET contact_id = '.$new_contact_id.' WHERE contact_id = '.$old_contact_id);
         return true;
     }
 
@@ -91,7 +91,7 @@ 
         $db = new DB_Sql;
         $db->query('SELECT * FROM debtor WHERE date_created >=
         	DATE_SUB(NOW(),INTERVAL 1 DAY)
-        	AND type = ' .$this->type_key . ' AND intranet_id = ' .$this->kernel->intranet->get('id'));
+        	AND type = ' .$this->type_key.' AND intranet_id = '.$this->kernel->intranet->get('id'));
         return $db->numRows();
     }
 
@@ -397,7 +397,7 @@ 
     public function isFilledIn()
     {
         $db = new DB_Sql;
-        $db->query("SELECT id FROM debtor WHERE type = " . $this->getTypeKey() . " AND intranet_id = " . $this->kernel->intranet->get('id'));
+        $db->query("SELECT id FROM debtor WHERE type = ".$this->getTypeKey()." AND intranet_id = ".$this->kernel->intranet->get('id'));
         return $db->numRows();
     }
 }

src/Intraface/modules/debtor/PaymentMethod.php

Doc Comments +2 added lines, -1 removed lines

@@ -13,7 +13,7 @@ 
     /**
      * Do not change the key for the payment methods
      *
-     * @return array The possible payment types
+     * @return string[] The possible payment types
      */
     public function getTypes()
     {
@@ -30,6 +30,7 @@ 
 
     /**
      * Returns specific payment method
+     * @param string $method
      */
     public function getByName($method)
     {

src/Intraface/modules/invoice/ReminderGateway.php

Doc Comments +3 added lines

@@ -22,6 +22,9 @@
         return $this->dbquery;
     }
 
+    /**
+     * @param integer $id
+     */
     function findById($id)
     {
         require_once dirname(__FILE__) . '/Reminder.php';

Spacing +4 added lines, -4 removed lines

@@ -24,7 +24,7 @@ 
 
     function findById($id)
     {
-        require_once dirname(__FILE__) . '/Reminder.php';
+        require_once dirname(__FILE__).'/Reminder.php';
         return new Reminder($this->kernel, $id);
     }
 
@@ -39,14 +39,14 @@ 
         }
         $db = new DB_Sql;
         $db->query("SELECT id
-            FROM invoice_reminder WHERE intranet_id = ".$this->kernel->intranet->get("id")." AND active = 1 AND contact_id=" . $contact_id);
+            FROM invoice_reminder WHERE intranet_id = ".$this->kernel->intranet->get("id")." AND active = 1 AND contact_id=".$contact_id);
         return $db->numRows();
     }
 
     function setNewContactId($old_contact_id, $new_contact_id)
     {
         $db = new DB_Sql;
-        $db->query('UPDATE invoice_reminder SET contact_id = ' . $new_contact_id . ' WHERE contact_id = ' . $old_contact_id);
+        $db->query('UPDATE invoice_reminder SET contact_id = '.$new_contact_id.' WHERE contact_id = '.$old_contact_id);
         return true;
     }
 
@@ -157,7 +157,7 @@ 
     function isFilledIn()
     {
         $db = new DB_Sql;
-        $db->query("SELECT id FROM invoice_reminder WHERE intranet_id = " . $this->kernel->intranet->get('id'));
+        $db->query("SELECT id FROM invoice_reminder WHERE intranet_id = ".$this->kernel->intranet->get('id'));
         return $db->numRows();
     }
 

src/Intraface/modules/modulepackage/AccessUpdate.php

Doc Comments +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
      * Run the AccessUpdate and applies module access acording to module packages
      *
      * @param integer intranet_id id on intranet, and the access update will only run on this intranet.
-     * @return boolean true on success, false on failure
+     * @return null|boolean true on success, false on failure
      */
     public function run($intranet_id = 0)
     {

src/Intraface/modules/modulepackage/Action.php

Doc Comments +2 added lines, -1 removed lines

@@ -155,8 +155,9 @@
      * Executes the actions by adding and deleting module packages according to the actions
      *
      * @param object intranet intranet object
+     * @param Intraface_Intranet $intranet
      *
-     * @return boolean true or false.
+     * @return null|boolean true or false.
      */
     public function execute($intranet)
     {

src/Intraface/modules/modulepackage/ShopExtension.php

Doc Comments +1 added lines, -1 removed lines

@@ -234,7 +234,7 @@
     /**
      * Returns order details from order identifier
      *
-     * @param string $order_identifier
+     * @param string $order_identification
      * @return array
      */
     public function getOrderDetails($order_identification)

src/Intraface/modules/newsletter/SubscribersGateway.php

Doc Comments +6 added lines

@@ -57,6 +57,9 @@ 
         return $db->numRows();
     }
 
+    /**
+     * @param string $code
+     */
     function findByCode($code)
     {
         // kernel og kode
@@ -73,6 +76,9 @@ 
         return new NewsletterSubscriber(new NewsletterList($this->kernel, $db->f('list_id')), $db->f('id'));
     }
 
+    /**
+     * @param string $email
+     */
     function findByListAndEmail($list, $email)
     {
         $email = safeToDb($email);

Spacing +7 added lines, -7 removed lines

@@ -16,7 +16,7 @@ 
 
     function getAllUnsubscribersForList($list)
     {
-        $this->dbquery = new Intraface_DBQuery($list->kernel, "newsletter_subscriber", "newsletter_subscriber.list_id=". $list->get('id') . " AND newsletter_subscriber.intranet_id = " . $list->kernel->intranet->get('id'));
+        $this->dbquery = new Intraface_DBQuery($list->kernel, "newsletter_subscriber", "newsletter_subscriber.list_id=".$list->get('id')." AND newsletter_subscriber.intranet_id = ".$list->kernel->intranet->get('id'));
         $this->dbquery->setJoin("LEFT", "contact", "newsletter_subscriber.contact_id = contact.id AND contact.intranet_id = ".$list->kernel->intranet->get("id"), '');
         $this->dbquery->setJoin("LEFT", "address", "address.belong_to_id = contact.id AND address.active = 1 AND address.type = 3", '');
         $this->dbquery->setFilter('optin', 1);
@@ -30,7 +30,7 @@ 
 
     function getByContactId($list, $id)
     {
-        $this->dbquery = new Intraface_DBQuery($list->kernel, "newsletter_subscriber", "newsletter_subscriber.list_id=". $list->get('id') . " AND newsletter_subscriber.intranet_id = " . $list->kernel->intranet->get('id'));
+        $this->dbquery = new Intraface_DBQuery($list->kernel, "newsletter_subscriber", "newsletter_subscriber.list_id=".$list->get('id')." AND newsletter_subscriber.intranet_id = ".$list->kernel->intranet->get('id'));
         $this->dbquery->setFilter('contact_id', $id);
         $this->getDBQuery()->setCondition('newsletter_subscriber.contact_id = '.$this->getDBQuery()->getFilter('contact_id'));
 
@@ -41,14 +41,14 @@ 
     {
         // @todo - make sure to delete old ones
         $db = MDB2::singleton();
-        $db->query('UPDATE newsletter_subscriber SET contact_id = ' . $new_id . ' WHERE contact_id = ' . $old_id);
+        $db->query('UPDATE newsletter_subscriber SET contact_id = '.$new_id.' WHERE contact_id = '.$old_id);
     }
 
     public function findCountByContactId($contact_id)
     {
         $sql = "SELECT id
                 FROM newsletter_subscriber
-                    WHERE intranet_id = " . $this->kernel->intranet->get("id") . "
+                    WHERE intranet_id = " . $this->kernel->intranet->get("id")."
                         AND contact_id = ".(int)$contact_id."
               AND active = 1";
 
@@ -65,7 +65,7 @@ 
         $code = strip_tags($code);
 
         $db = new DB_Sql;
-        $db->query("SELECT id, list_id FROM newsletter_subscriber WHERE code = '".$code."' AND intranet_id = " . $this->kernel->intranet->get('id')." and active = 1");
+        $db->query("SELECT id, list_id FROM newsletter_subscriber WHERE code = '".$code."' AND intranet_id = ".$this->kernel->intranet->get('id')." and active = 1");
         if (!$db->nextRecord()) {
             return false;
         }
@@ -84,8 +84,8 @@ 
                     LEFT JOIN address
                         ON address.belong_to_id = contact.id
                     WHERE address.email = '".$email."'
-                        AND newsletter_subscriber.list_id = " . $list->get('id') . "
-                        AND newsletter_subscriber.intranet_id = " . $this->kernel->intranet->get('id') . "
+                        AND newsletter_subscriber.list_id = " . $list->get('id')."
+                        AND newsletter_subscriber.intranet_id = " . $this->kernel->intranet->get('id')."
                         AND newsletter_subscriber.active = 1
                         AND contact.active = 1");
         if (!$db->nextRecord()) {