intraface / intraface.dk

src/Intraface/modules/invoice/Depreciation.php

Doc Comments +2 added lines, -2 removed lines

@@ -136,7 +136,7 @@ 
     /**

      * returns possible payment types

      *

-     * @return array payment types

+     * @return string[] payment types

      *

      */

     public static function getTypes()

@@ -149,7 +149,7 @@ 
     /**

      * returns the possible types payments can be for.

      *

-     * @return array payment for types

+     * @return string[] payment for types

      */

     private static function getPaymentForTypes()

     {

Spacing +1 added lines, -1 removed lines

@@ -127,7 +127,7 @@
         }

 

         $db = new DB_sql;

-        $db->query("UPDATE invoice_payment SET date_stated = NOW(), voucher_id = ".$voucher->get('id').' WHERE id = '. $this->id.' AND intranet_id = '.$this->kernel->intranet->getId());

+        $db->query("UPDATE invoice_payment SET date_stated = NOW(), voucher_id = ".$voucher->get('id').' WHERE id = '.$this->id.' AND intranet_id = '.$this->kernel->intranet->getId());

 

         $this->load();

         return true;

src/Intraface/modules/invoice/Invoice.php

Doc Comments +4 added lines, -1 removed lines

@@ -17,6 +17,9 @@ 
         parent::__construct($kernel, 'invoice', $id);

     }

 

+    /**
+     * @param string $status
+     */
     function setStatus($status)

     {

         if ($status == 'cancelled') {

@@ -58,7 +61,7 @@ 
     /**

      * returns DebtorAccount object

      *

-     * @return object DebtorAccount

+     * @return DebtorAccount DebtorAccount

      */

     public function getDebtorAccount()

     {

Spacing +10 added lines, -10 removed lines

@@ -32,7 +32,7 @@ 
     {

         $db = new DB_Sql;

         $sql = "SELECT id FROM debtor

-            WHERE type=3 AND status=1 AND active = 1 AND due_date < NOW() AND intranet_id = ".$this->kernel->intranet->get("id")." AND contact_id = " . $contact_id;

+            WHERE type=3 AND status=1 AND active = 1 AND due_date < NOW() AND intranet_id = ".$this->kernel->intranet->get("id")." AND contact_id = ".$contact_id;

         $db->query($sql);

 

         return $db->numRows();

@@ -129,12 +129,12 @@ 
             for ($i = 0, $max = count($items); $i < $max; $i++) {

                 $product = new Product($this->kernel, $items[$i]['product_id']);

                 if ($product->get('state_account_id') == 0) {

-                    $this->error->set('Produktet ' . $product->get('name') . ' ved ikke hvor den skal bogf�res');

+                    $this->error->set('Produktet '.$product->get('name').' ved ikke hvor den skal bogf�res');

                 } else {

                     require_once 'Intraface/modules/accounting/Account.php';

                     $account = Account::factory($year, $product->get('state_account_id'));

                     if ($account->get('id') == 0 || $account->get('type') != 'operating') {

-                        $this->error->set('Ugyldig konto for bogføring af produktet ' . $product->get('name'));

+                        $this->error->set('Ugyldig konto for bogføring af produktet '.$product->get('name'));

                         $return = false;

                     }

                 }

@@ -208,7 +208,7 @@ 
             $debet_account_number = $debet_account->get('number');

             $voucher = Voucher::factory($year, $voucher_number);

 

-            $amount = $item['quantity'] * $item['price']->getAsIso(2);

+            $amount = $item['quantity']*$item['price']->getAsIso(2);

 

             // hvis bel�bet er mindre end nul, skal konti byttes om og bel�bet skal g�res positivt

             if ($amount < 0) {

@@ -225,11 +225,11 @@ 
                 'debet_account_number' => $debet_account_number,

                 'credit_account_number' => $credit_account_number,

                 'vat_off' => 1,

-                'text' => $text . ' - ' . $item['name']

+                'text' => $text.' - '.$item['name']

             );

 

             if ($credit_account->get('vat') == 'out') {

-                $total_with_vat += $item["quantity"] * $item["price"]->getAsIso(2);

+                $total_with_vat += $item["quantity"]*$item["price"]->getAsIso(2);

             }

 

             if (!$voucher->saveInDaybook($input_values, true)) {

@@ -242,16 +242,16 @@ 
         if ($total_with_vat > 0) {

             $voucher = Voucher::factory($year, $voucher_number);

             $credit_account = new Account($year, $year->getSetting('vat_out_account_id'));

-            $debet_account = 	new Account($year, $year->getSetting('debtor_account_id'));

+            $debet_account = new Account($year, $year->getSetting('debtor_account_id'));

             $input_values = array(

                     'voucher_number' => $voucher_number,

                     'reference' => $this->get('number'),

                     'date' => $voucher_date,

-                    'amount' => number_format($total_with_vat * $this->kernel->setting->get('intranet', 'vatpercent') / 100, 2, ",", "."), // opm�rksom p� at vat bliver rigtig defineret

+                    'amount' => number_format($total_with_vat*$this->kernel->setting->get('intranet', 'vatpercent')/100, 2, ",", "."), // opm�rksom p� at vat bliver rigtig defineret

                     'debet_account_number' => $debet_account->get('number'),

                     'credit_account_number' => $credit_account->get('number'),

                     'vat_off' => 1,

-                    'text' => $text . ' - ' . $credit_account->get('name')

+                    'text' => $text.' - '.$credit_account->get('name')

             );

             if (!$voucher->saveInDaybook($input_values, true)) {

                 $this->error->merge($voucher->error->getMessage());

@@ -260,7 +260,7 @@ 
 

         require_once 'Intraface/modules/accounting/VoucherFile.php';

         $voucher_file = new VoucherFile($voucher);

-        if (!$voucher_file->save(array('description' => $text, 'belong_to'=>'invoice','belong_to_id'=>$this->get('id')))) {

+        if (!$voucher_file->save(array('description' => $text, 'belong_to'=>'invoice', 'belong_to_id'=>$this->get('id')))) {

             $this->error->merge($voucher_file->error->getMessage());

             $this->error->set('Filen blev ikke overflyttet');

         }

src/Intraface/modules/invoice/Payment.php

Doc Comments +5 added lines, -2 removed lines

@@ -17,6 +17,9 @@ 
     public $dbquery;

     private $db;

 

+    /**
+     * @return string
+     */
     function __construct($object, $id = 0)

     {

         if (!is_object($object)) {

@@ -447,7 +450,7 @@ 
     /**

      * returns possible payment types

      *

-     * @return array payment types

+     * @return string[] payment types

      *

      */

     public static function getTypes()

@@ -462,7 +465,7 @@ 
     /**

      * returns the possible types payments can be for.

      *

-     * @return array payment for types

+     * @return string[] payment for types

      */

     private static function getPaymentForTypes()

     {

Spacing +8 added lines, -8 removed lines

@@ -48,11 +48,11 @@ 
 

     public function load()

     {

-        $result = $this->db->query('SELECT id, amount, type, description, payment_date, payment_for_id, DATE_FORMAT(payment_date, "%d-%m-%Y") AS dk_payment_date, date_stated, voucher_id FROM invoice_payment ' .

-            'WHERE intranet_id = '.$this->kernel->intranet->get('id').' ' .

-                'AND payment_for = '.$this->payment_for_type_id.' ' .

-                'AND payment_for_id = '.$this->payment_for_id.' ' .

-                'AND type IN ('.implode(',', array_keys($this->getTypes())).')' .

+        $result = $this->db->query('SELECT id, amount, type, description, payment_date, payment_for_id, DATE_FORMAT(payment_date, "%d-%m-%Y") AS dk_payment_date, date_stated, voucher_id FROM invoice_payment '.

+            'WHERE intranet_id = '.$this->kernel->intranet->get('id').' '.

+                'AND payment_for = '.$this->payment_for_type_id.' '.

+                'AND payment_for_id = '.$this->payment_for_id.' '.

+                'AND type IN ('.implode(',', array_keys($this->getTypes())).')'.

                 'AND id = '.$this->id);

 

         if (PEAR::isError($result)) {

@@ -160,7 +160,7 @@ 
 

         $this->dbquery->setSorting("payment_date ASC");

         $db = $this->dbquery->getRecordset("id, amount, type, description, payment_date, payment_for_id, DATE_FORMAT(payment_date, '%d-%m-%Y') AS dk_payment_date, date_stated, voucher_id", "", false);

-        while($db->nextRecord()) {

+        while ($db->nextRecord()) {

             $payment[$i]["id"] = $db->f("id");

             $types = $this->getTypes();

             $payment[$i]["type"] = $types[$db->f('type')];

@@ -421,7 +421,7 @@ 
 

         $types = $this->getPaymentForTypes();

         // translation is needed!

-        $text = $translation->get('Payment') . ' ' . $this->get('description') . ' ('.$translation->get($types[$this->payment_for_type_id]).' #'.$this->payment_for->get('number') . ')';

+        $text = $translation->get('Payment').' '.$this->get('description').' ('.$translation->get($types[$this->payment_for_type_id]).' #'.$this->payment_for->get('number').')';

 

         $input_values = array(

             'voucher_number' => $voucher_number,

@@ -438,7 +438,7 @@ 
         }

 

         $db = new DB_sql;

-        $db->query("UPDATE invoice_payment SET date_stated = NOW(), voucher_id = ".$voucher->get('id') . " WHERE intranet_id = " . $this->kernel->intranet->getId() . ' AND id = ' . $this->id);

+        $db->query("UPDATE invoice_payment SET date_stated = NOW(), voucher_id = ".$voucher->get('id')." WHERE intranet_id = ".$this->kernel->intranet->getId().' AND id = '.$this->id);

 

         $this->load();

         return true;

Braces +12 added lines, -4 removed lines

@@ -97,23 +97,31 @@
         $input = safeToDb($input);

         $validator = new Intraface_Validator($this->error);

 

-        if (!isset($input["payment_date"])) $input["payment_date"] = '';

+        if (!isset($input["payment_date"])) {
+            $input["payment_date"] = '';
+        }
         if ($validator->isDate($input["payment_date"], "Ugyldig dato", "allow_no_year")) {

             $date = new Intraface_Date($input["payment_date"]);

             $date->convert2db();

         }

 

-        if (!isset($input["amount"])) $input["amount"] = 0;

+        if (!isset($input["amount"])) {
+            $input["amount"] = 0;
+        }
         if ($validator->isDouble($input["amount"], "Ugyldig bel�b")) {

             $amount = new Intraface_Amount($input["amount"]);

             $amount->convert2db();

             $amount = $amount->get();

         }

 

-        if (!isset($input['description'])) $input['description'] = '';

+        if (!isset($input['description'])) {
+            $input['description'] = '';
+        }
         $validator->isString($input["description"], "Fejl i beskrivelse", "", "allow_empty");

 

-        if (!isset($input['type'])) $input['type'] = NULL;

+        if (!isset($input['type'])) {
+            $input['type'] = NULL;
+        }
         $validator->isNumeric($input["type"], "Type er ikke angivet korrekt");

         $types = $this->getTypes();

         if (!isset($types[$input["type"]])) {

src/Intraface/modules/invoice/PaymentGateway.php

Doc Comments +2 added lines, -2 removed lines

@@ -113,7 +113,7 @@ 
     /**
      * returns possible payment types
      *
-     * @return array payment types
+     * @return string[] payment types
      *
      */
     public static function getTypes()
@@ -128,7 +128,7 @@ 
     /**
      * returns the possible types payments can be for.
      *
-     * @return array payment for types
+     * @return string[] payment for types
      */
     private static function getPaymentForTypes()
     {

Spacing +2 added lines, -2 removed lines

@@ -22,7 +22,7 @@ 
     function findById($id)
     {
         $db = new DB_Sql;
-        $db->query('SELECT * FROM invoice_payment WHERE id = ' . $id);
+        $db->query('SELECT * FROM invoice_payment WHERE id = '.$id);
 
         if (!$db->nextRecord()) {
             return false;
@@ -90,7 +90,7 @@ 
 
         $this->dbquery->setSorting("payment_date ASC");
         $db = $this->dbquery->getRecordset("id, amount, payment_for, type, description, payment_date, payment_for_id, DATE_FORMAT(payment_date, '%d-%m-%Y') AS dk_payment_date, date_stated, voucher_id", "", false);
-        while($db->nextRecord()) {
+        while ($db->nextRecord()) {
             $payment[$i]["id"] = $db->f("id");
             $types = $this->getTypes();
             $payment[$i]["type"] = $types[$db->f('type')];

src/Intraface/modules/invoice/Pdf/Reminder.php

Doc Comments +3 added lines

@@ -13,6 +13,9 @@
         parent::__construct($translation, $file);

     }

 

+    /**
+     * @param Reminder $reminder
+     */
     function visit($reminder)

     {

         if ($reminder->get('id') == 0) {

Spacing +10 added lines, -10 removed lines

@@ -34,7 +34,7 @@ 
         $intranet_address = new Intraface_Address($reminder->get("intranet_address_id"));

         $intranet = $intranet_address->get();

 

-        switch($reminder->kernel->setting->get('intranet', 'debtor.sender')) {

+        switch ($reminder->kernel->setting->get('intranet', 'debtor.sender')) {

             case 'intranet':

                 // void

                 break;

@@ -52,7 +52,7 @@ 
         $this->docinfo[0]["label"] = "Dato:";

         $this->docinfo[0]["value"] = $reminder->get("dk_this_date");

 

-        $this->addRecieverAndSender($contact , $intranet, "Reminder about payment", $this->docinfo);

+        $this->addRecieverAndSender($contact, $intranet, "Reminder about payment", $this->docinfo);

 

         $this->doc->setY('-20'); // space to the product list

 

@@ -61,18 +61,18 @@ 
             if ($line == "") {

                 $this->doc->setY('-'.$this->doc->get('font_spacing'));

 

-                if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing") * 2) {

+                if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing")*2) {

                     $this->doc->nextPage(true);

                 }

             } else {

-                while($line != "") {

+                while ($line != "") {

 

                     $this->doc->setY('-'.($this->doc->get("font_padding_top") + $this->doc->get("font_size")));

                     $line = $this->doc->addTextWrap($this->doc->get('x'), $this->doc->get('y'), $this->doc->get("right_margin_position") - $this->doc->get('x'), $this->doc->get("font_size"), $line); // $this->doc->get("right_margin_position") - $this->doc->get('x')

               

                     $this->doc->setY('-'.$this->doc->get("font_padding_bottom"));

 

-                    if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing") * 2) {

+                    if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing")*2) {

                         $this->doc->nextPage(true);

                     }

                 }

@@ -83,7 +83,7 @@ 
 

         $this->doc->setY('-20'); // space to product list

 

-        if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing") * 3) {

+        if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing")*3) {

             $this->doc->nextPage(true);

         }

 

@@ -97,7 +97,7 @@ 
         $this->doc->addText($apointX["text"], $this->doc->get('y'), $this->doc->get("font_size"), "Beskrivelse");

         $this->doc->addText($apointX["invoice_date"], $this->doc->get('y'), $this->doc->get("font_size"), "Dato");

         $this->doc->addText($apointX["due_date"], $this->doc->get('y'), $this->doc->get("font_size"), "Forfaldsdato");

-        $this->doc->addText($apointX["amount"] - $this->doc->getTextWidth($this->doc->get("font_size"), "Beløb") -3, $this->doc->get('y'), $this->doc->get("font_size"), "Bel�b");

+        $this->doc->addText($apointX["amount"] - $this->doc->getTextWidth($this->doc->get("font_size"), "Beløb") - 3, $this->doc->get('y'), $this->doc->get("font_size"), "Bel�b");

 

         $this->doc->setY('-'.($this->doc->get("font_spacing") - $this->doc->get("font_size")));

 

@@ -131,7 +131,7 @@ 
             $this->doc->setY('-'.$this->doc->get("font_padding_bottom"));

             $total += $items[$i]["arrears"];

 

-            if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing") * 2) {

+            if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing")*2) {

                 $this->doc->nextPage(true);

             }

         }

@@ -157,7 +157,7 @@ 
             $this->doc->setY('-'.$this->doc->get("font_padding_bottom"));

             $total += $items[$i]["reminder_fee"];

 

-            if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing") * 2) {

+            if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing")*2) {

                 $this->doc->nextPage(true);

             }

         }

@@ -179,7 +179,7 @@ 
             $this->doc->setY('-'.$this->doc->get("font_padding_bottom"));

             $total += $reminder->get("reminder_fee");

 

-            if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing") * 2) {

+            if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing")*2) {

                 $this->doc->nextPage(true);

             }

         }

src/Intraface/modules/invoice/Reminder.php

Doc Comments +8 added lines, -4 removed lines

@@ -36,6 +36,9 @@ 
         return $this->dbquery;

     }

 

+    /**
+     * @param string $type
+     */
     function getItems($type = NULL)

     {

         $this->loadItem();

@@ -273,7 +276,8 @@ 
     /**

      * Sets status for the reminder

      *

-     * @return true / false

+     * @param string $status
+     * @return boolean / false

      */

     function setStatus($status) {

 

@@ -331,7 +335,7 @@ 
     /**

      * returns DebtorAccount object

      *

-     * @return object DebtorAccount

+     * @return DebtorAccount DebtorAccount

      */

     public function getDebtorAccount()

     {

@@ -663,7 +667,7 @@ 
     /**

      * returns possible status types

      *

-     * @return array possible status types

+     * @return string[] possible status types

      */

     private static function getStatusTypes()

     {

@@ -678,7 +682,7 @@ 
     /**

      * returns possible payment methods

      *

-     * @return array possible payment methods

+     * @return string[] possible payment methods

      */

     private static function getPaymentMethods()

     {

Indentation +3 added lines, -3 removed lines

@@ -698,9 +698,9 @@
     function getPaymentInformation()

     {

         $info = array('bank_name'    => $this->kernel->setting->get("intranet", "bank_name"),

-                      'bank_reg_number' => $this->kernel->setting->get("intranet", "bank_reg_number"),

-                      'bank_account_number' => $this->kernel->setting->get("intranet", "bank_account_number"),

-                      'giro_account_number' => $this->kernel->setting->get("intranet", "giro_account_number")

+                        'bank_reg_number' => $this->kernel->setting->get("intranet", "bank_reg_number"),

+                        'bank_account_number' => $this->kernel->setting->get("intranet", "bank_account_number"),

+                        'giro_account_number' => $this->kernel->setting->get("intranet", "giro_account_number")

         );

 

         return $info;

Spacing +10 added lines, -10 removed lines

@@ -126,7 +126,7 @@ 
 

     function isNumberFree($number)

     {

-        $sql = "SELECT id FROM invoice_reminder WHERE number = ".intval($number)." AND id != ".$this->id . " AND intranet_id = " . $this->kernel->intranet->get('id');

+        $sql = "SELECT id FROM invoice_reminder WHERE number = ".intval($number)." AND id != ".$this->id." AND intranet_id = ".$this->kernel->intranet->get('id');

         $this->db->query($sql);

         if ($this->db->nextRecord()) {

             return false;

@@ -296,7 +296,7 @@ 
             throw new Exception("Tried to set status the same or lower than it was before. Can be because of reload. In Reminder->setStatus");

         }

 

-        switch($status) {

+        switch ($status) {

             case "sent":

                 $sql = "date_sent = NOW()";

                 break;

@@ -314,7 +314,7 @@ 
         }

 

         $db = new Db_Sql;

-        $db->query("UPDATE invoice_reminder SET status = ".$status_id.", ".$sql."  WHERE id = " . $this->id . " AND intranet_id = " . $this->kernel->intranet->get('id'));

+        $db->query("UPDATE invoice_reminder SET status = ".$status_id.", ".$sql."  WHERE id = ".$this->id." AND intranet_id = ".$this->kernel->intranet->get('id'));

         $this->load();

         return true;

     }

@@ -393,7 +393,7 @@ 
                 }

 

             } else {

-                switch($this->dbquery->getFilter("status")) {

+                switch ($this->dbquery->getFilter("status")) {

                     case "0":

                         $to_date_field = "date_created";

                         break;

@@ -427,7 +427,7 @@ 
         $db = $this->dbquery->getRecordset("id", "", false);

 

         $list = array();

-        while($db->nextRecord()) {

+        while ($db->nextRecord()) {

             $reminder = new Reminder($this->kernel, $db->f("id"));

             $list[$i] = $reminder->get();

             if (is_object($reminder->contact->address)) {

@@ -453,14 +453,14 @@ 
         }

         $db = new DB_Sql;

         $db->query("SELECT id

-            FROM invoice_reminder WHERE intranet_id = ".$this->kernel->intranet->get("id")." AND active = 1 AND contact_id=" . $contact_id);

+            FROM invoice_reminder WHERE intranet_id = ".$this->kernel->intranet->get("id")." AND active = 1 AND contact_id=".$contact_id);

         return $db->numRows();

     }

 

     function isFilledIn()

     {

         $db = new DB_Sql;

-        $db->query("SELECT id FROM invoice_reminder WHERE intranet_id = " . $this->kernel->intranet->get('id'));

+        $db->query("SELECT id FROM invoice_reminder WHERE intranet_id = ".$this->kernel->intranet->get('id'));

         return $db->numRows();

     }

 

@@ -476,7 +476,7 @@ 
     {

         // FIXME - check on date

         $db = new DB_Sql;

-        $db->query("UPDATE invoice_reminder SET date_stated = '" . $voucher_date . "', voucher_id = '".$voucher_id."' WHERE id = " . $this->id . " AND intranet_id = " . $this->kernel->intranet->get('id'));

+        $db->query("UPDATE invoice_reminder SET date_stated = '".$voucher_date."', voucher_id = '".$voucher_id."' WHERE id = ".$this->id." AND intranet_id = ".$this->kernel->intranet->get('id'));

         return true;

     }

 

@@ -623,7 +623,7 @@ 
 

         require_once 'Intraface/modules/accounting/VoucherFile.php';

         $voucher_file = new VoucherFile($voucher);

-        if (!$voucher_file->save(array('description' => $text, 'belong_to'=>'reminder','belong_to_id'=>$this->get('id')))) {

+        if (!$voucher_file->save(array('description' => $text, 'belong_to'=>'reminder', 'belong_to_id'=>$this->get('id')))) {

             $this->error->merge($voucher_file->error->getMessage());

             $this->error->set('Filen blev ikke overflyttet');

         }

@@ -641,7 +641,7 @@ 
 

     }

 

-    function pdf($type = 'stream', $filename='')

+    function pdf($type = 'stream', $filename = '')

     {

         if ($this->get('id') == 0) {

             throw new Exception('Cannot create pdf from debtor without valid id');

Braces +36 added lines, -12 removed lines

@@ -153,15 +153,21 @@ 
 

         $validator = new Intraface_Validator($this->error);

 

-        if (!isset($input['number'])) $input['number'] = 0;

+        if (!isset($input['number'])) {
+            $input['number'] = 0;
+        }
         if ($validator->isNumeric($input["number"], "Rykkernummer skal v�re et tal st�rre end nul", "greater_than_zero")) {

             if (!$this->isNumberFree($input["number"])) {

                 $this->error->set("Rykkernummer er allerede brugt");

             }

         }

 

-        if (!isset($input['contact_id'])) $input['contact_id'] = 0;

-        if (!isset($input["contact_person_id"])) $input["contact_person_id"] = 0;

+        if (!isset($input['contact_id'])) {
+            $input['contact_id'] = 0;
+        }
+        if (!isset($input["contact_person_id"])) {
+            $input["contact_person_id"] = 0;
+        }
         if ($validator->isNumeric($input["contact_id"], "Du skal angive en kunde", "greater_than_zero")) {

             $contact = new Contact($this->kernel, (int)$input["contact_id"]);

             if (is_object($contact->address)) {

@@ -177,38 +183,56 @@ 
         }

 

         // $validator->isString($input["attention_to"], "Fejl i att.", "", "allow_empty");

-        if (!isset($input['description'])) $input['description'] = '';

+        if (!isset($input['description'])) {
+            $input['description'] = '';
+        }
         $validator->isString($input["description"], "Fejl i beskrivelsen", "", "allow_empty");

 

-        if (!isset($input['this_date'])) $input['this_date'] = '';

+        if (!isset($input['this_date'])) {
+            $input['this_date'] = '';
+        }
         if ($validator->isDate($input["this_date"], "Ugyldig dato", "allow_no_year")) {

             $this_date = new Intraface_Date($input["this_date"]);

             $this_date->convert2db();

         }

 

-        if (!isset($input['due_date'])) $input['due_date'] = '';

+        if (!isset($input['due_date'])) {
+            $input['due_date'] = '';
+        }
         if ($validator->isDate($input["due_date"], "Ugyldig forfaldsdato", "allow_no_year")) {

             $due_date = new Intraface_Date($input["due_date"]);

             $due_date->convert2db();

         }

 

-        if (!isset($input['reminder_fee'])) $input['reminder_fee'] = 0;

+        if (!isset($input['reminder_fee'])) {
+            $input['reminder_fee'] = 0;
+        }
         $validator->isNumeric($input["reminder_fee"], "Rykkerbebyr skal v�re et tal");

-        if (!isset($input['text'])) $input['text'] = '';

+        if (!isset($input['text'])) {
+            $input['text'] = '';
+        }
         $validator->isString($input["text"], "Fejl i teksten", "<b><i>", "allow_empty");

-        if (!isset($input['send_as'])) $input['send_as'] = '';

+        if (!isset($input['send_as'])) {
+            $input['send_as'] = '';
+        }
         $validator->isString($input["send_as"], "Ugyldig m�de at sende rykkeren p�");

 

-        if (!isset($input['payment_method_key'])) $input['payment_method_key'] = 0;

+        if (!isset($input['payment_method_key'])) {
+            $input['payment_method_key'] = 0;
+        }
         $validator->isNumeric($input["payment_method_key"], "Du skal angive en betalingsmetode");

-        if (!isset($input['girocode'])) $input['girocode'] = '';

+        if (!isset($input['girocode'])) {
+            $input['girocode'] = '';
+        }
         if ($input["payment_method_key"] == 3) {

             $validator->isString($input["girocode"], "Du skal udfylde girokode");

         } else {

             $validator->isString($input["girocode"], "Ugyldig girokode", "", "allow_empty");

         }

 

-        if (!isset($input['checked_invoice'])) $input['checked_invoice'] = array();

+        if (!isset($input['checked_invoice'])) {
+            $input['checked_invoice'] = array();
+        }
         if (!is_array($input["checked_invoice"]) || count($input["checked_invoice"]) == 0) {

             $this->error->set("Der er ikke valgt nogle fakturaer til rykkeren");

         }

src/Intraface/modules/invoice/ReminderGateway.php

Doc Comments +3 added lines

@@ -22,6 +22,9 @@
         return $this->dbquery;
     }
 
+    /**
+     * @param integer $id
+     */
     function findById($id)
     {
         require_once dirname(__FILE__) . '/Reminder.php';

Spacing +6 added lines, -6 removed lines

@@ -24,7 +24,7 @@ 
 
     function findById($id)
     {
-        require_once dirname(__FILE__) . '/Reminder.php';
+        require_once dirname(__FILE__).'/Reminder.php';
         return new Reminder($this->kernel, $id);
     }
 
@@ -39,14 +39,14 @@ 
         }
         $db = new DB_Sql;
         $db->query("SELECT id
-            FROM invoice_reminder WHERE intranet_id = ".$this->kernel->intranet->get("id")." AND active = 1 AND contact_id=" . $contact_id);
+            FROM invoice_reminder WHERE intranet_id = ".$this->kernel->intranet->get("id")." AND active = 1 AND contact_id=".$contact_id);
         return $db->numRows();
     }
 
     function setNewContactId($old_contact_id, $new_contact_id)
     {
         $db = new DB_Sql;
-        $db->query('UPDATE invoice_reminder SET contact_id = ' . $new_contact_id . ' WHERE contact_id = ' . $old_contact_id);
+        $db->query('UPDATE invoice_reminder SET contact_id = '.$new_contact_id.' WHERE contact_id = '.$old_contact_id);
         return true;
     }
 
@@ -106,7 +106,7 @@ 
                 }
 
             } else {
-                switch($this->dbquery->getFilter("status")) {
+                switch ($this->dbquery->getFilter("status")) {
                     case "0":
                         $to_date_field = "date_created";
                         break;
@@ -140,7 +140,7 @@ 
         $db = $this->dbquery->getRecordset("id", "", false);
 
         $list = array();
-        while($db->nextRecord()) {
+        while ($db->nextRecord()) {
             $reminder = new Reminder($this->kernel, $db->f("id"));
             $list[$i] = $reminder->get();
             if (is_object($reminder->contact->address)) {
@@ -158,7 +158,7 @@ 
     function isFilledIn()
     {
         $db = new DB_Sql;
-        $db->query("SELECT id FROM invoice_reminder WHERE intranet_id = " . $this->kernel->intranet->get('id'));
+        $db->query("SELECT id FROM invoice_reminder WHERE intranet_id = ".$this->kernel->intranet->get('id'));
         return $db->numRows();
     }
 

src/Intraface/modules/invoice/ReminderItem.php

Doc Comments +3 added lines

@@ -11,6 +11,9 @@
     private $db;

     public $error;

 

+    /**
+     * @param Reminder $reminder
+     */
     function __construct($reminder, $id = 0)

     {

         $this->reminder = $reminder;

src/Intraface/modules/modulepackage/AccessUpdate.php

Doc Comments +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
      * Run the AccessUpdate and applies module access acording to module packages
      *
      * @param integer intranet_id id on intranet, and the access update will only run on this intranet.
-     * @return boolean true on success, false on failure
+     * @return null|boolean true on success, false on failure
      */
     public function run($intranet_id = 0)
     {

Spacing +2 added lines, -2 removed lines

@@ -74,7 +74,7 @@ 
             exit;
         }
 
-        while($row = $result->fetchRow()) {
+        while ($row = $result->fetchRow()) {
             $modulepackage = new Intraface_modules_modulepackage_ModulePackage($row['module_package_id']);
             $intranet = new IntranetMaintenance($row['intranet_id']);
 
@@ -101,7 +101,7 @@ 
             exit;
         }
 
-        while($row = $result->fetchRow()) {
+        while ($row = $result->fetchRow()) {
             $modulepackage = new Intraface_modules_modulepackage_ModulePackage($row['module_package_id']);
 
             // we prepare to give the intranet access