intraface / intraface.dk

install/Install.php

Doc Comments +4 added lines

@@ -126,6 +126,9 @@ 
 

     }

 

+    /**
+     * @param string $f
+     */
     function deleteUploadDirectory($f)

     {

         if ( is_dir( $f ) ){

@@ -234,6 +237,7 @@ 
 

     /**

      * splits a mysql export into separate

+     * @param string $sql
      */

     static function splitSql($sql)

     {

Spacing +15 added lines, -15 removed lines

@@ -26,13 +26,13 @@ 
 

     function dropDatabase()

     {

-        $result = $this->db->query("SHOW TABLES FROM " . DB_NAME);

+        $result = $this->db->query("SHOW TABLES FROM ".DB_NAME);

         if (PEAR::isError($result)) {

             throw new Exception($result->getUserInfo());

         }

 

         while ($line = $result->fetchRow(MDB2_FETCHMODE_ASSOC)) {

-            $drop = $this->db->exec('DROP TABLE ' . $line['tables_in_' . DB_NAME]);

+            $drop = $this->db->exec('DROP TABLE '.$line['tables_in_'.DB_NAME]);

             if (PEAR::IsError($drop)) {

                 throw new Exception($drop->getUserInfo());

             }

@@ -42,7 +42,7 @@ 
 

     function createDatabaseSchema()

     {

-        $sql_structure = file_get_contents(dirname(__FILE__) . '/database-structure.sql');

+        $sql_structure = file_get_contents(dirname(__FILE__).'/database-structure.sql');

         $sql_arr = Intraface_Install::splitSql($sql_structure);

 

         foreach ($sql_arr as $sql) {

@@ -53,7 +53,7 @@ 
             }

         }

 

-        $sql_structure = file_get_contents(dirname(__FILE__) . '/database-update.sql');

+        $sql_structure = file_get_contents(dirname(__FILE__).'/database-update.sql');

         $sql_arr = Intraface_Install::splitSql($sql_structure);

 

         foreach ($sql_arr as $sql) {

@@ -68,12 +68,12 @@ 
 

     function emptyDatabase()

     {

-        $result = $this->db->query("SHOW TABLES FROM " . DB_NAME);

+        $result = $this->db->query("SHOW TABLES FROM ".DB_NAME);

         if (PEAR::isError($result)) {

             throw new Exception($result->getUserInfo());

         }

         while ($line = $result->fetchRow(MDB2_FETCHMODE_ASSOC)) {

-            $truncate = $this->db->exec('TRUNCATE TABLE ' . $line['Tables_in_'.DB_NAME]);

+            $truncate = $this->db->exec('TRUNCATE TABLE '.$line['Tables_in_'.DB_NAME]);

             if (PEAR::IsError($truncate)) {

                 throw new Exception($truncate->getUserInfo());

             }

@@ -84,7 +84,7 @@ 
 

     function createStartingValues()

     {

-        $sql_values = file_get_contents(dirname(__FILE__) . '/database-values.sql');

+        $sql_values = file_get_contents(dirname(__FILE__).'/database-values.sql');

         $sql_arr = Intraface_Install::splitSql($sql_values);

 

         foreach ($sql_arr as $sql) {

@@ -128,15 +128,15 @@ 
 

     function deleteUploadDirectory($f)

     {

-        if ( is_dir( $f ) ){

-            foreach ( scandir( $f ) as $item ){

-                if ( !strcmp( $item, '.' ) || !strcmp( $item, '..' ) )

+        if (is_dir($f)) {

+            foreach (scandir($f) as $item) {

+                if (!strcmp($item, '.') || !strcmp($item, '..'))

                     continue;

-                $this->deleteUploadDirectory( $f . "/" . $item );

+                $this->deleteUploadDirectory($f."/".$item);

             }

-            rmdir( $f );

-        } else{

-            @unlink( $f );

+            rmdir($f);

+        } else {

+            @unlink($f);

         }

     }

 

@@ -215,7 +215,7 @@ 
             $object_method[0] = str_replace('/', '', $object_method[0]);

             $object_method[0] = str_replace('\\', '', $object_method[0]);

 

-            require_once dirname(__FILE__) . '/Helper/'.$object_method[0].'.php';

+            require_once dirname(__FILE__).'/Helper/'.$object_method[0].'.php';

             $object_name = 'Install_Helper_'.$object_method[0];

             $object = new $object_name($kernel, $this->db);

             $object->$object_method[1]();

Braces +3 added lines, -2 removed lines

@@ -130,8 +130,9 @@
     {

         if ( is_dir( $f ) ){

             foreach ( scandir( $f ) as $item ){

-                if ( !strcmp( $item, '.' ) || !strcmp( $item, '..' ) )

-                    continue;

+                if ( !strcmp( $item, '.' ) || !strcmp( $item, '..' ) ) {
+                                    continue;
+                }
                 $this->deleteUploadDirectory( $f . "/" . $item );

             }

             rmdir( $f );

src/DB/Sql.php

Doc Comments +6 added lines

@@ -26,6 +26,9 @@ 
         $this->db->setOption('portability', MDB2_PORTABILITY_NONE);
     }
 
+    /**
+     * @param string $SQL
+     */
     function query($SQL)
     {
         $this->result = $this->db->query($SQL);
@@ -101,6 +104,9 @@ 
         return mysql_escape_string($value);
     }
 
+    /**
+     * @param string $type
+     */
     function quote($value, $type)
     {
         return $this->db->quote($value, $type);

src/Intraface/Address.php

Doc Comments +3 added lines, -3 removed lines

@@ -83,7 +83,7 @@ 
      * @param string  $belong_to    What the address belongs to, corresponding to the ones in Address::getBelongToTypes()
      * @param integer $belong_to_id From belong_to. NB not id on the address
      *
-     * @return object Address
+     * @return Intraface_Address Address
      */
     function factory($belong_to, $belong_to_id)
     {
@@ -94,7 +94,7 @@ 
     /**
      * Returns possible belong to types
      *
-     * @return array
+     * @return string[]
      */
     public static function getBelongToTypes()
     {
@@ -220,7 +220,7 @@ 
      *
      * @param array $array_var et array med felter med adressen. Se felterne i init funktionen: $this->fields
      *
-     * @return bolean	true or false
+     * @return boolean	true or false
      */
     function save($array_var)
     {

Indentation +5 added lines, -5 removed lines

@@ -99,11 +99,11 @@
     public static function getBelongToTypes()
     {
         return array(1 => 'intranet',
-                     2 => 'user',
-                     3 => 'contact',
-                     4 => 'contact_delivery',
-                     5 => 'contact_invoice',
-                     6 => 'contactperson');
+                        2 => 'user',
+                        3 => 'contact',
+                        4 => 'contact_delivery',
+                        5 => 'contact_invoice',
+                        6 => 'contactperson');
     }
 
     /**

src/Intraface/AddressGateway.php

Doc Comments +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
      * @param string  $belong_to    What the address belongs to, corresponding to the ones in Address::getBelongToTypes()
      * @param integer $belong_to_id From belong_to. NB not id on the address
      *
-     * @return object Address
+     * @return Intraface_Address Address
      */
     public function findByBelongToAndId($belong_to, $belong_to_id)
     {

src/Intraface/Amount.php

Doc Comments +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 

     /**

      * Public: henter beløbet efter konvertering

-     * @return beløb

+     * @return double

      */

     function get()

     {

src/Intraface/Auth.php

Doc Comments +4 added lines, -1 removed lines

@@ -23,6 +23,9 @@ 
         $this->session_id = $session_id;

     }

 

+    /**
+     * @param Intraface_Auth_User $adapter
+     */
     public function authenticate($adapter)

     {

         if (is_callable(array($adapter, 'getIdentification'))) {

@@ -43,7 +46,7 @@ 
     /**

      * hasIdentity()

      *

-     * @return mixed user id or false

+     * @return boolean user id or false

      */

     public function hasIdentity()

     {

Spacing +2 added lines, -2 removed lines

@@ -32,9 +32,9 @@
         }

 

         if ($object = $adapter->auth()) {

-            $this->notifyObservers('login', $identification . ' logged in');

+            $this->notifyObservers('login', $identification.' logged in');

         } else {

-            $this->notifyObservers('login', $identification . ' could not login');

+            $this->notifyObservers('login', $identification.' could not login');

         }

 

         return $object;

src/Intraface/functions.php

Doc Comments +1 added lines

@@ -58,6 +58,7 @@
     /**

      * This function is dynamically redefinable.

      * @see $GLOBALS['_global_function_callback_email']

+     * @param string $args
      */

     function autoop($args) {

         $args = func_get_args();

Spacing +3 added lines, -3 removed lines

@@ -136,8 +136,8 @@ 
         return $data;

     }

 

-    if (is_array($data)){

-        return array_map('safeToDb',$data);

+    if (is_array($data)) {

+        return array_map('safeToDb', $data);

     }

 

     if (get_magic_quotes_gpc()) {

@@ -194,7 +194,7 @@ 
 function intrafaceBackendErrorhandler($errno, $errstr, $errfile, $errline, $errcontext)

 {

     if (!defined('ERROR_LOG')) {

-        define('ERROR_LOG', dirname(__FILE__) . '/../log/error.log');

+        define('ERROR_LOG', dirname(__FILE__).'/../log/error.log');

     }

     $errorhandler = new ErrorHandler;

     if (!defined('ERROR_LEVEL_CONTINUE_SCRIPT')) {

src/Intraface/Intranet.php

Doc Comments +3 added lines, -5 removed lines

@@ -36,8 +36,6 @@ 
     /**

      * Constructor

      *

-     * @param integer $intranet_id The id of the intranet

-     *

      * @return void

      */

     function __construct($id)

@@ -59,7 +57,7 @@ 
     /**

      * loads

      *

-     * @return void

+     * @return integer|null

      */

     function load()

     {

@@ -103,9 +101,9 @@ 
      * @todo might be smarter to throw in an actual module object

      *       that would make us sure that it is actually valid

      *

-     * @param mixed $module The id or name of the module

+     * @param string $module The id or name of the module

      *

-     * @return void

+     * @return boolean

      */

     function hasModuleAccess($module)

     {

Indentation +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
 

     public function getAddress()

     {

-    	return ($this->address = Intraface_Address::factory('intranet', $this->id));

+        return ($this->address = Intraface_Address::factory('intranet', $this->id));

     }

 

     /**

Spacing +1 added lines, -1 removed lines

@@ -109,7 +109,7 @@
      */

     function hasModuleAccess($module)

     {

-        $filename = PATH_INCLUDE_MODULE . $module . '/Main' . ucfirst($module) . '.php';

+        $filename = PATH_INCLUDE_MODULE.$module.'/Main'.ucfirst($module).'.php';

         if (file_exists($filename)) {

             require_once $filename;

             $module_class = 'Main'.ucfirst($module);

src/Intraface/Kernel.php

Doc Comments +1 added lines, -1 removed lines

@@ -167,7 +167,7 @@
      *
      * @param $count (integer) how many characters to return?
      *
-     * @return 	random key (string) only letters
+     * @return 	string key (string) only letters
      */
     function randomKey($length = 1)
     {

Indentation +3 added lines, -3 removed lines

@@ -58,9 +58,9 @@ 
     function getModuleHandler()
     {
         if (!empty($this->modulehandler)) {
-        	return $this->modulehandler;
+            return $this->modulehandler;
         }
-    	return ($this->modulehandler = new Intraface_ModuleHandler($this->intranet, $this->user));
+        return ($this->modulehandler = new Intraface_ModuleHandler($this->intranet, $this->user));
     }
 
     /**
@@ -177,7 +177,7 @@ 
 
     function getIntranet()
     {
-    	return $this->intranet;
+        return $this->intranet;
     }
 
     function getSetting()

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
         }
         $this->db = MDB2:: singleton(DB_DSN);
         if (PEAR::isError($this->db)) {
-            throw new Exception($this->db->getMessage() . $this->db->getUserInfo());
+            throw new Exception($this->db->getMessage().$this->db->getUserInfo());
         }
     }