intraface / intraface.dk

src/Intraface/modules/debtor/Controller/Depreciations.php

Doc Comments +3 added lines

@@ -23,6 +23,9 @@
         return $this->context->getKernel();
     }
 
+    /**
+     * @return Invoice
+     */
     function getModel()
     {
         return $this->context->getModel();

Spacing +2 added lines, -2 removed lines

@@ -52,7 +52,7 @@ 
         $depreciation = $this->getDepreciation();
         if ($id = $depreciation->update($_POST)) {
             if ($this->getKernel()->user->hasModuleAccess('accounting')) {
-                return new k_SeeOther($this->url($id . '/state'));
+                return new k_SeeOther($this->url($id.'/state'));
             } else {
                 return new k_SeeOther($this->url('../'));
             }
@@ -64,7 +64,7 @@ 
     {
         $invoice_module = $this->getKernel()->useModule('invoice');
         $depreciation = $this->getDepreciation();
-        $smarty = $this->template->create(dirname(__FILE__) . '/templates/depreciation');
+        $smarty = $this->template->create(dirname(__FILE__).'/templates/depreciation');
         return $smarty->render($this);
     }
 }
\ No newline at end of file

src/Intraface/modules/debtor/Debtor.php

Doc Comments +8 added lines, -8 removed lines

@@ -143,7 +143,7 @@ 
      *

      * @param object  $kernel Kernel

      * @param integer $id     Debtor id or debtor identifier_key

-     * @param type    $tpye   String TODO What is this used for as a last parameter?

+     * @param type    $type   String TODO What is this used for as a last parameter?

      */

     public static function factory($kernel, $id = 0, $type = "")

     {

@@ -617,7 +617,7 @@ 
     /**

      * S�tter status for debtoren

      *

-     * @return true / false

+     * @return boolean / false

      */

     public function setStatus($status)

     {

@@ -675,7 +675,7 @@ 
      * @param string  $from    Where from

      * @param integer $from_id From id

      *

-     * @return true / false

+     * @return boolean / false

      */

     private function setFrom($from = 'manuel', $from_id = 0)

     {

@@ -1141,7 +1141,7 @@ 
     /**

      * Gets the intranet address

      *

-     * @return object

+     * @return Intraface_Address

      */

     public function getIntranetAddress()

     {

@@ -1227,7 +1227,7 @@ 
     /**

      * returns the possible debtor types!

      *

-     * @return array types

+     * @return string[] types

      */

     static function getDebtorTypes()

     {

@@ -1241,7 +1241,7 @@ 
     /**

      * returns the possible places where the debtor comes from

      *

-     * @return array with the allowed froms

+     * @return string[] with the allowed froms

      */

     private function getFromTypes()

     {

@@ -1257,7 +1257,7 @@ 
     /**

      * returns possible status types

      *

-     * @return array possible status types

+     * @return string[] possible status types

      */

     private function getStatusTypes()

     {

@@ -1272,7 +1272,7 @@ 
     /**

      * returns possible payment methods

      *

-     * @return array possible payment methods

+     * @return string[] possible payment methods

      */

     private function getPaymentMethods()

     {

Indentation +8 added lines, -8 removed lines

@@ -389,7 +389,7 @@ 
         }

 

         if ($this->type == "invoice") {

-          // Hvis det er en faktura skal der indtastes en due_date, ellers er det ligegyldigt!

+            // Hvis det er en faktura skal der indtastes en due_date, ellers er det ligegyldigt!

             if ($validator->isDate($input["due_date"], "Ugyldig leveringsdato", "allow_no_year")) {

                 $due_date = new Intraface_Date($input["due_date"]);

                 $due_date->convert2db();

@@ -445,7 +445,7 @@ 
             $input["round_off"] = 0;

         }

 

-      // user_id = ".$this->kernel->user->get('id').", // skal puttes p�, men kun hvis det ikke er fra webshop.

+        // user_id = ".$this->kernel->user->get('id').", // skal puttes p�, men kun hvis det ikke er fra webshop.

         $db = new DB_Sql;

         if ($this->id == 0) {

 

@@ -717,9 +717,9 @@ 
 

     function getFromShopId()

     {

-    	if ($this->value['where_from'] == 'webshop') {

-    		return $this->value['where_from_id'];

-    	}

+        if ($this->value['where_from'] == 'webshop') {

+            return $this->value['where_from_id'];

+        }

         throw new Exception('Not from a shop');

     }

 

@@ -1130,9 +1130,9 @@ 
     function getPaymentInformation()

     {

         $info = array('bank_name'    => $this->kernel->setting->get("intranet", "bank_name"),

-                      'bank_reg_number' => $this->kernel->setting->get("intranet", "bank_reg_number"),

-                      'bank_account_number' => $this->kernel->setting->get("intranet", "bank_account_number"),

-                      'giro_account_number' => $this->kernel->setting->get("intranet", "giro_account_number")

+                        'bank_reg_number' => $this->kernel->setting->get("intranet", "bank_reg_number"),

+                        'bank_account_number' => $this->kernel->setting->get("intranet", "bank_account_number"),

+                        'giro_account_number' => $this->kernel->setting->get("intranet", "giro_account_number")

         );

 

         return $info;

Spacing +19 added lines, -19 removed lines

@@ -271,7 +271,7 @@ 
 

         // Bruges til at afg�re, hvor debtor er sendt hent til

         $db = new DB_Sql;

-        $db->query("SELECT id, type FROM debtor WHERE where_from > 2 AND where_from_id = " . $this->id . " AND active = 1");

+        $db->query("SELECT id, type FROM debtor WHERE where_from > 2 AND where_from_id = ".$this->id." AND active = 1");

         if ($db->nextRecord()) {

             if ($db->f('type') > 0) {

                 $types = self::getDebtorTypes();

@@ -305,7 +305,7 @@ 
         // @todo Currency is always loaded, should be done with left join. Oh give me more doctrine!

         $currency = $this->getCurrency();

 

-        for ($i = 0, $max = count($item), $total = 0, $total_currency = 0; $i<$max; $i++) {

+        for ($i = 0, $max = count($item), $total = 0, $total_currency = 0; $i < $max; $i++) {

             $total += $item[$i]["amount"]->getAsIso();

             if ($currency) $total_currency += $item[$i]['amount_currency']->getAsIso();

         }

@@ -461,12 +461,12 @@ 
             } while ($db->nextRecord());

 

             $sql_type = "INSERT INTO ";

-            $sql_after = ", date_created = NOW(), identifier_key = \"".$identifier."\", intranet_id = " . $this->kernel->intranet->get('id');

+            $sql_after = ", date_created = NOW(), identifier_key = \"".$identifier."\", intranet_id = ".$this->kernel->intranet->get('id');

         } else {

             $sql_type = "UPDATE ";

-            $sql_after = " WHERE id = " . $this->id . " AND intranet_id = " . $this->kernel->intranet->get('id');

+            $sql_after = " WHERE id = ".$this->id." AND intranet_id = ".$this->kernel->intranet->get('id');

         }

-        $sql = $sql_type . "debtor SET contact_id = " . $contact->get('id') . ",

+        $sql = $sql_type."debtor SET contact_id = ".$contact->get('id').",

             contact_address_id = ".$contact_address_id.",

             contact_person_id = ".$input['contact_person_id'].",

             intranet_address_id = ".$this->kernel->intranet->address->get("address_id").",

@@ -481,7 +481,7 @@ 
             currency_id = ".$currency_id.",

             currency_product_price_exchange_rate_id = ".$currency_exchange_rate_id.",

             payment_method=".$input['payment_method'].",

-            girocode='".$input['girocode']."' " . $internal_note_sql . $sql_after;

+            girocode='".$input['girocode']."' ".$internal_note_sql.$sql_after;

 

             // attention_to = '". $input['attention_to'] ."',

 

@@ -493,7 +493,7 @@ 
         }

 

         if (is_object($this->kernel->user) AND strtolower(get_class($this->kernel->user)) == 'user') {

-            $db->query("UPDATE debtor SET user_id = ".$this->kernel->user->get('id')." WHERE id = " . $this->id);

+            $db->query("UPDATE debtor SET user_id = ".$this->kernel->user->get('id')." WHERE id = ".$this->id);

         }

 

         $this->load();

@@ -513,9 +513,9 @@ 
             return false;

         }

         $db = new DB_Sql;

-        $db->query("SELECT id FROM debtor WHERE id = " . $this->id . " AND intranet_id = " . $this->kernel->intranet->get('id'). " AND type = '".$this->type_key."' LIMIT 1");

+        $db->query("SELECT id FROM debtor WHERE id = ".$this->id." AND intranet_id = ".$this->kernel->intranet->get('id')." AND type = '".$this->type_key."' LIMIT 1");

         if ($db->nextRecord()) {

-            $db->query("UPDATE debtor SET active = 0 WHERE id = " . $this->id . " AND intranet_id = " . $this->kernel->intranet->get('id') . "  AND type = '".$this->type_key."'");

+            $db->query("UPDATE debtor SET active = 0 WHERE id = ".$this->id." AND intranet_id = ".$this->kernel->intranet->get('id')."  AND type = '".$this->type_key."'");

             return true;

         }

         return false;

@@ -565,7 +565,7 @@ 
 

         switch ($this->type) {

             case "invoice":

-                $values['due_date'] = date("d-m-Y", time() + 24 * 60 * 60 * $debtor_object->contact->get("paymentcondition"));

+                $values['due_date'] = date("d-m-Y", time() + 24*60*60*$debtor_object->contact->get("paymentcondition"));

                 if (empty($values['payment_method']) AND $this->kernel->setting->get('intranet', 'bank_account_number')) {

                     $values['payment_method'] = 1;

                 }

@@ -626,7 +626,7 @@ 
             if ($status_id === false) {

                 throw new Exception("Debtor->setStatus(): Ugyldig status (streng)");

             }

-        } else{

+        } else {

             $status_id = intval($status);

             $status_types = $this->getStatusTypes();

             if (isset($status_types[$status_id])) {

@@ -662,7 +662,7 @@ 
         }

 

         $db = new Db_Sql;

-        $db->query("UPDATE debtor SET status = ".$status_id.", ".$sql."  WHERE id = " . $this->id . " AND intranet_id = " . $this->kernel->intranet->get('id'));

+        $db->query("UPDATE debtor SET status = ".$status_id.", ".$sql."  WHERE id = ".$this->id." AND intranet_id = ".$this->kernel->intranet->get('id'));

         $this->load();

 

         return true;

@@ -689,7 +689,7 @@ 
             return false;

         }

         $db = new Db_Sql;

-        $db->query("UPDATE debtor SET where_from = ".(int)$from.", where_from_id = " . $from_id . " WHERE id = " . $this->id);

+        $db->query("UPDATE debtor SET where_from = ".(int)$from.", where_from_id = ".$from_id." WHERE id = ".$this->id);

         return true;

     }

 

@@ -710,7 +710,7 @@ 
         }

         $contact_id = (int)$contact_id;

         $db = new DB_Sql;

-        $db->query("UPDATE debtor SET contact_id = " . $contact_id . " WHERE id = " . $this->id . " AND intranet_id = " . $this->kernel->intranet->get("id") . " AND type='".$this->type_key."'");

+        $db->query("UPDATE debtor SET contact_id = ".$contact_id." WHERE id = ".$this->id." AND intranet_id = ".$this->kernel->intranet->get("id")." AND type='".$this->type_key."'");

 

         return true;

     }

@@ -739,7 +739,7 @@ 
             case 'contact':

                 $sql = "SELECT id

                 FROM debtor

-                    WHERE intranet_id = " . $this->kernel->intranet->get("id") . "

+                    WHERE intranet_id = " . $this->kernel->intranet->get("id")."

                         AND contact_id = ".(int)$type_id."

               AND type='".$this->type_key."'

               AND active = 1";

@@ -773,7 +773,7 @@ 
     public function isFilledIn()

     {

         $db = new DB_Sql;

-        $db->query("SELECT id FROM debtor WHERE type = " . $this->type_key . " AND intranet_id = " . $this->kernel->intranet->get('id'));

+        $db->query("SELECT id FROM debtor WHERE type = ".$this->type_key." AND intranet_id = ".$this->kernel->intranet->get('id'));

         return $db->numRows();

     }

 

@@ -978,7 +978,7 @@ 
     {

         $number = safeToDb($number);

         $db = new DB_Sql;

-        $sql = "SELECT id FROM debtor WHERE intranet_id = " . $this->kernel->intranet->get('id') . " AND number = '".$number."' AND type = '".$this->type_key."' AND id != " . $this->id." AND active = 1";

+        $sql = "SELECT id FROM debtor WHERE intranet_id = ".$this->kernel->intranet->get('id')." AND number = '".$number."' AND type = '".$this->type_key."' AND id != ".$this->id." AND active = 1";

         $db->query($sql);

         if ($db->numRows() == 0) {

             return true;

@@ -1063,7 +1063,7 @@ 
     {

         // FIXME - check on date

         $db = new DB_Sql;

-        $db->query("UPDATE debtor SET date_stated = '" . $voucher_date . "', voucher_id = '".$voucher_id."' WHERE id = " . $this->id . " AND intranet_id = " . $this->kernel->intranet->get('id'));

+        $db->query("UPDATE debtor SET date_stated = '".$voucher_date."', voucher_id = '".$voucher_id."' WHERE id = ".$this->id." AND intranet_id = ".$this->kernel->intranet->get('id'));

         return true;

     }

 

@@ -1307,6 +1307,6 @@ 
 

     function getPaymentLink($url)

     {

-        return $url . $this->getIdentifier();

+        return $url.$this->getIdentifier();

     }

 }
\ No newline at end of file

Braces +3 added lines, -1 removed lines

@@ -307,7 +307,9 @@
 

         for ($i = 0, $max = count($item), $total = 0, $total_currency = 0; $i<$max; $i++) {

             $total += $item[$i]["amount"]->getAsIso();

-            if ($currency) $total_currency += $item[$i]['amount_currency']->getAsIso();

+            if ($currency) {
+                $total_currency += $item[$i]['amount_currency']->getAsIso();
+            }
         }

 

         // no round off of curreny yet!

src/Intraface/modules/debtor/DebtorDoctrineGateway.php

Doc Comments -1 removed lines

@@ -77,7 +77,6 @@
      * s� man kan se, hvad folk er interesseret i.
      * S�gemaskinen skal v�re tolerant for stavefejl
      *
-     * @param object $search
      *
      * @return object collection containing products
      */

Spacing +5 added lines, -5 removed lines

@@ -103,7 +103,7 @@ 
             ->addWhere('intranet_id = ?', $this->user->getActiveIntranetId());
 
         if ($dbquery->checkFilter("contact_id")) {
-            $query = $query->addWhere("contact_id = ?",intval($dbquery->getFilter("contact_id")));
+            $query = $query->addWhere("contact_id = ?", intval($dbquery->getFilter("contact_id")));
         }
 
         if ($dbquery->checkFilter("text")) {
@@ -204,16 +204,16 @@ 
 
         switch ($dbquery->getFilter("sorting")) {
             case 1:
-                $query =  $query->addOrderBy('number ASC, item.position');
+                $query = $query->addOrderBy('number ASC, item.position');
                 break;
             case 2:
-                $query =  $query->addOrderBy('contact.number ASC, item.position');
+                $query = $query->addOrderBy('contact.number ASC, item.position');
                 break;
             case 3:
-                $query =  $query->addOrderBy('contact_address.name ASC, item.position');
+                $query = $query->addOrderBy('contact_address.name ASC, item.position');
                 break;
             default:
-                $query =  $query->addOrderBy('number DESC, item.position');
+                $query = $query->addOrderBy('number DESC, item.position');
         }
 
 

src/Intraface/modules/debtor/DebtorGateway.php

Doc Comments +4 added lines, -3 removed lines

@@ -20,7 +20,7 @@ 
     /**
      * returns the possible debtor types!
      *
-     * @return array types
+     * @return string[] types
      */
     static function getDebtorTypes()
     {
@@ -60,8 +60,6 @@ 
     /**
      * Bruges til at lave en menu p� kontakten eller produktet
      *
-     * @param string  $type    contact eller product
-     * @param integer $type_id id p� contact eller product.
      *
      * @return integer
      */
@@ -95,6 +93,9 @@ 
         return $db->numRows();
     }
 
+    /**
+     * @param integer $id
+     */
     function findById($id)
     {
         if (is_int($id) && $id != 0) {

Spacing +5 added lines, -5 removed lines

@@ -38,7 +38,7 @@ 
 
     function getTypeKey()
     {
-        return array_search( $this->type, $this->getDebtorTypes());
+        return array_search($this->type, $this->getDebtorTypes());
     }
 
     function getDBQuery()
@@ -69,7 +69,7 @@ 
     {
                 $sql = "SELECT id
                 FROM debtor
-                    WHERE intranet_id = " . $this->kernel->intranet->get("id") . "
+                    WHERE intranet_id = " . $this->kernel->intranet->get("id")."
                         AND contact_id = ".(int)$contact_id."
               AND type='".$this->type_key."'
               AND active = 1";
@@ -82,7 +82,7 @@ 
     function setNewContactId($old_contact_id, $new_contact_id)
     {
         $db = new DB_Sql;
-        $db->query('UPDATE debtor SET contact_id = ' . $new_contact_id . ' WHERE contact_id = ' . $old_contact_id);
+        $db->query('UPDATE debtor SET contact_id = '.$new_contact_id.' WHERE contact_id = '.$old_contact_id);
         return true;
     }
 
@@ -91,7 +91,7 @@ 
         $db = new DB_Sql;
         $db->query('SELECT * FROM debtor WHERE date_created >=
         	DATE_SUB(NOW(),INTERVAL 1 DAY)
-        	AND type = ' .$this->type_key . ' AND intranet_id = ' .$this->kernel->intranet->get('id'));
+        	AND type = ' .$this->type_key.' AND intranet_id = '.$this->kernel->intranet->get('id'));
         return $db->numRows();
     }
 
@@ -403,7 +403,7 @@ 
     public function isFilledIn()
     {
         $db = new DB_Sql;
-        $db->query("SELECT id FROM debtor WHERE type = " . $this->getTypeKey() . " AND intranet_id = " . $this->kernel->intranet->get('id'));
+        $db->query("SELECT id FROM debtor WHERE type = ".$this->getTypeKey()." AND intranet_id = ".$this->kernel->intranet->get('id'));
         return $db->numRows();
     }
 }
\ No newline at end of file

src/Intraface/modules/debtor/DebtorItem.php

Doc Comments +2 added lines, -2 removed lines

@@ -64,7 +64,7 @@ 
     /**

      * Constructor

      *

-     * @param object  $debtor Debtor object

+     * @param Debtor  $debtor Debtor object

      * @param integer $id     If a special item id is needed

      *

      * @return void

@@ -244,7 +244,7 @@ 
     /**

      * Gets the tax percent on the individual product

      *

-     * @return float

+     * @return integer

      */

     public function getTaxPercent()

     {

Indentation +3 added lines, -3 removed lines

@@ -286,7 +286,7 @@ 
             $product = new Product($this->debtor->kernel, $input["product_id"], $input['product_detail_id']);

 

             if (!is_object($product) || $product->get('id') == 0) {

-                 $this->error->set("Ugyldigt produkt");

+                    $this->error->set("Ugyldigt produkt");

             } else {

                 $product_detail_id = $product->get("detail_id");

             }

@@ -372,7 +372,7 @@ 
         $product = new Product($this->debtor->kernel, $product_id);

 

         if (!is_object($product) || $product->get('id') == 0) {

-             throw new Excetion('Invalid product id');

+                throw new Excetion('Invalid product id');

         } else {

             $product_detail_id = $product->get("detail_id");

         }

@@ -500,7 +500,7 @@ 
                     $i++;

                 }

             } else {

-                 throw new Exception("Ugyldig produktdetalje i DebtorItem->getList() on ".$db->f('product_id').'/'.$db->f('product_detail_id'));

+                    throw new Exception("Ugyldig produktdetalje i DebtorItem->getList() on ".$db->f('product_id').'/'.$db->f('product_detail_id'));

             }

         }

         unset($db);

Spacing +8 added lines, -8 removed lines

@@ -228,7 +228,7 @@ 
         // TODO how do we handle vat? this should return raw prices

         // and then the tax percent should return the tax to apply

         // the calculator should handle the final price

-        return $this->getProductPrice() * $this->get('quantity');

+        return $this->getProductPrice()*$this->get('quantity');

     }

 

     /**

@@ -238,7 +238,7 @@ 
      */

     public function getWeight()

     {

-        return $this->getProductWeight() * $this->get('quantity');

+        return $this->getProductWeight()*$this->get('quantity');

     }

 

     /**

@@ -470,14 +470,14 @@ 
                     $variation = $product->getVariation($db->f('product_variation_id'));

                     $detail = $variation->getDetail($db->f('product_variation_detail_id'));

                     $item["name"] = $product->get("name").' - '.$variation->getName();

-                    $item["number"]= $product->get("number").'.'.$variation->getNumber();

+                    $item["number"] = $product->get("number").'.'.$variation->getNumber();

                     $item["price"] = $detail->getPrice($product);

                     if ($currency) {

                         $item['price_currency'] = $detail->getPriceInCurrency($currency, $this->debtor->get('currency_product_price_exchange_rate_id'), $product);

                     }

                 } else {

                     $item["name"] = $product->get("name");

-                    $item["number"]= $product->get("number");

+                    $item["number"] = $product->get("number");

                     $item["price"] = $product->getDetails()->getPrice();

                     if ($currency) {

                         $item['price_currency'] = $product->getDetails()->getPriceInCurrency($currency, $this->debtor->get('currency_product_price_exchange_rate_id'));

@@ -486,16 +486,16 @@ 
 

                 if ($product->get("vat") == 0) {

                     $item_no_vat[$j] = $item;

-                    $item_no_vat[$j]["amount"] = new Ilib_Variable_Float($item["quantity"] * $item["price"]->getAsIso(2));

+                    $item_no_vat[$j]["amount"] = new Ilib_Variable_Float($item["quantity"]*$item["price"]->getAsIso(2));

                     if ($currency) {

-                        $item_no_vat[$j]["amount_currency"] = new Ilib_Variable_Float($item["quantity"] * $item["price_currency"]->getAsIso(2), 'iso');

+                        $item_no_vat[$j]["amount_currency"] = new Ilib_Variable_Float($item["quantity"]*$item["price_currency"]->getAsIso(2), 'iso');

                     }

                     $j++;

                 } else {

                     $item_with_vat[$i] = $item;

-                    $item_with_vat[$i]["amount"] = new Ilib_Variable_Float($item["quantity"] * $item["price"]->getAsIso(2) * 1.25);

+                    $item_with_vat[$i]["amount"] = new Ilib_Variable_Float($item["quantity"]*$item["price"]->getAsIso(2)*1.25);

                     if ($currency) {

-                        $item_with_vat[$i]["amount_currency"] = new Ilib_Variable_Float($item["quantity"] * $item["price_currency"]->getAsIso(2) * 1.25, 'iso');

+                        $item_with_vat[$i]["amount_currency"] = new Ilib_Variable_Float($item["quantity"]*$item["price_currency"]->getAsIso(2)*1.25, 'iso');

                     }

                     $i++;

                 }

Braces +17 added lines, -14 removed lines

@@ -166,8 +166,7 @@ 
     {

         if ($this->getProduct()->get('has_variation')) {

             return $this->getProductVariationDetail()->getPrice($this->getProduct());

-        }

-        else {

+        } else {

             return $this->getProduct()->getDetails()->getPrice();

         }

     }

@@ -181,8 +180,7 @@ 
     {

         if ($this->getProduct()->get('has_variation')) {

             return $this->getProduct()->get("weight") + $this->getProductVariationDetail()->getWeightDifference();

-        }

-        else {

+        } else {

             return $this->getProduct()->get("weight");

         }

     }

@@ -196,8 +194,7 @@ 
     {

         if ($this->getProduct()->get('has_variation')) {

             return $this->getProduct()->get("number").'.'.$this->getProductVariation()->getNumber();

-        }

-        else {

+        } else {

             return $this->getProduct()->get("number");

         }

     }

@@ -211,8 +208,7 @@ 
     {

         if ($this->getProduct()->get('has_variation')) {

             return $this->getProduct()->get("name").' - '.$this->getProductVariation()->getName();

-        }

-        else {

+        } else {

             return $this->getProduct()->get("name");

         }

     }

@@ -291,14 +287,18 @@ 
                 $product_detail_id = $product->get("detail_id");

             }

 

-            if (!isset($input['product_variation_id'])) $input['product_variation_id'] = 0;

+            if (!isset($input['product_variation_id'])) {
+                $input['product_variation_id'] = 0;
+            }
             if (intval($input['product_variation_id']) != 0) {

                 $variation = $product->getVariation(intval($input['product_variation_id']));

                 if (!$variation->getId()) {

                     $this->error->set("Invalid product variation");

                 }

 

-                if (!isset($input['product_variation_detail_id'])) $input['product_variation_detail_id'] = 0;

+                if (!isset($input['product_variation_detail_id'])) {
+                    $input['product_variation_detail_id'] = 0;
+                }
                 $detail = $variation->getDetail(intval($input['product_variation_detail_id']));

                 if (!$detail->getId()) {

                     $this->error->set("Invalid product variation detail");

@@ -306,15 +306,16 @@ 
 

                 $variation_id = $variation->getId();

                 $variation_detail_id = $detail->getId();

-            }

-            else {

+            } else {

                 $variation_id = 0;

                 $variation_detail_id = 0;

             }

 

         }

 

-        if (!isset($input["quantity"])) $input["quantity"] = 0;

+        if (!isset($input["quantity"])) {
+            $input["quantity"] = 0;
+        }
         $validator->isDouble($input["quantity"], "Du skal angive et antal", "");

         $quantity = new Intraface_Amount($input["quantity"]);

         if ($quantity->convert2db()) {

@@ -322,7 +323,9 @@ 
         } else {

             $this->error->set("Ugyligt antal");

         }

-        if (!isset($input['description'])) $input['description'] = '';

+        if (!isset($input['description'])) {
+            $input['description'] = '';
+        }
         $validator->isString($input["description"], "Fejl i beskrivelse", "<b><i>", "allow_empty");

 

         if ($this->error->isError()) {

src/Intraface/modules/debtor/PaymentMethod.php

Doc Comments +2 added lines, -1 removed lines

@@ -13,7 +13,7 @@ 
     /**
      * Do not change the key for the payment methods
      *
-     * @return array The possible payment types
+     * @return string[] The possible payment types
      */
     public function getTypes()
     {
@@ -30,6 +30,7 @@ 
 
     /**
      * Returns specific payment method
+     * @param string $method
      */
     public function getByName($method)
     {

Indentation +2 added lines, -2 removed lines

@@ -17,7 +17,7 @@ 
      */
     public function getTypes()
     {
-     	$types[0] = 'None';
+            $types[0] = 'None';
         $types[1] = 'BankTransfer';
         $types[2] = 'GiroPayment01';
         $types[3] = 'GiroPayment71';
@@ -86,7 +86,7 @@ 
     {
         $payment_methods = array();
 
-   	    $methods = Doctrine::getTable('Intraface_modules_shop_PaymentMethods')->findByShopId($shop_id);
+            $methods = Doctrine::getTable('Intraface_modules_shop_PaymentMethods')->findByShopId($shop_id);
         foreach ($methods as $method) {
             $gateway = new Intraface_modules_debtor_PaymentMethod();
             $m = $gateway->getByKey($method->getPaymentMethodKey());

src/Intraface/modules/filemanager/AppendFile.php

Doc Comments +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
      * @param string  $belong_to    Which type the file belongs to

      * @param integer $belong_to_id The id this appended file belongs to

      *

-     * @return void

+     * @return integer

      */

     public function __construct($kernel, $belong_to, $belong_to_id)

     {

Spacing +2 added lines, -2 removed lines

@@ -99,7 +99,7 @@ 
         if ($this->dbquery) {

             return $this->dbquery;

         }

-        $this->dbquery = new Ilib_DBQuery('filehandler_append_file', 'filehandler_append_file.active = 1 AND filehandler_append_file.intranet_id='.$this->kernel->intranet->get('id').' AND filehandler_append_file.belong_to_key = '.$this->belong_to_key.' AND filehandler_append_file.belong_to_id = ' . $this->belong_to_id);

+        $this->dbquery = new Ilib_DBQuery('filehandler_append_file', 'filehandler_append_file.active = 1 AND filehandler_append_file.intranet_id='.$this->kernel->intranet->get('id').' AND filehandler_append_file.belong_to_key = '.$this->belong_to_key.' AND filehandler_append_file.belong_to_id = '.$this->belong_to_id);

         $this->dbquery->createStore($this->kernel->getSessionId(), 'intranet_id = '.intval($this->kernel->intranet->get('id')));

         return $this->dbquery;

     }

@@ -115,7 +115,7 @@ 
     {

         $db = new DB_Sql();

         $db->query("SELECT id FROM filehandler_append_file

-            WHERE intranet_id = " . $this->kernel->intranet->get('id') . "

+            WHERE intranet_id = " . $this->kernel->intranet->get('id')."

                 AND belong_to_key = ".$this->belong_to_key."

                 AND belong_to_id = ".$this->belong_to_id."

                 AND file_handler_id = ".$file_id."

src/Intraface/modules/filemanager/FileHandler.php

Doc Comments +2 added lines, -2 removed lines

@@ -358,7 +358,8 @@ 
      * creates and temporary file handler
      *
      * @param string optional file name
-     * @return object temporary file
+     * @param string $file_name
+     * @return TemporaryFile temporary file
      */
     public function createTemporaryFile($file_name = NULL)
     {
@@ -691,7 +692,6 @@ 
     /**
      * Returns RandomKeyGenerator
      *
-     * @param integer $length the length of the random key
      * @return object RandomKeyGenerator
      */
     private function getRandomKeyGenerator()

src/Intraface/modules/filemanager/FileHandlerHTML.php

Doc Comments +3 added lines

@@ -79,6 +79,9 @@
 {

     private $file_handler;

 

+    /**
+     * @param FileHandler $file_handler
+     */
     function __construct($file_handler)

     {

         $this->file_handler = $file_handler;

Indentation +13 added lines, -13 removed lines

@@ -86,19 +86,19 @@
 

 

     /**

-    * Denne funktion skal printe et upload field.

-    *

-    * Det skal p� en eller anden m�de v�re muligt at s�tte f�lgende parameter:

-    * @param checkbox_name: navnet p� den checkboks, som inds�ttes, n�r der er uploadet et billede

-    * @param upload_field_name: navnet p� type="file" input-felttet.

-    * @param submit_name: navnet p� submit-knappen, som f�rer til "V�lg fra filarkiv"

-    * @param options: array:

-    * 		image_attr (mulighed for at s�tte attributer p� img-tag);

-    *			field_description: (det som st�r foran upload feltet, standard 'Fil')

-    *			image_size: (st�rrelsen p� billedet. Standard original

-    *			type: full/only_upload

-    *			include_submit_button_name: hvis sat bliver der indsat en "Upload" knap efter fil-felt, men strengen som navn

-    */

+     * Denne funktion skal printe et upload field.

+     *

+     * Det skal p� en eller anden m�de v�re muligt at s�tte f�lgende parameter:

+     * @param checkbox_name: navnet p� den checkboks, som inds�ttes, n�r der er uploadet et billede

+     * @param upload_field_name: navnet p� type="file" input-felttet.

+     * @param submit_name: navnet p� submit-knappen, som f�rer til "V�lg fra filarkiv"

+     * @param options: array:

+     * 		image_attr (mulighed for at s�tte attributer p� img-tag);

+     *			field_description: (det som st�r foran upload feltet, standard 'Fil')

+     *			image_size: (st�rrelsen p� billedet. Standard original

+     *			type: full/only_upload

+     *			include_submit_button_name: hvis sat bliver der indsat en "Upload" knap efter fil-felt, men strengen som navn

+     */

 

     function printFormUploadTag($checkbox_name, $upload_field_name, $submit_name, $options = array())

     {

Spacing +2 added lines, -2 removed lines

@@ -133,7 +133,7 @@ 
         echo '<label for="'.$upload_field_name.'">'.t($options['field_description'], 'filehandler').'</label>';

         echo '<input name="'.$upload_field_name.'" type="file" id="'.$upload_field_name.'" />';

         if ($options['include_submit_button_name'] != '') {

-            echo ' <input type="submit" name="'.$options['include_submit_button_name'].'" value="'.t('upload', 'filehandler') . '" /> <br />';

+            echo ' <input type="submit" name="'.$options['include_submit_button_name'].'" value="'.t('upload', 'filehandler').'" /> <br />';

         }

         if ($this->file_handler->kernel->user->hasModuleAccess('filemanager') AND $options['filemanager'] === true) {

             echo ' &nbsp; '.t('or').' &nbsp; <input type="submit" name="'.$submit_name.'" value="'.t('choose from filemanager', 'filehandler').'" />';

@@ -155,7 +155,7 @@ 
             $this->file_handler->createInstance('small');

 

             if ($options['div_style'] == '') {

-                $options['div_style'] = 'height: '.($this->file_handler->instance->get('height')+10).'px;';

+                $options['div_style'] = 'height: '.($this->file_handler->instance->get('height') + 10).'px;';

             }

             echo '<div class="show_file" style="'.$options['div_style'].'"><img src="'.$this->file_handler->instance->get('file_uri').'" style="width: '.$this->file_handler->instance->get('width').'px; height: '.$this->file_handler->instance->get('height').'px" /> '.$this->file_handler->get('file_name');

             if ($delete_link != '') {