intraface / intraface.dk

src/Intraface/XMLRPC/CMS/Server.php

Doc Comments +3 added lines

@@ -12,6 +12,9 @@
     private $credentials;

     private $kernel;

 

+    /**
+     * @param integer $site_id
+     */
     private function factory($site_id)

     {

         if (!$this->kernel->weblogin->hasModuleAccess('cms')) { // -2

Indentation +5 added lines, -5 removed lines

@@ -150,13 +150,13 @@
             throw new XML_RPC2_FaultException('Wrong parameters. You need to specify the private key.', -5);

         }

 

-		$auth_adapter = new Intraface_Auth_PrivateKeyLogin(MDB2::singleton(DB_DSN), $credentials['session_id'], $credentials['private_key']);

-		$weblogin = $auth_adapter->auth();

+        $auth_adapter = new Intraface_Auth_PrivateKeyLogin(MDB2::singleton(DB_DSN), $credentials['session_id'], $credentials['private_key']);

+        $weblogin = $auth_adapter->auth();

 

-		if (!$weblogin) {

-		    require_once 'XML/RPC2/Exception.php';

+        if (!$weblogin) {

+            require_once 'XML/RPC2/Exception.php';

             throw new XML_RPC2_FaultException('Access to the intranet denied. The private key is probably wrong.', -5);

-		}

+        }

 

         $this->kernel = new Intraface_Kernel();

         $this->kernel->weblogin = $weblogin;

Spacing +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
              * niveau 9999 g�r at den ikke kan genkende den, og tager top_level.

              * 0 der ellers skulle v�re topmenu virker af en m�rkelig grund ikke. Variablen er ikke registeret som sat!

              */

-            $cmspage->value['navigation_toplevel'] = $cmspage->navigation->build(9999, 'array');	// 'toplevel'

+            $cmspage->value['navigation_toplevel'] = $cmspage->navigation->build(9999, 'array'); // 'toplevel'

             $cmspage->value['navigation_sublevel'] = $cmspage->navigation->build(1, 'array'); // 'sublevel'

             $cmspage->value['sections'] = $cmspage->collect();

             $cmspage->value['comments'] = $cmspage->getComments();

src/Intraface/XMLRPC/CMS/Server0300.php

Doc Comments +3 added lines

@@ -9,6 +9,9 @@
  */

 class Intraface_XMLRPC_CMS_Server0300 extends Intraface_XMLRPC_Server

 {

+    /**
+     * @param integer $site_id
+     */
     private function factory($site_id)

     {

         if (!$this->kernel->weblogin->hasModuleAccess('cms')) { // -2

Spacing +2 added lines, -2 removed lines

@@ -68,7 +68,7 @@ 
             // niveau 9999 g�r at den ikke kan genkende den, og tager top_level.

             // 0 der ellers skulle v�re topmenu virker af en m�rkelig grund ikke. Variablen er ikke registeret som sat!

             //

-            $cmspage->value['navigation_toplevel'] = $cmspage->navigation->build(9999, 'array');	// 'toplevel'

+            $cmspage->value['navigation_toplevel'] = $cmspage->navigation->build(9999, 'array'); // 'toplevel'

             $cmspage->value['navigation_sublevel'] = $cmspage->navigation->build(1, 'array'); // 'sublevel'

             $cmspage->value['sections'] = $cmspage->collect();

             $cmspage->value['comments'] = $cmspage->getComments();

@@ -152,7 +152,7 @@ 
         $this->factory($site_id);

 

         $cmspage = new CMS_Page($this->site);

-        $value['toplevel'] = $cmspage->navigation->build(9999, 'array');    // 'toplevel'

+        $value['toplevel'] = $cmspage->navigation->build(9999, 'array'); // 'toplevel'

         $value['sublevel'] = $cmspage->navigation->build(1, 'array'); // 'sublevel'

 

         return $this->prepareResponseData($value);

src/Intraface/XMLRPC/CMS/Server0400.php

Doc Comments +3 added lines

@@ -9,6 +9,9 @@
  */

 class Intraface_XMLRPC_CMS_Server0300 extends Intraface_XMLRPC_Server0100

 {

+    /**
+     * @param integer $site_id
+     */
     private function factory($site_id)

     {

         if (!$this->kernel->weblogin->hasModuleAccess('cms')) { // -2

Spacing +2 added lines, -2 removed lines

@@ -63,7 +63,7 @@ 
             // level 9999 cannot be recognized, so we take top level

             // 0 which should be top level does not work - the variable is not set

 

-            $cmspage->value['navigation_toplevel'] = $cmspage->navigation->build(9999, 'array');	// 'toplevel'

+            $cmspage->value['navigation_toplevel'] = $cmspage->navigation->build(9999, 'array'); // 'toplevel'

             $cmspage->value['navigation_sublevel'] = $cmspage->navigation->build(1, 'array'); // 'sublevel'

             $cmspage->value['sections'] = $cmspage->collect();

             $cmspage->value['comments'] = $cmspage->getComments();

@@ -145,7 +145,7 @@ 
         $this->factory($site_id);

 

         $cmspage = new CMS_Page($this->site);

-        $value['toplevel'] = $cmspage->navigation->build(9999, 'array');    // 'toplevel'

+        $value['toplevel'] = $cmspage->navigation->build(9999, 'array'); // 'toplevel'

         $value['sublevel'] = $cmspage->navigation->build(1, 'array'); // 'sublevel'

 

         return $this->prepareResponseData($value);

src/Intraface/XMLRPC/Contact/Server.php

Doc Comments +1 added lines, -1 removed lines

@@ -263,7 +263,7 @@
      * Checking credentials

      *

      * @param struct $credentials

-     * @return array

+     * @return boolean

      */

     protected function checkCredentials($credentials)

     {

Indentation +5 added lines, -5 removed lines

@@ -280,13 +280,13 @@
             throw new XML_RPC2_FaultException('supply a session_id', -5);

         }

 

-		$auth_adapter = new Intraface_Auth_PrivateKeyLogin(MDB2::singleton(DB_DSN), $credentials['session_id'], $credentials['private_key']);

-		$weblogin = $auth_adapter->auth();

+        $auth_adapter = new Intraface_Auth_PrivateKeyLogin(MDB2::singleton(DB_DSN), $credentials['session_id'], $credentials['private_key']);

+        $weblogin = $auth_adapter->auth();

 

-		if (!$weblogin) {

-		    require_once 'XML/RPC2/Exception.php';

+        if (!$weblogin) {

+            require_once 'XML/RPC2/Exception.php';

             throw new XML_RPC2_FaultException('Access to the intranet denied. The private key is probably wrong.', -5);

-		}

+        }

 

         $this->kernel = new Intraface_Kernel();

         $this->kernel->intranet = new Intraface_Intranet($weblogin->getActiveIntranetId());

Spacing +1 added lines, -1 removed lines

@@ -269,7 +269,7 @@
     {

         if (count($credentials) != 2) { // -4

             require_once 'XML/RPC2/Exception.php';

-            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got ' . count($credentials) . ' arguments - need 2', -4);

+            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got '.count($credentials).' arguments - need 2', -4);

         }

         if (empty($credentials['private_key'])) { // -5

             require_once 'XML/RPC2/Exception.php';

src/Intraface/XMLRPC/Controller/Server.php

Doc Comments +9 added lines

@@ -26,6 +26,9 @@ 
         return parent::dispatch();
     }
 
+    /**
+     * @param string $backend
+     */
     function setBackend($backend)
     {
         if ($backend == 'xmlrpcext') {
@@ -74,6 +77,9 @@ 
         return $backend;
     }
 
+    /**
+     * @return string
+     */
     function getEncoding()
     {
         return $this->encoding = $this->backends[$this->getBackend()];
@@ -122,6 +128,9 @@ 
         return ($this->backend == 'xmlrpcext');
     }
 
+    /**
+     * @return string
+     */
     function getResponse()
     {
         if ($this->isXmlRpcExt()) {

Spacing +1 added lines, -1 removed lines

@@ -86,7 +86,7 @@
         }
 
         $options = array(
-            'prefix' => $this->prefix . '.',
+            'prefix' => $this->prefix.'.',
             'encoding' => $this->getEncoding(), // $this->encoding
             'backend' => $this->getBackend());
 

src/Intraface/XMLRPC/Newsletter/Server.php

Doc Comments +3 added lines

@@ -18,6 +18,9 @@
     private $subscriber;
     private $credentials;
 
+    /**
+     * @param integer $list_id
+     */
     private function factoryList($list_id)
     {
         $this->list = new NewsletterList($this->kernel, $list_id);

Spacing +3 added lines, -3 removed lines

@@ -73,7 +73,7 @@ 
 
         if (!$this->subscriber->unsubscribe($email)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('you could not unsubscribe with ' .$email, -4);
+            throw new XML_RPC2_FaultException('you could not unsubscribe with '.$email, -4);
         }
 
         return true;
@@ -175,7 +175,7 @@ 
     function getListIdFromOptinCode($credentials, $code)
     {
         $db = MDB2::singleton(DB_DSN);
-        $result = $db->query('SELECT list_id FROM newsletter_subscriber WHERE code = ' . $db->quote($code, 'text'));
+        $result = $db->query('SELECT list_id FROM newsletter_subscriber WHERE code = '.$db->quote($code, 'text'));
         if ($row = $result->fetchRow(MDB2_FETCHMODE_ASSOC)) {
             return $row['list_id'];
         }
@@ -193,7 +193,7 @@ 
     {
         if (count($credentials) != 2) { // -4
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got ' . count($credentials) . ' arguments - need 2', -4);
+            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got '.count($credentials).' arguments - need 2', -4);
         }
         if (empty($credentials['private_key'])) { // -5
             require_once 'XML/RPC2/Exception.php';

src/Intraface/XMLRPC/Server.php

Doc Comments +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
      *
      * @param struct $credentials Credentials to use the server
      *
-     * @return array
+     * @return boolean
      */
     protected function checkCredentials($credentials)
     {

Indentation +2 added lines, -2 removed lines

@@ -110,8 +110,8 @@
     {
         if ($value === null) {
             return '';
-       }
-       return $value;
+        }
+        return $value;
     }
 
     /**

Spacing +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
 
         if (count($credentials) != 2) { // -4
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got ' . count($credentials) . ' arguments - need 2', -4);
+            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got '.count($credentials).' arguments - need 2', -4);
         }
         if (empty($credentials['private_key'])) { // -5
             require_once 'XML/RPC2/Exception.php';

src/Intraface/XMLRPC/Server0100.php

Doc Comments +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
      *
      * @param struct $credentials Credentials to use the server
      *
-     * @return array
+     * @return boolean
      */
     protected function checkCredentials($credentials)
     {

Indentation +2 added lines, -2 removed lines

@@ -140,8 +140,8 @@
     {
         if (is_null($value)) {
             return '';
-       }
-       return $value;
+        }
+        return $value;
     }
 
     protected function recursiveMap($function, $values)

Spacing +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
 
         if (count($credentials) != 2) { // -4
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got ' . count($credentials) . ' arguments - need 2', -4);
+            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got '.count($credentials).' arguments - need 2', -4);
         }
         if (empty($credentials['private_key'])) { // -5
             require_once 'XML/RPC2/Exception.php';

src/Intraface/XMLRPC/Server0200.php

Doc Comments +1 added lines, -2 removed lines

@@ -49,7 +49,6 @@ 
     /**
      * Constructor
      *
-     * @param string  $encoding The encoding wich the server recieves and returns data in
      *
      * @return void
      */
@@ -62,7 +61,7 @@ 
      *
      * @param struct $credentials Credentials to use the server
      *
-     * @return array
+     * @return boolean
      */
     protected function checkCredentials($credentials)
     {

Indentation +2 added lines, -2 removed lines

@@ -129,8 +129,8 @@
     {
         if (is_null($value)) {
             return '';
-       }
-       return $value;
+        }
+        return $value;
     }
 
     protected function recursiveMap($function, $values)

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
 
         if (count($credentials) != 2) { // -4
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got ' . count($credentials) . ' arguments - need 2', -4);
+            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got '.count($credentials).' arguments - need 2', -4);
         }
         if (empty($credentials['private_key'])) { // -5
             require_once 'XML/RPC2/Exception.php';