Intraface_Intranet::hasModuleAccess() - Code Metrics - intraface/intraface.dk - Measure and Improve Code Quality continuously with Scrutinizer

Intraface_Intranet::hasModuleAccess() C
last analyzed 2017-03-20 12:20 UTC

↳ Parent: Intraface_Intranet

Complexity

Conditions	14
Paths	42

Size

Total Lines	51
Code Lines	33

Duplication

Lines	23
Ratio	45.1 %

Code Coverage

Tests	30
CRAP Score	15.3274

Importance

Changes

Metric	Value
cc	14
eloc	33
nc	42
nop	1
dl	23
loc	51
rs	5.6426
c	0
b	0
f	0
ccs	30
cts	37
cp	0.8108
crap	15.3274

How to fix Long Method Complexity

<?php
/**
 * Styrer hvilket intranet man arbejder i
 *
 * @author Sune Jensen <[email protected]>
 * @author Lars Olesen <[email protected]>
 * @version 002
 */
class Intraface_Intranet extends Intraface_Standard
{
    /**
     * @var object
     */
    public $address;

    /**
     * @var array
     */
    public $value;

    /**
     * @var integer
     */
    protected $id;

    /**
     * @var object
     */
    private $db;

    /**
     * @var array
     */
    protected $permissions;

    /**
     * Constructor
     *
     * @param integer $intranet_id The id of the intranet
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return void

     */
    function __construct($id)
    {
        $this->id = intval($id);
        $this->db = MDB2::singleton(DB_DSN);
        $this->error = new Intraface_Error();
class MyClass { }

$x = new MyClass();
$x->foo = true;

        if (!$this->load()) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            throw new Exception('unknown intranet');
        }
    }

    function getName()
    {
        return $this->get('name');
    }

    /**
     * loads
     *
     * @return void
     */
    function load()
    {
        $this->db = MDB2::singleton(DB_DSN);
        $result = $this->db->query("SELECT
                id,
                name,
                identifier,
                key_code,
                public_key,
                contact_id,
                private_key,
                pdf_header_file_id,
                maintained_by_user_id
            FROM intranet
            WHERE id = ".$this->db->quote($this->id, 'integer'));

        if (PEAR::isError($result)) {
            throw new Exception($result->getUserInfo());
        }

        if ($row = $result->fetchRow(MDB2_FETCHMODE_ASSOC)) {
            $this->value   = $row;
            $this->address = $this->getAddress();
            return $this->id;
        } else {
            $this->id = 0;
            return 0;
        }
        $result->free();
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    public function getAddress()
    {
        return ($this->address = Intraface_Address::factory('intranet', $this->id));

    }

    /**
     * Returns whether the intranet has access to the module
     *
     * @todo might be smarter to throw in an actual module object
     *       that would make us sure that it is actually valid
     *
     * @param mixed $module The id or name of the module
     *
     * @return void
     */
    function hasModuleAccess($module)
    {
        $filename = PATH_INCLUDE_MODULE . $module . '/Main' . ucfirst($module) . '.php';
        if (file_exists($filename)) {
            require_once $filename;
            $module_class = 'Main'.ucfirst($module);
            $module_object = new $module_class;
            if ($module_object->isShared()) {
                return true;
            }
            if ($module_object->isRequired()) {
                return true;
            }
        }

        if (is_string($module)) {
            if (empty($this->modules)) {
                $result = $this->db->query("SELECT id, name FROM module WHERE active = 1");
                while ($row = $result->fetchRow(MDB2_FETCHMODE_ASSOC)) {
                    $this->modules[$row['name']] = $row['id'];
class MyClass { }

$x = new MyClass();
$x->foo = true;
                }
                $result->free();
            }

            if (!empty($this->modules[$module])) {
                $module_id = $this->modules[$module];
            } else {
                throw new Exception('intranet says invalid module name '.$module);
            }
        } else {
            $module_id = intval($module);
        }

        if (!empty($this->permissions)) {
            if (!empty($this->permissions['intranet']['module'][$module_id]) and $this->permissions['intranet']['module'][$module_id] == true) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
                return true;
            }
            return false;
        }

        $result = $this->db->query("SELECT module_id FROM permission WHERE intranet_id = ".$this->db->quote($this->id, 'integer')." AND user_id = 0");
        while ($row = $result->fetchRow(MDB2_FETCHMODE_ASSOC)) {
            $this->permissions['intranet']['module'][$row['module_id']] = true;
        }
        $result->free();

        if (!empty($this->permissions['intranet']['module'][$module_id]) and $this->permissions['intranet']['module'][$module_id] == true) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            return true;
        }
        return false;
    }

    /**
     * Returns the id of the intranet
     *
     * @return integer
     */
    function getId()
    {
        return $this->id;
    }
}


Intraface_Intranet::hasModuleAccess() C
last analyzed 2017-03-20 12:20 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

intraface / intraface.dk

Intraface_Intranet::hasModuleAccess() C last analyzed 2017-03-20 12:20 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like

Intraface_Intranet::hasModuleAccess() C
last analyzed 2017-03-20 12:20 UTC