Intraface_Intranet

Complexity

Total Complexity

22

Size/Duplication

Total Lines	163
Duplicated Lines	19.02 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

77.42%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	2
A	getName()	0	4	1
B	load()	8	30	3
A	getAddress()	0	4	1
C	hasModuleAccess()	23	51	14
A	getId()	0	4	1

<?php
/**
 * Styrer hvilket intranet man arbejder i
 *
 * @author Sune Jensen <sj@sunet.dk>
 * @author Lars Olesen <lars@legestue.net>
 * @version 002
 */
class Intraface_Intranet extends Intraface_Standard
{
    /**
     * @var object
     */
    public $address;

    /**
     * @var array
     */
    public $value;

    /**
     * @var integer
     */
    protected $id;

    /**
     * @var object
     */
    private $db;

    /**
     * @var array
     */
    protected $permissions;

    /**
     * Constructor
     *
     * @param integer $intranet_id The id of the intranet

There is no parameter named $intranet_id. Was it maybe removed?

     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    function __construct($id)
    {
        $this->id = intval($id);
        $this->db = MDB2::singleton(DB_DSN);
        $this->error = new Intraface_Error();

The property error does not exist. Did you maybe forget to declare it?

        if (!$this->load()) {

The expression $this->load() of type integer|null is loosely compared to false; this is ambiguous if the integer can be zero. You might want to explicitly use === null instead.

            throw new Exception('unknown intranet');
        }
    }

    function getName()
    {
        return $this->get('name');
    }

    /**
     * loads
     *
     * @return void
     */
    function load()
    {
        $this->db = MDB2::singleton(DB_DSN);
        $result = $this->db->query("SELECT
                id,
                name,
                identifier,
                key_code,
                public_key,
                contact_id,
                private_key,
                pdf_header_file_id,
                maintained_by_user_id
            FROM intranet
            WHERE id = ".$this->db->quote($this->id, 'integer'));

        if (PEAR::isError($result)) {
            throw new Exception($result->getUserInfo());
        }

        if ($row = $result->fetchRow(MDB2_FETCHMODE_ASSOC)) {
            $this->value   = $row;
            $this->address = $this->getAddress();
            return $this->id;
        } else {
            $this->id = 0;
            return 0;
        }
        $result->free();

$result->free(); does not seem to be reachable.

    }

    public function getAddress()
    {
        return ($this->address = Intraface_Address::factory('intranet', $this->id));

The method Intraface_Address::factory() has been deprecated.

    }

    /**
     * Returns whether the intranet has access to the module
     *
     * @todo might be smarter to throw in an actual module object
     *       that would make us sure that it is actually valid
     *
     * @param mixed $module The id or name of the module
     *
     * @return void
     */
    function hasModuleAccess($module)
    {
        $filename = PATH_INCLUDE_MODULE . $module . '/Main' . ucfirst($module) . '.php';
        if (file_exists($filename)) {
            require_once $filename;
            $module_class = 'Main'.ucfirst($module);
            $module_object = new $module_class;
            if ($module_object->isShared()) {
                return true;
            }
            if ($module_object->isRequired()) {
                return true;
            }
        }

        if (is_string($module)) {
            if (empty($this->modules)) {
                $result = $this->db->query("SELECT id, name FROM module WHERE active = 1");
                while ($row = $result->fetchRow(MDB2_FETCHMODE_ASSOC)) {
                    $this->modules[$row['name']] = $row['id'];

The property modules does not exist. Did you maybe forget to declare it?

                }
                $result->free();
            }

            if (!empty($this->modules[$module])) {
                $module_id = $this->modules[$module];
            } else {
                throw new Exception('intranet says invalid module name '.$module);
            }
        } else {
            $module_id = intval($module);
        }

        if (!empty($this->permissions)) {
            if (!empty($this->permissions['intranet']['module'][$module_id]) and $this->permissions['intranet']['module'][$module_id] == true) {

Using logical operators such as and instead of && is generally not recommended.

                return true;
            }
            return false;
        }

        $result = $this->db->query("SELECT module_id FROM permission WHERE intranet_id = ".$this->db->quote($this->id, 'integer')." AND user_id = 0");
        while ($row = $result->fetchRow(MDB2_FETCHMODE_ASSOC)) {
            $this->permissions['intranet']['module'][$row['module_id']] = true;
        }
        $result->free();

        if (!empty($this->permissions['intranet']['module'][$module_id]) and $this->permissions['intranet']['module'][$module_id] == true) {

Using logical operators such as and instead of && is generally not recommended.

            return true;
        }
        return false;
    }

    /**
     * Returns the id of the intranet
     *
     * @return integer
     */
    function getId()
    {
        return $this->id;
    }
}