Inspection of "fix term screen" - insideout10/wordlift-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bee9d7...e12ca1 )

by Naveen

created 2022-07-06 03:45 UTC

Status

Indentation +40 added lines, -40 removed lines patch added patch discarded remove patch

@@ -14,65 +14,65 @@
 block discarded – undo
  */
 class Term_Page_Hook {
 
-	const HANDLE = 'wl-vocabulary-term-page-handle';
+    const HANDLE = 'wl-vocabulary-term-page-handle';
 
-	const LOCALIZED_KEY = '_wlVocabularyTermPageSettings';
+    const LOCALIZED_KEY = '_wlVocabularyTermPageSettings';
 
-	private $term_data_factory;
+    private $term_data_factory;
 
-	/**
-	 * Term_Page_Hook constructor.
-	 *
-	 * @param $term_data_factory Term_Data_Factory
-	 */
-	public function __construct( $term_data_factory ) {
-		$this->term_data_factory = $term_data_factory;
-	}
+    /**
+     * Term_Page_Hook constructor.
+     *
+     * @param $term_data_factory Term_Data_Factory
+     */
+    public function __construct( $term_data_factory ) {
+        $this->term_data_factory = $term_data_factory;
+    }
 
-	public function connect_hook() {
-		$taxonomies = Terms_Compat::get_public_taxonomies();
-		foreach ( $taxonomies as $taxonomy ) {
-			add_action( "${taxonomy}_edit_form_fields", array( $this, 'load_scripts' ), 2, PHP_INT_MAX );
-		}
-	}
+    public function connect_hook() {
+        $taxonomies = Terms_Compat::get_public_taxonomies();
+        foreach ( $taxonomies as $taxonomy ) {
+            add_action( "${taxonomy}_edit_form_fields", array( $this, 'load_scripts' ), 2, PHP_INT_MAX );
+        }
+    }
 
-	/**
-	 * @param $term \WP_Term
-	 */
-	public function load_scripts( $term ) {
+    /**
+     * @param $term \WP_Term
+     */
+    public function load_scripts( $term ) {
 
-		$term_data = $this->term_data_factory->get_term_data( $term );
+        $term_data = $this->term_data_factory->get_term_data( $term );
 
-		Scripts_Helper::enqueue_based_on_wordpress_version(
-			self::HANDLE,
-			plugin_dir_url( dirname( dirname( __DIR__ ) ) ) . 'js/dist/vocabulary-term-page',
-			array( 'react', 'react-dom', 'wp-polyfill', 'wp-i18n' ),
-			true
-		);
+        Scripts_Helper::enqueue_based_on_wordpress_version(
+            self::HANDLE,
+            plugin_dir_url( dirname( dirname( __DIR__ ) ) ) . 'js/dist/vocabulary-term-page',
+            array( 'react', 'react-dom', 'wp-polyfill', 'wp-i18n' ),
+            true
+        );
 
-		wp_enqueue_style( self::HANDLE, plugin_dir_url( dirname( dirname( __DIR__ ) ) ) . 'js/dist/vocabulary-term-page.full.css' );
+        wp_enqueue_style( self::HANDLE, plugin_dir_url( dirname( dirname( __DIR__ ) ) ) . 'js/dist/vocabulary-term-page.full.css' );
 
 
-		$term_data_arr = $term_data->get_data();
+        $term_data_arr = $term_data->get_data();
 
-		$term_data_arr['entities'] = Entity_List_Utils::mark_is_active_for_entities( $term->term_id, $term_data_arr['entities'] );
+        $term_data_arr['entities'] = Entity_List_Utils::mark_is_active_for_entities( $term->term_id, $term_data_arr['entities'] );
 
-		wp_localize_script( self::HANDLE, self::LOCALIZED_KEY, array(
-			'termData'  => $term_data_arr,
-			'apiConfig' => Api_Config::get_api_config(),
-			'restUrl'   => get_rest_url( null, Api_Config::REST_NAMESPACE . '/search-entity/' ),
-			'nonce'     => wp_create_nonce( 'wp_rest' ),
-		) );
+        wp_localize_script( self::HANDLE, self::LOCALIZED_KEY, array(
+            'termData'  => $term_data_arr,
+            'apiConfig' => Api_Config::get_api_config(),
+            'restUrl'   => get_rest_url( null, Api_Config::REST_NAMESPACE . '/search-entity/' ),
+            'nonce'     => wp_create_nonce( 'wp_rest' ),
+        ) );
 
-		echo "<tr class=\"form-field\">
+        echo "<tr class=\"form-field\">
 				<th>Match</th>
 				<td style='width: 100%;' id='wl_vocabulary_terms_widget'></td>
 			</tr>";
 
-		echo "<tr class=\"form-field\">
+        echo "<tr class=\"form-field\">
 		     <th></th>
 		     <td id='wl_vocabulary_terms_autocomplete_select'></td></tr>";
 
-	}
+    }
 
 }

Please login to merge, or discard this patch.

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -25,44 +25,44 @@
 block discarded – undo
 	 *
 	 * @param $term_data_factory Term_Data_Factory
 	 */
-	public function __construct( $term_data_factory ) {
+	public function __construct($term_data_factory) {
 		$this->term_data_factory = $term_data_factory;
 	}
 
 	public function connect_hook() {
 		$taxonomies = Terms_Compat::get_public_taxonomies();
-		foreach ( $taxonomies as $taxonomy ) {
-			add_action( "${taxonomy}_edit_form_fields", array( $this, 'load_scripts' ), 2, PHP_INT_MAX );
+		foreach ($taxonomies as $taxonomy) {
+			add_action("${taxonomy}_edit_form_fields", array($this, 'load_scripts'), 2, PHP_INT_MAX);
 		}
 	}
 
 	/**
 	 * @param $term \WP_Term
 	 */
-	public function load_scripts( $term ) {
+	public function load_scripts($term) {
 
-		$term_data = $this->term_data_factory->get_term_data( $term );
+		$term_data = $this->term_data_factory->get_term_data($term);
 
 		Scripts_Helper::enqueue_based_on_wordpress_version(
 			self::HANDLE,
-			plugin_dir_url( dirname( dirname( __DIR__ ) ) ) . 'js/dist/vocabulary-term-page',
-			array( 'react', 'react-dom', 'wp-polyfill', 'wp-i18n' ),
+			plugin_dir_url(dirname(dirname(__DIR__))).'js/dist/vocabulary-term-page',
+			array('react', 'react-dom', 'wp-polyfill', 'wp-i18n'),
 			true
 		);
 
-		wp_enqueue_style( self::HANDLE, plugin_dir_url( dirname( dirname( __DIR__ ) ) ) . 'js/dist/vocabulary-term-page.full.css' );
+		wp_enqueue_style(self::HANDLE, plugin_dir_url(dirname(dirname(__DIR__))).'js/dist/vocabulary-term-page.full.css');
 
 
 		$term_data_arr = $term_data->get_data();
 
-		$term_data_arr['entities'] = Entity_List_Utils::mark_is_active_for_entities( $term->term_id, $term_data_arr['entities'] );
+		$term_data_arr['entities'] = Entity_List_Utils::mark_is_active_for_entities($term->term_id, $term_data_arr['entities']);
 
-		wp_localize_script( self::HANDLE, self::LOCALIZED_KEY, array(
+		wp_localize_script(self::HANDLE, self::LOCALIZED_KEY, array(
 			'termData'  => $term_data_arr,
 			'apiConfig' => Api_Config::get_api_config(),
-			'restUrl'   => get_rest_url( null, Api_Config::REST_NAMESPACE . '/search-entity/' ),
-			'nonce'     => wp_create_nonce( 'wp_rest' ),
-		) );
+			'restUrl'   => get_rest_url(null, Api_Config::REST_NAMESPACE.'/search-entity/'),
+			'nonce'     => wp_create_nonce('wp_rest'),
+		));
 
 		echo "<tr class=\"form-field\">
 				<th>Match</th>

Please login to merge, or discard this patch.

		@@ -14,65 +14,65 @@
		block discarded – undo
14	14	*/
15	15	class Term_Page_Hook {
16	16
17		- const HANDLE = 'wl-vocabulary-term-page-handle';
	17	+ const HANDLE = 'wl-vocabulary-term-page-handle';
18	18
19		- const LOCALIZED_KEY = '_wlVocabularyTermPageSettings';
	19	+ const LOCALIZED_KEY = '_wlVocabularyTermPageSettings';
20	20
21		- private $term_data_factory;
	21	+ private $term_data_factory;
22	22
23		- /**
24		- * Term_Page_Hook constructor.
25		- *
26		- * @param $term_data_factory Term_Data_Factory
27		- */
28		- public function __construct( $term_data_factory ) {
29		- $this->term_data_factory = $term_data_factory;
30		- }
	23	+ /**
	24	+ * Term_Page_Hook constructor.
	25	+ *
	26	+ * @param $term_data_factory Term_Data_Factory
	27	+ */
	28	+ public function __construct( $term_data_factory ) {
	29	+ $this->term_data_factory = $term_data_factory;
	30	+ }
31	31
32		- public function connect_hook() {
33		- $taxonomies = Terms_Compat::get_public_taxonomies();
34		- foreach ( $taxonomies as $taxonomy ) {
35		- add_action( "${taxonomy}_edit_form_fields", array( $this, 'load_scripts' ), 2, PHP_INT_MAX );
36		- }
37		- }
	32	+ public function connect_hook() {
	33	+ $taxonomies = Terms_Compat::get_public_taxonomies();
	34	+ foreach ( $taxonomies as $taxonomy ) {
	35	+ add_action( "${taxonomy}_edit_form_fields", array( $this, 'load_scripts' ), 2, PHP_INT_MAX );
	36	+ }
	37	+ }
38	38
39		- /**
40		- * @param $term \WP_Term
41		- */
42		- public function load_scripts( $term ) {
	39	+ /**
	40	+ * @param $term \WP_Term
	41	+ */
	42	+ public function load_scripts( $term ) {
43	43
44		- $term_data = $this->term_data_factory->get_term_data( $term );
	44	+ $term_data = $this->term_data_factory->get_term_data( $term );
45	45
46		- Scripts_Helper::enqueue_based_on_wordpress_version(
47		- self::HANDLE,
48		- plugin_dir_url( dirname( dirname( __DIR__ ) ) ) . 'js/dist/vocabulary-term-page',
49		- array( 'react', 'react-dom', 'wp-polyfill', 'wp-i18n' ),
50		- true
51		- );
	46	+ Scripts_Helper::enqueue_based_on_wordpress_version(
	47	+ self::HANDLE,
	48	+ plugin_dir_url( dirname( dirname( __DIR__ ) ) ) . 'js/dist/vocabulary-term-page',
	49	+ array( 'react', 'react-dom', 'wp-polyfill', 'wp-i18n' ),
	50	+ true
	51	+ );
52	52
53		- wp_enqueue_style( self::HANDLE, plugin_dir_url( dirname( dirname( __DIR__ ) ) ) . 'js/dist/vocabulary-term-page.full.css' );
	53	+ wp_enqueue_style( self::HANDLE, plugin_dir_url( dirname( dirname( __DIR__ ) ) ) . 'js/dist/vocabulary-term-page.full.css' );
54	54
55	55
56		- $term_data_arr = $term_data->get_data();
	56	+ $term_data_arr = $term_data->get_data();
57	57
58		- $term_data_arr['entities'] = Entity_List_Utils::mark_is_active_for_entities( $term->term_id, $term_data_arr['entities'] );
	58	+ $term_data_arr['entities'] = Entity_List_Utils::mark_is_active_for_entities( $term->term_id, $term_data_arr['entities'] );
59	59
60		- wp_localize_script( self::HANDLE, self::LOCALIZED_KEY, array(
61		- 'termData' => $term_data_arr,
62		- 'apiConfig' => Api_Config::get_api_config(),
63		- 'restUrl' => get_rest_url( null, Api_Config::REST_NAMESPACE . '/search-entity/' ),
64		- 'nonce' => wp_create_nonce( 'wp_rest' ),
65		- ) );
	60	+ wp_localize_script( self::HANDLE, self::LOCALIZED_KEY, array(
	61	+ 'termData' => $term_data_arr,
	62	+ 'apiConfig' => Api_Config::get_api_config(),
	63	+ 'restUrl' => get_rest_url( null, Api_Config::REST_NAMESPACE . '/search-entity/' ),
	64	+ 'nonce' => wp_create_nonce( 'wp_rest' ),
	65	+ ) );
66	66
67		- echo "<tr class=\"form-field\">
	67	+ echo "<tr class=\"form-field\">
68	68	<th>Match</th>
69	69	<td style='width: 100%;' id='wl_vocabulary_terms_widget'></td>
70	70	</tr>";
71	71
72		- echo "<tr class=\"form-field\">
	72	+ echo "<tr class=\"form-field\">
73	73	<th></th>
74	74	<td id='wl_vocabulary_terms_autocomplete_select'></td></tr>";
75	75
76		- }
	76	+ }
77	77
78	78	}

		@@ -25,44 +25,44 @@
		block discarded – undo
25	25	*
26	26	* @param $term_data_factory Term_Data_Factory
27	27	*/
28		- public function __construct( $term_data_factory ) {
	28	+ public function __construct($term_data_factory) {
29	29	$this->term_data_factory = $term_data_factory;
30	30	}
31	31
32	32	public function connect_hook() {
33	33	$taxonomies = Terms_Compat::get_public_taxonomies();
34		- foreach ( $taxonomies as $taxonomy ) {
35		- add_action( "${taxonomy}_edit_form_fields", array( $this, 'load_scripts' ), 2, PHP_INT_MAX );
	34	+ foreach ($taxonomies as $taxonomy) {
	35	+ add_action("${taxonomy}_edit_form_fields", array($this, 'load_scripts'), 2, PHP_INT_MAX);
36	36	}
37	37	}
38	38
39	39	/**
40	40	* @param $term \WP_Term
41	41	*/
42		- public function load_scripts( $term ) {
	42	+ public function load_scripts($term) {
43	43
44		- $term_data = $this->term_data_factory->get_term_data( $term );
	44	+ $term_data = $this->term_data_factory->get_term_data($term);
45	45
46	46	Scripts_Helper::enqueue_based_on_wordpress_version(
47	47	self::HANDLE,
48		- plugin_dir_url( dirname( dirname( __DIR__ ) ) ) . 'js/dist/vocabulary-term-page',
49		- array( 'react', 'react-dom', 'wp-polyfill', 'wp-i18n' ),
	48	+ plugin_dir_url(dirname(dirname(__DIR__))).'js/dist/vocabulary-term-page',
	49	+ array('react', 'react-dom', 'wp-polyfill', 'wp-i18n'),
50	50	true
51	51	);
52	52
53		- wp_enqueue_style( self::HANDLE, plugin_dir_url( dirname( dirname( __DIR__ ) ) ) . 'js/dist/vocabulary-term-page.full.css' );
	53	+ wp_enqueue_style(self::HANDLE, plugin_dir_url(dirname(dirname(__DIR__))).'js/dist/vocabulary-term-page.full.css');
54	54
55	55
56	56	$term_data_arr = $term_data->get_data();
57	57
58		- $term_data_arr['entities'] = Entity_List_Utils::mark_is_active_for_entities( $term->term_id, $term_data_arr['entities'] );
	58	+ $term_data_arr['entities'] = Entity_List_Utils::mark_is_active_for_entities($term->term_id, $term_data_arr['entities']);
59	59
60		- wp_localize_script( self::HANDLE, self::LOCALIZED_KEY, array(
	60	+ wp_localize_script(self::HANDLE, self::LOCALIZED_KEY, array(
61	61	'termData' => $term_data_arr,
62	62	'apiConfig' => Api_Config::get_api_config(),
63		- 'restUrl' => get_rest_url( null, Api_Config::REST_NAMESPACE . '/search-entity/' ),
64		- 'nonce' => wp_create_nonce( 'wp_rest' ),
65		- ) );
	63	+ 'restUrl' => get_rest_url(null, Api_Config::REST_NAMESPACE.'/search-entity/'),
	64	+ 'nonce' => wp_create_nonce('wp_rest'),
	65	+ ));
66	66
67	67	echo "<tr class=\"form-field\">
68	68	<th>Match</th>

insideout10 / wordlift-plugin

Push — master ( bee9d7...e12ca1 )

Status

Category

Indentation +40 added lines, -40 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch