Inspection of "Merge pull request #104 from inshore/develop" - inshore/bookwhen - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 2c9072...01edf2 )

by Daniel

created 2023-04-26 13:24 UTC

Status

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

@@ -276,7 +276,7 @@  discard block
 block discarded – undo
         if (!$this->validator->validInclude($includeAttachments)) {
             throw new ValidationException('includeAttachments', $includeAttachments);
         } else {
-            if($includeAttachments) {
+            if ($includeAttachments) {
                 array_push($this->includes, 'attachments');
             }
         }
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
         if (!$this->validator->validInclude($includeLocation)) {
             throw new ValidationException('includeLocation', $includeLocation);
         } else {
-            if($includeLocation) {
+            if ($includeLocation) {
                 array_push($this->includes, 'location');
             }
         }
@@ -294,7 +294,7 @@  discard block
 block discarded – undo
         if (!$this->validator->validInclude($includeTickets)) {
             throw new ValidationException('includeTickets', $includeTickets);
         } else {
-            if($includeTickets) {
+            if ($includeTickets) {
                 array_push($this->includes, 'tickets');
             }
         }
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
         if (!$this->validator->validInclude($includeTicketsEvents)) {
             throw new ValidationException('includeTicketsEvents', $includeTicketsEvents);
         } else {
-            if($includeTicketsEvents) {
+            if ($includeTicketsEvents) {
                 array_push($this->includes, 'tickets.events');
             }
         }
@@ -312,7 +312,7 @@  discard block
 block discarded – undo
         if (!$this->validator->validInclude($includeTicketsClassPasses)) {
             throw new ValidationException('includeTicketsClassPasses', $includeTicketsClassPasses);
         } else {
-            if($includeTicketsClassPasses) {
+            if ($includeTicketsClassPasses) {
                 array_push($this->includes, 'tickets.class_passes');
             }
         }
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
 
         // eventTickets
         $eventTickets = [];
-        foreach($event->tickets as $ticket) {
+        foreach ($event->tickets as $ticket) {
             array_push($eventTickets, new Ticket(
                 $ticket->available,
                 $ticket->availableFrom,
@@ -420,7 +420,7 @@  discard block
 block discarded – undo
                 throw new ValidationException('detail', implode(' ', $detail));
             } else {
                 $detail = array_unique($detail);
-                foreach($detail as $item) {
+                foreach ($detail as $item) {
                     if (!$this->validator->validLocation($item)) {
                         throw new ValidationException('detail', $item);
                     }
@@ -447,7 +447,7 @@  discard block
 block discarded – undo
                 throw new ValidationException('location', implode(' ', $title));
             } else {
                 $location = array_unique($location);
-                foreach($location as $item) {
+                foreach ($location as $item) {
                     if (!$this->validator->validLocation($item)) {
                         throw new ValidationException('location', $item);
                     }
@@ -477,7 +477,7 @@  discard block
 block discarded – undo
                 throw new ValidationException('title', implode(' ', $title));
             } else {
                 $title = array_unique($title);
-                foreach($title as $item) {
+                foreach ($title as $item) {
                     if (!$this->validator->validTitle($item)) {
                         throw new ValidationException('title', $item);
                     }
@@ -499,7 +499,7 @@  discard block
 block discarded – undo
         if (!$this->validator->validInclude($includeAttachments)) {
             throw new ValidationException('includeAttachments', $includeAttachments);
         } else {
-            if($includeAttachments) {
+            if ($includeAttachments) {
                 array_push($this->includes, 'attachments');
             }
         }
@@ -508,7 +508,7 @@  discard block
 block discarded – undo
         if (!$this->validator->validInclude($includeLocation)) {
             throw new ValidationException('includeLocation', $includeLocation);
         } else {
-            if($includeLocation) {
+            if ($includeLocation) {
                 array_push($this->includes, 'location');
             }
         }
@@ -517,7 +517,7 @@  discard block
 block discarded – undo
         if (!$this->validator->validInclude($includeTickets)) {
             throw new ValidationException('includeTickets', $includeTickets);
         } else {
-            if($includeTickets) {
+            if ($includeTickets) {
                 array_push($this->includes, 'tickets');
             }
         }
@@ -526,7 +526,7 @@  discard block
 block discarded – undo
         if (!$this->validator->validInclude($includeTicketsEvents)) {
             throw new ValidationException('includeTicketsEvents', $includeTicketsEvents);
         } else {
-            if($includeTicketsEvents) {
+            if ($includeTicketsEvents) {
                 array_push($this->includes, 'tickets.events');
             }
         }
@@ -535,7 +535,7 @@  discard block
 block discarded – undo
         if (!$this->validator->validInclude($includeTicketsClassPasses)) {
             throw new ValidationException('includeTicketsClassPasses', $includeTicketsClassPasses);
         } else {
-            if($includeTicketsClassPasses) {
+            if ($includeTicketsClassPasses) {
                 array_push($this->includes, 'tickets.class_passes');
             }
         }
@@ -545,7 +545,7 @@  discard block
 block discarded – undo
         foreach ($events->data as $event) {
 
             $eventTickets = [];
-            foreach($event->tickets as $ticket) {
+            foreach ($event->tickets as $ticket) {
                 array_push($eventTickets, new Ticket(
                     $ticket->available,
                     $ticket->availableFrom,
@@ -706,7 +706,7 @@  discard block
 block discarded – undo
             throw new ValidationException('includeClassPasses', $includeClassPasses);
         }
             
-        if($includeClassPasses) {
+        if ($includeClassPasses) {
             array_push($this->includes, 'class_passes');
         }
 
@@ -714,7 +714,7 @@  discard block
 block discarded – undo
         if (!$this->validator->validInclude($includeEvents)) {
             throw new ValidationException('includeEvents', $includeEvents);
         }
-        if($includeEvents) {
+        if ($includeEvents) {
             array_push($this->includes, 'events');
         }
 
@@ -722,7 +722,7 @@  discard block
 block discarded – undo
         if (!$this->validator->validInclude($includeEventsAttachments)) {
             throw new ValidationException('includeEventssAttachments', $includeEventsAttachments);
         }
-        if($includeEventsAttachments) {
+        if ($includeEventsAttachments) {
             array_push($this->includes, 'events.attachments');
         }
 
@@ -730,7 +730,7 @@  discard block
 block discarded – undo
         if (!$this->validator->validInclude($includeEventsLocation)) {
             throw new ValidationException('includeEventsLocation', $includeEventsLocation);
         }
-        if($includeEventsLocation) {
+        if ($includeEventsLocation) {
             array_push($this->includes, 'events.location');
         }
 
@@ -738,7 +738,7 @@  discard block
 block discarded – undo
         if (!$this->validator->validInclude($includeEventsTickets)) {
             throw new ValidationException('includeEventsTickets', $includeEventsTickets);
         }
-        if($includeEventsTickets) {
+        if ($includeEventsTickets) {
             array_push($this->includes, 'events.tickets');
         }
 
@@ -786,7 +786,7 @@  discard block
 block discarded – undo
             throw new ValidationException('includeClassPasses', $includeClassPasses);
         }
         
-        if($includeClassPasses) {
+        if ($includeClassPasses) {
             array_push($this->includes, 'class_passes');
         }
         
@@ -795,7 +795,7 @@  discard block
 block discarded – undo
             throw new ValidationException('includeEvents', $includeEvents);
         }
         
-        if($includeEvents) {
+        if ($includeEvents) {
             array_push($this->includes, 'events');
         }
         
@@ -804,7 +804,7 @@  discard block
 block discarded – undo
             throw new ValidationException('includeEventssAttachments', $includeEventsAttachments);
         }
         
-        if($includeEventsAttachments) {
+        if ($includeEventsAttachments) {
             array_push($this->includes, 'events.attachments');
         }
         
@@ -813,7 +813,7 @@  discard block
 block discarded – undo
             throw new ValidationException('includeEventsLocation', $includeEventsLocation);
         }
         
-        if($includeEventsLocation) {
+        if ($includeEventsLocation) {
             array_push($this->includes, 'events.location');
         }
         
@@ -822,7 +822,7 @@  discard block
 block discarded – undo
             throw new ValidationException('includeEventsTickets', $includeEventsTickets);
         }
         
-        if($includeEventsTickets) {
+        if ($includeEventsTickets) {
             array_push($this->includes, 'events.tickets');
         }
 

Please login to merge, or discard this patch.

src/Interfaces/ValidatorInterface.php 1 patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -136,9 +136,9 @@
 block discarded – undo
     public function validusageType(string $usageType): bool;
 
         /**
-     * @param int $useRestrictedForDays
-     * @return bool
-     */
+         * @param int $useRestrictedForDays
+         * @return bool
+         */
     public function validUseRestrictedForDays(int $useRestrictedForDays): bool;
 
 }

Please login to merge, or discard this patch.

		@@ -136,9 +136,9 @@
		block discarded – undo
136	136	public function validusageType(string $usageType): bool;
137	137
138	138	/**
139		- * @param int $useRestrictedForDays
140		- * @return bool
141		- */
	139	+ * @param int $useRestrictedForDays
	140	+ * @return bool
	141	+ */
142	142	public function validUseRestrictedForDays(int $useRestrictedForDays): bool;
143	143
144	144	}

		@@ -276,7 +276,7 @@ discard block
		block discarded – undo
276	276	if (!$this->validator->validInclude($includeAttachments)) {
277	277	throw new ValidationException('includeAttachments', $includeAttachments);
278	278	} else {
279		- if($includeAttachments) {
	279	+ if ($includeAttachments) {
280	280	array_push($this->includes, 'attachments');
281	281	}
282	282	}
		@@ -285,7 +285,7 @@ discard block
		block discarded – undo
285	285	if (!$this->validator->validInclude($includeLocation)) {
286	286	throw new ValidationException('includeLocation', $includeLocation);
287	287	} else {
288		- if($includeLocation) {
	288	+ if ($includeLocation) {
289	289	array_push($this->includes, 'location');
290	290	}
291	291	}
		@@ -294,7 +294,7 @@ discard block
		block discarded – undo
294	294	if (!$this->validator->validInclude($includeTickets)) {
295	295	throw new ValidationException('includeTickets', $includeTickets);
296	296	} else {
297		- if($includeTickets) {
	297	+ if ($includeTickets) {
298	298	array_push($this->includes, 'tickets');
299	299	}
300	300	}
		@@ -303,7 +303,7 @@ discard block
		block discarded – undo
303	303	if (!$this->validator->validInclude($includeTicketsEvents)) {
304	304	throw new ValidationException('includeTicketsEvents', $includeTicketsEvents);
305	305	} else {
306		- if($includeTicketsEvents) {
	306	+ if ($includeTicketsEvents) {
307	307	array_push($this->includes, 'tickets.events');
308	308	}
309	309	}
		@@ -312,7 +312,7 @@ discard block
		block discarded – undo
312	312	if (!$this->validator->validInclude($includeTicketsClassPasses)) {
313	313	throw new ValidationException('includeTicketsClassPasses', $includeTicketsClassPasses);
314	314	} else {
315		- if($includeTicketsClassPasses) {
	315	+ if ($includeTicketsClassPasses) {
316	316	array_push($this->includes, 'tickets.class_passes');
317	317	}
318	318	}
		@@ -338,7 +338,7 @@ discard block
		block discarded – undo
338	338
339	339	// eventTickets
340	340	$eventTickets = [];
341		- foreach($event->tickets as $ticket) {
	341	+ foreach ($event->tickets as $ticket) {
342	342	array_push($eventTickets, new Ticket(
343	343	$ticket->available,
344	344	$ticket->availableFrom,
		@@ -420,7 +420,7 @@ discard block
		block discarded – undo
420	420	throw new ValidationException('detail', implode(' ', $detail));
421	421	} else {
422	422	$detail = array_unique($detail);
423		- foreach($detail as $item) {
	423	+ foreach ($detail as $item) {
424	424	if (!$this->validator->validLocation($item)) {
425	425	throw new ValidationException('detail', $item);
426	426	}
		@@ -447,7 +447,7 @@ discard block
		block discarded – undo
447	447	throw new ValidationException('location', implode(' ', $title));
448	448	} else {
449	449	$location = array_unique($location);
450		- foreach($location as $item) {
	450	+ foreach ($location as $item) {
451	451	if (!$this->validator->validLocation($item)) {
452	452	throw new ValidationException('location', $item);
453	453	}
		@@ -477,7 +477,7 @@ discard block
		block discarded – undo
477	477	throw new ValidationException('title', implode(' ', $title));
478	478	} else {
479	479	$title = array_unique($title);
480		- foreach($title as $item) {
	480	+ foreach ($title as $item) {
481	481	if (!$this->validator->validTitle($item)) {
482	482	throw new ValidationException('title', $item);
483	483	}
		@@ -499,7 +499,7 @@ discard block
		block discarded – undo
499	499	if (!$this->validator->validInclude($includeAttachments)) {
500	500	throw new ValidationException('includeAttachments', $includeAttachments);
501	501	} else {
502		- if($includeAttachments) {
	502	+ if ($includeAttachments) {
503	503	array_push($this->includes, 'attachments');
504	504	}
505	505	}
		@@ -508,7 +508,7 @@ discard block
		block discarded – undo
508	508	if (!$this->validator->validInclude($includeLocation)) {
509	509	throw new ValidationException('includeLocation', $includeLocation);
510	510	} else {
511		- if($includeLocation) {
	511	+ if ($includeLocation) {
512	512	array_push($this->includes, 'location');
513	513	}
514	514	}
		@@ -517,7 +517,7 @@ discard block
		block discarded – undo
517	517	if (!$this->validator->validInclude($includeTickets)) {
518	518	throw new ValidationException('includeTickets', $includeTickets);
519	519	} else {
520		- if($includeTickets) {
	520	+ if ($includeTickets) {
521	521	array_push($this->includes, 'tickets');
522	522	}
523	523	}
		@@ -526,7 +526,7 @@ discard block
		block discarded – undo
526	526	if (!$this->validator->validInclude($includeTicketsEvents)) {
527	527	throw new ValidationException('includeTicketsEvents', $includeTicketsEvents);
528	528	} else {
529		- if($includeTicketsEvents) {
	529	+ if ($includeTicketsEvents) {
530	530	array_push($this->includes, 'tickets.events');
531	531	}
532	532	}
		@@ -535,7 +535,7 @@ discard block
		block discarded – undo
535	535	if (!$this->validator->validInclude($includeTicketsClassPasses)) {
536	536	throw new ValidationException('includeTicketsClassPasses', $includeTicketsClassPasses);
537	537	} else {
538		- if($includeTicketsClassPasses) {
	538	+ if ($includeTicketsClassPasses) {
539	539	array_push($this->includes, 'tickets.class_passes');
540	540	}
541	541	}
		@@ -545,7 +545,7 @@ discard block
		block discarded – undo
545	545	foreach ($events->data as $event) {
546	546
547	547	$eventTickets = [];
548		- foreach($event->tickets as $ticket) {
	548	+ foreach ($event->tickets as $ticket) {
549	549	array_push($eventTickets, new Ticket(
550	550	$ticket->available,
551	551	$ticket->availableFrom,
		@@ -706,7 +706,7 @@ discard block
		block discarded – undo
706	706	throw new ValidationException('includeClassPasses', $includeClassPasses);
707	707	}
708	708
709		- if($includeClassPasses) {
	709	+ if ($includeClassPasses) {
710	710	array_push($this->includes, 'class_passes');
711	711	}
712	712
		@@ -714,7 +714,7 @@ discard block
		block discarded – undo
714	714	if (!$this->validator->validInclude($includeEvents)) {
715	715	throw new ValidationException('includeEvents', $includeEvents);
716	716	}
717		- if($includeEvents) {
	717	+ if ($includeEvents) {
718	718	array_push($this->includes, 'events');
719	719	}
720	720
		@@ -722,7 +722,7 @@ discard block
		block discarded – undo
722	722	if (!$this->validator->validInclude($includeEventsAttachments)) {
723	723	throw new ValidationException('includeEventssAttachments', $includeEventsAttachments);
724	724	}
725		- if($includeEventsAttachments) {
	725	+ if ($includeEventsAttachments) {
726	726	array_push($this->includes, 'events.attachments');
727	727	}
728	728
		@@ -730,7 +730,7 @@ discard block
		block discarded – undo
730	730	if (!$this->validator->validInclude($includeEventsLocation)) {
731	731	throw new ValidationException('includeEventsLocation', $includeEventsLocation);
732	732	}
733		- if($includeEventsLocation) {
	733	+ if ($includeEventsLocation) {
734	734	array_push($this->includes, 'events.location');
735	735	}
736	736
		@@ -738,7 +738,7 @@ discard block
		block discarded – undo
738	738	if (!$this->validator->validInclude($includeEventsTickets)) {
739	739	throw new ValidationException('includeEventsTickets', $includeEventsTickets);
740	740	}
741		- if($includeEventsTickets) {
	741	+ if ($includeEventsTickets) {
742	742	array_push($this->includes, 'events.tickets');
743	743	}
744	744
		@@ -786,7 +786,7 @@ discard block
		block discarded – undo
786	786	throw new ValidationException('includeClassPasses', $includeClassPasses);
787	787	}
788	788
789		- if($includeClassPasses) {
	789	+ if ($includeClassPasses) {
790	790	array_push($this->includes, 'class_passes');
791	791	}
792	792
		@@ -795,7 +795,7 @@ discard block
		block discarded – undo
795	795	throw new ValidationException('includeEvents', $includeEvents);
796	796	}
797	797
798		- if($includeEvents) {
	798	+ if ($includeEvents) {
799	799	array_push($this->includes, 'events');
800	800	}
801	801
		@@ -804,7 +804,7 @@ discard block
		block discarded – undo
804	804	throw new ValidationException('includeEventssAttachments', $includeEventsAttachments);
805	805	}
806	806
807		- if($includeEventsAttachments) {
	807	+ if ($includeEventsAttachments) {
808	808	array_push($this->includes, 'events.attachments');
809	809	}
810	810
		@@ -813,7 +813,7 @@ discard block
		block discarded – undo
813	813	throw new ValidationException('includeEventsLocation', $includeEventsLocation);
814	814	}
815	815
816		- if($includeEventsLocation) {
	816	+ if ($includeEventsLocation) {
817	817	array_push($this->includes, 'events.location');
818	818	}
819	819
		@@ -822,7 +822,7 @@ discard block
		block discarded – undo
822	822	throw new ValidationException('includeEventsTickets', $includeEventsTickets);
823	823	}
824	824
825		- if($includeEventsTickets) {
	825	+ if ($includeEventsTickets) {
826	826	array_push($this->includes, 'events.tickets');
827	827	}
828	828

inshore / bookwhen

Push — master ( 2c9072...01edf2 )

Status

Category

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch