DeliveryProvider::getCity() - Code Metrics - Inspection of "fix" - injitools/cms-Inji - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 51d55d...1c8811 )

by Alexey

created 2017-11-22 12:34 UTC

DeliveryProvider::getCity() A

↳ Parent: DeliveryProvider

Complexity

Conditions	4
Paths	8

Size

Total Lines	15
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	11
nc	8
nop	1
dl	0
loc	15
rs	9.2
c	0
b	0
f	0

<?php
/**
 * INJI
 *
 * @author Alexey Krupskiy <[email protected]>
 * @link http://inji.ru/
 * @copyright 2017 Alexey Krupskiy
 * @license https://github.com/injitools/Inji/blob/master/LICENSE
 */

namespace Ecommerce;


class DeliveryProvider {
    static $name = 'Unnamed';
class A {
    var $property;
}

    static function calcPrice($cart) {

        return new \Money\Sums([]);
    }

    static function deliveryTime($cart) {

        return [
            'min' => 0,
            'max' => 0
        ];
    }

    static function config() {

        $provider = \Ecommerce\Delivery\Provider::get((new \ReflectionClass(get_called_class()))->getShortName(), 'object');
        $config = [];
        foreach ($provider->configs as $item) {
            $config[$item->name] = $item->value;
        }
        return $config;
    }

    static function availablePayTypeGroups($cart) {

        return ['*'];
    }

    /**
     * @param \Ecommerce\Cart $cart
     * @return bool|\Ecommerce\Delivery\Field\Item
     */
    static function getCity($cart) {

        $fieldInfo = \Ecommerce\UserAdds\Field::get('deliveryfield_city', 'code');
        $field = \Ecommerce\Delivery\Field::get('city', 'code');
        $cityItem = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (isset($cart->infos[$fieldInfo->id])) {
            $itemId = $cart->infos[$fieldInfo->id]->value;
        }
        if (isset($cart->deliveryInfos[$field->id])) {
            $itemId = $cart->deliveryInfos[$field->id]->value;
        }
        if (!empty($itemId)) {
            return \Ecommerce\Delivery\Field\Item::get([['id', $itemId], ['delivery_field_id', $field->id]]);
        }
        return false;
    }
}

1			<?php
2			/**
3			* INJI
4			*
5			* @author Alexey Krupskiy <[email protected]>
6			* @link http://inji.ru/
7			* @copyright 2017 Alexey Krupskiy
8			* @license https://github.com/injitools/Inji/blob/master/LICENSE
9			*/
10
11			namespace Ecommerce;
12
13
14			class DeliveryProvider {
15			static $name = 'Unnamed';
			0 ignored issues – show Coding Style introduced 2017-08-16 04:07 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$name`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
16
17			static function calcPrice($cart) {
			0 ignored issues – show Best Practice introduced 2017-08-16 04:07 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
18			return new \Money\Sums([]);
19			}
20
21			static function deliveryTime($cart) {
			0 ignored issues – show Best Practice introduced 2017-11-16 09:16 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
22			return [
23			'min' => 0,
24			'max' => 0
25			];
26			}
27
28			static function config() {
			0 ignored issues – show Best Practice introduced 2017-11-20 13:25 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
29			$provider = \Ecommerce\Delivery\Provider::get((new \ReflectionClass(get_called_class()))->getShortName(), 'object');
30			$config = [];
31			foreach ($provider->configs as $item) {
32			$config[$item->name] = $item->value;
33			}
34			return $config;
35			}
36
37			static function availablePayTypeGroups($cart) {
			0 ignored issues – show Best Practice introduced 2017-11-20 13:25 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
38			return ['*'];
39			}
40
41			/**
42			* @param \Ecommerce\Cart $cart
43			* @return bool\|\Ecommerce\Delivery\Field\Item
44			*/
45			static function getCity($cart) {
			0 ignored issues – show Best Practice introduced 2017-11-22 12:44 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
46			$fieldInfo = \Ecommerce\UserAdds\Field::get('deliveryfield_city', 'code');
47			$field = \Ecommerce\Delivery\Field::get('city', 'code');
48			$cityItem = null;
			0 ignored issues – show Unused Code introduced 2017-11-22 12:44 UTC by Report Bug Copy Issue Report `$cityItem` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
49			if (isset($cart->infos[$fieldInfo->id])) {
50			$itemId = $cart->infos[$fieldInfo->id]->value;
51			}
52			if (isset($cart->deliveryInfos[$field->id])) {
53			$itemId = $cart->deliveryInfos[$field->id]->value;
54			}
55			if (!empty($itemId)) {
56			return \Ecommerce\Delivery\Field\Item::get([['id', $itemId], ['delivery_field_id', $field->id]]);
57			}
58			return false;
59			}
60			}

injitools / cms-Inji

Push — master ( 51d55d...1c8811 )

DeliveryProvider::getCity() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like