Ecommerce\DeliveryProvider

Complexity

Total Complexity

9

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	7

Importance

Changes	1
Bugs	1	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	calcPrice()	0	3	1
A	deliveryTime()	0	6	1
A	config()	0	8	2
A	availablePayTypeGroups()	0	3	1
A	getCity()	0	15	4

<?php
/**
 * INJI
 *
 * @author Alexey Krupskiy <admin@inji.ru>
 * @link http://inji.ru/
 * @copyright 2017 Alexey Krupskiy
 * @license https://github.com/injitools/Inji/blob/master/LICENSE
 */

namespace Ecommerce;


class DeliveryProvider {
    static $name = 'Unnamed';

The visibility should be declared for property $name.

    static function calcPrice($cart) {

It is generally recommended to explicitly declare the visibility for methods.

        return new \Money\Sums([]);
    }

    static function deliveryTime($cart) {

It is generally recommended to explicitly declare the visibility for methods.

        return [
            'min' => 0,
            'max' => 0
        ];
    }

    static function config() {

It is generally recommended to explicitly declare the visibility for methods.

        $provider = \Ecommerce\Delivery\Provider::get((new \ReflectionClass(get_called_class()))->getShortName(), 'object');
        $config = [];
        foreach ($provider->configs as $item) {
            $config[$item->name] = $item->value;
        }
        return $config;
    }

    static function availablePayTypeGroups($cart) {

It is generally recommended to explicitly declare the visibility for methods.

        return ['*'];
    }

    /**
     * @param \Ecommerce\Cart $cart
     * @return bool|\Ecommerce\Delivery\Field\Item
     */
    static function getCity($cart) {

It is generally recommended to explicitly declare the visibility for methods.

        $fieldInfo = \Ecommerce\UserAdds\Field::get('deliveryfield_city', 'code');
        $field = \Ecommerce\Delivery\Field::get('city', 'code');
        $cityItem = null;

$cityItem is not used, you could remove the assignment.

        if (isset($cart->infos[$fieldInfo->id])) {
            $itemId = $cart->infos[$fieldInfo->id]->value;
        }
        if (isset($cart->deliveryInfos[$field->id])) {
            $itemId = $cart->deliveryInfos[$field->id]->value;
        }
        if (!empty($itemId)) {
            return \Ecommerce\Delivery\Field\Item::get([['id', $itemId], ['delivery_field_id', $field->id]]);
        }
        return false;
    }
}