ingeniasoftware / luthier

src/Core/Route.php

Doc Comments +12 added lines, -18 removed lines

@@ -110,7 +110,6 @@ 
      * Generic method to add a improved route
      *
      * @param  mixed $verb String or array of string of valid HTTP Verbs that will be accepted in this route
-     * @param  mixed $url String or array of strings that will trigger this route
      * @param  array $attr Associative array of route attributes
      * @param  bool $hideOriginal (Optional) map the original $url as a route with a show_404() callback inside
      *
@@ -267,7 +266,7 @@ 
     /**
      * Adds a GET route, alias of Route::add('GET',$url,$attr,$hideOriginal)
      *
-     * @param  mixed $url String or array of strings that will trigger this route
+     * @param  string $url String or array of strings that will trigger this route
      * @param  array $attr Associative array of route attributes
      * @param  bool $hideOriginal (Optional) map the original $url as a route with a show_404() callback inside
      *
@@ -284,7 +283,7 @@ 
     /**
      * Adds a POST route, alias of Route::add('POST',$url,$attr,$hideOriginal)
      *
-     * @param  mixed $url String or array of strings that will trigger this route
+     * @param  string $url String or array of strings that will trigger this route
      * @param  array $attr Associative array of route attributes
      * @param  bool $hideOriginal (Optional) map the original $url as a route with a show_404() callback inside
      *
@@ -335,7 +334,7 @@ 
     /**
      * Adds a DELETE route, alias of Route::add('DELETE',$url,$attr,$hideOriginal)
      *
-     * @param  mixed $url String or array of strings that will trigger this route
+     * @param  string $url String or array of strings that will trigger this route
      * @param  array $attr Associative array of route attributes
      * @param  bool $hideOriginal (Optional) map the original $url as a route with a show_404() callback inside
      *
@@ -373,8 +372,8 @@ 
     /**
      * Adds a list of routes with the verbs contained in $verbs, alias of Route::add($verbs,$url,$attr,$hideOriginal)
      *
-     * @param  mixed $verb String or array of string of valid HTTP Verbs that will be accepted in this route
-     * @param  mixed $url String or array of strings that will trigger this route
+     * @param  string[] $verbs String or array of string of valid HTTP Verbs that will be accepted in this route
+     * @param  string $url String or array of strings that will trigger this route
      * @param  array $attr Associative array of route attributes
      * @param  bool $hideOriginal (Optional) map the original $url as a route with a show_404() callback inside
      *
@@ -408,7 +407,6 @@ 
      *
      * PLEASE NOTE: This is NOT a crud generator, just a bundle of predefined routes.
      *
-     * @param  string $url String or array of strings that will trigger this route
      * @param  string $controller Controller name (only controller name)
      * @param  array $attr Associative array of route attributes
      *
@@ -716,10 +714,6 @@ 
     /**
      * Creates the 'default_controller' key in CodeIgniter's route array
      *
-     * @param  string $route controller/method name
-     * @param  string $alias (Optional) alias of the default controller
-     *
-     * Due a CodeIgniter limitations, this route MAY NOT be a directory.
      *
      * @return void
      *
@@ -775,7 +769,7 @@ 
     /**
      * Get all hidden routes
      *
-     * @return array
+     * @return Route
      *
      * @access public
      * @static
@@ -791,7 +785,7 @@ 
      * This middleware actually works as uri filter since they will not check the route,
      * just check if the current uri string matches the prefix of the route group.
      *
-     * @return array
+     * @return Route
      *
      * @access public
      * @static
@@ -869,8 +863,9 @@ 
      *  This is the 'reverse' process of the improved routing, it'll take the current
      *  uri string and attempts to find a CodeIgniter route that matches with his pattern
      *
-     * @param  string $search
      *
+     * @param Middleware $path
+     * @param string $requestMethod
      * @return mixed
      */
     public static function getRouteByPath($path, $requestMethod = NULL)
@@ -947,7 +942,7 @@ 
     /**
      * Returns an array with the valid HTTP Verbs used in routes
      *
-     * @return array
+     * @return Route
      *
      * @access public
      * @static
@@ -961,7 +956,6 @@ 
      * Set the 404 error controller ($route['404_override'])
      *
      * @param  string  $controller
-     * @param  string  $namespace (Optional)
      *
      * @return void
      *
@@ -980,9 +974,9 @@ 
     /**
      * Get the 404 route
      *
-     * @return array $_404page
+     * @return Route $_404page
      *
-     * @return object | null
+     * @return Route | null
      *
      * @access public
      * @static

Spacing +113 added lines, -113 removed lines

@@ -121,17 +121,17 @@ 
      */
     public static function add($verb, $path, $attr, $hideOriginal = TRUE, $return = FALSE)
     {
-        if(!is_array($attr))
+        if (!is_array($attr))
         {
-            show_error('You must specify the route attributes as an array',500,'Route error: bad attributes');
+            show_error('You must specify the route attributes as an array', 500, 'Route error: bad attributes');
         }
 
-        if(!isset($attr['uses']))
+        if (!isset($attr['uses']))
         {
             show_error('Route requires a \'controller@method\' to be pointed and it\'s not defined in the route attributes', 500, 'Route error: missing controller');
         }
 
-        if(!preg_match('/^([a-zA-Z1-9-_]+)@([a-zA-Z1-9-_]+)$/', $attr['uses'], $parsedController) !== FALSE)
+        if (!preg_match('/^([a-zA-Z1-9-_]+)@([a-zA-Z1-9-_]+)$/', $attr['uses'], $parsedController) !== FALSE)
         {
             show_error('Route controller must be in format controller@method', 500, 'Route error: bad controller format');
         }
@@ -140,34 +140,34 @@ 
         $controller = $parsedController[1];
         $method     = $parsedController[2];
 
-        if(!is_string($path))
+        if (!is_string($path))
             show_error('Route path must be a string ', 500, 'Route error: bad route path');
 
-        if(!is_string($verb))
+        if (!is_string($verb))
             show_error('Route HTTP Verb must be a string', 500, 'Route error: bad verb type');
 
         $verb = strtoupper($verb);
 
-        if(!in_array($verb, self::$http_verbs,TRUE))
+        if (!in_array($verb, self::$http_verbs, TRUE))
         {
             $errorMsg = 'Verb "'.$verb.'" is not a valid HTTP Verb, allowed verbs:<ul>';
-            foreach( self::$http_verbs as $validVerb )
+            foreach (self::$http_verbs as $validVerb)
             {
                 $errorMsg .= '<li>'.$validVerb.'</li>';
             }
             $errorMsg .= '</ul>';
-            show_error($errorMsg,500,'Route error: unknow method');
+            show_error($errorMsg, 500, 'Route error: unknow method');
         }
 
         $route['verb'] = $verb;
 
-        $path = trim($path,'/');
+        $path = trim($path, '/');
 
         $route['path']       = $path;
         $route['controller'] = $controller;
         $route['method']     = $method;
 
-        if(isset($attr['as']))
+        if (isset($attr['as']))
         {
             $route['name'] = $attr['as'];
         }
@@ -181,10 +181,10 @@ 
         $route['prefix'] = NULL;
         $group_prefix = end(self::$prefix);
 
-        if($group_prefix)
+        if ($group_prefix)
             $route['prefix'] = $group_prefix.'/';
 
-        if(isset($attr['prefix']))
+        if (isset($attr['prefix']))
             $route['prefix'] .= $attr['prefix'];
 
         // Setting up the namespace
@@ -192,36 +192,36 @@ 
         $route['namespace'] = NULL;
         $group_namespace = end(self::$namespace);
 
-        if(!is_null($group_namespace))
+        if (!is_null($group_namespace))
             $route['namespace'] = $group_namespace.'/';
-        if(isset($attr['namespace']))
+        if (isset($attr['namespace']))
             $route['namespace'] .= $attr['namespace'];
 
         $route['prefix']    = trim($route['prefix'], '/');
-        $route['namespace'] = trim($route['namespace'],'/');
+        $route['namespace'] = trim($route['namespace'], '/');
 
-        if(empty($route['prefix']))
+        if (empty($route['prefix']))
             $route['prefix'] = NULL;
 
-        if(empty($route['namespace']))
+        if (empty($route['namespace']))
             $route['namespace'] = NULL;
 
         $route['middleware'] = array();
 
-        if(isset($attr['middleware']))
+        if (isset($attr['middleware']))
         {
-            if(is_array($attr['middleware']))
+            if (is_array($attr['middleware']))
             {
-                foreach($attr['middleware'] as $middleware)
+                foreach ($attr['middleware'] as $middleware)
                     $route['middleware'][] = $middleware; # Group
             }
-            elseif( is_string($attr['middleware']))
+            elseif (is_string($attr['middleware']))
             {
                 $route['middleware'][] = $attr['middleware']; # Group
             }
             else
             {
-                show_error('Route middleware must be a string or an array',500,'Route error: bad middleware format');
+                show_error('Route middleware must be a string or an array', 500, 'Route error: bad middleware format');
             }
         }
 
@@ -234,27 +234,27 @@ 
 
         $groupHideOriginals = end(self::$hideOriginals);
 
-        if($hideOriginal || $groupHideOriginals || ($compiledRoute->path != '' && $compiledRoute->path != '/' ) )
+        if ($hideOriginal || $groupHideOriginals || ($compiledRoute->path != '' && $compiledRoute->path != '/'))
         {
             $hiddenRoutePath      = $controller.'/'.$method;
             $hiddenRouteNamespace = '';
 
-            if(!is_null($route['namespace']))
+            if (!is_null($route['namespace']))
             {
                 $hiddenRouteNamespace = $route['namespace'].'/';
             }
 
             $hiddenRoutePath = $hiddenRouteNamespace.$hiddenRoutePath;
 
-            if($method == 'index')
+            if ($method == 'index')
             {
-                self::$hiddenRoutes[] = [ $hiddenRouteNamespace.$controller  => function(){ show_404(); }];
+                self::$hiddenRoutes[] = [$hiddenRouteNamespace.$controller  => function() { show_404(); }];
             }
 
-            self::$hiddenRoutes[] = [$hiddenRoutePath => function(){ show_404(); }];
+            self::$hiddenRoutes[] = [$hiddenRoutePath => function() { show_404(); }];
         }
 
-        if(!$return)
+        if (!$return)
         {
             self::$routes[] = (object) $route;
         }
@@ -278,7 +278,7 @@ 
      */
     public static function get($url, $attr, $hideOriginal = TRUE)
     {
-        self::add('GET', $url,$attr, $hideOriginal);
+        self::add('GET', $url, $attr, $hideOriginal);
     }
 
     /**
@@ -295,7 +295,7 @@ 
      */
     public static function post($url, $attr, $hideOriginal = TRUE)
     {
-        self::add('POST', $url,$attr, $hideOriginal);
+        self::add('POST', $url, $attr, $hideOriginal);
     }
 
     /**
@@ -312,7 +312,7 @@ 
      */
     public static function put($url, $attr, $hideOriginal = TRUE)
     {
-        self::add('PUT', $url,$attr, $hideOriginal);
+        self::add('PUT', $url, $attr, $hideOriginal);
     }
 
     /**
@@ -329,7 +329,7 @@ 
      */
     public static function patch($url, $attr, $hideOriginal = TRUE)
     {
-        self::add('PATCH', $url,$attr, $hideOriginal);
+        self::add('PATCH', $url, $attr, $hideOriginal);
     }
 
     /**
@@ -346,7 +346,7 @@ 
      */
     public static function delete($url, $attr, $hideOriginal = TRUE)
     {
-        self::add('DELETE', $url,$attr, $hideOriginal);
+        self::add('DELETE', $url, $attr, $hideOriginal);
     }
 
     /**
@@ -363,7 +363,7 @@ 
      */
     public static function any($url, $attr, $hideOriginal = TRUE)
     {
-        foreach(self::$http_verbs as $verb)
+        foreach (self::$http_verbs as $verb)
         {
             $verb = strtolower($verb);
             self::add($verb, $url, $attr, $hideOriginal);
@@ -385,10 +385,10 @@ 
      */
     public static function matches($verbs, $url, $attr, $hideOriginal = FALSE)
     {
-        if(!is_array($verbs))
+        if (!is_array($verbs))
             show_error('Route::matches() first argument must be an array of valid HTTP Verbs', 500, 'Route error: bad Route::matches() verb list');
 
-        foreach($verbs as $verb)
+        foreach ($verbs as $verb)
         {
             self::add($verb, $url, $attr, $hideOriginal);
         }
@@ -423,29 +423,29 @@ 
 
         $hideOriginal = FALSE;
 
-        if(isset($attr['namespace']))
+        if (isset($attr['namespace']))
             $base_attr['namespace']  = $attr['namespace'];
 
-        if(isset($attr['middleware']))
+        if (isset($attr['middleware']))
             $base_attr['middleware'] = $attr['middleware'];
 
-        if(isset($attr['hideOriginal']))
+        if (isset($attr['hideOriginal']))
             $hideOriginal = (bool) $attr['hideOriginal'];
 
         $base_attr['prefix'] = strtolower($name);
 
-        if(isset($attr['prefix']))
-            $base_attr['prefix']  = $attr['prefix'];
+        if (isset($attr['prefix']))
+            $base_attr['prefix'] = $attr['prefix'];
 
         $only = array();
 
         $controller = strtolower($controller);
 
-        if(isset($attr['only']) && (is_array($attr['only']) || is_string($attr['only'])))
+        if (isset($attr['only']) && (is_array($attr['only']) || is_string($attr['only'])))
         {
-            if(is_array($attr['only']))
+            if (is_array($attr['only']))
             {
-                $only  = $attr['only'];
+                $only = $attr['only'];
             }
             else
             {
@@ -453,43 +453,43 @@ 
             }
         }
 
-        if(empty($only) || in_array('index', $only))
+        if (empty($only) || in_array('index', $only))
         {
-            $route_attr = array_merge($base_attr, ['uses' => $controller.'@index',   'as' => $name.'.index']);
+            $route_attr = array_merge($base_attr, ['uses' => $controller.'@index', 'as' => $name.'.index']);
             self::get('/', $route_attr, $hideOriginal);
         }
 
-        if(empty($only) || in_array('create', $only))
+        if (empty($only) || in_array('create', $only))
         {
             $route_attr = array_merge($base_attr, ['uses' => $controller.'@create', 'as' => $name.'.create']);
             self::get('create', $route_attr, $hideOriginal);
         }
 
-        if(empty($only) || in_array('store', $only))
+        if (empty($only) || in_array('store', $only))
         {
             $route_attr = array_merge($base_attr, ['uses' => $controller.'@store', 'as' => $name.'.store']);
             self::post('/', $route_attr, $hideOriginal);
         }
 
-        if(empty($only) || in_array('show', $only))
+        if (empty($only) || in_array('show', $only))
         {
             $route_attr = array_merge($base_attr, ['uses' => $controller.'@show', 'as' => $name.'.show']);
             self::get('{slug}', $route_attr, $hideOriginal);
         }
 
-        if(empty($only) || in_array('edit', $only))
+        if (empty($only) || in_array('edit', $only))
         {
             $route_attr = array_merge($base_attr, ['uses' => $controller.'@edit', 'as' => $name.'.edit']);
             self::get('{slug}/edit', $route_attr, $hideOriginal);
         }
 
-        if(empty($only) || in_array('update', $only))
+        if (empty($only) || in_array('update', $only))
         {
             $route_attr = array_merge($base_attr, ['uses' => $controller.'@update', 'as' => $name.'.update']);
             self::matches(['PUT', 'PATCH'], '{slug}/update', $route_attr, $hideOriginal);
         }
 
-        if(empty($only) || in_array('destroy', $only))
+        if (empty($only) || in_array('destroy', $only))
         {
             $route_attr = array_merge($base_attr, ['uses' => $controller.'@destroy', 'as' => $name.'.destroy']);
             self::delete('{slug}', $route_attr, $hideOriginal);
@@ -511,19 +511,19 @@ 
         $prefix    = NULL;
         $namespace = NULL;
 
-        if(!is_null($route->prefix))
+        if (!is_null($route->prefix))
         {
             $prefix = $route->prefix;
         }
 
-        if(!is_null($route->namespace))
+        if (!is_null($route->namespace))
         {
             $namespace = $route->namespace;
         }
 
         $path = $route->path;
 
-        if(!is_null($prefix))
+        if (!is_null($prefix))
             $path = $prefix.'/'.$path;
 
         /*
@@ -533,15 +533,15 @@ 
 
         $controller = $route->controller.'/'.$route->method;
 
-        if(!is_null($namespace))
+        if (!is_null($namespace))
             $controller = $namespace.'/'.$controller;
 
-        $path       = trim($path,'/');
-        $controller = trim($controller,'/');
+        $path       = trim($path, '/');
+        $controller = trim($controller, '/');
 
         $replaces =
             [
-                '{\((.*)\):[a-zA-Z0-9-_]*(\?}|})' => '($1)',   # Custom regular expression
+                '{\((.*)\):[a-zA-Z0-9-_]*(\?}|})' => '($1)', # Custom regular expression
                 '{num:[a-zA-Z0-9-_]*(\?}|})'      => '(:num)', # (:num) route
                 '{any:[a-zA-Z0-9-_]*(\?}|})'      => '(:any)', # (:any) route
                 '{[a-zA-Z0-9-_]*(\?}|})'          => '(:any)', # Everything else
@@ -549,10 +549,10 @@ 
 
         $foundedArgs = [];
 
-        foreach($replaces as $regex => $replace)
+        foreach ($replaces as $regex => $replace)
         {
             $matches = [];
-            if(preg_match_all('/'.$regex.'/', $path, $matches ))
+            if (preg_match_all('/'.$regex.'/', $path, $matches))
             {
                 $foundedArgs = $matches[0];
             }
@@ -566,24 +566,24 @@ 
         $args['required'] = [];
         $args['optional'] = [];
 
-        foreach($foundedArgs as $arg)
+        foreach ($foundedArgs as $arg)
         {
-            if(substr($arg,-2) == '?}')
+            if (substr($arg, -2) == '?}')
             {
                 $args['optional'][] = $arg;
                 $argConstraint = TRUE;
             }
             else
             {
-                if($argConstraint)
+                if ($argConstraint)
                     show_error('Optional route path argument not valid at this position', 500, 'Route error');
                 $args['required'][] = $arg;
             }
         }
 
-        if(count($foundedArgs) > 0)
+        if (count($foundedArgs) > 0)
         {
-            for($i = 0; $i < count($foundedArgs); $i++)
+            for ($i = 0; $i < count($foundedArgs); $i++)
             {
                 $controller .= '/$'.($i + 1);
             }
@@ -608,11 +608,11 @@ 
     {
         $routes = array();
 
-        foreach(self::$routes as $index => $route)
+        foreach (self::$routes as $index => $route)
         {
             $compiled = self::compileRoute($route);
 
-            if( !isset($routes[$compiled->path]) || $route->verb == 'GET' )
+            if (!isset($routes[$compiled->path]) || $route->verb == 'GET')
             {
                 $routes[$compiled->path] = $compiled->route;
             }
@@ -620,16 +620,16 @@ 
             self::$routes[$index] = (object) $route;
         }
 
-        foreach(self::$hiddenRoutes as $route)
+        foreach (self::$hiddenRoutes as $route)
         {
             $path = key($route);
             $_404 = $route[$path];
 
-            if(!isset($routes[$path]))
+            if (!isset($routes[$path]))
                 $routes[$path] = $_404;
         }
 
-        if(is_null(self::$defaultController))
+        if (is_null(self::$defaultController))
             show_error('You must specify a home route: Route::home() as default controller!', 500, 'Route error: missing default controller');
 
         $defaultController = self::$defaultController->compiled;
@@ -637,7 +637,7 @@ 
 
         $routes['default_controller'] = $defaultController;
 
-        if(is_null(self::$_404page))
+        if (is_null(self::$_404page))
         {
             $routes['404_override'] = '';
         }
@@ -664,20 +664,20 @@ 
      */
     public static function group($attr, $routes)
     {
-        if(!is_array($attr))
+        if (!is_array($attr))
             show_error('Group attribute must be a valid array');
 
-        if(!isset($attr['prefix']))
+        if (!isset($attr['prefix']))
             show_error('You must specify an prefix!');
 
         self::$prefix[] = $attr['prefix'];
 
-        if(isset($attr['namespace']))
+        if (isset($attr['namespace']))
         {
             self::$namespace[] = $attr['namespace'];
         }
 
-        if(isset($attr['hideOriginals']) && $attr['hideOriginals'] === TRUE)
+        if (isset($attr['hideOriginals']) && $attr['hideOriginals'] === TRUE)
         {
             self::$hideOriginals[] = TRUE;
         }
@@ -686,18 +686,18 @@ 
             self::$hideOriginals[] = FALSE;
         }
 
-        if(isset($attr['middleware']))
+        if (isset($attr['middleware']))
         {
-            if(is_array($attr['middleware']) || is_string($attr['middleware']))
+            if (is_array($attr['middleware']) || is_string($attr['middleware']))
             {
-                if(is_array($attr['middleware']) && !empty($attr['middleware']))
+                if (is_array($attr['middleware']) && !empty($attr['middleware']))
                 {
-                    foreach($attr['middleware'] as $middleware)
-                        self::$groupMiddleware[] = [ $attr['prefix'] => $middleware ];
+                    foreach ($attr['middleware'] as $middleware)
+                        self::$groupMiddleware[] = [$attr['prefix'] => $middleware];
                 }
                 else
                 {
-                    self::$groupMiddleware[] = [ $attr['prefix'] => $attr['middleware'] ];
+                    self::$groupMiddleware[] = [$attr['prefix'] => $attr['middleware']];
                 }
             }
             else
@@ -734,16 +734,16 @@ 
                 'as'   => $as
             ];
 
-        if(!is_null($attr) && !is_array($attr))
-            show_error('Default controller attributes must be an array',500,'Route error: bad attribute type');
+        if (!is_null($attr) && !is_array($attr))
+            show_error('Default controller attributes must be an array', 500, 'Route error: bad attribute type');
 
-        if(!is_null($attr))
-            $routeAttr = array_merge($routeAttr,$attr);
+        if (!is_null($attr))
+            $routeAttr = array_merge($routeAttr, $attr);
 
-        if(isset($attr['prefix']))
-            show_error('Default controller may not have a prefix!',500,'Route error: prefix not allowed');
+        if (isset($attr['prefix']))
+            show_error('Default controller may not have a prefix!', 500, 'Route error: prefix not allowed');
 
-        self::$defaultController = self::$routes[] = self::add('GET', '/', ['uses' => $controller, 'as' => $as],TRUE, TRUE);
+        self::$defaultController = self::$routes[] = self::add('GET', '/', ['uses' => $controller, 'as' => $as], TRUE, TRUE);
     }
 
     /**
@@ -756,16 +756,16 @@ 
      */
     public static function getRoutes($verb = NULL)
     {
-        if(is_null($verb))
+        if (is_null($verb))
         {
             return self::$routes;
         }
         else
         {
             $routes = [];
-            foreach(self::$routes as $route)
+            foreach (self::$routes as $route)
             {
-                if($route->verb == $verb)
+                if ($route->verb == $verb)
                     $routes[] = $route;
             }
             return $routes;
@@ -819,45 +819,45 @@ 
         $args = func_get_args();
         unset($args[0]);
 
-        foreach(self::$routes as $route)
+        foreach (self::$routes as $route)
         {
-            if($route->name == $search)
+            if ($route->name == $search)
             {
                 $founded = $route;
             }
         }
 
-        if(!is_null($founded))
+        if (!is_null($founded))
         {
             $routeArgs        = self::compileRoute($founded)->args;
             $routeArgCount    = count($routeArgs['required']) + count($routeArgs['optional']);
             $routeReqArgCount = count($routeArgs['required']);
 
-            if(count($args) < $routeReqArgCount)
+            if (count($args) < $routeReqArgCount)
             {
                 $missingArgs = $routeReqArgCount - count($args);
                 throw new \Exception('Missing '.$missingArgs.' required argument'.($missingArgs != 1 ? 's' : '').' for route "'.$founded->name.'"');
             }
-            if(count($args) > $routeArgCount)
+            if (count($args) > $routeArgCount)
             {
                 throw new \Exception('The route "'.$founded->name.'" expects maximum '.$routeArgCount.' argument'.($routeArgCount != 1 ? 's' : '').', '.count($args).' provided');
             }
 
             $path = self::compileRoute($founded)->path;
 
-            foreach($args as $replacement)
+            foreach ($args as $replacement)
             {
                 $path = preg_replace('/\((.*?)\)/', $replacement, $path, 1);
             }
 
-            $argsLeft =  $routeArgCount - count($args);
+            $argsLeft = $routeArgCount - count($args);
 
-            for($i = $argsLeft; $i >= 0; $i--)
+            for ($i = $argsLeft; $i >= 0; $i--)
             {
                 $path = preg_replace('/\((.*?)\)/', '', $path, 1);
             }
 
-            return base_url(trim($path,'/'));
+            return base_url(trim($path, '/'));
         }
 
         throw new \Exception('The route "'.$search.'" is not defined');
@@ -875,12 +875,12 @@ 
      */
     public static function getRouteByPath($path, $requestMethod = NULL)
     {
-        if(is_null($requestMethod))
+        if (is_null($requestMethod))
             $requestMethod = $_SERVER['REQUEST_METHOD'];
 
         $routes = self::getRoutes($requestMethod);
 
-        if(empty($routes))
+        if (empty($routes))
             return FALSE;
 
         $founded = FALSE;
@@ -888,7 +888,7 @@ 
 
         $path = trim($path);
 
-        if($path == '')
+        if ($path == '')
             return self::$defaultController;
 
         $wildcards =
@@ -906,17 +906,17 @@ 
             ];
 
 
-        foreach( ['exact' , 'regex'] as $mode)
+        foreach (['exact', 'regex'] as $mode)
         {
-            foreach( [ $path, $path.'/index' ] as $findPath )
+            foreach ([$path, $path.'/index'] as $findPath)
             {
-                foreach($routes as $route)
+                foreach ($routes as $route)
                 {
                     $compiledPath = key($route->compiled);
 
-                    if($mode == 'exact')
+                    if ($mode == 'exact')
                     {
-                        if($findPath == $compiledPath)
+                        if ($findPath == $compiledPath)
                             return $route;
                     }
                     else
@@ -924,16 +924,16 @@ 
                         $e_findPath     = explode('/', $findPath);
                         $e_compiledPath = explode('/', $compiledPath);
 
-                        if( count($e_findPath) == count($e_compiledPath))
+                        if (count($e_findPath) == count($e_compiledPath))
                         {
                             $valid = TRUE;
-                            for($i = 0; $i < count($e_findPath); $i++)
+                            for ($i = 0; $i < count($e_findPath); $i++)
                             {
                                 $reg = preg_replace($wildcards, $replaces, $e_compiledPath[$i]);
 
                                 $valid = (bool) preg_match('#^'.$reg.'$#', $e_findPath[$i]);
                             }
-                            if($valid)
+                            if ($valid)
                                 return $route;
                         }
                     }

Braces +106 added lines, -86 removed lines

@@ -140,11 +140,13 @@ 
         $controller = $parsedController[1];
         $method     = $parsedController[2];
 
-        if(!is_string($path))
-            show_error('Route path must be a string ', 500, 'Route error: bad route path');
+        if(!is_string($path)) {
+                    show_error('Route path must be a string ', 500, 'Route error: bad route path');
+        }
 
-        if(!is_string($verb))
-            show_error('Route HTTP Verb must be a string', 500, 'Route error: bad verb type');
+        if(!is_string($verb)) {
+                    show_error('Route HTTP Verb must be a string', 500, 'Route error: bad verb type');
+        }
 
         $verb = strtoupper($verb);
 
@@ -170,8 +172,7 @@ 
         if(isset($attr['as']))
         {
             $route['name'] = $attr['as'];
-        }
-        else
+        } else
         {
             $route['name'] = NULL;
         }
@@ -181,30 +182,36 @@ 
         $route['prefix'] = NULL;
         $group_prefix = end(self::$prefix);
 
-        if($group_prefix)
-            $route['prefix'] = $group_prefix.'/';
+        if($group_prefix) {
+                    $route['prefix'] = $group_prefix.'/';
+        }
 
-        if(isset($attr['prefix']))
-            $route['prefix'] .= $attr['prefix'];
+        if(isset($attr['prefix'])) {
+                    $route['prefix'] .= $attr['prefix'];
+        }
 
         // Setting up the namespace
 
         $route['namespace'] = NULL;
         $group_namespace = end(self::$namespace);
 
-        if(!is_null($group_namespace))
-            $route['namespace'] = $group_namespace.'/';
-        if(isset($attr['namespace']))
-            $route['namespace'] .= $attr['namespace'];
+        if(!is_null($group_namespace)) {
+                    $route['namespace'] = $group_namespace.'/';
+        }
+        if(isset($attr['namespace'])) {
+                    $route['namespace'] .= $attr['namespace'];
+        }
 
         $route['prefix']    = trim($route['prefix'], '/');
         $route['namespace'] = trim($route['namespace'],'/');
 
-        if(empty($route['prefix']))
-            $route['prefix'] = NULL;
+        if(empty($route['prefix'])) {
+                    $route['prefix'] = NULL;
+        }
 
-        if(empty($route['namespace']))
-            $route['namespace'] = NULL;
+        if(empty($route['namespace'])) {
+                    $route['namespace'] = NULL;
+        }
 
         $route['middleware'] = array();
 
@@ -212,14 +219,14 @@ 
         {
             if(is_array($attr['middleware']))
             {
-                foreach($attr['middleware'] as $middleware)
-                    $route['middleware'][] = $middleware; # Group
-            }
-            elseif( is_string($attr['middleware']))
+                foreach($attr['middleware'] as $middleware) {
+                                    $route['middleware'][] = $middleware;
+                }
+                # Group
+            } elseif( is_string($attr['middleware']))
             {
                 $route['middleware'][] = $attr['middleware']; # Group
-            }
-            else
+            } else
             {
                 show_error('Route middleware must be a string or an array',500,'Route error: bad middleware format');
             }
@@ -257,8 +264,7 @@ 
         if(!$return)
         {
             self::$routes[] = (object) $route;
-        }
-        else
+        } else
         {
             return (object) $route;
         }
@@ -385,8 +391,9 @@ 
      */
     public static function matches($verbs, $url, $attr, $hideOriginal = FALSE)
     {
-        if(!is_array($verbs))
-            show_error('Route::matches() first argument must be an array of valid HTTP Verbs', 500, 'Route error: bad Route::matches() verb list');
+        if(!is_array($verbs)) {
+                    show_error('Route::matches() first argument must be an array of valid HTTP Verbs', 500, 'Route error: bad Route::matches() verb list');
+        }
 
         foreach($verbs as $verb)
         {
@@ -423,19 +430,23 @@ 
 
         $hideOriginal = FALSE;
 
-        if(isset($attr['namespace']))
-            $base_attr['namespace']  = $attr['namespace'];
+        if(isset($attr['namespace'])) {
+                    $base_attr['namespace']  = $attr['namespace'];
+        }
 
-        if(isset($attr['middleware']))
-            $base_attr['middleware'] = $attr['middleware'];
+        if(isset($attr['middleware'])) {
+                    $base_attr['middleware'] = $attr['middleware'];
+        }
 
-        if(isset($attr['hideOriginal']))
-            $hideOriginal = (bool) $attr['hideOriginal'];
+        if(isset($attr['hideOriginal'])) {
+                    $hideOriginal = (bool) $attr['hideOriginal'];
+        }
 
         $base_attr['prefix'] = strtolower($name);
 
-        if(isset($attr['prefix']))
-            $base_attr['prefix']  = $attr['prefix'];
+        if(isset($attr['prefix'])) {
+                    $base_attr['prefix']  = $attr['prefix'];
+        }
 
         $only = array();
 
@@ -446,8 +457,7 @@ 
             if(is_array($attr['only']))
             {
                 $only  = $attr['only'];
-            }
-            else
+            } else
             {
                 $only[] = $attr['only'];
             }
@@ -523,8 +533,9 @@ 
 
         $path = $route->path;
 
-        if(!is_null($prefix))
-            $path = $prefix.'/'.$path;
+        if(!is_null($prefix)) {
+                    $path = $prefix.'/'.$path;
+        }
 
         /*
         if(substr($path, 0, 1) == "/" && strlen($path) > 1)
@@ -533,8 +544,9 @@ 
 
         $controller = $route->controller.'/'.$route->method;
 
-        if(!is_null($namespace))
-            $controller = $namespace.'/'.$controller;
+        if(!is_null($namespace)) {
+                    $controller = $namespace.'/'.$controller;
+        }
 
         $path       = trim($path,'/');
         $controller = trim($controller,'/');
@@ -572,11 +584,11 @@ 
             {
                 $args['optional'][] = $arg;
                 $argConstraint = TRUE;
-            }
-            else
+            } else
             {
-                if($argConstraint)
-                    show_error('Optional route path argument not valid at this position', 500, 'Route error');
+                if($argConstraint) {
+                                    show_error('Optional route path argument not valid at this position', 500, 'Route error');
+                }
                 $args['required'][] = $arg;
             }
         }
@@ -625,12 +637,14 @@ 
             $path = key($route);
             $_404 = $route[$path];
 
-            if(!isset($routes[$path]))
-                $routes[$path] = $_404;
+            if(!isset($routes[$path])) {
+                            $routes[$path] = $_404;
+            }
         }
 
-        if(is_null(self::$defaultController))
-            show_error('You must specify a home route: Route::home() as default controller!', 500, 'Route error: missing default controller');
+        if(is_null(self::$defaultController)) {
+                    show_error('You must specify a home route: Route::home() as default controller!', 500, 'Route error: missing default controller');
+        }
 
         $defaultController = self::$defaultController->compiled;
         $defaultController = $defaultController[key($defaultController)];
@@ -640,8 +654,7 @@ 
         if(is_null(self::$_404page))
         {
             $routes['404_override'] = '';
-        }
-        else
+        } else
         {
             $routes['404_override'] = self::$_404page->controller;
         }
@@ -664,11 +677,13 @@ 
      */
     public static function group($attr, $routes)
     {
-        if(!is_array($attr))
-            show_error('Group attribute must be a valid array');
+        if(!is_array($attr)) {
+                    show_error('Group attribute must be a valid array');
+        }
 
-        if(!isset($attr['prefix']))
-            show_error('You must specify an prefix!');
+        if(!isset($attr['prefix'])) {
+                    show_error('You must specify an prefix!');
+        }
 
         self::$prefix[] = $attr['prefix'];
 
@@ -680,8 +695,7 @@ 
         if(isset($attr['hideOriginals']) && $attr['hideOriginals'] === TRUE)
         {
             self::$hideOriginals[] = TRUE;
-        }
-        else
+        } else
         {
             self::$hideOriginals[] = FALSE;
         }
@@ -692,15 +706,14 @@ 
             {
                 if(is_array($attr['middleware']) && !empty($attr['middleware']))
                 {
-                    foreach($attr['middleware'] as $middleware)
-                        self::$groupMiddleware[] = [ $attr['prefix'] => $middleware ];
-                }
-                else
+                    foreach($attr['middleware'] as $middleware) {
+                                            self::$groupMiddleware[] = [ $attr['prefix'] => $middleware ];
+                    }
+                } else
                 {
                     self::$groupMiddleware[] = [ $attr['prefix'] => $attr['middleware'] ];
                 }
-            }
-            else
+            } else
             {
                 show_error('Group middleware not valid');
             }
@@ -734,14 +747,17 @@ 
                 'as'   => $as
             ];
 
-        if(!is_null($attr) && !is_array($attr))
-            show_error('Default controller attributes must be an array',500,'Route error: bad attribute type');
+        if(!is_null($attr) && !is_array($attr)) {
+                    show_error('Default controller attributes must be an array',500,'Route error: bad attribute type');
+        }
 
-        if(!is_null($attr))
-            $routeAttr = array_merge($routeAttr,$attr);
+        if(!is_null($attr)) {
+                    $routeAttr = array_merge($routeAttr,$attr);
+        }
 
-        if(isset($attr['prefix']))
-            show_error('Default controller may not have a prefix!',500,'Route error: prefix not allowed');
+        if(isset($attr['prefix'])) {
+                    show_error('Default controller may not have a prefix!',500,'Route error: prefix not allowed');
+        }
 
         self::$defaultController = self::$routes[] = self::add('GET', '/', ['uses' => $controller, 'as' => $as],TRUE, TRUE);
     }
@@ -759,14 +775,14 @@ 
         if(is_null($verb))
         {
             return self::$routes;
-        }
-        else
+        } else
         {
             $routes = [];
             foreach(self::$routes as $route)
             {
-                if($route->verb == $verb)
-                    $routes[] = $route;
+                if($route->verb == $verb) {
+                                    $routes[] = $route;
+                }
             }
             return $routes;
         }
@@ -875,21 +891,24 @@ 
      */
     public static function getRouteByPath($path, $requestMethod = NULL)
     {
-        if(is_null($requestMethod))
-            $requestMethod = $_SERVER['REQUEST_METHOD'];
+        if(is_null($requestMethod)) {
+                    $requestMethod = $_SERVER['REQUEST_METHOD'];
+        }
 
         $routes = self::getRoutes($requestMethod);
 
-        if(empty($routes))
-            return FALSE;
+        if(empty($routes)) {
+                    return FALSE;
+        }
 
         $founded = FALSE;
         $matches = array();
 
         $path = trim($path);
 
-        if($path == '')
-            return self::$defaultController;
+        if($path == '') {
+                    return self::$defaultController;
+        }
 
         $wildcards =
             [
@@ -916,10 +935,10 @@ 
 
                     if($mode == 'exact')
                     {
-                        if($findPath == $compiledPath)
-                            return $route;
-                    }
-                    else
+                        if($findPath == $compiledPath) {
+                                                    return $route;
+                        }
+                    } else
                     {
                         $e_findPath     = explode('/', $findPath);
                         $e_compiledPath = explode('/', $compiledPath);
@@ -933,8 +952,9 @@ 
 
                                 $valid = (bool) preg_match('#^'.$reg.'$#', $e_findPath[$i]);
                             }
-                            if($valid)
-                                return $route;
+                            if($valid) {
+                                                            return $route;
+                            }
                         }
                     }
                 }