Luthier\Core\Route::compileRoute()

Complexity

Conditions	12
Paths	384

Size

Total Lines	89
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function compileRoute($route)
    {
        $prefix    = NULL;
        $namespace = NULL;

        if(!is_null($route->prefix))
        {
            $prefix = $route->prefix;
        }

        if(!is_null($route->namespace))
        {
            $namespace = $route->namespace;
        }

        $path = $route->path;

        if(!is_null($prefix))
            $path = $prefix.'/'.$path;

        /*

57% of this comment could be valid code. Did you maybe forget this after debugging?

        if(substr($path, 0, 1) == "/" && strlen($path) > 1)
            $path = substr($path,1);
        */

        $controller = $route->controller.'/'.$route->method;

        if(!is_null($namespace))
            $controller = $namespace.'/'.$controller;

        $path       = trim($path,'/');
        $controller = trim($controller,'/');

        $replaces =
            [
                '{\((.*)\):[a-zA-Z0-9-_]*(\?}|})' => '($1)',   # Custom regular expression
                '{num:[a-zA-Z0-9-_]*(\?}|})'      => '(:num)', # (:num) route

43% of this comment could be valid code. Did you maybe forget this after debugging?

                '{any:[a-zA-Z0-9-_]*(\?}|})'      => '(:any)', # (:any) route

43% of this comment could be valid code. Did you maybe forget this after debugging?

                '{[a-zA-Z0-9-_]*(\?}|})'          => '(:any)', # Everything else
            ];

        $foundedArgs = [];

        foreach($replaces as $regex => $replace)
        {
            $matches = [];
            if(preg_match_all('/'.$regex.'/', $path, $matches ))
            {
                $foundedArgs = $matches[0];
            }

            $path = preg_replace('/'.$regex.'/', $replace, $path);
        }

        $argConstraint = FALSE;

        $args = [];
        $args['required'] = [];
        $args['optional'] = [];

        foreach($foundedArgs as $arg)
        {
            if(substr($arg,-2) == '?}')
            {
                $args['optional'][] = $arg;
                $argConstraint = TRUE;
            }
            else
            {
                if($argConstraint)
                    show_error('Optional route path argument not valid at this position', 500, 'Route error');
                $args['required'][] = $arg;
            }
        }

        if(count($foundedArgs) > 0)
        {
            for($i = 0; $i < count($foundedArgs); $i++)

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            {
                $controller .= '/$'.($i + 1);
            }
        }

        return (object) [
            'path'  => $path,
            'route' => $controller,
            'args'  => $args,
        ];
    }

}