@@ -179,7 +179,7 @@ |
||
| 179 | 179 | * $view->set_filename($file); |
| 180 | 180 | * |
| 181 | 181 | * @param string view filename |
| 182 | - * @return View |
|
| 182 | + * @return Kohana_View_Model |
|
| 183 | 183 | * @throws Kohana_View_Exception |
| 184 | 184 | */ |
| 185 | 185 | public function set_filename($file) |
@@ -34,8 +34,7 @@ discard block |
||
| 34 | 34 | try |
| 35 | 35 | { |
| 36 | 36 | include 'kohana.view://'.$kohana_view_filename; |
| 37 | - } |
|
| 38 | - catch (Exception $e) |
|
| 37 | + } catch (Exception $e) |
|
| 39 | 38 | { |
| 40 | 39 | // Delete the output buffer |
| 41 | 40 | ob_end_clean(); |
@@ -59,8 +58,7 @@ discard block |
||
| 59 | 58 | try |
| 60 | 59 | { |
| 61 | 60 | return $this->render(); |
| 62 | - } |
|
| 63 | - catch (Exception $e) |
|
| 61 | + } catch (Exception $e) |
|
| 64 | 62 | { |
| 65 | 63 | // Display the exception message |
| 66 | 64 | Kohana_Exception::handler($e); |
@@ -16,8 +16,8 @@ |
||
| 16 | 16 | interface TemplateSpecifyingViewModel |
| 17 | 17 | { |
| 18 | 18 | |
| 19 | - /** |
|
| 20 | - * @return string |
|
| 21 | - */ |
|
| 22 | - public function getTemplateName(); |
|
| 19 | + /** |
|
| 20 | + * @return string |
|
| 21 | + */ |
|
| 22 | + public function getTemplateName(); |
|
| 23 | 23 | } |
@@ -18,61 +18,61 @@ |
||
| 18 | 18 | class ViewTemplateSelector |
| 19 | 19 | { |
| 20 | 20 | |
| 21 | - /** |
|
| 22 | - * @param ViewModel $view |
|
| 23 | - * |
|
| 24 | - * @return string |
|
| 25 | - */ |
|
| 26 | - public function getTemplateName(ViewModel $view) |
|
| 27 | - { |
|
| 28 | - if ($view instanceof TemplateSpecifyingViewModel) { |
|
| 29 | - return $this->validateSpecifiedTemplateName($view); |
|
| 30 | - } else { |
|
| 31 | - return $this->calculateTemplateFromClassName($view); |
|
| 32 | - } |
|
| 33 | - } |
|
| 21 | + /** |
|
| 22 | + * @param ViewModel $view |
|
| 23 | + * |
|
| 24 | + * @return string |
|
| 25 | + */ |
|
| 26 | + public function getTemplateName(ViewModel $view) |
|
| 27 | + { |
|
| 28 | + if ($view instanceof TemplateSpecifyingViewModel) { |
|
| 29 | + return $this->validateSpecifiedTemplateName($view); |
|
| 30 | + } else { |
|
| 31 | + return $this->calculateTemplateFromClassName($view); |
|
| 32 | + } |
|
| 33 | + } |
|
| 34 | 34 | |
| 35 | - /** |
|
| 36 | - * @param TemplateSpecifyingViewModel $view |
|
| 37 | - * |
|
| 38 | - * @return mixed |
|
| 39 | - * @throws \UnexpectedValueException if no template is provided |
|
| 40 | - */ |
|
| 41 | - protected function validateSpecifiedTemplateName(TemplateSpecifyingViewModel $view) |
|
| 42 | - { |
|
| 43 | - $template = $view->getTemplateName(); |
|
| 44 | - $view_class = get_class($view); |
|
| 45 | - if ( ! $template) { |
|
| 46 | - throw new \UnexpectedValueException( |
|
| 47 | - "$view_class::getTemplateName() must return a template name, empty value returned" |
|
| 48 | - ); |
|
| 49 | - } |
|
| 35 | + /** |
|
| 36 | + * @param TemplateSpecifyingViewModel $view |
|
| 37 | + * |
|
| 38 | + * @return mixed |
|
| 39 | + * @throws \UnexpectedValueException if no template is provided |
|
| 40 | + */ |
|
| 41 | + protected function validateSpecifiedTemplateName(TemplateSpecifyingViewModel $view) |
|
| 42 | + { |
|
| 43 | + $template = $view->getTemplateName(); |
|
| 44 | + $view_class = get_class($view); |
|
| 45 | + if ( ! $template) { |
|
| 46 | + throw new \UnexpectedValueException( |
|
| 47 | + "$view_class::getTemplateName() must return a template name, empty value returned" |
|
| 48 | + ); |
|
| 49 | + } |
|
| 50 | 50 | |
| 51 | - if ( ! is_string($template)) { |
|
| 52 | - $type = is_object($template) ? get_class($template) : gettype($template); |
|
| 53 | - throw new \UnexpectedValueException( |
|
| 54 | - "$view_class::getTemplateName() must return a string template name, $type value returned" |
|
| 55 | - ); |
|
| 56 | - } |
|
| 51 | + if ( ! is_string($template)) { |
|
| 52 | + $type = is_object($template) ? get_class($template) : gettype($template); |
|
| 53 | + throw new \UnexpectedValueException( |
|
| 54 | + "$view_class::getTemplateName() must return a string template name, $type value returned" |
|
| 55 | + ); |
|
| 56 | + } |
|
| 57 | 57 | |
| 58 | - return $template; |
|
| 59 | - } |
|
| 58 | + return $template; |
|
| 59 | + } |
|
| 60 | 60 | |
| 61 | - /** |
|
| 62 | - * @param ViewModel $view |
|
| 63 | - * |
|
| 64 | - * @return string |
|
| 65 | - */ |
|
| 66 | - protected function calculateTemplateFromClassName(ViewModel $view) |
|
| 67 | - { |
|
| 68 | - $template = preg_replace('/\\\\|_/', '/', get_class($view)); |
|
| 69 | - $template = preg_replace('/([a-z])([A-Z])/', '\1_\2', $template); |
|
| 70 | - $template = strtolower($template); |
|
| 71 | - if (substr($template, 0, 5) === 'view/') { |
|
| 72 | - $template = substr($template, 5); |
|
| 73 | - } |
|
| 61 | + /** |
|
| 62 | + * @param ViewModel $view |
|
| 63 | + * |
|
| 64 | + * @return string |
|
| 65 | + */ |
|
| 66 | + protected function calculateTemplateFromClassName(ViewModel $view) |
|
| 67 | + { |
|
| 68 | + $template = preg_replace('/\\\\|_/', '/', get_class($view)); |
|
| 69 | + $template = preg_replace('/([a-z])([A-Z])/', '\1_\2', $template); |
|
| 70 | + $template = strtolower($template); |
|
| 71 | + if (substr($template, 0, 5) === 'view/') { |
|
| 72 | + $template = substr($template, 5); |
|
| 73 | + } |
|
| 74 | 74 | |
| 75 | - return $template; |
|
| 76 | - } |
|
| 75 | + return $template; |
|
| 76 | + } |
|
| 77 | 77 | |
| 78 | 78 | } |
@@ -1,9 +1,9 @@ discard block |
||
| 1 | 1 | <?php |
| 2 | 2 | /** |
| 3 | - * @author Andrew Coulton <[email protected]> |
|
| 4 | - * @copyright 2015 inGenerator Ltd |
|
| 5 | - * @license http://kohanaframework.org/license |
|
| 6 | - */ |
|
| 3 | + * @author Andrew Coulton <[email protected]> |
|
| 4 | + * @copyright 2015 inGenerator Ltd |
|
| 5 | + * @license http://kohanaframework.org/license |
|
| 6 | + */ |
|
| 7 | 7 | |
| 8 | 8 | namespace Ingenerator\KohanaView; |
| 9 | 9 | |
@@ -17,10 +17,10 @@ discard block |
||
| 17 | 17 | interface ViewModel |
| 18 | 18 | { |
| 19 | 19 | |
| 20 | - /** |
|
| 21 | - * @param array $variables |
|
| 22 | - * @return void |
|
| 23 | - */ |
|
| 24 | - public function display(array $variables); |
|
| 20 | + /** |
|
| 21 | + * @param array $variables |
|
| 22 | + * @return void |
|
| 23 | + */ |
|
| 24 | + public function display(array $variables); |
|
| 25 | 25 | |
| 26 | 26 | } |
@@ -37,81 +37,81 @@ |
||
| 37 | 37 | */ |
| 38 | 38 | abstract class AbstractViewModel implements ViewModel |
| 39 | 39 | { |
| 40 | - /** |
|
| 41 | - * @var array The actual view data |
|
| 42 | - */ |
|
| 43 | - protected $variables = []; |
|
| 40 | + /** |
|
| 41 | + * @var array The actual view data |
|
| 42 | + */ |
|
| 43 | + protected $variables = []; |
|
| 44 | 44 | |
| 45 | - /** |
|
| 46 | - * @var string[] The names of the valid set of fields that must be passed to the display() method |
|
| 47 | - */ |
|
| 48 | - protected $expect_var_names = []; |
|
| 45 | + /** |
|
| 46 | + * @var string[] The names of the valid set of fields that must be passed to the display() method |
|
| 47 | + */ |
|
| 48 | + protected $expect_var_names = []; |
|
| 49 | 49 | |
| 50 | - public function __construct() |
|
| 51 | - { |
|
| 52 | - // Assign the expect_var_names to ensure that we don't accidentally start requiring compiled fields |
|
| 53 | - $this->expect_var_names = array_keys($this->variables); |
|
| 54 | - } |
|
| 50 | + public function __construct() |
|
| 51 | + { |
|
| 52 | + // Assign the expect_var_names to ensure that we don't accidentally start requiring compiled fields |
|
| 53 | + $this->expect_var_names = array_keys($this->variables); |
|
| 54 | + } |
|
| 55 | 55 | |
| 56 | - /** |
|
| 57 | - * Get field values |
|
| 58 | - * |
|
| 59 | - * @param string $name |
|
| 60 | - * |
|
| 61 | - * @return mixed |
|
| 62 | - */ |
|
| 63 | - public function __get($name) |
|
| 64 | - { |
|
| 65 | - if (array_key_exists($name, $this->variables)) { |
|
| 66 | - return $this->variables[$name]; |
|
| 67 | - } elseif (method_exists($this, 'var_'.$name)) { |
|
| 68 | - $method = 'var_'.$name; |
|
| 56 | + /** |
|
| 57 | + * Get field values |
|
| 58 | + * |
|
| 59 | + * @param string $name |
|
| 60 | + * |
|
| 61 | + * @return mixed |
|
| 62 | + */ |
|
| 63 | + public function __get($name) |
|
| 64 | + { |
|
| 65 | + if (array_key_exists($name, $this->variables)) { |
|
| 66 | + return $this->variables[$name]; |
|
| 67 | + } elseif (method_exists($this, 'var_'.$name)) { |
|
| 68 | + $method = 'var_'.$name; |
|
| 69 | 69 | |
| 70 | - return $this->$method(); |
|
| 71 | - } else { |
|
| 72 | - throw new \BadMethodCallException(static::class." does not define a '$name' field"); |
|
| 73 | - } |
|
| 74 | - } |
|
| 70 | + return $this->$method(); |
|
| 71 | + } else { |
|
| 72 | + throw new \BadMethodCallException(static::class." does not define a '$name' field"); |
|
| 73 | + } |
|
| 74 | + } |
|
| 75 | 75 | |
| 76 | - /** |
|
| 77 | - * @param string $name |
|
| 78 | - * @param mixed $value |
|
| 79 | - * |
|
| 80 | - * @throws \BadMethodCallException values cannot be assigned except with the display method |
|
| 81 | - */ |
|
| 82 | - public function __set($name, $value) |
|
| 83 | - { |
|
| 84 | - throw new \BadMethodCallException(static::class.' variables are read-only, cannot assign '.$name); |
|
| 85 | - } |
|
| 76 | + /** |
|
| 77 | + * @param string $name |
|
| 78 | + * @param mixed $value |
|
| 79 | + * |
|
| 80 | + * @throws \BadMethodCallException values cannot be assigned except with the display method |
|
| 81 | + */ |
|
| 82 | + public function __set($name, $value) |
|
| 83 | + { |
|
| 84 | + throw new \BadMethodCallException(static::class.' variables are read-only, cannot assign '.$name); |
|
| 85 | + } |
|
| 86 | 86 | |
| 87 | - /** |
|
| 88 | - * Set the data to be rendered in the view - note this does not actually render the view. |
|
| 89 | - * |
|
| 90 | - * @param array $variables |
|
| 91 | - */ |
|
| 92 | - public function display(array $variables) |
|
| 93 | - { |
|
| 94 | - $errors = []; |
|
| 95 | - $provided_variables = array_keys($variables); |
|
| 96 | - foreach (array_diff($provided_variables, $this->expect_var_names) as $unexpected_var) { |
|
| 97 | - if (method_exists($this, 'var_'.$unexpected_var)) { |
|
| 98 | - $errors[] = "'$unexpected_var' conflicts with ::var_$unexpected_var()"; |
|
| 99 | - } else { |
|
| 100 | - $errors[] = "'$unexpected_var' is not expected"; |
|
| 101 | - } |
|
| 102 | - } |
|
| 103 | - foreach (array_diff($this->expect_var_names, $provided_variables) as $missing_var) { |
|
| 104 | - $errors[] = "'$missing_var' is missing"; |
|
| 105 | - } |
|
| 87 | + /** |
|
| 88 | + * Set the data to be rendered in the view - note this does not actually render the view. |
|
| 89 | + * |
|
| 90 | + * @param array $variables |
|
| 91 | + */ |
|
| 92 | + public function display(array $variables) |
|
| 93 | + { |
|
| 94 | + $errors = []; |
|
| 95 | + $provided_variables = array_keys($variables); |
|
| 96 | + foreach (array_diff($provided_variables, $this->expect_var_names) as $unexpected_var) { |
|
| 97 | + if (method_exists($this, 'var_'.$unexpected_var)) { |
|
| 98 | + $errors[] = "'$unexpected_var' conflicts with ::var_$unexpected_var()"; |
|
| 99 | + } else { |
|
| 100 | + $errors[] = "'$unexpected_var' is not expected"; |
|
| 101 | + } |
|
| 102 | + } |
|
| 103 | + foreach (array_diff($this->expect_var_names, $provided_variables) as $missing_var) { |
|
| 104 | + $errors[] = "'$missing_var' is missing"; |
|
| 105 | + } |
|
| 106 | 106 | |
| 107 | - if ( ! empty($errors)) { |
|
| 108 | - throw new \InvalidArgumentException( |
|
| 109 | - "Invalid variables provided to ".static::class."::display()" |
|
| 110 | - ."\n - ".implode("\n - ", $errors) |
|
| 111 | - ); |
|
| 112 | - } |
|
| 107 | + if ( ! empty($errors)) { |
|
| 108 | + throw new \InvalidArgumentException( |
|
| 109 | + "Invalid variables provided to ".static::class."::display()" |
|
| 110 | + ."\n - ".implode("\n - ", $errors) |
|
| 111 | + ); |
|
| 112 | + } |
|
| 113 | 113 | |
| 114 | - $this->variables = $variables; |
|
| 115 | - } |
|
| 114 | + $this->variables = $variables; |
|
| 115 | + } |
|
| 116 | 116 | |
| 117 | 117 | } |