Completed
Pull Request — master (#60)
by amir
01:45
created
src/Commands/CheckCompact.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
     /**
21 21
      * Execute the console command.
22 22
      *
23
-     * @return void
23
+     * @return integer
24 24
      */
25 25
     public function handle()
26 26
     {
Please login to merge, or discard this patch.
Unused Use Statements   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,13 +3,13 @@
 block discarded – undo
3 3
 namespace Imanghafoori\LaravelMicroscope\Commands;
4 4
 
5 5
 use Illuminate\Console\Command;
6
-use Imanghafoori\LaravelMicroscope\Analyzers\Ifs;
6
+use Imanghafoori\LaravelMicroscope\Analyzers\ComposerJson;
7 7
 use Imanghafoori\LaravelMicroscope\Analyzers\FilePath;
8
-use Imanghafoori\LaravelMicroscope\SpyClasses\RoutePaths;
9 8
 use Imanghafoori\LaravelMicroscope\Analyzers\FunctionCall;
10
-use Imanghafoori\LaravelMicroscope\Analyzers\ComposerJson;
9
+use Imanghafoori\LaravelMicroscope\Analyzers\Ifs;
11 10
 use Imanghafoori\LaravelMicroscope\ErrorReporters\ErrorPrinter;
12 11
 use Imanghafoori\LaravelMicroscope\ErrorTypes\CompactCall;
12
+use Imanghafoori\LaravelMicroscope\SpyClasses\RoutePaths;
13 13
 
14 14
 class CheckCompact extends Command
15 15
 {
Please login to merge, or discard this patch.
src/Commands/CheckEarlyReturns.php 2 patches
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
     /**
28 28
      * Execute the console command.
29 29
      *
30
-     * @return mixed
30
+     * @return null|integer
31 31
      */
32 32
     public function handle()
33 33
     {
@@ -71,6 +71,9 @@  discard block
 block discarded – undo
71 71
         return app(ErrorPrinter::class)->hasErrors() ? 1 : 0;
72 72
     }
73 73
 
74
+    /**
75
+     * @param integer $tries
76
+     */
74 77
     private function fix($filePath, $tokens, $tries)
75 78
     {
76 79
         Refactor::saveTokens($filePath, $tokens, $this->option('test'));
@@ -88,6 +91,9 @@  discard block
 block discarded – undo
88 91
         return [$fixes, $tokens];
89 92
     }
90 93
 
94
+    /**
95
+     * @param integer $fixed
96
+     */
91 97
     private function printFinalMsg($fixed)
92 98
     {
93 99
         if ($fixed > 0) {
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,9 +3,9 @@
 block discarded – undo
3 3
 namespace Imanghafoori\LaravelMicroscope\Commands;
4 4
 
5 5
 use Illuminate\Console\Command;
6
+use Imanghafoori\LaravelMicroscope\Analyzers\ComposerJson;
6 7
 use Imanghafoori\LaravelMicroscope\Analyzers\FilePath;
7 8
 use Imanghafoori\LaravelMicroscope\Analyzers\Refactor;
8
-use Imanghafoori\LaravelMicroscope\Analyzers\ComposerJson;
9 9
 use Imanghafoori\LaravelMicroscope\ErrorReporters\ErrorPrinter;
10 10
 
11 11
 class CheckEarlyReturns extends Command
Please login to merge, or discard this patch.
src/Commands/CheckPsr4.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
      *
38 38
      * @param  ErrorPrinter  $errorPrinter
39 39
      *
40
-     * @return mixed
40
+     * @return integer
41 41
      */
42 42
     public function handle(ErrorPrinter $errorPrinter)
43 43
     {
@@ -57,6 +57,9 @@  discard block
 block discarded – undo
57 57
         return app(ErrorPrinter::class)->hasErrors() ? 1 : 0;
58 58
     }
59 59
 
60
+    /**
61
+     * @param ErrorPrinter $errorPrinter
62
+     */
60 63
     private function composerDumpIfNeeded($errorPrinter)
61 64
     {
62 65
         if ($errorPrinter->counts['badNamespace']) {
Please login to merge, or discard this patch.
src/Commands/CheckRoutes.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
      *
27 27
      * @param  ErrorPrinter  $errorPrinter
28 28
      *
29
-     * @return mixed
29
+     * @return integer
30 30
      */
31 31
     public function handle(ErrorPrinter $errorPrinter)
32 32
     {
@@ -62,6 +62,9 @@  discard block
 block discarded – undo
62 62
         return 'Error on route '.$msg;
63 63
     }
64 64
 
65
+    /**
66
+     * @param ErrorPrinter $errorPrinter
67
+     */
65 68
     private function checkRouteDefinitions($errorPrinter, $routes)
66 69
     {
67 70
         foreach ($routes as $route) {
Please login to merge, or discard this patch.
src/Commands/CheckViews.php 1 patch
Unused Use Statements   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -4,14 +4,14 @@
 block discarded – undo
4 4
 
5 5
 use Illuminate\Console\Command;
6 6
 use Illuminate\Support\Facades\View;
7
-use Imanghafoori\LaravelMicroscope\BladeFiles;
8
-use Imanghafoori\LaravelMicroscope\Analyzers\FilePath;
9
-use Imanghafoori\LaravelMicroscope\ErrorTypes\BladeFile;
10
-use Imanghafoori\LaravelMicroscope\SpyClasses\RoutePaths;
11 7
 use Imanghafoori\LaravelMicroscope\Analyzers\ComposerJson;
8
+use Imanghafoori\LaravelMicroscope\Analyzers\FilePath;
12 9
 use Imanghafoori\LaravelMicroscope\Analyzers\FunctionCall;
10
+use Imanghafoori\LaravelMicroscope\BladeFiles;
13 11
 use Imanghafoori\LaravelMicroscope\Checks\CheckViewFilesExistence;
14 12
 use Imanghafoori\LaravelMicroscope\ErrorReporters\ErrorPrinter;
13
+use Imanghafoori\LaravelMicroscope\ErrorTypes\BladeFile;
14
+use Imanghafoori\LaravelMicroscope\SpyClasses\RoutePaths;
15 15
 
16 16
 class CheckViews extends Command
17 17
 {
Please login to merge, or discard this patch.