Completed
Pull Request — master (#60)
by amir
01:45
created
src/Commands/CheckRoutes.php 2 patches
Unused Use Statements   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -3,15 +3,15 @@
 block discarded – undo
3 3
 namespace Imanghafoori\LaravelMicroscope\Commands;
4 4
 
5 5
 use Exception;
6
-use Illuminate\Support\Str;
7
-use Illuminate\Routing\Router;
8 6
 use Illuminate\Console\Command;
9
-use Imanghafoori\LaravelMicroscope\Psr4Classes;
7
+use Illuminate\Routing\Router;
8
+use Illuminate\Support\Str;
10 9
 use Imanghafoori\LaravelMicroscope\BladeFiles;
11
-use Imanghafoori\LaravelMicroscope\Traits\LogsErrors;
12 10
 use Imanghafoori\LaravelMicroscope\Checks\CheckRouteCalls;
13 11
 use Imanghafoori\LaravelMicroscope\Checks\RoutelessActions;
14 12
 use Imanghafoori\LaravelMicroscope\ErrorReporters\ErrorPrinter;
13
+use Imanghafoori\LaravelMicroscope\Psr4Classes;
14
+use Imanghafoori\LaravelMicroscope\Traits\LogsErrors;
15 15
 
16 16
 class CheckRoutes extends Command
17 17
 {
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
      *
27 27
      * @param  ErrorPrinter  $errorPrinter
28 28
      *
29
-     * @return mixed
29
+     * @return integer
30 30
      */
31 31
     public function handle(ErrorPrinter $errorPrinter)
32 32
     {
@@ -62,6 +62,9 @@  discard block
 block discarded – undo
62 62
         return 'Error on route '.$msg;
63 63
     }
64 64
 
65
+    /**
66
+     * @param ErrorPrinter $errorPrinter
67
+     */
65 68
     private function checkRouteDefinitions($errorPrinter, $routes)
66 69
     {
67 70
         foreach ($routes as $route) {
Please login to merge, or discard this patch.
src/Checks/ActionsComments.php 2 patches
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,8 +2,8 @@
 block discarded – undo
2 2
 
3 3
 namespace Imanghafoori\LaravelMicroscope\Checks;
4 4
 
5
-use Imanghafoori\LaravelMicroscope\Analyzers\Refactor;
6 5
 use Imanghafoori\LaravelMicroscope\Analyzers\ClassMethods;
6
+use Imanghafoori\LaravelMicroscope\Analyzers\Refactor;
7 7
 
8 8
 class ActionsComments extends RoutelessActions
9 9
 {
Please login to merge, or discard this patch.
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -28,6 +28,9 @@  discard block
 block discarded – undo
28 28
         }
29 29
     }
30 30
 
31
+    /**
32
+     * @param string $fullNamespace
33
+     */
31 34
     protected function checkActions($tokens, $fullNamespace, $path)
32 35
     {
33 36
         $class = ClassMethods::read($tokens);
@@ -73,6 +76,9 @@  discard block
 block discarded – undo
73 76
         return $routelessActions;
74 77
     }
75 78
 
79
+    /**
80
+     * @param \Illuminate\Routing\Route $r
81
+     */
76 82
     protected function getMsg($methods, $r)
77 83
     {
78 84
         $msg = '/** '."\n";
Please login to merge, or discard this patch.
src/Checks/ExtractBladePartial.php 2 patches
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -45,6 +45,9 @@  discard block
 block discarded – undo
45 45
         return $tokens;
46 46
     }
47 47
 
48
+    /**
49
+     * @param string $name
50
+     */
48 51
     public static function find($name)
49 52
     {
50 53
         if (self::hasHintInformation($name = trim($name))) {
@@ -61,6 +64,9 @@  discard block
 block discarded – undo
61 64
         }, ['blade.php']);
62 65
     }
63 66
 
67
+    /**
68
+     * @param string $name
69
+     */
64 70
     protected static function findNamespacedView($name)
65 71
     {
66 72
         [$namespace, $view] = self::parseNamespaceSegments($name);
@@ -95,11 +101,17 @@  discard block
 block discarded – undo
95 101
         }
96 102
     }
97 103
 
104
+    /**
105
+     * @param string $name
106
+     */
98 107
     public static function hasHintInformation($name)
99 108
     {
100 109
         return strpos($name, '::') > 0;
101 110
     }
102 111
 
112
+    /**
113
+     * @param string $message
114
+     */
103 115
     public static function forceFilePutContents($filepath, $message){
104 116
         try {
105 117
             $isInFolder = preg_match("/^(.*)\/([^\/]+)$/", $filepath, $filepathMatches);
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,8 +2,8 @@
 block discarded – undo
2 2
 
3 3
 namespace Imanghafoori\LaravelMicroscope\Checks;
4 4
 
5
-use Illuminate\Support\Str;
6 5
 use Illuminate\Support\Facades\View;
6
+use Illuminate\Support\Str;
7 7
 use Imanghafoori\LaravelMicroscope\Analyzers\FunctionCall;
8 8
 
9 9
 class ExtractBladePartial
Please login to merge, or discard this patch.
src/LaravelMicroscopeServiceProvider.php 1 patch
Unused Use Statements   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -2,21 +2,21 @@
 block discarded – undo
2 2
 
3 3
 namespace Imanghafoori\LaravelMicroscope;
4 4
 
5
-use Illuminate\View\View;
6
-use Illuminate\Support\Str;
5
+use Illuminate\Contracts\Auth\Access\Gate as GateContract;
6
+use Illuminate\Contracts\Queue\Factory as QueueFactoryContract;
7 7
 use Illuminate\Support\Facades\Event;
8 8
 use Illuminate\Support\Facades\Route;
9 9
 use Illuminate\Support\ServiceProvider;
10
+use Illuminate\Support\Str;
11
+use Illuminate\View\View;
10 12
 use Imanghafoori\LaravelMicroscope\Commands;
13
+use Imanghafoori\LaravelMicroscope\ErrorReporters\ConsolePrinterInstaller;
14
+use Imanghafoori\LaravelMicroscope\ErrorReporters\ErrorPrinter;
15
+use Imanghafoori\LaravelMicroscope\SpyClasses\SpyBladeCompiler;
16
+use Imanghafoori\LaravelMicroscope\SpyClasses\SpyDispatcher;
11 17
 use Imanghafoori\LaravelMicroscope\SpyClasses\SpyGate;
12 18
 use Imanghafoori\LaravelMicroscope\SpyClasses\SpyRouter;
13 19
 use Imanghafoori\LaravelMicroscope\SpyClasses\ViewsData;
14
-use Illuminate\Contracts\Auth\Access\Gate as GateContract;
15
-use Imanghafoori\LaravelMicroscope\SpyClasses\SpyDispatcher;
16
-use Imanghafoori\LaravelMicroscope\SpyClasses\SpyBladeCompiler;
17
-use Illuminate\Contracts\Queue\Factory as QueueFactoryContract;
18
-use Imanghafoori\LaravelMicroscope\ErrorReporters\ErrorPrinter;
19
-use Imanghafoori\LaravelMicroscope\ErrorReporters\ConsolePrinterInstaller;
20 20
 
21 21
 class LaravelMicroscopeServiceProvider extends ServiceProvider
22 22
 {
Please login to merge, or discard this patch.
src/SpyClasses/SpyDispatcher.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -13,6 +13,9 @@  discard block
 block discarded – undo
13 13
         $this->validateCallback($event[0], $listener);
14 14
     }
15 15
 
16
+    /**
17
+     * @param string $string
18
+     */
16 19
     private function error($string)
17 20
     {
18 21
         app(ErrorPrinter::class)->pended[] = $string;
@@ -47,6 +50,9 @@  discard block
 block discarded – undo
47 50
         }
48 51
     }
49 52
 
53
+    /**
54
+     * @return string
55
+     */
50 56
     private function stringify($event)
51 57
     {
52 58
         return is_object($event) ? get_class($event) : $event;
@@ -68,6 +74,9 @@  discard block
 block discarded – undo
68 74
         return 'The method of '.$at.' is not callable as an event listener for "'.$e.'" event';
69 75
     }
70 76
 
77
+    /**
78
+     * @return string
79
+     */
71 80
     protected function getTypeHintedClass($listenerObj, $methodName)
72 81
     {
73 82
         try {
Please login to merge, or discard this patch.
src/Commands/PrettyPrintRoutes.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,8 +3,8 @@
 block discarded – undo
3 3
 namespace Imanghafoori\LaravelMicroscope\Commands;
4 4
 
5 5
 use Exception;
6
-use Illuminate\Support\Str;
7 6
 use Illuminate\Console\Command;
7
+use Illuminate\Support\Str;
8 8
 
9 9
 class PrettyPrintRoutes extends Command
10 10
 {
Please login to merge, or discard this patch.
src/Commands/CheckCompact.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
     /**
21 21
      * Execute the console command.
22 22
      *
23
-     * @return void
23
+     * @return integer
24 24
      */
25 25
     public function handle()
26 26
     {
Please login to merge, or discard this patch.
Unused Use Statements   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,13 +3,13 @@
 block discarded – undo
3 3
 namespace Imanghafoori\LaravelMicroscope\Commands;
4 4
 
5 5
 use Illuminate\Console\Command;
6
-use Imanghafoori\LaravelMicroscope\Analyzers\Ifs;
6
+use Imanghafoori\LaravelMicroscope\Analyzers\ComposerJson;
7 7
 use Imanghafoori\LaravelMicroscope\Analyzers\FilePath;
8
-use Imanghafoori\LaravelMicroscope\SpyClasses\RoutePaths;
9 8
 use Imanghafoori\LaravelMicroscope\Analyzers\FunctionCall;
10
-use Imanghafoori\LaravelMicroscope\Analyzers\ComposerJson;
9
+use Imanghafoori\LaravelMicroscope\Analyzers\Ifs;
11 10
 use Imanghafoori\LaravelMicroscope\ErrorReporters\ErrorPrinter;
12 11
 use Imanghafoori\LaravelMicroscope\ErrorTypes\CompactCall;
12
+use Imanghafoori\LaravelMicroscope\SpyClasses\RoutePaths;
13 13
 
14 14
 class CheckCompact extends Command
15 15
 {
Please login to merge, or discard this patch.
src/Commands/CheckEarlyReturns.php 2 patches
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
     /**
28 28
      * Execute the console command.
29 29
      *
30
-     * @return mixed
30
+     * @return null|integer
31 31
      */
32 32
     public function handle()
33 33
     {
@@ -71,6 +71,9 @@  discard block
 block discarded – undo
71 71
         return app(ErrorPrinter::class)->hasErrors() ? 1 : 0;
72 72
     }
73 73
 
74
+    /**
75
+     * @param integer $tries
76
+     */
74 77
     private function fix($filePath, $tokens, $tries)
75 78
     {
76 79
         Refactor::saveTokens($filePath, $tokens, $this->option('test'));
@@ -88,6 +91,9 @@  discard block
 block discarded – undo
88 91
         return [$fixes, $tokens];
89 92
     }
90 93
 
94
+    /**
95
+     * @param integer $fixed
96
+     */
91 97
     private function printFinalMsg($fixed)
92 98
     {
93 99
         if ($fixed > 0) {
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,9 +3,9 @@
 block discarded – undo
3 3
 namespace Imanghafoori\LaravelMicroscope\Commands;
4 4
 
5 5
 use Illuminate\Console\Command;
6
+use Imanghafoori\LaravelMicroscope\Analyzers\ComposerJson;
6 7
 use Imanghafoori\LaravelMicroscope\Analyzers\FilePath;
7 8
 use Imanghafoori\LaravelMicroscope\Analyzers\Refactor;
8
-use Imanghafoori\LaravelMicroscope\Analyzers\ComposerJson;
9 9
 use Imanghafoori\LaravelMicroscope\ErrorReporters\ErrorPrinter;
10 10
 
11 11
 class CheckEarlyReturns extends Command
Please login to merge, or discard this patch.
src/Commands/CheckViews.php 1 patch
Unused Use Statements   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -4,14 +4,14 @@
 block discarded – undo
4 4
 
5 5
 use Illuminate\Console\Command;
6 6
 use Illuminate\Support\Facades\View;
7
-use Imanghafoori\LaravelMicroscope\BladeFiles;
8
-use Imanghafoori\LaravelMicroscope\Analyzers\FilePath;
9
-use Imanghafoori\LaravelMicroscope\ErrorTypes\BladeFile;
10
-use Imanghafoori\LaravelMicroscope\SpyClasses\RoutePaths;
11 7
 use Imanghafoori\LaravelMicroscope\Analyzers\ComposerJson;
8
+use Imanghafoori\LaravelMicroscope\Analyzers\FilePath;
12 9
 use Imanghafoori\LaravelMicroscope\Analyzers\FunctionCall;
10
+use Imanghafoori\LaravelMicroscope\BladeFiles;
13 11
 use Imanghafoori\LaravelMicroscope\Checks\CheckViewFilesExistence;
14 12
 use Imanghafoori\LaravelMicroscope\ErrorReporters\ErrorPrinter;
13
+use Imanghafoori\LaravelMicroscope\ErrorTypes\BladeFile;
14
+use Imanghafoori\LaravelMicroscope\SpyClasses\RoutePaths;
15 15
 
16 16
 class CheckViews extends Command
17 17
 {
Please login to merge, or discard this patch.