imajinyun / leetcode-php

src/leetcode/KthSmallestElementInABST.php

<?php

declare(strict_types=1);

namespace leetcode;

use leetcode\util\TreeNode;

class KthSmallestElementInABST
{
    public static function kthSmallest(TreeNode $root, int $k): int
    {
        if ($k <= 0) {
            return 0;
        }
        $stack = [];
        while ($root || $stack) {

The expression $stack of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            while ($root && $root->val) {
                array_push($stack, $root);
                $root = $root->left;
            }
            $root = array_pop($stack);
            if (--$k === 0) {
                break;
            }
            $root = $root->right;
        }

        return $root->val;
    }

    public static function kthSmallest2(TreeNode $root, int $k): int
    {
        if ($k <= 0) {
            return 0;
        }
        $n = 0;
        self::helper($root, $k, $n);

        return $n;
    }

    private static function helper(?TreeNode $node, int &$k, int &$n)
    {
        if ($node instanceof TreeNode && $node->val) {
            self::helper($node->left, $k, $n);
            if (--$k === 0) {
                $n = $node->val;
                return;
            }
            self::helper($node->right, $k, $n);
        }
    }
}