KthSmallestElementInABST::kthSmallest() - Code Metrics - imajinyun/leetcode-php - Measure and Improve Code Quality continuously with Scrutinizer

KthSmallestElementInABST::kthSmallest() B
last analyzed 2022-03-29 06:17 UTC

↳ Parent: KthSmallestElementInABST

Complexity

Conditions	7
Paths	6

Size

Total Lines	19
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	12
c	1
b	0
f	0
dl	0
loc	19
rs	8.8333
cc	7
nc	6
nop	2

<?php

declare(strict_types=1);

namespace leetcode;

use leetcode\util\TreeNode;

class KthSmallestElementInABST
{
    public static function kthSmallest(TreeNode $root, int $k): int
    {
        if ($k <= 0) {
            return 0;
        }
        $stack = [];
        while ($root || $stack) {

            while ($root && $root->val) {
                array_push($stack, $root);
                $root = $root->left;
            }
            $root = array_pop($stack);
            if (--$k === 0) {
                break;
            }
            $root = $root->right;
        }

        return $root->val;
    }

    public static function kthSmallest2(TreeNode $root, int $k): int
    {
        if ($k <= 0) {
            return 0;
        }
        $n = 0;
        self::helper($root, $k, $n);

        return $n;
    }

    private static function helper(?TreeNode $node, int &$k, int &$n)
    {
        if ($node instanceof TreeNode && $node->val) {
            self::helper($node->left, $k, $n);
            if (--$k === 0) {
                $n = $node->val;
                return;
            }
            self::helper($node->right, $k, $n);
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace leetcode;
6
7			use leetcode\util\TreeNode;
8
9			class KthSmallestElementInABST
10			{
11			public static function kthSmallest(TreeNode $root, int $k): int
12			{
13			if ($k <= 0) {
14			return 0;
15			}
16			$stack = [];
17			while ($root \|\| $stack) {
			0 ignored issues – show Bug Best Practice introduced 2021-08-28 03:48 UTC by Report Bug Copy Issue Report The expression `$stack` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
18			while ($root && $root->val) {
19			array_push($stack, $root);
20			$root = $root->left;
21			}
22			$root = array_pop($stack);
23			if (--$k === 0) {
24			break;
25			}
26			$root = $root->right;
27			}
28
29			return $root->val;
30			}
31
32			public static function kthSmallest2(TreeNode $root, int $k): int
33			{
34			if ($k <= 0) {
35			return 0;
36			}
37			$n = 0;
38			self::helper($root, $k, $n);
39
40			return $n;
41			}
42
43			private static function helper(?TreeNode $node, int &$k, int &$n)
44			{
45			if ($node instanceof TreeNode && $node->val) {
46			self::helper($node->left, $k, $n);
47			if (--$k === 0) {
48			$n = $node->val;
49			return;
50			}
51			self::helper($node->right, $k, $n);
52			}
53			}
54			}
55

imajinyun / leetcode-php

KthSmallestElementInABST::kthSmallest() B last analyzed 2022-03-29 06:17 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

KthSmallestElementInABST::kthSmallest() B
last analyzed 2022-03-29 06:17 UTC