UserController::deleteAction() - Code Metrics - iesoretania/atica-ng - Measure and Improve Code Quality continuously with Scrutinizer

UserController::deleteAction() A
last analyzed 2017-12-09 11:59 UTC

↳ Parent: UserController

Complexity

Conditions	4
Paths	7

Size

Total Lines	56
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	56
rs	9.0544
cc	4
eloc	41
nc	7
nop	1

How to fix Long Method

<?php
/*
  ÁTICA - Aplicación web para la gestión documental de centros educativos

  Copyright (C) 2015-2017: Luis Ramón López López

  This program is free software: you can redistribute it and/or modify
  it under the terms of the GNU Affero General Public License as published by
  the Free Software Foundation, either version 3 of the License, or
  (at your option) any later version.

  This program is distributed in the hope that it will be useful,
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU Affero General Public License for more details.

  You should have received a copy of the GNU Affero General Public License
  along with this program.  If not, see [http://www.gnu.org/licenses/].
*/

namespace AppBundle\Controller\Admin;

use AppBundle\Entity\User;
use AppBundle\Form\Type\UserType;
use Doctrine\ORM\QueryBuilder;
use Pagerfanta\Adapter\DoctrineORMAdapter;
use Pagerfanta\Pagerfanta;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\Form\Form;
use Symfony\Component\Form\SubmitButton;
use Symfony\Component\HttpFoundation\Request;

/**
 * @Route("/admin/usuarios")
 * @Security("is_granted('ROLE_ADMIN')")
 */
class UserController extends Controller
{
    /**
     * @Route("/nuevo", name="admin_user_form_new", methods={"GET", "POST"})
     * @Route("/{id}", name="admin_user_form_edit", requirements={"id" = "\d+"}, methods={"GET", "POST"})
     */
    public function indexAction(User $localUser = null, Request $request)
    {
        $em = $this->getDoctrine()->getManager();

        if (null === $localUser) {
            $localUser = new User();
            $em->persist($localUser);
        }

        $form = $this->createForm(UserType::class, $localUser, [
            'own' => $this->getUser()->getId() === $localUser->getId(),
            'admin' => $this->getUser()->isGlobalAdministrator(),
            'new' => $localUser->getId() === null
        ]);

        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {

            $message = $this->processPasswordChange($localUser, $form);


            try {
                $em->flush();
                $this->addFlash('success', $message);
                return $this->redirectToRoute('admin_user_list');
            } catch (\Exception $e) {
                $this->addFlash('error', $this->get('translator')->trans('message.error', [], 'user'));
            }
        }

        $title = $this->get('translator')->trans($localUser->getId() ? 'title.edit' : 'title.new', [], 'user');


        $breadcrumb = [$localUser->getId() ? ['fixed' => (string) $localUser] : ['fixed' => $this->get('translator')->trans('title.new', [], 'user')]];

        return $this->render('admin/user/user_form.html.twig', [
            'menu_path' => 'admin_user_list',
            'breadcrumb' => $breadcrumb,
            'title' => $title,
            'form' => $form->createView(),
            'user' => $localUser
        ]);
    }

    /**
     * @Route("/listar/{page}", name="admin_user_list", requirements={"page" = "\d+"}, defaults={"page" = "1"}, methods={"GET"})
     */
    public function listAction($page, Request $request)

    {
        /** @var QueryBuilder $queryBuilder */
        $queryBuilder = $this->getDoctrine()->getManager()->createQueryBuilder();

        $queryBuilder
            ->select('u')
            ->from('AppBundle:User', 'u')
            ->orderBy('u.lastName')
            ->addOrderBy('u.firstName');

        $q = $request->get('q', null);
        if ($q) {
            $queryBuilder
                ->where('u.id = :q')
                ->orWhere('u.loginUsername LIKE :tq')
                ->orWhere('u.firstName LIKE :tq')
                ->orWhere('u.lastName LIKE :tq')
                ->orWhere('u.emailAddress LIKE :tq')
                ->setParameter('tq', '%'.$q.'%')
                ->setParameter('q', $q);
        }

        $adapter = new DoctrineORMAdapter($queryBuilder, false);
        $pager = new Pagerfanta($adapter);
        $pager
            ->setMaxPerPage($this->getParameter('page.size'))
            ->setCurrentPage($q ? 1 : $page);

        $title = $this->get('translator')->trans('title.list', [], 'user');

        return $this->render('admin/user/list.html.twig', [
            'title' => $title,
            'pager' => $pager,
            'q' => $q,
            'domain' => 'user'
        ]);
    }

    /**
     * @Route("/eliminar", name="admin_user_delete", methods={"POST"})
     */
    public function deleteAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();

        /** @var QueryBuilder $queryBuilder */
        $queryBuilder = $em->createQueryBuilder();

        $items = $request->request->get('users', []);
        if (count($items) === 0) {
            return $this->redirectToRoute('admin_user_list');
        }

        $users = $queryBuilder
            ->select('u')
            ->from('AppBundle:User', 'u')
            ->where('u.id IN (:items)')
            ->andWhere('u.id != :current')
            ->setParameter('items', $items)
            ->setParameter('current', $this->getUser()->getId())
            ->orderBy('u.firstName')
            ->addOrderBy('u.lastName')
            ->getQuery()
            ->getResult();

        if ($request->get('confirm', '') === 'ok') {
            try {
                /* Borrar primero las pertenencias */
                $em->createQueryBuilder()
                    ->delete('AppBundle:Membership', 'm')
                    ->where('m.user IN (:items)')
                    ->setParameter('items', $items)
                    ->getQuery()
                    ->execute();

                $em->createQueryBuilder()
                    ->delete('AppBundle:User', 'u')
                    ->where('u IN (:items)')
                    ->setParameter('items', $items)
                    ->getQuery()
                    ->execute();

                $em->flush();
                $this->addFlash('success', $this->get('translator')->trans('message.deleted', [], 'user'));
            } catch (\Exception $e) {
                $this->addFlash('error', $this->get('translator')->trans('message.delete_error', [], 'user'));
            }
            return $this->redirectToRoute('admin_user_list');
        }

        return $this->render('admin/user/delete.html.twig', [
            'menu_path' => 'admin_user_list',
            'breadcrumb' => [['fixed' => $this->get('translator')->trans('title.delete', [], 'user')]],
            'title' => $this->get('translator')->trans('title.delete', [], 'user'),
            'users' => $users
        ]);
    }

    /**
     * @param User $user
     * @param Form $form
     * @return string
     */
    private function processPasswordChange(User $user, Form $form)
    {
// Si es solicitado, cambiar la contraseña
        $passwordSubmit = $form->get('changePassword');
        if (($passwordSubmit instanceof SubmitButton) && $passwordSubmit->isClicked()) {
            $user->setPassword($this->container->get('security.password_encoder')
                ->encodePassword($user, $form->get('newPassword')->get('first')->getData()));
            $message = $this->get('translator')->trans('message.password_changed', [], 'user');
        } else {
            $message = $this->get('translator')->trans('message.saved', [], 'user');
        }
        return $message;
    }
}


1		<?php
2		/*
3		ÁTICA - Aplicación web para la gestión documental de centros educativos
4
5		Copyright (C) 2015-2017: Luis Ramón López López
6
7		This program is free software: you can redistribute it and/or modify
8		it under the terms of the GNU Affero General Public License as published by
9		the Free Software Foundation, either version 3 of the License, or
10		(at your option) any later version.
11
12		This program is distributed in the hope that it will be useful,
13		but WITHOUT ANY WARRANTY; without even the implied warranty of
14		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15		GNU Affero General Public License for more details.
16
17		You should have received a copy of the GNU Affero General Public License
18		along with this program. If not, see [http://www.gnu.org/licenses/].
19		*/
20
21		namespace AppBundle\Controller\Admin;
22
23		use AppBundle\Entity\User;
24		use AppBundle\Form\Type\UserType;
25		use Doctrine\ORM\QueryBuilder;
26		use Pagerfanta\Adapter\DoctrineORMAdapter;
27		use Pagerfanta\Pagerfanta;
28		use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
29		use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
30		use Symfony\Bundle\FrameworkBundle\Controller\Controller;
31		use Symfony\Component\Form\Form;
32		use Symfony\Component\Form\SubmitButton;
33		use Symfony\Component\HttpFoundation\Request;
34
35		/**
36		* @Route("/admin/usuarios")
37		* @Security("is_granted('ROLE_ADMIN')")
38		*/
39		class UserController extends Controller
40		{
41		/**
42		* @Route("/nuevo", name="admin_user_form_new", methods={"GET", "POST"})
43		* @Route("/{id}", name="admin_user_form_edit", requirements={"id" = "\d+"}, methods={"GET", "POST"})
44		*/
45		public function indexAction(User $localUser = null, Request $request)
46		{
47		$em = $this->getDoctrine()->getManager();
48
49		if (null === $localUser) {
50		$localUser = new User();
51		$em->persist($localUser);
52		}
53
54		$form = $this->createForm(UserType::class, $localUser, [
55		'own' => $this->getUser()->getId() === $localUser->getId(),
56		'admin' => $this->getUser()->isGlobalAdministrator(),
57		'new' => $localUser->getId() === null
58		]);
59
60		$form->handleRequest($request);
61
62		if ($form->isSubmitted() && $form->isValid()) {
63
64		$message = $this->processPasswordChange($localUser, $form);
		0 ignored issues – show Compatibility introduced 2017-11-12 21:11 UTC by Report Bug Copy Issue Report `$form` of type `object<Symfony\Component\Form\FormInterface>` is not a sub-type of `object<Symfony\Component\Form\Form>`. It seems like you assume a concrete implementation of the interface `Symfony\Component\Form\FormInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
65
66		try {
67		$em->flush();
68		$this->addFlash('success', $message);
69		return $this->redirectToRoute('admin_user_list');
70		} catch (\Exception $e) {
71		$this->addFlash('error', $this->get('translator')->trans('message.error', [], 'user'));
72		}
73		}
74
75		$title = $this->get('translator')->trans($localUser->getId() ? 'title.edit' : 'title.new', [], 'user');
76
77
78		$breadcrumb = [$localUser->getId() ? ['fixed' => (string) $localUser] : ['fixed' => $this->get('translator')->trans('title.new', [], 'user')]];
79
80		return $this->render('admin/user/user_form.html.twig', [
81		'menu_path' => 'admin_user_list',
82		'breadcrumb' => $breadcrumb,
83		'title' => $title,
84		'form' => $form->createView(),
85		'user' => $localUser
86		]);
87		}
88
89		/**
90		* @Route("/listar/{page}", name="admin_user_list", requirements={"page" = "\d+"}, defaults={"page" = "1"}, methods={"GET"})
91		*/
92	View Code Duplication	public function listAction($page, Request $request)
		0 ignored issues – show Duplication introduced 2017-08-01 00:32 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
93		{
94		/** @var QueryBuilder $queryBuilder */
95		$queryBuilder = $this->getDoctrine()->getManager()->createQueryBuilder();
96
97		$queryBuilder
98		->select('u')
99		->from('AppBundle:User', 'u')
100		->orderBy('u.lastName')
101		->addOrderBy('u.firstName');
102
103		$q = $request->get('q', null);
104		if ($q) {
105		$queryBuilder
106		->where('u.id = :q')
107		->orWhere('u.loginUsername LIKE :tq')
108		->orWhere('u.firstName LIKE :tq')
109		->orWhere('u.lastName LIKE :tq')
110		->orWhere('u.emailAddress LIKE :tq')
111		->setParameter('tq', '%'.$q.'%')
112		->setParameter('q', $q);
113		}
114
115		$adapter = new DoctrineORMAdapter($queryBuilder, false);
116		$pager = new Pagerfanta($adapter);
117		$pager
118		->setMaxPerPage($this->getParameter('page.size'))
119		->setCurrentPage($q ? 1 : $page);
120
121		$title = $this->get('translator')->trans('title.list', [], 'user');
122
123		return $this->render('admin/user/list.html.twig', [
124		'title' => $title,
125		'pager' => $pager,
126		'q' => $q,
127		'domain' => 'user'
128		]);
129		}
130
131		/**
132		* @Route("/eliminar", name="admin_user_delete", methods={"POST"})
133		*/
134		public function deleteAction(Request $request)
135		{
136		$em = $this->getDoctrine()->getManager();
137
138		/** @var QueryBuilder $queryBuilder */
139		$queryBuilder = $em->createQueryBuilder();
140
141		$items = $request->request->get('users', []);
142		if (count($items) === 0) {
143		return $this->redirectToRoute('admin_user_list');
144		}
145
146		$users = $queryBuilder
147		->select('u')
148		->from('AppBundle:User', 'u')
149		->where('u.id IN (:items)')
150		->andWhere('u.id != :current')
151		->setParameter('items', $items)
152		->setParameter('current', $this->getUser()->getId())
153		->orderBy('u.firstName')
154		->addOrderBy('u.lastName')
155		->getQuery()
156		->getResult();
157
158		if ($request->get('confirm', '') === 'ok') {
159		try {
160		/* Borrar primero las pertenencias */
161		$em->createQueryBuilder()
162		->delete('AppBundle:Membership', 'm')
163		->where('m.user IN (:items)')
164		->setParameter('items', $items)
165		->getQuery()
166		->execute();
167
168		$em->createQueryBuilder()
169		->delete('AppBundle:User', 'u')
170		->where('u IN (:items)')
171		->setParameter('items', $items)
172		->getQuery()
173		->execute();
174
175		$em->flush();
176		$this->addFlash('success', $this->get('translator')->trans('message.deleted', [], 'user'));
177		} catch (\Exception $e) {
178		$this->addFlash('error', $this->get('translator')->trans('message.delete_error', [], 'user'));
179		}
180		return $this->redirectToRoute('admin_user_list');
181		}
182
183		return $this->render('admin/user/delete.html.twig', [
184		'menu_path' => 'admin_user_list',
185		'breadcrumb' => [['fixed' => $this->get('translator')->trans('title.delete', [], 'user')]],
186		'title' => $this->get('translator')->trans('title.delete', [], 'user'),
187		'users' => $users
188		]);
189		}
190
191		/**
192		* @param User $user
193		* @param Form $form
194		* @return string
195		*/
196		private function processPasswordChange(User $user, Form $form)
197		{
198		// Si es solicitado, cambiar la contraseña
199		$passwordSubmit = $form->get('changePassword');
200		if (($passwordSubmit instanceof SubmitButton) && $passwordSubmit->isClicked()) {
201		$user->setPassword($this->container->get('security.password_encoder')
202		->encodePassword($user, $form->get('newPassword')->get('first')->getData()));
203		$message = $this->get('translator')->trans('message.password_changed', [], 'user');
204		} else {
205		$message = $this->get('translator')->trans('message.saved', [], 'user');
206		}
207		return $message;
208		}
209		}
210

iesoretania / atica-ng

UserController::deleteAction() A last analyzed 2017-12-09 11:59 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

UserController::deleteAction() A
last analyzed 2017-12-09 11:59 UTC