AppBundle\Controller\Admin\UserController

Complexity

Total Complexity

17

Size/Duplication

Total Lines	171
Duplicated Lines	22.22 %

Coupling/Cohesion

Components	1
Dependencies	12

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	processPasswordChange()	0	13	3
A	deleteAction()	0	56	4
C	indexAction()	0	43	7

<?php
/*
  ÁTICA - Aplicación web para la gestión documental de centros educativos

  Copyright (C) 2015-2017: Luis Ramón López López

  This program is free software: you can redistribute it and/or modify
  it under the terms of the GNU Affero General Public License as published by
  the Free Software Foundation, either version 3 of the License, or
  (at your option) any later version.

  This program is distributed in the hope that it will be useful,
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU Affero General Public License for more details.

  You should have received a copy of the GNU Affero General Public License
  along with this program.  If not, see [http://www.gnu.org/licenses/].
*/

namespace AppBundle\Controller\Admin;

use AppBundle\Entity\User;
use AppBundle\Form\Type\UserType;
use Doctrine\ORM\QueryBuilder;
use Pagerfanta\Adapter\DoctrineORMAdapter;
use Pagerfanta\Pagerfanta;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\Form\Form;
use Symfony\Component\Form\SubmitButton;
use Symfony\Component\HttpFoundation\Request;

/**
 * @Route("/admin/usuarios")
 * @Security("is_granted('ROLE_ADMIN')")
 */
class UserController extends Controller
{
    /**
     * @Route("/nuevo", name="admin_user_form_new", methods={"GET", "POST"})
     * @Route("/{id}", name="admin_user_form_edit", requirements={"id" = "\d+"}, methods={"GET", "POST"})
     */
    public function indexAction(User $localUser = null, Request $request)
    {
        $em = $this->getDoctrine()->getManager();

        if (null === $localUser) {
            $localUser = new User();
            $em->persist($localUser);
        }

        $form = $this->createForm(UserType::class, $localUser, [
            'own' => $this->getUser()->getId() === $localUser->getId(),
            'admin' => $this->getUser()->isGlobalAdministrator(),
            'new' => $localUser->getId() === null
        ]);

        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {

            $message = $this->processPasswordChange($localUser, $form);

$form of type object<Symfony\Component\Form\FormInterface> is not a sub-type of object<Symfony\Component\Form\Form>. It seems like you assume a concrete implementation of the interface Symfony\Component\Form\FormInterface to be always present.

            try {
                $em->flush();
                $this->addFlash('success', $message);
                return $this->redirectToRoute('admin_user_list');
            } catch (\Exception $e) {
                $this->addFlash('error', $this->get('translator')->trans('message.error', [], 'user'));
            }
        }

        $title = $this->get('translator')->trans($localUser->getId() ? 'title.edit' : 'title.new', [], 'user');


        $breadcrumb = [$localUser->getId() ? ['fixed' => (string) $localUser] : ['fixed' => $this->get('translator')->trans('title.new', [], 'user')]];

        return $this->render('admin/user/user_form.html.twig', [
            'menu_path' => 'admin_user_list',
            'breadcrumb' => $breadcrumb,
            'title' => $title,
            'form' => $form->createView(),
            'user' => $localUser
        ]);
    }

    /**
     * @Route("/listar/{page}", name="admin_user_list", requirements={"page" = "\d+"}, defaults={"page" = "1"}, methods={"GET"})
     */
    public function listAction($page, Request $request)

This method seems to be duplicated in your project.

    {
        /** @var QueryBuilder $queryBuilder */
        $queryBuilder = $this->getDoctrine()->getManager()->createQueryBuilder();

        $queryBuilder
            ->select('u')
            ->from('AppBundle:User', 'u')
            ->orderBy('u.lastName')
            ->addOrderBy('u.firstName');

        $q = $request->get('q', null);
        if ($q) {
            $queryBuilder
                ->where('u.id = :q')
                ->orWhere('u.loginUsername LIKE :tq')
                ->orWhere('u.firstName LIKE :tq')
                ->orWhere('u.lastName LIKE :tq')
                ->orWhere('u.emailAddress LIKE :tq')
                ->setParameter('tq', '%'.$q.'%')
                ->setParameter('q', $q);
        }

        $adapter = new DoctrineORMAdapter($queryBuilder, false);
        $pager = new Pagerfanta($adapter);
        $pager
            ->setMaxPerPage($this->getParameter('page.size'))
            ->setCurrentPage($q ? 1 : $page);

        $title = $this->get('translator')->trans('title.list', [], 'user');

        return $this->render('admin/user/list.html.twig', [
            'title' => $title,
            'pager' => $pager,
            'q' => $q,
            'domain' => 'user'
        ]);
    }

    /**
     * @Route("/eliminar", name="admin_user_delete", methods={"POST"})
     */
    public function deleteAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();

        /** @var QueryBuilder $queryBuilder */
        $queryBuilder = $em->createQueryBuilder();

        $items = $request->request->get('users', []);
        if (count($items) === 0) {
            return $this->redirectToRoute('admin_user_list');
        }

        $users = $queryBuilder
            ->select('u')
            ->from('AppBundle:User', 'u')
            ->where('u.id IN (:items)')
            ->andWhere('u.id != :current')
            ->setParameter('items', $items)
            ->setParameter('current', $this->getUser()->getId())
            ->orderBy('u.firstName')
            ->addOrderBy('u.lastName')
            ->getQuery()
            ->getResult();

        if ($request->get('confirm', '') === 'ok') {
            try {
                /* Borrar primero las pertenencias */
                $em->createQueryBuilder()
                    ->delete('AppBundle:Membership', 'm')
                    ->where('m.user IN (:items)')
                    ->setParameter('items', $items)
                    ->getQuery()
                    ->execute();

                $em->createQueryBuilder()
                    ->delete('AppBundle:User', 'u')
                    ->where('u IN (:items)')
                    ->setParameter('items', $items)
                    ->getQuery()
                    ->execute();

                $em->flush();
                $this->addFlash('success', $this->get('translator')->trans('message.deleted', [], 'user'));
            } catch (\Exception $e) {
                $this->addFlash('error', $this->get('translator')->trans('message.delete_error', [], 'user'));
            }
            return $this->redirectToRoute('admin_user_list');
        }

        return $this->render('admin/user/delete.html.twig', [
            'menu_path' => 'admin_user_list',
            'breadcrumb' => [['fixed' => $this->get('translator')->trans('title.delete', [], 'user')]],
            'title' => $this->get('translator')->trans('title.delete', [], 'user'),
            'users' => $users
        ]);
    }

    /**
     * @param User $user
     * @param Form $form
     * @return string
     */
    private function processPasswordChange(User $user, Form $form)
    {
// Si es solicitado, cambiar la contraseña
        $passwordSubmit = $form->get('changePassword');
        if (($passwordSubmit instanceof SubmitButton) && $passwordSubmit->isClicked()) {
            $user->setPassword($this->container->get('security.password_encoder')
                ->encodePassword($user, $form->get('newPassword')->get('first')->getData()));
            $message = $this->get('translator')->trans('message.password_changed', [], 'user');
        } else {
            $message = $this->get('translator')->trans('message.saved', [], 'user');
        }
        return $message;
    }
}