icewind1991 / SearchDAV

src/DAV/SearchPlugin.php

Doc Comments +5 added lines, -2 removed lines

@@ -71,6 +71,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $uri
+	 */
 	private function getPathFromUri($uri) {
 		if (strpos($uri, '://') === false) {
 			return $uri;
@@ -170,9 +173,9 @@ 
 	 * If a depth of 1 is requested child elements will also be returned.
 	 *
 	 * @param SearchResult[] $results
-	 * @param array $propertyNames
+	 * @param string[] $propertyNames
 	 * @param int $depth
-	 * @return \Iterator
+	 * @return \Traversable
 	 */
 	function getPropertiesIteratorResults($results, $propertyNames = [], $depth = 0) {
 		$propFindType = $propertyNames ? PropFind::NORMAL : PropFind::ALLPROPS;

Unused Use Statements -3 removed lines

@@ -24,15 +24,12 @@
 use Sabre\DAV\Exception\BadRequest;
 use Sabre\DAV\Exception\Forbidden;
 use Sabre\DAV\INode;
-use Sabre\DAV\Node;
 use Sabre\DAV\PropFind;
 use Sabre\DAV\Server;
 use Sabre\DAV\ServerPlugin;
-use Sabre\DAV\Xml\Element\Response;
 use Sabre\DAV\Xml\Response\MultiStatus;
 use Sabre\HTTP\RequestInterface;
 use Sabre\HTTP\ResponseInterface;
-use Sabre\Xml\Writer;
 use SearchDAV\Backend\ISearchBackend;
 use SearchDAV\Backend\SearchPropertyDefinition;
 use SearchDAV\Backend\SearchResult;

Spacing +1 added lines, -1 removed lines

@@ -140,7 +140,7 @@
 				/** @var BasicSearch $query */
 				$query = $xml['{DAV:}basicsearch'];
 				$scopes = $query->from;
-				$results = array_map(function (Scope $scope) {
+				$results = array_map(function(Scope $scope) {
 					$scope->path = $this->getPathFromUri($scope->href);
 					if ($this->searchBackend->isValidScope($scope->href, $scope->depth, $scope->path)) {
 						$searchProperties = $this->searchBackend->getPropertyDefinitionsForScope($scope->href, $scope->path);

src/XML/QueryDiscoverResponse.php

Doc Comments +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
 	 *
 	 * @param string $href
 	 * @param BasicSearchSchema|null $schema
-	 * @param null|int|string $httpStatus
+	 * @param integer $httpStatus
 	 */
 	function __construct($href, BasicSearchSchema $schema = null, $httpStatus = null) {
 		parent::__construct($href, [], $httpStatus);

src/XML/Scope.php

Doc Comments +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
 
 	/**
 	 * @param string $href
-	 * @param int|string $depth
+	 * @param integer $depth
 	 */
 	public function __construct($href = '', $depth = 1) {
 		$this->href = $href;

src/DAV/QueryParser.php

Spacing +5 added lines, -5 removed lines

@@ -43,18 +43,18 @@
 			'{DAV:}searchrequest' => Element\KeyValue::class,
 			'{DAV:}query-schema-discovery' => Element\KeyValue::class,
 			'{DAV:}basicsearch' => BasicSearch::class,
-			'{DAV:}select' => function (Reader $reader) {
+			'{DAV:}select' => function(Reader $reader) {
 				return \Sabre\Xml\Deserializer\keyValue($reader, '{DAV:}scope')['{DAV:}prop'];
 			},
-			'{DAV:}from' => function (Reader $reader) {
+			'{DAV:}from' => function(Reader $reader) {
 				return \Sabre\Xml\Deserializer\repeatingElements($reader, '{DAV:}scope');
 			},
-			'{DAV:}orderby' => function (Reader $reader) {
+			'{DAV:}orderby' => function(Reader $reader) {
 				return \Sabre\Xml\Deserializer\repeatingElements($reader, '{DAV:}order');
 			},
 			'{DAV:}scope' => Scope::class,
-			'{DAV:}where' => function (Reader $reader) {
-				$operators = array_map(function ($element) {
+			'{DAV:}where' => function(Reader $reader) {
+				$operators = array_map(function($element) {
 					return $element['value'];
 				}, $reader->parseGetElements());
 				return (isset($operators[0])) ? $operators[0] : null;

src/XML/PropDesc.php

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
 		if ($this->selectable) {
 			$data['{DAV:}selectable'] = null;
 		}
-		$writer->write(array_map(function ($propName) {
+		$writer->write(array_map(function($propName) {
 			return [
 				'name' => '{DAV:}prop',
 				'value' => $propName