Completed
Pull Request — master (#85)
by Raffael
02:45
created
src/Native/NativeReadStream.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
 	/**
32 32
 	 * Wrap a stream from libsmbclient-php into a regular php stream
33 33
 	 *
34
-	 * @param \Icewind\SMB\NativeState $state
34
+	 * @param NativeState $state
35 35
 	 * @param resource $smbStream
36 36
 	 * @param string $mode
37 37
 	 * @param string $url
Please login to merge, or discard this patch.
src/Native/NativeWriteStream.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
 	/**
32 32
 	 * Wrap a stream from libsmbclient-php into a regular php stream
33 33
 	 *
34
-	 * @param \Icewind\SMB\NativeState $state
34
+	 * @param NativeState $state
35 35
 	 * @param resource $smbStream
36 36
 	 * @param string $mode
37 37
 	 * @param string $url
Please login to merge, or discard this patch.
src/Wrapped/Server.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
 	 * Check if the smbclient php extension is available
21 21
 	 *
22 22
 	 * @param ISystem $system
23
-	 * @return bool
23
+	 * @return string|boolean
24 24
 	 */
25 25
 	public static function available(ISystem $system) {
26 26
 		return $system->getSmbclientPath();
Please login to merge, or discard this patch.
src/Wrapped/Share.php 2 patches
Doc Comments   +7 added lines, -3 removed lines patch added patch discarded remove patch
@@ -121,6 +121,10 @@  discard block
 block discarded – undo
121 121
 		return $this->name;
122 122
 	}
123 123
 
124
+	/**
125
+	 * @param string $command
126
+	 * @param string $path
127
+	 */
124 128
 	protected function simpleCommand($command, $path) {
125 129
 		$escapedPath = $this->escapePath($path);
126 130
 		$cmd = $command . ' ' . $escapedPath;
@@ -131,7 +135,7 @@  discard block
 block discarded – undo
131 135
 	/**
132 136
 	 * List the content of a remote folder
133 137
 	 *
134
-	 * @param $path
138
+	 * @param string $path
135 139
 	 * @return \Icewind\SMB\IFileInfo[]
136 140
 	 *
137 141
 	 * @throws \Icewind\SMB\Exception\NotFoundException
@@ -344,7 +348,7 @@  discard block
 block discarded – undo
344 348
 	/**
345 349
 	 * @param string $path
346 350
 	 * @param int $mode a combination of FileInfo::MODE_READONLY, FileInfo::MODE_ARCHIVE, FileInfo::MODE_SYSTEM and FileInfo::MODE_HIDDEN, FileInfo::NORMAL
347
-	 * @return mixed
351
+	 * @return boolean
348 352
 	 */
349 353
 	public function setMode($path, $mode) {
350 354
 		$modeString = '';
@@ -388,7 +392,7 @@  discard block
 block discarded – undo
388 392
 
389 393
 	/**
390 394
 	 * @param string $command
391
-	 * @return array
395
+	 * @return string[]
392 396
 	 */
393 397
 	protected function execute($command) {
394 398
 		$this->connect();
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -13,14 +13,11 @@
 block discarded – undo
13 13
 use Icewind\SMB\Exception\FileInUseException;
14 14
 use Icewind\SMB\Exception\InvalidTypeException;
15 15
 use Icewind\SMB\Exception\NotFoundException;
16
-use Icewind\SMB\Exception\InvalidRequestException;
17 16
 use Icewind\SMB\IFileInfo;
18 17
 use Icewind\SMB\INotifyHandler;
19 18
 use Icewind\SMB\IServer;
20 19
 use Icewind\SMB\ISystem;
21 20
 use Icewind\Streams\CallbackWrapper;
22
-use Icewind\SMB\Native\NativeShare;
23
-use Icewind\SMB\Native\NativeServer;
24 21
 
25 22
 class Share extends AbstractShare {
26 23
 	/**
Please login to merge, or discard this patch.
src/Wrapped/Connection.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,6 +20,9 @@  discard block
 block discarded – undo
20 20
 	/** @var Parser */
21 21
 	private $parser;
22 22
 
23
+	/**
24
+	 * @param string $command
25
+	 */
23 26
 	public function __construct($command, Parser $parser, $env = []) {
24 27
 		parent::__construct($command, $env);
25 28
 		$this->parser = $parser;
@@ -88,7 +91,7 @@  discard block
 block discarded – undo
88 91
 	/**
89 92
 	 * Check
90 93
 	 *
91
-	 * @param $line
94
+	 * @param string|false $line
92 95
 	 * @return bool
93 96
 	 */
94 97
 	private function isPrompt($line) {
Please login to merge, or discard this patch.
src/Native/NativeShare.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -129,6 +129,9 @@  discard block
 block discarded – undo
129 129
 		return '';
130 130
 	}
131 131
 
132
+	/**
133
+	 * @param string $path
134
+	 */
132 135
 	private function getStat($path) {
133 136
 		return $this->getState()->stat($this->buildUrl($path));
134 137
 	}
@@ -309,7 +312,7 @@  discard block
 block discarded – undo
309 312
 	 *
310 313
 	 * @param string $path
311 314
 	 * @param string $attribute attribute to get the info
312
-	 * @param string|int $value
315
+	 * @param integer $value
313 316
 	 * @return mixed the attribute value
314 317
 	 */
315 318
 	public function setAttribute($path, $attribute, $value) {
Please login to merge, or discard this patch.