icewind1991 / SMB

src/Wrapped/Share.php

Doc Comments +6 added lines, -2 removed lines

@@ -113,6 +113,10 @@ 
 		return $this->name;
 	}
 
+	/**
+	 * @param string $command
+	 * @param string $path
+	 */
 	protected function simpleCommand($command, $path) {
 		$escapedPath = $this->escapePath($path);
 		$cmd = $command . ' ' . $escapedPath;
@@ -323,7 +327,7 @@ 
 	/**
 	 * @param string $path
 	 * @param int $mode a combination of FileInfo::MODE_READONLY, FileInfo::MODE_ARCHIVE, FileInfo::MODE_SYSTEM and FileInfo::MODE_HIDDEN, FileInfo::NORMAL
-	 * @return mixed
+	 * @return boolean
 	 */
 	public function setMode($path, $mode) {
 		$modeString = '';
@@ -373,7 +377,7 @@ 
 
 	/**
 	 * @param string $command
-	 * @return array
+	 * @return string[]
 	 */
 	protected function execute($command) {
 		$this->connect();

Unused Use Statements -3 removed lines

@@ -13,14 +13,11 @@
 use Icewind\SMB\Exception\FileInUseException;
 use Icewind\SMB\Exception\InvalidTypeException;
 use Icewind\SMB\Exception\NotFoundException;
-use Icewind\SMB\Exception\InvalidRequestException;
 use Icewind\SMB\IFileInfo;
 use Icewind\SMB\INotifyHandler;
 use Icewind\SMB\IServer;
 use Icewind\SMB\ISystem;
 use Icewind\Streams\CallbackWrapper;
-use Icewind\SMB\Native\NativeShare;
-use Icewind\SMB\Native\NativeServer;
 
 class Share extends AbstractShare {
 	/**

src/Wrapped/Server.php

Doc Comments +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
 	 * Check if the smbclient php extension is available
 	 *
 	 * @param ISystem $system
-	 * @return bool
+	 * @return string|boolean
 	 */
 	public static function available(ISystem $system) {
 		return $system->getSmbclientPath();

src/Native/NativeShare.php

Doc Comments +4 added lines, -1 removed lines

@@ -66,6 +66,9 @@ 
 		return $this->name;
 	}
 
+	/**
+	 * @param string $path
+	 */
 	private function buildUrl($path) {
 		$this->verifyPath($path);
 		$url = sprintf('smb://%s/%s', $this->server->getHost(), $this->name);
@@ -311,7 +314,7 @@ 
 	 *
 	 * @param string $path
 	 * @param string $attribute attribute to get the info
-	 * @param string|int $value
+	 * @param integer $value
 	 * @return mixed the attribute value
 	 */
 	public function setAttribute($path, $attribute, $value) {

src/Wrapped/Connection.php

Doc Comments +3 added lines

@@ -21,6 +21,9 @@
 	/** @var Parser */
 	private $parser;
 
+	/**
+	 * @param string $command
+	 */
 	public function __construct($command, Parser $parser, $env = []) {
 		parent::__construct($command, $env);
 		$this->parser = $parser;